http://bugs.winehq.org/show_bug.cgi?id=24773
Summary: It is possible to click behind certain modal dialogs
in Worms Armageddon, leading to loss of focus and
crashes
Product: Wine
Version: unspecified
Platform: x86
OS/Version: Linux
Status: UNCONFIRMED
Severity: normal
Priority: P2
Component: user32
AssignedTo: wine-bugs(a)winehq.org
ReportedBy: thecybershadow(a)gmail.com
Created an attachment (id=31310)
--> (http://bugs.winehq.org/attachment.cgi?id=31310)
Proposed patch
Problem description:
It is possible to click behind modal dialogs displayed in e.g. the Weapon
Options screen. This causes the modal pop-up window to lose focus and go behind
the Weapon Options screen. It continues to be drawn in front on the Weapon
Options screen, however input events go to the Weapon Options screen instead.
Attempting to close the Weapon Options screen causes the game to crash.
Analysis:
1. It is possible to click behind certain modal dialogs because they are not
disabled.
2. The reason why they are not disabled, is that the MFC code which brings up a
new modal dialog disables the wrong window.
3. The reason for which the wrong window is disabled, is because the Wine
implementation of GetLastActivePopup, which is used by MFC to find the active
dialog to disable, returns an incorrect value in certain cases. Specifically,
it doesn't work correctly with nested popups.
4. The reason for that is that a new popup of an owned window doesn't update
the root window's "last active" window. As seen in Wine's make_window_active,
only the immediate owner is updated.
Attached patch + test (will send to wine-patches).
--
Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email
Do not reply to this email, post in Bugzilla using the
above URL to reply.
------- You are receiving this mail because: -------
You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=9127
Dan Kegel <dank(a)kegel.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |dank(a)kegel.com
--- Comment #28 from Dan Kegel <dank(a)kegel.com> 2010-12-03 10:39:55 CST ---
Video is working in several games here thanks to the recent gstreamer changes.
The title of this bug is quite broad, it might be useful to close
this one and open individual bugs for games whose video doesn't work yet.
--
Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email
Do not reply to this email, post in Bugzilla using the
above URL to reply.
------- You are receiving this mail because: -------
You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=6971
Sebastian <nil094(a)yahoo.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |nil094(a)yahoo.com
--
Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email
Do not reply to this email, post in Bugzilla using the
above URL to reply.
------- You are receiving this mail because: -------
You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=9127
--- Comment #27 from Karl H. Grube <karlthepaladin(a)yahoo.com> 2010-12-03 05:38:37 CST ---
(In reply to comment #26)
> (In reply to comment #23)
> > This bug is fixed as of wine 1.3.8 (at least, the movies do play, though the
> > games crash after end of playback, but this is reported as another bug).
> (In reply to comment #25)
> > (In reply to comment #24)
> > > Reported fixed.
> >
> > I tested several games with this bug and it seems to still be present.
>
> and which games are those working and not working ?
> what video formats are they using ?
>
> (In reply to comment #24)
> > Reported fixed.
>
> let's not get ahead of ourselves.
> which formats exactly should be supported ?
> mpeg1, mpeg2, asf, bik with in-game-built-in decoder, something else ?
> are you sure all of those work now ?
Winter Bells (しろくまベルスターズ) doesn't have working video, (it's not on the appdb,
but it has the same engine as one game that is) and I believe it's MPEG-2.
Shuffle! doesn't seem to play the opening (also MPEG-2 as I recall). Fate/Stay
Night doesn't play its videos (according to my fast test). I can probably find
more games with the same bug that just don't play MPEG-2 video.
However, I could be mistaken, so if someone wants to double-check this and test
things themselves, that would help. I am currently on 1.3.8.
--
Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email
Do not reply to this email, post in Bugzilla using the
above URL to reply.
------- You are receiving this mail because: -------
You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=9127
Predatory QQmber <virtuousfox(a)gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|RESOLVED |REOPENED
Resolution|FIXED |
--- Comment #26 from Predatory QQmber <virtuousfox(a)gmail.com> 2010-12-03 04:40:37 CST ---
(In reply to comment #23)
> This bug is fixed as of wine 1.3.8 (at least, the movies do play, though the
> games crash after end of playback, but this is reported as another bug).
(In reply to comment #25)
> (In reply to comment #24)
> > Reported fixed.
>
> I tested several games with this bug and it seems to still be present.
and which games are those working and not working ?
what video formats are they using ?
(In reply to comment #24)
> Reported fixed.
let's not get ahead of ourselves.
which formats exactly should be supported ?
mpeg1, mpeg2, asf, bik with in-game-built-in decoder, something else ?
are you sure all of those work now ?
--
Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email
Do not reply to this email, post in Bugzilla using the
above URL to reply.
------- You are receiving this mail because: -------
You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=9127
--- Comment #25 from Karl H. Grube <karlthepaladin(a)yahoo.com> 2010-12-03 01:28:17 CST ---
(In reply to comment #24)
> Reported fixed.
I tested several games with this bug and it seems to still be present.
--
Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email
Do not reply to this email, post in Bugzilla using the
above URL to reply.
------- You are receiving this mail because: -------
You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=9127
Dmitry Timoshkov <dmitry(a)codeweavers.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution| |FIXED
--- Comment #24 from Dmitry Timoshkov <dmitry(a)codeweavers.com> 2010-12-02 23:56:22 CST ---
Reported fixed.
--
Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email
Do not reply to this email, post in Bugzilla using the
above URL to reply.
------- You are receiving this mail because: -------
You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=5552
--- Comment #22 from awesome <ilyakon(a)gmail.com> 2010-12-02 18:20:38 CST ---
The bug still exists with 1.3.8 version of Wine.
--
Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email
Do not reply to this email, post in Bugzilla using the
above URL to reply.
------- You are receiving this mail because: -------
You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=4432
--- Comment #17 from Wolfram Sang <wolfram(a)the-dreams.de> 2010-12-02 14:48:52 CST ---
If that counts, I "tested" Blobby Volley almost daily since wineconf ;)
--
Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email
Do not reply to this email, post in Bugzilla using the
above URL to reply.
------- You are receiving this mail because: -------
You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=9127
--- Comment #23 from Ruslan <b7.10110111(a)gmail.com> 2010-12-02 14:01:39 CST ---
This bug is fixed as of wine 1.3.8 (at least, the movies do play, though the
games crash after end of playback, but this is reported as another bug).
--
Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email
Do not reply to this email, post in Bugzilla using the
above URL to reply.
------- You are receiving this mail because: -------
You are watching all bug changes.