[Bug 58961] SynthFont2 crashes when attempting to launch it

[WineHQ Bugzilla]

http://bugs.winehq.org/show_bug.cgi?id=58961

Louis Lenders  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
     Ever confirmed|0                           |1
           Keywords|                            |download
                 CC|                            |[e-mail]
             Status|UNCONFIRMED                 |NEW
                URL|                            |https://www.synthfont.com/S
                   |                            |ynthFont2x64Setup.exe

--- Comment #1 from Louis Lenders  ---
Confirming.

The access violation is just after  failing call to SHGetImageList. The hack
below makes the program start for me ( SHGetImageList is called with iImageList
= -1) .
I don't know how to fix this bug, maybe one of the devs might know what's going
on.

HACK:

diff --git a/dlls/shell32/iconcache.c b/dlls/shell32/iconcache.c
index 9433361440c..7a131ce4c9d 100644
--- a/dlls/shell32/iconcache.c
+++ b/dlls/shell32/iconcache.c
@@ -1135,7 +1135,7 @@ HRESULT WINAPI SHGetImageList(int iImageList, REFIID
riid, void **ppv)
     TRACE("(%d, %s, %p)\n", iImageList, debugstr_guid(riid), ppv);

if (iImageList < 0 || iImageList > SHIL_LAST)
-        return E_FAIL;
+        iImageList = 0;//return E_FAIL;

InitOnceExecuteOnce( &sic_init_once, SIC_Initialize, NULL, NULL );
     return HIMAGELIST_QueryInterface(shell_imagelists[iImageList], riid, ppv);