[Bug 58585] New: unnamed keymap layout leads to null pointer dereference in find_xkb_layout_variant

[WineHQ Bugzilla]

http://bugs.winehq.org/show_bug.cgi?id=58585

Bug ID: 58585
           Summary: unnamed keymap layout leads to null pointer
                    dereference in find_xkb_layout_variant
           Product: Wine
           Version: unspecified
          Hardware: x86-64
                OS: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: winewayland
          Assignee: [e-mail]
          Reporter: [e-mail]
      Distribution: ---

Created attachment 79112
  --> http://bugs.winehq.org/attachment.cgi?id=79112
gdb backtrace

Using the winewayland would abruptly exit at launch. Running wine64 under gdb
uncovers a segv happening in find_xkb_layout_variant's strcmp (see attachement,
due to name being NULL).

As per the
documentation(https://xkbcommon.org/doc/current/group__components.html#ga50c26edab590b92c7...),
xkb_keymap_layout_get_name can return null if the layout does not have any
name(or if there is an error). This is problematic as find_xkb_layout_variant
does not handle the case where name is NULL. Returning false in
find_xkb_layout_variant if name is NULL fixes the issue.

[Bug 58585] unnamed keymap layout leads to null pointer dereference in find_xkb_layout_variant

[WineHQ Bugzilla]

http://bugs.winehq.org/show_bug.cgi?id=58585

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |alexandros.frantzis@collabo
                   |                            |ra.com

--- Comment #1 from [e-mail] ---
Thanks for the report. Please try
https://gitlab.winehq.org/wine/wine/-/merge_requests/8855 .

[Bug 58585] unnamed keymap layout leads to null pointer dereference in find_xkb_layout_variant

[WineHQ Bugzilla]

http://bugs.winehq.org/show_bug.cgi?id=58585

--- Comment #2 from lompik  ---
(In reply to alexandros.frantzis from comment #1)
> Thanks for the report. Please try
> https://gitlab.winehq.org/wine/wine/-/merge_requests/8855 .

Thanks ! That patch solves the issue.

[Bug 58585] unnamed keymap layout leads to null pointer dereference in find_xkb_layout_variant

[WineHQ Bugzilla]

http://bugs.winehq.org/show_bug.cgi?id=58585

lompik  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|---                         |FIXED

--- Comment #3 from lompik  ---
above patch merged into master

[Bug 58585] unnamed keymap layout leads to null pointer dereference in find_xkb_layout_variant

[WineHQ Bugzilla]

http://bugs.winehq.org/show_bug.cgi?id=58585

Sven Baars  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
      Fixed by SHA1|                            |35b1775b2d56249d9386b8b1674
                   |                            |0012a02724f67

[Bug 58585] unnamed keymap layout leads to null pointer dereference in find_xkb_layout_variant

[WineHQ Bugzilla]

http://bugs.winehq.org/show_bug.cgi?id=58585

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #4 from Alexandre Julliard  ---
Closing bugs fixed in 10.15.