[Bug 57656] New: CryptMsgGetParam() with CMSG_SIGNER_AUTH_ATTR_PARAM/CMSG_SIGNER_UNAUTH_ATTR_PARAM returns success with 0 buffer size

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=57656

Bug ID: 57656
           Summary: CryptMsgGetParam() with
                    CMSG_SIGNER_AUTH_ATTR_PARAM/CMSG_SIGNER_UNAUTH_ATTR_PA
                    RAM returns success with 0 buffer size
           Product: Wine
           Version: 10.0-rc5
          Hardware: x86-64
                OS: Linux
            Status: NEW
          Severity: normal
          Priority: P2
         Component: crypt32
          Assignee: [e-mail]
          Reporter: [e-mail]
      Distribution: ---

This is currently triggered by wintrust tests from test_wintrust_digest(). The
issue is that GetParam returns TRUE when there is no attributes to return. That
leads to malloc(0) and then attempt to read attributes from that.

I don't know how to write a proper test for this at crypt32 side, so filing a
bug instead.

[Bug 57656] CryptMsgGetParam() with CMSG_SIGNER_AUTH_ATTR_PARAM/CMSG_SIGNER_UNAUTH_ATTR_PARAM returns success with 0 buffer size

[WineHQ Bugzilla]

http://bugs.winehq.org/show_bug.cgi?id=57656

Bernhard Übelacker  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #1 from Bernhard Übelacker  ---
At least in my tree makes this merge request ASan happy:
https://gitlab.winehq.org/wine/wine/-/merge_requests/8350

[Bug 57656] CryptMsgGetParam() with CMSG_SIGNER_AUTH_ATTR_PARAM/CMSG_SIGNER_UNAUTH_ATTR_PARAM returns success with 0 buffer size

[WineHQ Bugzilla]

http://bugs.winehq.org/show_bug.cgi?id=57656

--- Comment #2 from Bernhard Übelacker  ---
(In reply to Bernhard Übelacker from comment #1)
> At least in my tree makes this merge request ASan happy:
> https://gitlab.winehq.org/wine/wine/-/merge_requests/8350

Was a false alarm, did run Asan the wrong flags, sorry for the noise.

[Bug 57656] CryptMsgGetParam() with CMSG_SIGNER_AUTH_ATTR_PARAM/CMSG_SIGNER_UNAUTH_ATTR_PARAM returns success with 0 buffer size

[WineHQ Bugzilla]

http://bugs.winehq.org/show_bug.cgi?id=57656

Bernhard Übelacker  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
      Fixed by SHA1|                            |057e1d73e84b06fac90cba96dbf
                   |                            |0305d219df3d5

--- Comment #3 from Bernhard Übelacker  ---
But this time the ASan report vanished with this commit:

https://gitlab.winehq.org/wine/wine/-/commit/057e1d73e84b06fac90cba96dbf0305...

Therefore this bug can be closed?

[Bug 57656] CryptMsgGetParam() with CMSG_SIGNER_AUTH_ATTR_PARAM/CMSG_SIGNER_UNAUTH_ATTR_PARAM returns success with 0 buffer size

[WineHQ Bugzilla]

http://bugs.winehq.org/show_bug.cgi?id=57656

Nikolay Sivov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #4 from Nikolay Sivov  ---
Sure, thanks.

[Bug 57656] CryptMsgGetParam() with CMSG_SIGNER_AUTH_ATTR_PARAM/CMSG_SIGNER_UNAUTH_ATTR_PARAM returns success with 0 buffer size

[WineHQ Bugzilla]

http://bugs.winehq.org/show_bug.cgi?id=57656

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #5 from Alexandre Julliard  ---
Closing bugs fixed in 10.11.