[Bug 54927] New: grepwinNP3 (part of Notepad3) crashes inside uxtheme

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=54927

Bug ID: 54927
           Summary: grepwinNP3 (part of Notepad3) crashes inside uxtheme
           Product: Wine
           Version: 8.7
          Hardware: x86-64
               URL: https://github.com/rizonesoft/Notepad3/releases/downlo
                    ad/RELEASE_6.23.203.2/Notepad3_6.23.203.2_x64_Setup.ex
                    e
                OS: Linux
            Status: NEW
          Keywords: download, source
          Severity: normal
          Priority: P2
         Component: uxtheme
          Assignee: [e-mail]
          Reporter: [e-mail]
      Distribution: ---

This is a kind of "grep with GUI":

Unhandled exception: page fault on read access to 0x0000000000000004 in 64-bit
code (0x0000006d5089f5).

=>0 0x0000006d5089f5 DrawThemeTextEx+0x45(hTheme=000000000025CA20,
hdc=0000000001410094, iPartId=0x2, iStateId=0, pszText=L"Regex search",
iCharCount=0xffffffff, flags=0x2450, rect=00000000001FC400,
options=0000000000000000)
[/home/louis/sda2/wine64-build/../wine/dlls/uxtheme/draw.c:1790] in uxtheme
(0x000000001fc400)

Apparently crashes in next line because "options" pointer is NULL:

if (options->dwFlags & ~(DTT_TEXTCOLOR | DTT_FONTPROP))
        FIXME("unsupported flags 0x%08lx\n", options->dwFlags);

[Bug 54927] grepwinNP3 (part of Notepad3) crashes inside uxtheme

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=54927

Mohamad Al-Jaf  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #1 from Mohamad Al-Jaf  ---
Created attachment 74456
  --> https://bugs.winehq.org/attachment.cgi?id=74456
uxtheme: Add a NULL check for options parameter in DrawThemeTextEx().

Does this patch help?

[Bug 54927] grepwinNP3 (part of Notepad3) crashes inside uxtheme

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=54927

--- Comment #2 from Louis Lenders  ---
(In reply to Mohamad Al-Jaf from comment #1)
> Created attachment 74456 [details]
> uxtheme: Add a NULL check for options parameter in DrawThemeTextEx().
>
> Does this patch help?

Hi Mohammed, Yes it fixes the crash and allows the application to start.

Regards

[Bug 54927] grepwinNP3 (part of Notepad3) crashes inside uxtheme

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=54927

Sagawa  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |sagawa.aki+winebugs@gmail.c
                   |                            |om

--- Comment #3 from Sagawa  ---
For your reference, the code which calls DrawThemeTextEx with nullptr is no
longer used. See the commit which imports a latest release from grepWin,
https://github.com/rizonesoft/Notepad3/commit/9c148389142d6e45da4930bbdd824d...
.

[Bug 54927] grepwinNP3 (part of Notepad3) crashes inside uxtheme

[WineHQ Bugzilla]

http://bugs.winehq.org/show_bug.cgi?id=54927

Louis Lenders  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |patch

--- Comment #4 from Louis Lenders  ---
Still prsent in wine-10.17 (in the program release from the downloadlink)

@Mohamad: Have you ever submitted the patch for review?

[Bug 54927] grepwinNP3 (part of Notepad3) crashes inside uxtheme

[WineHQ Bugzilla]

http://bugs.winehq.org/show_bug.cgi?id=54927

--- Comment #5 from Mohamad Al-Jaf  ---
(In reply to Louis Lenders from comment #4)
> Still prsent in wine-10.17 (in the program release from the downloadlink)
>
> @Mohamad: Have you ever submitted the patch for review?

Hi Louis, I haven't submitted it before as I didn't write a test for it.

Made an MR now - https://gitlab.winehq.org/wine/wine/-/merge_requests/9287

[Bug 54927] grepwinNP3 (part of Notepad3) crashes inside uxtheme

[WineHQ Bugzilla]

http://bugs.winehq.org/show_bug.cgi?id=54927

--- Comment #6 from Mohamad Al-Jaf  ---
Fixed in commit cdc4af0c266ce3f001f51edbaf2c6e3af2029ee7

https://gitlab.winehq.org/wine/wine/-/commit/cdc4af0c266ce3f001f51edbaf2c6e3...

[Bug 54927] grepwinNP3 (part of Notepad3) crashes inside uxtheme

[WineHQ Bugzilla]

http://bugs.winehq.org/show_bug.cgi?id=54927

Louis Lenders  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|NEW                         |RESOLVED
      Fixed by SHA1|                            |cdc4af0c266ce3f001f51edbaf2
                   |                            |c6e3af2029ee7

--- Comment #7 from Louis Lenders  ---
(In reply to Mohamad Al-Jaf from comment #6)
> Fixed in commit cdc4af0c266ce3f001f51edbaf2c6e3af2029ee7
>
> https://gitlab.winehq.org/wine/wine/-/commit/
> cdc4af0c266ce3f001f51edbaf2c6e3af2029ee7

Yes, I can confirm that. Thanks Mohamad!