[Bug 56883] New: Dualshock bumpers registering as two buttons on wine 9.9 and later

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=56883

Bug ID: 56883
           Summary: Dualshock bumpers registering as two buttons on wine
                    9.9 and later
           Product: Wine
           Version: 9.9
          Hardware: x86-64
                OS: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: -unknown
          Assignee: [e-mail]
          Reporter: [e-mail]
      Distribution: ---

As of wine 9.9 and later a dualshock (Playstation 5) controller when connected
via bluetooth and only bluetooth, the left and right bumpers will trigger two
button presses at the same time.

Right bumper will trigger the buttons number 5 and 13 instead of just 5
Left bumper will trigger the buttons number 4 and 13 instead of just 4

[Bug 56883] DualSense bumpers registering as two buttons on wine 9.9 and later

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=56883

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Dualshock bumpers           |DualSense bumpers
                   |registering as two buttons  |registering as two buttons
                   |on wine 9.9 and later       |on wine 9.9 and later

[Bug 56883] DualSense bumpers registering as two buttons on wine 9.9 and later

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=56883

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |hardware

--- Comment #1 from Austin English  ---
Did this work in previous versions? If so, can you run a regression test:
https://wiki.winehq.org/Regression_Testing

[Bug 56883] DualSense bumpers registering as two buttons on wine 9.9 and later

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=56883

--- Comment #2 from [e-mail] ---
I was able to bisect the issue down to c708295ed6de3eca5a5406ed886904fd5c398053

[Bug 56883] DualSense bumpers registering as two buttons on wine 9.9 and later

[WineHQ Bugzilla]

http://bugs.winehq.org/show_bug.cgi?id=56883

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #3 from [e-mail] ---
As per first post I am also seeing this behavior; Dualsense bumpers since wine
9.9 send two buttons when in hidraw on Bluetooth specifically. Physical R1
press reports R1 and Touchpad Click in dinput, physical L1 press reports L1 and
Mic Mute in dinput. The touchpad click and mic mute physical buttons do not
report any button to dinput.

This breaks software with native Dualsense support that use both inputs mapped
to one button, ie. Zenless Zone Zero. R1 is expected to switch character, but
brings up the pause menu instead (touchpad click).

This is not an issue when Dualsense is connected via USB, each button correctly
reports as a separate input and works properly with games that natively support
Dualsense and use all of these inputs.

I am observing this behavior since Wine 9.9-10.9 (present). 9.8 and earlier do
not exhibit this issue.

[Bug 56883] DualSense bumpers registering as two buttons on wine 9.9 and later

[WineHQ Bugzilla]

http://bugs.winehq.org/show_bug.cgi?id=56883

Ken Sharp  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |regression
    Regression SHA1|                            |c708295ed6de3eca5a5406ed886
                   |                            |904fd5c398053
                 CC|                            |[e-mail]

--- Comment #4 from Ken Sharp  ---
(In reply to quackdoctech from comment #2)
> I was able to bisect the issue down to
> c708295ed6de3eca5a5406ed886904fd5c398053

winebus: Move Sony controllers report fixups to PE side.

[Bug 56883] DualSense bumpers registering as two buttons on wine 9.9 and later

[WineHQ Bugzilla]

http://bugs.winehq.org/show_bug.cgi?id=56883

--- Comment #5 from Cameron Kelly  ---
Created attachment 78837
  --> http://bugs.winehq.org/attachment.cgi?id=78837
Patch for dlls/winebus.sys/main.c

Patches dlls/winebus.sys/main.c, process_hid_report function regarding
Dualsense Bluetooth reports. Adjusts memmove to shift 11 bytes instead of 10,
including extra button state byte for Dualsense Bluetooth input report.

Resolves unusable inputs "Home Button", "Mic Button" and "Touchpad Click" (and
R1/L1 mis-reporting extra buttons) on Dualsense controller used with hidraw