[Bug 43275] New: Sacred Gold v2.28 (GOG.com): invisible characters

https://bugs.winehq.org/show_bug.cgi?id=43275

Bug ID: 43275
           Summary: Sacred Gold v2.28 (GOG.com): invisible characters
           Product: Wine
           Version: 2.6
          Hardware: x86
               URL: https://www.gog.com/game/sacred_gold
                OS: Linux
            Status: NEW
          Keywords: regression
          Severity: normal
          Priority: P2
         Component: directx-d3d
          Assignee: [e-mail]
          Reporter: [e-mail]
                CC: [e-mail]
   Regression SHA1: b98ece0d38ca3ec401370ccf95eb08946533850c
      Distribution: ---

Created attachment 58611
  --> https://bugs.winehq.org/attachment.cgi?id=58611
plain terminal output

This was tested with Sacred Gold from GOG.com. I tried the original demo but it
doesn't have the bug: the demo runs in 16-bit color mode whereas the problem
occurs only in 32-bit color mode.
I reproduced the problem with Nvidia binary drivers 381.22 and with
nouveau/mesa 17.1.4, too.

The problem: in-game characters are invisible.

Regression introduced by

commit b98ece0d38ca3ec401370ccf95eb08946533850c
Author: Henri Verbeet 
Date:   Tue Apr 4 09:07:47 2017 +0200

wined3d: Use the blitter interface in wined3d_cs_exec_clear().

Characters are visible with the previous commit.
In the game configuration tool if I uncheck the 32 bit Color Depth option, the
problem doesn't occur.

wine-2.11-150-g287be7c5ee
OpenGL vendor string: NVIDIA Corporation
OpenGL renderer string: GeForce GT 730/PCIe/SSE2
OpenGL core profile version string: 4.5.0 NVIDIA 381.22

[Bug 43275] Sacred Gold v2.28 (GOG.com): invisible characters

https://bugs.winehq.org/show_bug.cgi?id=43275

--- Comment #1 from Henri Verbeet  ---
Could you attach a +tid,+ddraw,+d3d,+seh log?

[Bug 43275] Sacred Gold v2.28 (GOG.com): invisible characters

https://bugs.winehq.org/show_bug.cgi?id=43275

--- Comment #2 from Béla Gyebrószki  ---
Created attachment 58668
  --> https://bugs.winehq.org/attachment.cgi?id=58668
+tid,+ddraw,+d3d,+seh log (uncompressed 94 MB)

[Bug 43275] Sacred Gold v2.28 (GOG.com): invisible characters

https://bugs.winehq.org/show_bug.cgi?id=43275

--- Comment #3 from Henri Verbeet  ---
Created attachment 58672
  --> https://bugs.winehq.org/attachment.cgi?id=58672
patch

Does the attached patch make it any better?

[Bug 43275] Sacred Gold v2.28 (GOG.com): invisible characters

https://bugs.winehq.org/show_bug.cgi?id=43275

--- Comment #4 from Béla Gyebrószki  ---
Created attachment 58673
  --> https://bugs.winehq.org/attachment.cgi?id=58673
the same log with patch applied

The patch doesn't help, characters remain invisible.

[Bug 43275] Sacred Gold v2.28 (GOG.com): invisible characters

https://bugs.winehq.org/show_bug.cgi?id=43275

Henri Verbeet  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #58672|0                           |1
        is obsolete|                            |

--- Comment #5 from Henri Verbeet  ---
Created attachment 58686
  --> https://bugs.winehq.org/attachment.cgi?id=58686
patch

How about this one?

[Bug 43275] Sacred Gold v2.28 (GOG.com): invisible characters

https://bugs.winehq.org/show_bug.cgi?id=43275

--- Comment #6 from Béla Gyebrószki  ---
(In reply to Henri Verbeet from comment #5)
> Created attachment 58686 [details]
> patch
>
> How about this one?

This one works better and fixes the issue, thank you.
Is there anything concerning about the constant spamming of
"fixme:d3d:cpu_blitter_clear flags 0x6 not implemented." lines? This was also
introduced by commit b98ece0d38ca3ec401370ccf95eb08946533850c as far as I see.

[Bug 43275] Sacred Gold v2.28 (GOG.com): invisible characters

https://bugs.winehq.org/show_bug.cgi?id=43275

--- Comment #7 from Henri Verbeet  ---
(In reply to Béla Gyebrószki from comment #6)
> Is there anything concerning about the constant spamming of
> "fixme:d3d:cpu_blitter_clear flags 0x6 not implemented." lines?

There's an issue there, but the fixme is a little inaccurate.

[Bug 43275] Sacred Gold v2.28 (GOG.com): invisible characters

https://bugs.winehq.org/show_bug.cgi?id=43275

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #8 from [e-mail] ---
(In reply to Béla Gyebrószki from comment #6)
> (In reply to Henri Verbeet from comment #5)
> > Created attachment 58686 [details]
> > patch
> >
> > How about this one?
>
> This one works better and fixes the issue, thank you.
> Is there anything concerning about the constant spamming of
> "fixme:d3d:cpu_blitter_clear flags 0x6 not implemented." lines? This was
> also introduced by commit b98ece0d38ca3ec401370ccf95eb08946533850c as far as
> I see.

https://source.winehq.org/git/wine.git/commit/7578e09801b7a2a651be258322bd45...

[Bug 43275] Sacred Gold v2.28 (GOG.com): invisible characters

https://bugs.winehq.org/show_bug.cgi?id=43275

Béla Gyebrószki  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
      Fixed by SHA1|                            |7578e09801b7a2a651be258322b
                   |                            |d4574bcd8e7c5
         Resolution|---                         |FIXED

--- Comment #9 from Béla Gyebrószki  ---
Fixed in wine-2.12-148-gc2f464decb.

[Bug 43275] Sacred Gold v2.28 (GOG.com): invisible characters

https://bugs.winehq.org/show_bug.cgi?id=43275

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #10 from Alexandre Julliard  ---
Closing bugs fixed in 2.13.