[Bug 51848] New: Performance Regression in Secondhand Lands

List overview All Threads

newer

older

[Bug 53488] New: The dxgi:dxgi...

[Bug 54649] New:...

WineHQ Bugzilla

6 Oct 2021 6 Oct '21

7:32 p.m.

https://bugs.winehq.org/show_bug.cgi?id=51848

Bug ID: 51848 Summary: Performance Regression in Secondhand Lands Product: Wine Version: 6.18 Hardware: x86-64 OS: Linux Status: UNCONFIRMED Severity: normal Priority: P2 Component: directx-d3d Assignee: wine-bugs@winehq.org Reporter: escomk3@hotmail.com Distribution: ---

After 4261369e5d8 [1], FPS will be near zero, and the game area will be black, with the actual should-be content sometimes appearing and disappearing.

Standard output with default'ish debug channels doesn't show any difference with a build prior to this commit.

1. https://source.winehq.org/git/wine.git/commit/4261369e5d8f1d71e8d20747475158...

-- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

Show replies by date

WineHQ Bugzilla

6 Oct 6 Oct

7:33 p.m.

New subject: [Bug 51848] Performance Regression in Secondhand Lands

https://bugs.winehq.org/show_bug.cgi?id=51848

Chiitoo escomk3@hotmail.com changed:

-- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

WineHQ Bugzilla

15 Oct 15 Oct

12:57 p.m.

New subject: [Bug 51848] Performance Regression in Secondhand Lands

https://bugs.winehq.org/show_bug.cgi?id=51848

--- Comment #1 from Henri Verbeet hverbeet@gmail.com --- Could you attach a "+ddraw,+d3d9,+d3d" log?

-- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

WineHQ Bugzilla

1:54 p.m.

New subject: [Bug 51848] Performance Regression in Secondhand Lands

https://bugs.winehq.org/show_bug.cgi?id=51848

--- Comment #2 from Chiitoo escomk3@hotmail.com --- Created attachment 70818 --> https://bugs.winehq.org/attachment.cgi?id=70818 Trace with channels: +ddraw,+d3d9,+d3d

Forgot to mention that the game does require native 'd3dcompiler_43' and 'd3dx9_43' to run at all at this time.

Thank you!

-- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

WineHQ Bugzilla

17 Dec 17 Dec

9:53 p.m.

New subject: [Bug 51848] Performance Regression in Secondhand Lands

https://bugs.winehq.org/show_bug.cgi?id=51848

--- Comment #3 from Henri Verbeet hverbeet@gmail.com --- Is this still reproducible?

I was unable to reproduce the slowdown earlier, and unfortunately I didn't get any leads from your log either. I tried revisiting this for code freeze though, and right now it's just not rendering anything at all for me. I initially suspected a second regression, but I'm seeing the same behaviour with older Wine versions, including wine-6.0 and wine-6.17. Trying to look into that, I came across a message claiming the game was shut down between when this bug was originally filed and now.

-- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

WineHQ Bugzilla

11:10 p.m.

New subject: [Bug 51848] Performance Regression in Secondhand Lands

https://bugs.winehq.org/show_bug.cgi?id=51848

--- Comment #4 from Chiitoo escomk3@hotmail.com --- Indeed, the servers have been taken down, possibly permanently.

However, it's possible to run the client directly by giving it anything as an argument like so:

'Client.exe 123'

At 7.0-rc2 the FPS hangs around 20, so that's an improvement of sorts, but there's still a very fast-flashing UI happening.

-- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

WineHQ Bugzilla

18 Dec 18 Dec

11:39 a.m.

New subject: [Bug 51848] Performance Regression in Secondhand Lands

https://bugs.winehq.org/show_bug.cgi?id=51848

Sagawa sagawa.aki+winebugs@gmail.com changed:

-- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

WineHQ Bugzilla

21 Dec 21 Dec

5:13 a.m.

New subject: [Bug 51848] Performance Regression in Secondhand Lands

https://bugs.winehq.org/show_bug.cgi?id=51848

--- Comment #5 from Conor McCarthy cmccarthy@codeweavers.com --- *** Bug 52236 has been marked as a duplicate of this bug. ***

-- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

WineHQ Bugzilla

5:24 a.m.

New subject: [Bug 51848] Performance Regression in Secondhand Lands

https://bugs.winehq.org/show_bug.cgi?id=51848

Conor McCarthy cmccarthy@codeweavers.com changed:

--- Comment #6 from Conor McCarthy cmccarthy@codeweavers.com --- I think this is a driver problem. The chosen GL pixel format with WGL_SWAP_COPY_ARB is identical to the one chosen without this patch except for the different swap attribute. I found nothing wrong with how the pixel format is used. There were no GL errors and no assertion failures in a Mesa debug build. No effect occurs in swapchain_gl_present() because swapchain_present_is_partial_copy() is false anyway. The problem persists if the changes to swapchain_gl_present() are reverted.

On my system with an RX580, it freezes the entire X window UI, so the exe must be terminated from an alternate console. This problem is worse in Secondhand Lands because X window doesn't unfreeze after I terminate the game.

-- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

WineHQ Bugzilla

4 Jan 4 Jan

1:46 p.m.

New subject: [Bug 51848] Performance Regression in Secondhand Lands

https://bugs.winehq.org/show_bug.cgi?id=51848

--- Comment #7 from Henri Verbeet hverbeet@gmail.com --- Created attachment 71508 --> https://bugs.winehq.org/attachment.cgi?id=71508 patch

(In reply to Chiitoo from comment #4)

...

However, it's possible to run the client directly by giving it anything as an argument like so:

'Client.exe 123'

Thanks, that helps a lot, and I'm able to reproduce the issue now. The attached patch helps here, although I don't believe it's entirely correct. (In particular, it will incorrectly clear a pixel format previously set by the application in some cases.)

(In reply to Conor McCarthy from comment #6)

...

I think this is a driver problem. The chosen GL pixel format with WGL_SWAP_COPY_ARB is identical to the one chosen without this patch except for the different swap attribute. I found nothing wrong with how the pixel format is used. There were no GL errors and no assertion failures in a Mesa debug build. No effect occurs in swapchain_gl_present() because swapchain_present_is_partial_copy() is false anyway. The problem persists if the changes to swapchain_gl_present() are reverted.

The problem seems to be a bit more subtle; always using a WGL_SWAP_COPY_ARB format also works fine. The issue in this particular application is that the application first creates swapchains with a "copy" swap effect, and then later creates a swapchain with a "non-copy" swap effect on the same window. That causes us to end up switching between the two different pixel formats, even though the original context that needed the WGL_SWAP_COPY_ARB pixel format has long since been destroyed. On the winex11 side, changing the pixel format causes the GL drawable to be recreated, and that's the cause of the flickering, and likely the slowdown as well.

-- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

WineHQ Bugzilla

6:34 p.m.

New subject: [Bug 51848] Performance Regression in Secondhand Lands

https://bugs.winehq.org/show_bug.cgi?id=51848

--- Comment #8 from Chiitoo escomk3@hotmail.com --- (In reply to Henri Verbeet from comment #7)

...

Created attachment 71508 [details] patch

(In reply to Chiitoo from comment #4)

...
However, it's possible to run the client directly by giving it anything as an argument like so:

'Client.exe 123'

Thanks, that helps a lot, and I'm able to reproduce the issue now. The attached patch helps here, although I don't believe it's entirely correct. (In particular, it will incorrectly clear a pixel format previously set by the application in some cases.)

Very good!

Indeed, works for me as well; no more blinking, and FPS went from 23 to 33.

Thanks!

-- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

WineHQ Bugzilla

9 Jan 9 Jan

1:09 p.m.

New subject: [Bug 51848] Performance Regression in Secondhand Lands

https://bugs.winehq.org/show_bug.cgi?id=51848

--- Comment #9 from Sagawa sagawa.aki+winebugs@gmail.com --- *** Bug 52236 has been marked as a duplicate of this bug. ***

-- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

WineHQ Bugzilla

3 Feb 3 Feb

11:41 p.m.

New subject: [Bug 51848] Multiple applications have very poor performance after 4261369e5d8 (Secondhand Lands, SPORE)

https://bugs.winehq.org/show_bug.cgi?id=51848

Zebediah Figura z.figura12@gmail.com changed:

--- Comment #10 from Zebediah Figura z.figura12@gmail.com --- I can reproduce the same problem in SPORE, and it's fixed by the same patch.

-- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

WineHQ Bugzilla

9 Apr 9 Apr

4:08 p.m.

New subject: [Bug 51848] Multiple applications have very poor performance after 4261369e5d8 (Secondhand Lands, SPORE)

https://bugs.winehq.org/show_bug.cgi?id=51848

--- Comment #11 from Andrey Gusev andrey.goosev@gmail.com --- WRC 4 FIA World Rally Championship is also affected.

-- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

WineHQ Bugzilla

23 Apr 23 Apr

7:10 p.m.

New subject: [Bug 51848] Multiple applications have very poor performance after 4261369e5d8 (Secondhand Lands, SPORE)

https://bugs.winehq.org/show_bug.cgi?id=51848

--- Comment #12 from Andrey Gusev andrey.goosev@gmail.com --- And Crysis 2 Maximum Edition in DX9 mode.

-- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

WineHQ Bugzilla

9 Jan 9 Jan

11:46 a.m.

New subject: [Bug 51848] Multiple applications have very poor performance after 4261369e5d8 (Secondhand Lands, SPORE)

https://bugs.winehq.org/show_bug.cgi?id=51848

--- Comment #13 from Sagawa sagawa.aki+winebugs@gmail.com --- This is still an issue in Wine 8.0-rc3.

-- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

WineHQ Bugzilla

10 Jan 10 Jan

8:41 a.m.

New subject: [Bug 51848] Multiple applications have very poor performance after 4261369e5d8 (Secondhand Lands, SPORE)

https://bugs.winehq.org/show_bug.cgi?id=51848

Alistair Leslie-Hughes leslie_alistair@hotmail.com changed:

What |Removed |Added ---------------------------------------------------------------------------- Keywords| |patch

-- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

WineHQ Bugzilla

13 Mar 13 Mar

10:09 p.m.

New subject: [Bug 51848] Multiple applications have very poor performance after 4261369e5d8 (Secondhand Lands, SPORE)

https://bugs.winehq.org/show_bug.cgi?id=51848

Zeb Figura z.figura12@gmail.com changed:

--- Comment #14 from Zeb Figura z.figura12@gmail.com --- Should be fixed by https://source.winehq.org/git/wine.git/commitdiff/46c8a637525d0f1cf67830295fb460c819b800b6.

-- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

WineHQ Bugzilla

17 Mar 17 Mar

9:27 p.m.

New subject: [Bug 51848] Multiple applications have very poor performance after 4261369e5d8 (Secondhand Lands, SPORE)

https://bugs.winehq.org/show_bug.cgi?id=51848

Alexandre Julliard julliard@winehq.org changed:

What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED

--- Comment #15 from Alexandre Julliard julliard@winehq.org --- Closing bugs fixed in 8.4.

-- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

962

Age (days ago)

1489

Last active (days ago)

wine-bugs@winehq.org

18 comments

1 participants

tags (0)

participants (1)

WineHQ Bugzilla