[Bug 38446] New: valgrind shows an unitialized variable in dlls/msi/tests/msi.c

https://bugs.winehq.org/show_bug.cgi?id=38446

Bug ID: 38446
           Summary: valgrind shows an unitialized variable in
                    dlls/msi/tests/msi.c
           Product: Wine
           Version: 1.7.41
          Hardware: x86
                OS: Linux
            Status: NEW
          Keywords: download, source, testcase, valgrind
          Severity: normal
          Priority: P2
         Component: msi
          Assignee: [e-mail]
          Reporter: [e-mail]
      Distribution: ---

==10469== Conditional jump or move depends on uninitialised value(s)
==10469==    at 0x7B84D5B5: WideCharToMultiByte (locale.c:2337)
==10469==    by 0x4A92B3A: msi_strcpy_to_awstring (install.c:198)
==10469==    by 0x4AA032D: MSI_GetComponentPath (msi.c:2864)
==10469==    by 0x4AA03F7: MsiGetComponentPathW (msi.c:2884)
==10469==    by 0x4AA37F7: MsiProvideComponentW (msi.c:4264)
==10469==    by 0x4AA358A: MsiProvideComponentA (msi.c:4213)
==10469==    by 0x4902EA8: test_MsiProvideComponent (msi.c:3456)
==10469==    by 0x494BA35: func_msi (msi.c:14403)
==10469==    by 0x499DB19: run_test (test.h:584)
==10469==    by 0x499DF53: main (test.h:666)
==10469==  Uninitialised value was created by a stack allocation
==10469==    at 0x4AA345F: MsiProvideComponentA (msi.c:4201)
==10469==

[Bug 38446] valgrind shows an unitialized variable in dlls/msi/tests/msi.c

https://bugs.winehq.org/show_bug.cgi?id=38446

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
       Distribution|---                         |Debian

[Bug 38446] valgrind shows an unitialized variable in dlls/msi/tests/msi.c

https://bugs.winehq.org/show_bug.cgi?id=38446

--- Comment #1 from Hans Leidekker  ---
Created attachment 51300
  --> https://bugs.winehq.org/attachment.cgi?id=51300
patch

Can you try this patch?

[Bug 38446] valgrind shows an unitialized variable in dlls/msi/tests/msi.c

https://bugs.winehq.org/show_bug.cgi?id=38446

--- Comment #2 from Austin English  ---
(In reply to Hans Leidekker from comment #1)
> Created attachment 51300 [details]
> patch
>
> Can you try this patch?

Works here, thanks.

[Bug 38446] valgrind shows an unitialized variable in dlls/msi/tests/msi.c

https://bugs.winehq.org/show_bug.cgi?id=38446

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
      Fixed by SHA1|                            |55b678e18686862e25d1dc310d2
                   |                            |7a6f2c751dadf
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #3 from Austin English  ---
(In reply to Hans Leidekker from comment #1)
> Created attachment 51300 [details]
> patch
>
> Can you try this patch?

https://source.winehq.org/git/wine.git/commitdiff/55b678e18686862e25d1dc310d...

[Bug 38446] valgrind shows an unitialized variable in dlls/msi/tests/msi.c

https://bugs.winehq.org/show_bug.cgi?id=38446

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #4 from Alexandre Julliard  ---
Closing bugs fixed in 1.7.42.