[Bug 58547] New: Roblox Studio has a strange window behavior on winewayland driver

[WineHQ Bugzilla]

http://bugs.winehq.org/show_bug.cgi?id=58547

Bug ID: 58547
           Summary: Roblox Studio has a strange window behavior on
                    winewayland driver
           Product: Wine
           Version: 10.12
          Hardware: x86-64
               URL: https://setup.rbxcdn.com/RobloxStudioInstaller.exe
                OS: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: winewayland
          Assignee: [e-mail]
          Reporter: [e-mail]
                CC: [e-mail]
   Regression SHA1: c756ea4e801d7eae32bc8a00efa26fc0f0f47819
      Distribution: ArchLinux

Created attachment 79047
  --> http://bugs.winehq.org/attachment.cgi?id=79047
Terminal logs without reverting the guilty commit. Almost no difference on the
post-revert version.

Wine version 10.11 had introduced a new update to winewayland driver that makes
Roblox Studio on Wayland more usable, sometimes more than it's X11 counterpart
due to lesser microstutters and almost non-existent flickering (most likely due
to buggy implementation of the Vulkan child windowing system).

Ever since the patch introduced in c756ea4e801d7eae32bc8a00efa26fc0f0f47819,
Studio on winewayland is broken again like <=10.10 (e.g. invisible home screen,
out-of-place teamcreate/contribute button, 3D workspace layer overriding GUIs
including the script viewer, etc).

Since the issue is only viewable after logging in, it's recommended to use
Vinegar (from Flathub or by source: https://github.com/vinegarhq/vinegar - the
launcher does allow specifying a custom wineroot), but the official installer
can also be used if the EdgeWebView2 installer payload returns success to the
official installer.

[Bug 58547] Roblox Studio has a strange window behavior on winewayland driver

[WineHQ Bugzilla]

http://bugs.winehq.org/show_bug.cgi?id=58547

--- Comment #1 from Wilson  ---
Created attachment 79048
  --> http://bugs.winehq.org/attachment.cgi?id=79048
Screen recording of the occuring issue.

[Bug 58547] Roblox Studio has a strange window behavior on winewayland driver

[WineHQ Bugzilla]

http://bugs.winehq.org/show_bug.cgi?id=58547

Wilson  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |download, regression

[Bug 58547] Roblox Studio has a strange window behavior on winewayland driver

[WineHQ Bugzilla]

http://bugs.winehq.org/show_bug.cgi?id=58547

--- Comment #2 from Wilson  ---
Forgot to mention that since version 681, Roblox Studio requires
VirtualProtectFromApp which isn't correctly declared, thus causing it to crash
before the splash screen, thus requiring this MR patch to be applied:
https://gitlab.winehq.org/wine/wine/-/merge_requests/8553

And yes, simply reversing the guilty commit, even on the current upstream
commit does fix the winewayland issue.

[Bug 58547] Roblox Studio has a strange window behavior on winewayland driver

[WineHQ Bugzilla]

http://bugs.winehq.org/show_bug.cgi?id=58547

--- Comment #3 from Wilson  ---
Created attachment 79051
  --> http://bugs.winehq.org/attachment.cgi?id=79051
Semi-reversion patch that solves the issue on current upstream Wine

While using a Wine build right before the faulty commit, semi-reversing the
entire commit's patch by simply removing the `if (new_client !=
data->client_surface)` bracket (and taking out everything inside the bracket,
without modifying anything inside the bracket) does solve the issue regarding
to Roblox Studio on winewayland.

Since the commmit was supposed to fix Vulkan flickering on certain compositors
with explicit sync, I have yet to test if by only removing the "faulty" if
bracket and taking out everything inside it, the Vulkan flickering on those
compositors are still occuring or not.