[Bug 55414] New: Ultimate Spider-Man: Widescreen Fix shifts HUD too much to the right

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=55414

Bug ID: 55414
           Summary: Ultimate Spider-Man: Widescreen Fix shifts HUD too
                    much to the right
           Product: Wine
           Version: 8.13
          Hardware: x86-64
                OS: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: -unknown
          Assignee: [e-mail]
          Reporter: [e-mail]
      Distribution: ---

Created attachment 74975
  --> https://bugs.winehq.org/attachment.cgi?id=74975
Logs taken from fresh prefix, with `WINEDEBUG=warn+all`

The game Ultimate Spider-Man works well in Wine (I played it from start to
finish).
I also played with the Widescreen Fix, which works except for one thing.

The mod offers the option (enabled by default) to fix the HUD (without it, the
HUD would be stretched). That is the problematic part under Wine, because with
it the HUD is shifted too much to the right, rendering the mod unusable.

It works no problem with it disabled (which is how I played).

So, to reproduce:
- Install Ultimate Spider-Man
- Install the mod:
https://github.com/ThirteenAG/WidescreenFixesPack/releases/tag/usm
- Set `WINEDLLOVERRIDES` for `dsound`
- Make sure that in the mod settings, `FixHUD` is set to `1` (it's the default)
- Launch the game, you should see the problem right in the main menu.

Source code of the mod:
https://github.com/ThirteenAG/WidescreenFixesPack/tree/master/source/Ultimat...
Images of the issue (made an issue on GitHub in case the issue wasn't on from
Wine's side): https://github.com/ThirteenAG/WidescreenFixesPack/issues/1309

[Bug 55414] Ultimate Spider-Man: Widescreen Fix shifts HUD too much to the right

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=55414

--- Comment #1 from [e-mail] ---
Created attachment 74976
  --> https://bugs.winehq.org/attachment.cgi?id=74976
Backtrace when closing the game in this condition

If the game is closed with the Widescreen Fix enabled (and FixHUD=1), the game
crashes, leaving this backtrace.
(No crashes occur without these conditions)

[Bug 55414] Ultimate Spider-Man: Widescreen Fix shifts HUD too much to the right

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=55414

--- Comment #2 from [e-mail] ---
I just found out that with `WINEDLLOVERRIDES="dsound=n,b;msvcr71=n,b"`, then
the HUD will be shifted correctly.

I also tried removing `msvcr71.dll` from the game's directory and install it
with winetricks (`winetricks vcrun2003`), the HUD is shifted correctly there
too.

In conclusion: Wine has a problem with `msvcr71`'s implementation.

(Which component should I set in this bug report?)

[Bug 55414] Ultimate Spider-Man: Widescreen Fix shifts HUD too much to the right

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=55414

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|-unknown                    |msvcrt

[Bug 55414] Ultimate Spider-Man: Widescreen Fix shifts HUD too much to the right

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=55414

Piotr Caban  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #3 from Piotr Caban  ---
This bug is similar to https://bugs.winehq.org/show_bug.cgi?id=27594

The main difference is that the application uses msvcr71 that probably
shouldn't touch sse control word at all.

[Bug 55414] Ultimate Spider-Man: Widescreen Fix shifts HUD too much to the right

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=55414

--- Comment #4 from Piotr Caban  ---
I've created MR that should fix it:
https://gitlab.winehq.org/wine/wine/-/merge_requests/3634

[Bug 55414] Ultimate Spider-Man: Widescreen Fix shifts HUD too much to the right

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=55414

--- Comment #5 from [e-mail] ---
Tested the MR, it fixes the problem!

[Bug 55414] Ultimate Spider-Man: Widescreen Fix shifts HUD too much to the right

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=55414

Piotr Caban  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
      Fixed by SHA1|                            |254dd0a2b24dbc14c5f6c7a1078
                   |                            |eacb287a5906a
             Status|UNCONFIRMED                 |RESOLVED

--- Comment #6 from Piotr Caban  ---
The patch was merged to wine. Marking as fixed.

[Bug 55414] Ultimate Spider-Man: Widescreen Fix shifts HUD too much to the right

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=55414

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #7 from Alexandre Julliard  ---
Closing bugs fixed in 8.15.

[Bug 55414] Ultimate Spider-Man: Widescreen Fix shifts HUD too much to the right

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=55414

Michael Stefaniuc  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |8.0.x

[Bug 55414] Ultimate Spider-Man: Widescreen Fix shifts HUD too much to the right

[WineHQ Bugzilla]

http://bugs.winehq.org/show_bug.cgi?id=55414

Michael Stefaniuc  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|8.0.x                       |---