[Bug 58488] New: Bejeweled 3: black screen on start

[WineHQ Bugzilla]

http://bugs.winehq.org/show_bug.cgi?id=58488

Bug ID: 58488
           Summary: Bejeweled 3: black screen on start
           Product: Wine
           Version: 10.12
          Hardware: x86-64
               URL: https://store.steampowered.com/app/78000/Bejeweled_3/
                OS: Linux
            Status: NEW
          Keywords: regression
          Severity: normal
          Priority: P2
         Component: winex11.drv
          Assignee: [e-mail]
          Reporter: [e-mail]
                CC: [e-mail]
   Regression SHA1: ae487930f8d3811a7434dc2cbb561982c894f5ba
      Distribution: ---

In Wine-10.12 the black screen issue reappeared. (bug #58373)

This time it was caused by
commit ae487930f8d3811a7434dc2cbb561982c894f5ba
winex11: Create client surfaces for opengl drawables.

The patch from bug #58459 fixes the problem (attachment #78940)

Nvidia binary drivers 575.64.03
X.Org X Server 1.21.1.18

[Bug 58488] Bejeweled 3: black screen on start

[WineHQ Bugzilla]

http://bugs.winehq.org/show_bug.cgi?id=58488

Stian Low  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #1 from Stian Low  ---
(In reply to Béla Gyebrószki from comment #0)
> In Wine-10.12 the black screen issue reappeared. (bug #58373)
>
> This time it was caused by
> commit ae487930f8d3811a7434dc2cbb561982c894f5ba
> winex11: Create client surfaces for opengl drawables.
>
> The patch from bug #58459 fixes the problem (attachment #78940 [details])
>
> Nvidia binary drivers 575.64.03
> X.Org X Server 1.21.1.18

Confirmed working without black screen bug for wine-10.11-217-g3c4cc9d04b6 with
patch from bug #58459 applied.

[Bug 58488] Bejeweled 3: black screen on start

[WineHQ Bugzilla]

http://bugs.winehq.org/show_bug.cgi?id=58488

MarcinZw  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #2 from MarcinZw  ---
I'm experiencing a similar issue with Colin Mcrae Rally 2 -
https://www.myabandonware.com/game/colin-mcrae-rally-2-0-bgj. After the intro
video plays, the screen isn't drawn anymore. This happens when I run the game
in "Emulate a virtual desktop" mode – I can still hear the sound, but the
visuals are gone. It works fine in fullscreen.

A bisect showed that the problem is this commit: 
commit ae487930f8d3811a7434dc2cbb561982c894f5ba
winex11: Create client surfaces for opengl drawables.

I tried applying the patch from bug #58459, but it didn't fix the problem. The 
screen still isn't drawn when using the virtual desktop.

[Bug 58488] Bejeweled 3: black screen on start

[WineHQ Bugzilla]

http://bugs.winehq.org/show_bug.cgi?id=58488

--- Comment #3 from MarcinZw  ---
I ran into another issue. This time it’s with WinUAE — after hitting "Start".
In Sway, it creates "XWayland unmanaged surface" that shows up as a black
rectangle in the top-left corner of the screen.

Bisect points to this commit:

commit 62449bcfec546a7d52fd4c556c239a28c107b207
win32u: Update client surfaces when window state changes.

Looks like it might be related. This time it works fine when using "Emulate a
virtual desktop".

[Bug 58488] Bejeweled 3: black screen on start

[WineHQ Bugzilla]

http://bugs.winehq.org/show_bug.cgi?id=58488

--- Comment #4 from Ken Sharp  ---
> I ran into another issue

One issue = one bug report.
Please open a new bug report, don't just add them to the end of others.

[Bug 58488] Bejeweled 3: black screen on start

[WineHQ Bugzilla]

http://bugs.winehq.org/show_bug.cgi?id=58488

--- Comment #5 from MarcinZw  ---
(In reply to Ken Sharp from comment #4)
> > I ran into another issue
>
> One issue = one bug report.
> Please open a new bug report, don't just add them to the end of others.

Okay, sure. I just think they are related, as in fullscreen Colin, the screen 
is also rendered as an XWayland unmanaged window (override redirect). Although 
it works, it looks rather ugly in Sway. There seem to be a lot more problems 
with recent patches, which is why I reported the bug here, as they appear 
connected to this one.

[Bug 58488] Bejeweled 3: black screen on start

[WineHQ Bugzilla]

http://bugs.winehq.org/show_bug.cgi?id=58488

--- Comment #6 from MarcinZw  ---
The following patch fixes the screen update issue in Colin McRae Rally 2 when
emulating a virtual desktop. It might not cover all cases.

--- a/dlls/winex11.drv/opengl.c
+++ b/dlls/winex11.drv/opengl.c
@@ -1462,7 +1462,7 @@ static BOOL x11drv_surface_swap( struct opengl_drawable
*base )
         if (pglXWaitForSbcOML) pglXWaitForSbcOML( gdi_display, gl->drawable,
target_sbc, &ust, &msc, &sbc );
     }

-    if (InterlockedCompareExchange( &base->client->offscreen, 0, 0 ))
+    //if (InterlockedCompareExchange( &base->client->offscreen, 0, 0 ))
     {
         if (!pglXWaitForSbcOML) XFlush( gdi_display );
         client_surface_present( base->client, gl->hdc );

[Bug 58488] Bejeweled 3: black screen on start

[WineHQ Bugzilla]

http://bugs.winehq.org/show_bug.cgi?id=58488

--- Comment #7 from Béla Gyebrószki  ---
(In reply to MarcinZw from comment #6)
> The following patch fixes the screen update issue in Colin McRae Rally 2
> when emulating a virtual desktop. It might not cover all cases.
>
> --- a/dlls/winex11.drv/opengl.c
> +++ b/dlls/winex11.drv/opengl.c
> @@ -1462,7 +1462,7 @@ static BOOL x11drv_surface_swap( struct
> opengl_drawable *base )
>          if (pglXWaitForSbcOML) pglXWaitForSbcOML( gdi_display,
> gl->drawable, target_sbc, &ust, &msc, &sbc );
>      }
> - if (InterlockedCompareExchange( &base->client->offscreen, 0, 0 ))
> - //if (InterlockedCompareExchange( &base->client->offscreen, 0, 0 ))
> {
>     if (!pglXWaitForSbcOML) XFlush( gdi_display );
>     client_surface_present( base->client, gl->hdc );

This also fixes the black screen issue in Bejeweled 3.

[Bug 58488] Bejeweled 3: black screen on start

[WineHQ Bugzilla]

http://bugs.winehq.org/show_bug.cgi?id=58488

Rémi Bernon  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
      Fixed by SHA1|                            |980a2e3c65bee1422adbe06fead
                   |                            |768669835e3e1
         Resolution|---                         |FIXED
             Status|NEW                         |RESOLVED

--- Comment #8 from Rémi Bernon  ---
This should be fixed after 980a2e3c65bee1422adbe06fead768669835e3e1

[Bug 58488] Bejeweled 3: black screen on start

[WineHQ Bugzilla]

http://bugs.winehq.org/show_bug.cgi?id=58488

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #9 from Alexandre Julliard  ---
Closing bugs fixed in 10.13.

[Bug 58488] Bejeweled 3: black screen on start

[WineHQ Bugzilla]

http://bugs.winehq.org/show_bug.cgi?id=58488

--- Comment #10 from MarcinZw  ---
The regression is still present in Wine 10.13. The patch I provided earlier 
fixes the problem.

[Bug 58488] Bejeweled 3: black screen on start

[WineHQ Bugzilla]

http://bugs.winehq.org/show_bug.cgi?id=58488

--- Comment #11 from Béla Gyebrószki  ---
(In reply to MarcinZw from comment #10)
> The regression is still present in Wine 10.13. The patch I provided earlier 
> fixes the problem.

Works for me in Wine-10.13, Nvidia 580.76.05, X.Org 1.21.1.18, XFCE 4.20.

[Bug 58488] Bejeweled 3: black screen on start

[WineHQ Bugzilla]

http://bugs.winehq.org/show_bug.cgi?id=58488

--- Comment #12 from Béla Gyebrószki  ---
(In reply to MarcinZw from comment #10)
> The regression is still present in Wine 10.13. The patch I provided earlier 
> fixes the problem.

Ah, you probably meant Colin McRae Rally 2. I don't have that game. I was
referring to Bejeweled 3.
Maybe worth opening a new bug report for that game if the problem persists for
you.

[Bug 58488] Bejeweled 3: black screen on start

[WineHQ Bugzilla]

http://bugs.winehq.org/show_bug.cgi?id=58488

--- Comment #13 from MarcinZw  ---
If this release fixes the issue for you, and you've reported it, it's likely a
separate bug. I'll open a new report. Thanks.