[Bug 55979] New: Blizzard Battle.net Launcher: New Version Released On 11/30/2023 Hangs During Installation

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=55979

Bug ID: 55979
           Summary: Blizzard Battle.net Launcher: New Version Released On
                    11/30/2023 Hangs During Installation
           Product: Wine
           Version: unspecified
          Hardware: x86-64
                OS: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: -unknown
          Assignee: [e-mail]
          Reporter: [e-mail]
      Distribution: ---

Created attachment 75569
  --> https://bugs.winehq.org/attachment.cgi?id=75569
Terminal output when running the Battle.net client installer in a clean Wine
prefix

When attempting to install Battle.net in a clean 64-bit prefix on a clean
install of Linux Mint 21.2 with all needed dependencies, I get the attached
terminal output and the progress hangs at 45%.

Also, I know the maintainers of Bugzilla encourage reporting only one problem
per bug. That being said, the exact same time this started happening, my
existing Wine prefix for Battle.net (and my Battle.net games) caused thread
crashes when opening Battle.net after installing yesterday's update. The update
was installed from within the Battle.net client by clicking the green icon to
install the update. Prior to this update released yesterday on November 30,
2023, Battle.net and the games were running flawlessly.

Because I can only add a single attachment, the Pastebin links below will give
more detail on the related issue of thread crashes described above:

Existing prefix terminal output when the thread crash occurs:

https://pastebin.com/4UwxTsEP

Here is my system information:

https://pastebin.com/v3MVemgg

Was able to save a crash report for the thread crash issue:

https://pastebin.com/mYX68NrX

[Bug 55979] Blizzard Battle.net Launcher: New Version Released On 11/30/2023 Hangs During Installation

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=55979

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|unspecified                 |8.21

[Bug 55979] Blizzard Battle.net Launcher: New Version Released On 11/30/2023 Hangs During Installation

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=55979

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 55979] Blizzard Battle.net Launcher: New Version Released On 11/30/2023 Hangs During Installation

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=55979

--- Comment #1 from [e-mail] ---
When discussing this on the WineHQ subreddit, a user by the name of rage2021
has confirmed this bug via a comment:

https://www.reddit.com/r/winehq/comments/187z58y/battlenet_launcher_update_c...

[Bug 55979] Blizzard Battle.net Launcher: New Version Released On 11/30/2023 Hangs During Installation

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=55979

--- Comment #2 from [e-mail] ---
As a further note, using thirds party Wine runners resolves the thread crashing
issue. Specifically, I installed the Lutris Wine-GE runner from here:

https://github.com/GloriousEggroll/wine-ge-custom

Now the Battle.net launcher in the existing Wine prefix works successfully.

[Bug 55979] Blizzard Battle.net Launcher: New Version Released On 11/30/2023 Hangs During Installation

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=55979

Olivier F. R. Dierick  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #3 from Olivier F. R. Dierick  ---
*** Bug 55976 has been marked as a duplicate of this bug. ***

[Bug 55979] Blizzard Battle.net Launcher: New Version Released On 11/30/2023 Hangs During Installation

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=55979

Olivier F. R. Dierick  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #4 from Olivier F. R. Dierick  ---
*** Bug 55980 has been marked as a duplicate of this bug. ***

[Bug 55979] Blizzard Battle.net Launcher: New Version Released On 11/30/2023 Hangs During Installation

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=55979

Olivier F. R. Dierick  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
     Ever confirmed|0                           |1
                 CC|                            |[e-mail]
             Status|UNCONFIRMED                 |NEW

--- Comment #5 from Olivier F. R. Dierick  ---
Hello,

Confirming from my own experience.

As mentioned on bug 55980: It's possible to downgrade the application if you
have an older Battle.net.XXXXX directory in drive_c/Program Files
(x86)/Battle.net/, but this won't work if you have to login, as the app will
update and force you to restart before you have a chance to enter your
credentials.

From the linked reddit discussion, the issue is worked-around downstream with a
hack (by Paul Gofman) from Valve/Proton:
https://github.com/ValveSoftware/wine/commit/98bce52ddf46c0c8c6be57c27d4aa9c...

Wine-GE is based on Proton, which is based on wine-staging.
wine-staging has a ntdll-WRITECOPY patchset, but enabling it doesn't help with
the issue.

Regards.

[Bug 55979] Blizzard Battle.net Launcher: New Version Released On 11/30/2023 Hangs During Installation

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=55979

PeterG  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #6 from PeterG  ---
As mentioned, deleting the Battle.net.14542 folder and using an older folder
works until the app updates itself when you run it. 
However, if you delete the Battle.net.14542 folder and replace it with a
symlink to the older folder, the app can not update itself when it runs.

e.g.  Open a terminal inside the Battle.net folder after deleting the
Battle.net.14542 folder:

ln -s ./Battle.net.14494 ./Battle.net.14542

[Bug 55979] Blizzard Battle.net Launcher: New Version Released On 11/30/2023 Hangs During Installation

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=55979

Peter van de Werken  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 55979] Blizzard Battle.net Launcher: New Version Released On 11/30/2023 Hangs During Installation

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=55979

Ker noa  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 55979] Blizzard Battle.net Launcher: New Version Released On 11/30/2023 Hangs During Installation

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=55979

Grigory Vasilyev  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #7 from Grigory Vasilyev  ---
(In reply to Olivier F. R. Dierick from comment #5)
> Hello,
>
> Confirming from my own experience.
>
> As mentioned on bug 55980: It's possible to downgrade the application if you
> have an older Battle.net.XXXXX directory in drive_c/Program Files
> (x86)/Battle.net/, but this won't work if you have to login, as the app will
> update and force you to restart before you have a chance to enter your
> credentials.
>
> From the linked reddit discussion, the issue is worked-around downstream
> with a hack (by Paul Gofman) from Valve/Proton:
> https://github.com/ValveSoftware/wine/commit/
> 98bce52ddf46c0c8c6be57c27d4aa9c48303798b
>
> Wine-GE is based on Proton, which is based on wine-staging.
> wine-staging has a ntdll-WRITECOPY patchset, but enabling it doesn't help
> with the issue.
>
> Regards.

I made my own patch and solved battle.net crash. But there are other problems
with wine-9.0rc1 that are interfering with blizzard games. For example, my fps
is about 55 instead of 240.
https://pastebin.com/TTPuqyV6

[Bug 55979] Blizzard Battle.net Launcher: New Version Released On 11/30/2023 Hangs During Installation

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=55979

Liz Fong-Jones  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 55979] Blizzard Battle.net Launcher: New Version Released On 11/30/2023 Hangs During Installation

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=55979

--- Comment #8 from Liz Fong-Jones  ---
See also #29384 - this is a possible CEF problem since battle.net updated their
CEF to one with the regression (but sadly not past the commit that fixes the
regression).

[Bug 55979] Blizzard Battle.net Launcher: New Version Released On 11/30/2023 Hangs During Installation

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=55979

Jean DELVARE  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 55979] Blizzard Battle.net Launcher: New Version Released On 11/30/2023 Hangs During Installation

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=55979

Jay  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 55979] Blizzard Battle.net Launcher: New Version Released On 11/30/2023 Hangs During Installation

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=55979

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 55979] Blizzard Battle.net Launcher: New Version Released On 11/30/2023 Hangs During Installation

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=55979

--- Comment #9 from Jean DELVARE  ---
The WINE_SIMULATE_WRITECOPY=1 trick doesn't work for me (wine-staging 9.0-rc2,
openSUSE package). Do I understand correctly that the code handling this
environment variable is a downstream workaround and isn't present in upstream
wine yet?

[Bug 55979] Blizzard Battle.net Launcher: New Version Released On 11/30/2023 Hangs During Installation

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=55979

--- Comment #10 from Olivier F. R. Dierick  ---
(In reply to Jean DELVARE from comment #9)
> The WINE_SIMULATE_WRITECOPY=1 trick doesn't work for me (wine-staging
> 9.0-rc2, openSUSE package). Do I understand correctly that the code handling
> this environment variable is a downstream workaround and isn't present in
> upstream wine yet?

Hello,

Yes, that is a Valve/Proton hack. It's not included in wine or wine-staging.
GloriousEggroll's wine-ge-custom includes it. I don't know about others wine
forks.

If you want the hack in wine or wine-staging, you'll have to apply the patch
from comment 7 on the source code and compile it. Note that the patch won't
apply cleanly on wine-staging.

Regards.

[Bug 55979] Blizzard Battle.net Launcher: New Version Released On 11/30/2023 Hangs During Installation

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=55979

--- Comment #11 from Jean DELVARE  ---
I tried backporting the workaround to wine-staging, but Battle.net still
crashes for me with an "unhandled stack overflow". Apparently I'll have a to
let more seasoned wine developers deal with the issue.

I hope that we can come up with a workaround in wine-staging soon, because the
next WotLK update on the server side will certainly require a client-side game
update as well, and I won't be able to perform that update without a working
Battle.net client.

[Bug 55979] Blizzard Battle.net Launcher: New Version Released On 11/30/2023 Hangs During Installation

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=55979

--- Comment #12 from Olivier F. R. Dierick  ---
(In reply to Jean DELVARE from comment #11)
> I tried backporting the workaround to wine-staging, but Battle.net still
> crashes for me with an "unhandled stack overflow". Apparently I'll have a to
> let more seasoned wine developers deal with the issue.
>
> I hope that we can come up with a workaround in wine-staging soon, because
> the next WotLK update on the server side will certainly require a
> client-side game update as well, and I won't be able to perform that update
> without a working Battle.net client.

Hello,

Ideally, the ntdll-WRITECOPY patchset of wine-staging should be revised.

In the meantime, I'll try to patch wine-staging 9.0-rc2 too and report what I
can find.

Regards.

[Bug 55979] Blizzard Battle.net Launcher: New Version Released On 11/30/2023 Hangs During Installation

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=55979

--- Comment #13 from Olivier F. R. Dierick  ---
Created attachment 75723
  --> https://bugs.winehq.org/attachment.cgi?id=75723
Hack for wine-staging

Hello,

I'm unable to reproduce a stack overflow with a shared wow64 build of
wine-staging 9.0-rc2 and the attached patch.

I tested from scratch: Fresh Battle.net installer download in a new 64-bit
wineprefix in its initial state.

Regards.

[Bug 55979] Blizzard Battle.net Launcher: New Version Released On 11/30/2023 Hangs During Installation

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=55979

--- Comment #14 from Jean DELVARE  ---
Thanks Olivier, but still no luck for me with your patch. I suppose my problem
is slightly different from the one being reported here, even though it appeared
with the same Battle.net update and the workaround seems to work for everyone
else. I don't get it :-(

[Bug 55979] Blizzard Battle.net Launcher: New Version Released On 11/30/2023 Hangs During Installation

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=55979

--- Comment #15 from [e-mail] ---
(In reply to Jean DELVARE from comment #14)
> Thanks Olivier, but still no luck for me with your patch. I suppose my
> problem is slightly different from the one being reported here, even though
> it appeared with the same Battle.net update and the workaround seems to work
> for everyone else. I don't get it :-(

Rest assured, you are not alone.
Personally, I'm waiting for wine-staging to contain all what is needed.

[Bug 55979] Blizzard Battle.net Launcher: New Version Released On 11/30/2023 Hangs During Installation

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=55979

--- Comment #16 from [e-mail] ---
(In reply to Jean DELVARE from comment #14)
> Thanks Olivier, but still no luck for me with your patch. I suppose my
> problem is slightly different from the one being reported here, even though
> it appeared with the same Battle.net update and the workaround seems to work
> for everyone else. I don't get it :-(

https://bugs.winehq.org/show_bug.cgi?id=29384#c56 worked for me !

[Bug 55979] Blizzard Battle.net Launcher: New Version Released On 11/30/2023 Hangs During Installation

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=55979

--- Comment #17 from Joshua  ---
I am finding it's still broken with the hack applied, fresh .wine prefix,
launched with PATH=~/wine/bin:$PATH WINEARCH=win64 WINEPREFIX=~/.wine2 wine
Battle.net-Setup.exe (needs to be a 64 bit wine prefix or there will just be
problems further down the line as something doesn't like 32 bit even though it
says it does)

[Bug 55979] Blizzard Battle.net Launcher: New Version Released On 11/30/2023 Hangs During Installation

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=55979

Igor Polyakov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #18 from Igor Polyakov  ---
(In reply to PeterG from comment #6)
> As mentioned, deleting the Battle.net.14542 folder and using an older folder
> works until the app updates itself when you run it. 
> However, if you delete the Battle.net.14542 folder and replace it with a
> symlink to the older folder, the app can not update itself when it runs.
>
> e.g.  Open a terminal inside the Battle.net folder after deleting the
> Battle.net.14542 folder:
> ln -s ./Battle.net.14494 ./Battle.net.14542

this hack works with the new version as well

delete the old folder then:

ln -s ./Battle.net.14494 ./Battle.net.14589

[Bug 55979] Blizzard Battle.net Launcher: New Version Released On 11/30/2023 Hangs During Installation

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=55979

Alexander Potashev  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 55979] Blizzard Battle.net Launcher: New Version Released On 11/30/2023 Hangs During Installation

[WineHQ Bugzilla]

http://bugs.winehq.org/show_bug.cgi?id=55979

zefkerr  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]