[Bug 51386] New: ln.exe needs KERNEL32.dll.FindFirstFileNameW

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=51386

Bug ID: 51386
           Summary: ln.exe needs KERNEL32.dll.FindFirstFileNameW
           Product: Wine
           Version: 6.12
          Hardware: x86-64
               URL: https://web.archive.org/web/20210530064017/https://sch
                    inagl.priv.at/nt/ln/ln.html
                OS: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: kernel32
          Assignee: [e-mail]
          Reporter: [e-mail]
      Distribution: Ubuntu

ln.exe, a command line utility that works with hard links and symbolic links,
can crash during a "deloreon copy" (incremental backup). Specifically, the
command used was this:

ln --backup --unroll --1023safe --progress --delorean <source directory>
<previous backup dir> <new backup dir>

When it crashes, the terminal output says:

wine: Call from 7BC2980A to unimplemented function
KERNEL32.dll.FindFirstFileNameW, aborting

Sometimes the command completes without crashing, so apparently it doesn't
always call this function?

Note: the 32-bit version of ln.exe was used. I haven't tested the 64-bit
version.

[Bug 51386] ln.exe needs KERNEL32.dll.FindFirstFileNameW

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=51386

A Wine user  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |download, source

--- Comment #1 from A Wine user  ---
Source code is available here, in the "ln" subfolder:
https://gitlab.com/schinagl/link-shell-extension

[Bug 51386] ln.exe needs KERNEL32.dll.FindFirstFileNameW

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=51386

Jactry Zeng  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 51386] ln.exe needs KERNEL32.dll.FindFirstFileNameW

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=51386

Mejituu  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #2 from Mejituu  ---
Created attachment 75073
  --> https://bugs.winehq.org/attachment.cgi?id=75073
WeChat KERNEL32.dll.FindFirstFileNameW

WeChat crash log also requires KERNEL32.dll.FindFirstFileNameW

[Bug 51386] ln.exe needs KERNEL32.dll.FindFirstFileNameW

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=51386

--- Comment #3 from Mejituu  ---
Latest version 8.14 winehq-devel winehq-staging
and WeChat 3.9.6.32 x86

[Bug 51386] ln.exe needs KERNEL32.dll.FindFirstFileNameW

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=51386

[e-mail]  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #4 from [e-mail]  ---
Same error on:
Latest version 8.16 winehq-devel
and WeChat 3.9.7.24 x86

[Bug 51386] ln.exe needs KERNEL32.dll.FindFirstFileNameW

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=51386

Louis Lenders  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #5 from Louis Lenders  ---
Created attachment 77157
  --> https://bugs.winehq.org/attachment.cgi?id=77157
stub for FindFirstFileNameW patch

I guess attached patch with stub might be enough for wechat, but for the first
mentioned ln.exe a real implementation would be needed???

Any chance you could try out to attached patch?

[Bug 51386] ln.exe needs KERNEL32.dll.FindFirstFileNameW

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=51386

Louis Lenders  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #77157|0                           |1
        is obsolete|                            |

--- Comment #6 from Louis Lenders  ---
Created attachment 77158
  --> https://bugs.winehq.org/attachment.cgi?id=77158
stub for FindFirstFileNameW patch fixed spec entry

Here's patch again with fixed copy/paste typo

[Bug 51386] ln.exe needs KERNEL32.dll.FindFirstFileNameW

[WineHQ Bugzilla]

http://bugs.winehq.org/show_bug.cgi?id=51386

Andrew Nguyen  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|UNCONFIRMED                 |RESOLVED
      Fixed by SHA1|                            |7c1fbc40b7ed0b9b1f2c96b99a5
                   |                            |92530eadae14f

--- Comment #7 from Andrew Nguyen  ---
A stub was added for FindFirstFileNameW in wine-9.19 by
https://gitlab.winehq.org/wine/wine/-/commit/7c1fbc40b7ed0b9b1f2c96b99a59253...,
and as the source code for ln.exe shows fallback logic for when
FindFirstFileNameW fails on a filesystem lacking hard link support, I think the
existing stub is sufficient to call this bug fixed.

[Bug 51386] ln.exe needs KERNEL32.dll.FindFirstFileNameW

[WineHQ Bugzilla]

http://bugs.winehq.org/show_bug.cgi?id=51386

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #8 from Alexandre Julliard  ---
Closing bugs fixed in 10.9.