[Bug 58961] New: SynthFont2 crashes when attempting to launch it

[WineHQ Bugzilla]

http://bugs.winehq.org/show_bug.cgi?id=58961

Bug ID: 58961
           Summary: SynthFont2 crashes when attempting to launch it
           Product: Wine
           Version: 10.18
          Hardware: x86-64
                OS: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: -unknown
          Assignee: [e-mail]
          Reporter: [e-mail]
      Distribution: ---

Created attachment 79662
  --> http://bugs.winehq.org/attachment.cgi?id=79662
Backtrace of the described bug.

The latest version of SynthFont2 (2.9.1.1) crashes with an access violation in
SynthFont2x64.exe when opening, once the 30-day trial dialog is closed.

To reproduce:

0. Download and install the program from the following link:
https://www.synthfont.com/SynthFont2x64Setup.exe
1. Launch SynthFont2 (the main executable is "SynthFont2x64.exe", present at
"C:\Program Files\SynthFont2").
2. Dismiss the 30-day trial window ("You are on day X of the 30 day trial
period. Have fun!").
3. The app notifies of an access violation in "SynthFont2x64.exe".

Expected behaviour:

The app doesn't crash on startup.

The issue occurs on SynthFont2 v2.9.1.1 when running on Linux Mint 22.2 with
the latest wine-devel (10.18).
The issue does NOT occur on the same SynthFont version (v2.9.1.1) running on
latest Windows 10.

Additional information:

SynthFont is a MIDI player and editor for Windows. v1 is the original free
version (with less features), v2 is the newer paid version (described in this
bug report). Only v1 is listed in the AppDB, and even then it hasn't been
updated since v1.322 (released in 2009), with the latest version being 1.815.

Backtrace is attached. Not sure where to find Wine logs, so they aren't
included.

[Bug 58961] SynthFont2 crashes when attempting to launch it

[WineHQ Bugzilla]

http://bugs.winehq.org/show_bug.cgi?id=58961

Louis Lenders  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
     Ever confirmed|0                           |1
           Keywords|                            |download
                 CC|                            |[e-mail]
             Status|UNCONFIRMED                 |NEW
                URL|                            |https://www.synthfont.com/S
                   |                            |ynthFont2x64Setup.exe

--- Comment #1 from Louis Lenders  ---
Confirming.

The access violation is just after  failing call to SHGetImageList. The hack
below makes the program start for me ( SHGetImageList is called with iImageList
= -1) .
I don't know how to fix this bug, maybe one of the devs might know what's going
on.

HACK:

diff --git a/dlls/shell32/iconcache.c b/dlls/shell32/iconcache.c
index 9433361440c..7a131ce4c9d 100644
--- a/dlls/shell32/iconcache.c
+++ b/dlls/shell32/iconcache.c
@@ -1135,7 +1135,7 @@ HRESULT WINAPI SHGetImageList(int iImageList, REFIID
riid, void **ppv)
     TRACE("(%d, %s, %p)\n", iImageList, debugstr_guid(riid), ppv);

if (iImageList < 0 || iImageList > SHIL_LAST)
-        return E_FAIL;
+        iImageList = 0;//return E_FAIL;

InitOnceExecuteOnce( &sic_init_once, SIC_Initialize, NULL, NULL );
     return HIMAGELIST_QueryInterface(shell_imagelists[iImageList], riid, ppv);