[Bug 58603] New: Some games terminate uncleanly with an X Error when switching ttys

[WineHQ Bugzilla]

http://bugs.winehq.org/show_bug.cgi?id=58603

Bug ID: 58603
           Summary: Some games terminate uncleanly with an X Error when
                    switching ttys
           Product: Wine
           Version: 10.12
          Hardware: x86-64
                OS: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: -unknown
          Assignee: [e-mail]
          Reporter: [e-mail]
      Distribution: ---

Created attachment 79139
  --> http://bugs.winehq.org/attachment.cgi?id=79139
Log containing the X Errors and other debug stuff

When switching ttys, some apps terminate uncleanly, but do not crash. The
tested app in this case is Final Fantasy XIV (ffxiv_dx11.exe) which sent me on
this wild goose chase to make sure this is happening in vanilla wine-staging
(on Arch Linux) and not just in their, xivlauncher's, tuned wine version. The
second app tested is DYSMANTLE (steam version), a game that runs great in
vanilla wine and proton both. Interestingly, DYSMANTLE behaves perfectly fine
after a tty switch in proton-ge, so there is very likely a fix in proton,
somewhere.
Both apps emit the same X Error after a tty switch. Because both have the exact
same X Error, I am only attaching a single log.

[Bug 58603] Some games terminate uncleanly with an X Error when switching ttys

[WineHQ Bugzilla]

http://bugs.winehq.org/show_bug.cgi?id=58603

--- Comment #1 from Ken Sharp  ---
So this occurs in both vanilla Wine and Staging?

[Bug 58603] Some games terminate uncleanly with an X Error when switching ttys

[WineHQ Bugzilla]

http://bugs.winehq.org/show_bug.cgi?id=58603

--- Comment #2 from [e-mail] ---
I have just tested. This only happens in wine-staging, surprisingly. I did not
expect that. Normal wine is perfectly fine. Smells like a regression?
Also, I'd like to add that this is normal, native Xorg. No xwayland shenanigans
or similar.

[Bug 58603] Some games terminate uncleanly with an X Error when switching ttys

[WineHQ Bugzilla]

http://bugs.winehq.org/show_bug.cgi?id=58603

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|10.12                       |10.13

[Bug 58603] Some games terminate uncleanly with an X Error when switching ttys

[WineHQ Bugzilla]

http://bugs.winehq.org/show_bug.cgi?id=58603

--- Comment #3 from [e-mail] ---
Updated to 10.13-staging. Issue still persists. I'll see if I can bisect later.

[Bug 58603] Some games terminate uncleanly with an X Error when switching ttys

[WineHQ Bugzilla]

http://bugs.winehq.org/show_bug.cgi?id=58603

Ken Sharp  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]
                   |                            |, [e-mail]
            Product|Wine                        |Wine-staging
            Version|10.13                       |10.12
          Component|-unknown                    |-unknown

[Bug 58603] Some games terminate uncleanly with an X Error when switching ttys

[WineHQ Bugzilla]

http://bugs.winehq.org/show_bug.cgi?id=58603

--- Comment #4 from [e-mail] ---
The past 3 hours I have attempted to bisect unsuccessfully. Normal wine is
perfectly unaffected. The issue has been present since *at least* 10.7, but I
can not go farther because I am getting compilation issues below that version,
possibly due to dependency hell.

However, I believe there is another way forward: Manually deleting the patches
in wine-staging until I have found the one that is causing the issue. Yet there
are 147 patches and it would take me too long to test them all. I think maybe
it would be possible if I do them in groups, e.g delete half of them. Issue
still present? delete another half. Is this a viable approach or are there
gotchas?

[Bug 58603] Some games terminate uncleanly with an X Error when switching ttys

[WineHQ Bugzilla]

http://bugs.winehq.org/show_bug.cgi?id=58603

--- Comment #5 from Alistair Leslie-Hughes  ---
When applying patches, use the "force-autoconf" parameter to allow bisect to
work.

patchinstall.py --all --force-autoconf

[Bug 58603] Some games terminate uncleanly with an X Error when switching ttys

[WineHQ Bugzilla]

http://bugs.winehq.org/show_bug.cgi?id=58603

--- Comment #6 from [e-mail] ---
I have determined that the patch user32-rawinput-mouse is causing the issue. I
will update the title and such accordingly. What now? I am not a programmer, I
have no idea how any of the code works but give me commands to run and I will
happily help to debug this further.

[Bug 58603] Some games terminate uncleanly with an X Error when switching ttys caused by the user32-rawinput-mouse patch

[WineHQ Bugzilla]

http://bugs.winehq.org/show_bug.cgi?id=58603

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Some games terminate        |Some games terminate
                   |uncleanly with an X Error   |uncleanly with an X Error
                   |when switching ttys         |when switching ttys caused
                   |                            |by the
                   |                            |user32-rawinput-mouse patch

[Bug 58603] Some games terminate uncleanly with an X Error when switching ttys caused by the user32-rawinput-mouse patch

[WineHQ Bugzilla]

http://bugs.winehq.org/show_bug.cgi?id=58603

Zeb Figura  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #7 from Zeb Figura  ---
Thanks for the bisect, CCing patch author.