http://bugs.winehq.org/show_bug.cgi?id=3945
------- Additional Comments From xerox_xerox2000@yahoo.co.uk 2006-27-04 13:54 ------- Created an attachment (id=2348) --> (http://bugs.winehq.org/attachment.cgi?id=2348&action=view) crash in pixelshader.c
Hi, it crashes now again, see attached log. Ivan, this is caused by a patch by you. Following patch fixes it but i don't know if it's really correct. Ivan , could you have a look at it? I think curOpcode is NULL on my computer, which seems to cause the crash. What should happen in the function if this happens? Thanks.
diff --git a/dlls/wined3d/pixelshader.c b/dlls/wined3d/pixelshader.c index cb14a83..04587b4 100644 --- a/dlls/wined3d/pixelshader.c +++ b/dlls/wined3d/pixelshader.c @@ -926,7 +926,8 @@ inline static void pshader_program_get_r }
/* Fetch opcode */ - curOpcode = shader_get_opcode((IWineD3DBaseShader*) This, *pToken); + curOpcode = shader_get_opcode((IWineD3DBaseShader*) This, *pToken); + if(!curOpcode) return; ++pToken;
/* Skip declarations (for now) */