[Bug 55212] New: Need for Speed SHIFT demo crashes due to HLSL syntax error "unexpected '<', expecting ';' or ','"

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=55212

Bug ID: 55212
           Summary: Need for Speed SHIFT demo crashes due to HLSL syntax
                    error "unexpected '<', expecting ';' or ','"
           Product: vkd3d
           Version: 1.8
          Hardware: x86-64
               URL: https://www.fileplanet.com/archive/p-69053/Need-For-Sp
                    eed-Shift-Demo
                OS: Linux
            Status: NEW
          Keywords: download
          Severity: normal
          Priority: P2
         Component: hlsl
          Assignee: [e-mail]
          Reporter: [e-mail]
      Distribution: ---

Created attachment 74822
  --> https://bugs.winehq.org/attachment.cgi?id=74822
VKD3D_SHADER_DEBUG=trace WINEDEBUG=+d3dcompiler

0024:err:d3dcompiler:D3DCompile2 Failed to compile shader, vkd3d result -4.
0024:err:d3dcompiler:D3DCompile2 Shader log:
0024:err:d3dcompiler:D3DCompile2     <anonymous>:1:40: E5000: syntax error,
unexpected '<', expecting ';' or ','
0024:err:d3dcompiler:D3DCompile2

This seems to be the relevant trace:

vkd3d:0024:trace:preproc_lexer_parse float4x4 worldViewProj : WORLDVIEWPROJ <
bool appEdit = false ; > ;

[Bug 55212] Need for Speed SHIFT demo crashes due to HLSL syntax error "unexpected '<', expecting ';' or ','"

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=55212

--- Comment #1 from Nikolay Sivov  ---
That's annotations that are only used for "fx" profiles. They are still parsed
and validated on regular profiles.

[Bug 55212] Need for Speed SHIFT demo crashes due to HLSL syntax error "unexpected '<', expecting ';' or ','"

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=55212

Gijs Vermeulen  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #2 from Gijs Vermeulen  ---
*** Bug 54391 has been marked as a duplicate of this bug. ***

[Bug 55212] Need for Speed SHIFT crashes due to HLSL syntax error "unexpected '<', expecting ';' or ','"

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=55212

Gijs Vermeulen  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Need for Speed SHIFT demo   |Need for Speed SHIFT
                   |crashes due to HLSL syntax  |crashes due to HLSL syntax
                   |error "unexpected '<',      |error "unexpected '<',
                   |expecting ';' or ','"       |expecting ';' or ','"

--- Comment #3 from Gijs Vermeulen  ---
Still present with wine-8.17 and current vkd3d-git. Also present with the full
game (given bug 54391.

[Bug 55212] Need for Speed SHIFT crashes due to HLSL syntax error "unexpected '<', expecting ';' or ','"

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=55212

Christian Costa  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #4 from Christian Costa  ---
I tested with bare wine 10.4 and wine 10.4 + vkd3d
110edf32d0b2a2f0a49cdd76c977b9eedd06628e and I don't get this compilation
errors so I guess these issues are fixed.

Remaining bugs are described in https://bugs.winehq.org/show_bug.cgi?id=58045.

[Bug 55212] Need for Speed SHIFT crashes due to HLSL syntax error "unexpected '<', expecting ';' or ','"

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=55212

--- Comment #5 from Christian Costa  ---
(In reply to Christian Costa from comment #4)
> I tested with bare wine 10.4 and wine 10.4 + vkd3d
> 110edf32d0b2a2f0a49cdd76c977b9eedd06628e and I don't get this compilation
> errors so I guess these issues are fixed.
>
> Remaining bugs are described in
> https://bugs.winehq.org/show_bug.cgi?id=58045.

Wrong bug. Please ignore.

[Bug 55212] Need for Speed SHIFT crashes due to HLSL syntax error "unexpected '<', expecting ';' or ','"

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=55212

--- Comment #6 from Christian Costa  ---
Created attachment 78319
  --> https://bugs.winehq.org/attachment.cgi?id=78319
debug log with VKD3D_DEBUG=trace WINEDEBUG=+d3dcompiler

I tested with wine 10.4 (d3dx9_41 & d3dcompiler_47 set as builtin).
The issue is apparently fixed.
Still crashing though.