[Bug 58932] New: Some comboboxes are no longer size correctly after commit in version 10.16
http://bugs.winehq.org/show_bug.cgi?id=58932
Bug ID: 58932 Summary: Some comboboxes are no longer size correctly after commit in version 10.16 Product: Wine Version: 10.16 Hardware: x86-64 OS: Linux Status: UNCONFIRMED Severity: normal Priority: P2 Component: comctl32 Assignee: wine-bugs@list.winehq.org Reporter: cayok52759@wivstore.com Distribution: ---
Certain combo boxes are no longer sized correctly beginning in Wine 10.16 and have extra spacing below the text in them. This can be seen in a Bible study program that can be downloaded at https://www.theword.net/files/setup/getmulti.php/en.
To see the problem, the program can be installed using the "Basic" layout. From the View|Toolbars menu, enable the Formatting toolbar. In the Book documents view there should be a button called "My Subject-notes." Select that book and click inside the view. The Formatting toolbar should now appear at the top with the other toolbars. Now position all toolbars so that they are on the same row. Alternately click between the book view and another view. Because the font size combobox is now slightly too large when an editable book view is active, the program will shift its views in order to compensate. If another view is clicked in, then the Formatting toolbar will disappear and the views will shift again. Other comboboxes in the program are also affected by this regression.
The comboboxes are sized properly after reverting the commit "comctl32/combo: Don't update item height on WM_SETFONT for owner drawn CB" at https://gitlab.winehq.org/wine/wine/-/commit/9efece4a98774a9ee12bfd4d221e4e9....
The program that this is happening in is written in Delphi 12. I do not know if any non-Delphi programs exhibit this problem or not.
http://bugs.winehq.org/show_bug.cgi?id=58932
cayok cayok52759@wivstore.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Summary|Some comboboxes are no |Some comboboxes are no |longer size correctly after |longer sized correctly |commit in version 10.16 |after commit in version | |10.16
http://bugs.winehq.org/show_bug.cgi?id=58932
cayok cayok52759@wivstore.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Regression SHA1| |9efece4a98774a9ee12bfd4d221 | |e4e9395d1d9b
http://bugs.winehq.org/show_bug.cgi?id=58932
cayok cayok52759@wivstore.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Keywords| |regression
http://bugs.winehq.org/show_bug.cgi?id=58932
Paul Gofman gofmanp@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |gofmanp@gmail.com
http://bugs.winehq.org/show_bug.cgi?id=58932
--- Comment #1 from Paul Gofman gofmanp@gmail.com --- Thanks for reporting and bisecting!
What I am seeing as problems is: - The size of combobox with font sizes in formatting toolbar is a bit bigger than font selection control right when those appear (they are the same size on Windows and with blamed commit reverted); - When switching between tabs so that the text formatting toolbar disappear / appear back the outer toolbar is getting smaller or bigger, also resizing other docked windows (also doesn't happen on Windows and with the commit reverted).
I found nothing wrong so far in the blamed commit, although the problem is still in combo box implementation it looks like. The combo boxes end up with wrong size during creation from within WM_CREATE handling (which involves querying WM_MEASUREITEM since those are CBS_OWNERDRAWFIXED comboboxes). Out interpretation of MEASUREITEMSTRUCT.itemHeight turns out to be off a few pixels. Previously when WM_SETFONT was causing window resize that was accidentally getting fixed up but that's not how that works on Windows.
I sent MR upstream: https://gitlab.winehq.org/wine/wine/-/merge_requests/9427
Could you please check if that helps if possible (and also confirm that I understood the problems introduced by the blamed commit correctly)?
http://bugs.winehq.org/show_bug.cgi?id=58932
--- Comment #2 from cayok cayok52759@wivstore.com --- Thank you for the quick response! I think you described the problem accurately. I'll test it as soon as the patches have been merged.
http://bugs.winehq.org/show_bug.cgi?id=58932
Paul Gofman pgofman@codeweavers.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Fixed by SHA1| |26b28277532eb1e912516518d7d | |972e352258fc4 CC| |pgofman@codeweavers.com Status|UNCONFIRMED |RESOLVED Resolution|--- |FIXED
--- Comment #3 from Paul Gofman pgofman@codeweavers.com --- Should be fixed by 26b28277532eb1e912516518d7d972e352258fc4 .
http://bugs.winehq.org/show_bug.cgi?id=58932
--- Comment #4 from cayok cayok52759@wivstore.com --- I made a build from the git master, and it does look fixed. Thank you!
-
WineHQ Bugzilla