[Bug 58061] New: [FL Studio] When holding CTRL to zoom in the playlist, it also scrolls vertically - possible regression

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=58061

Bug ID: 58061
           Summary: [FL Studio] When holding CTRL to zoom in the playlist,
                    it also scrolls vertically - possible regression
           Product: Wine
           Version: 10.5
          Hardware: x86-64
                OS: Linux
            Status: UNCONFIRMED
          Severity: major
          Priority: P2
         Component: -unknown
          Assignee: [e-mail]
          Reporter: [e-mail]
      Distribution: ---

Created attachment 78314
  --> https://bugs.winehq.org/attachment.cgi?id=78314
video of the issue

So basically the normal behavior is that if you hold CTRL in the playlist and
scroll the mouse wheel, it only zooms and doesen't scroll, but after Wine 10.4
the bug started appearing and instead of only zooming, it also started to
scroll up and down.

I've also just tested on Windows and it works correctly, so it's not a mouse
problem, I've also tested on 2 different distros with Wine 10.4 and 10.5 and I
have the same issue on both of them.

In the video that I've attached I was holding CTRL all the time, and as you can
see it zooms in the playlist, but it also scrolls vertically, which it
shouldn't, it should only scroll vertically when I'm NOT holding down CTRL.

My system info:
NVIDIA rtx 4060 with 570.133 drivers (latest arivers at the moment)
Wayland + xwayland for Wine

[Bug 58061] [FL Studio] When holding CTRL to zoom in the playlist, it also scrolls vertically - possible regression

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=58061

--- Comment #1 from Miliardo  ---
you can download a free version of flstudio no registration required to test
this issue here: https://www.image-line.com/fl-studio-download/

[Bug 58061] [FL Studio] When holding CTRL to zoom in the playlist, it also scrolls vertically - possible regression

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=58061

--- Comment #2 from Miliardo  ---
I've also just discovered that it only happens when wine uses xwayland, if I
set wine to use the wayland driver then the issue doesen't appear anymore

[Bug 58061] [FL Studio] When holding CTRL to zoom in the playlist, it also scrolls vertically - possible regression

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=58061

--- Comment #3 from Miliardo  ---
but xwayland is still the best way to run windows software, as the wayland
driver is still incomplete and super buggy

[Bug 58061] [FL Studio] When holding CTRL to zoom in the playlist, it also scrolls vertically - possible regression

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=58061

Sagawa  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |sagawa.aki+winebugs@gmail.c
                   |                            |om

--- Comment #4 from Sagawa  ---
This issue may have been fixed by my commit,
42b0d6c682916ae3daceffff91ceae32115722ac.
Could you retest with the latest git or the upcoming 10.6 release?

[Bug 58061] [FL Studio] When holding CTRL to zoom in the playlist, it also scrolls vertically - possible regression

[WineHQ Bugzilla]

http://bugs.winehq.org/show_bug.cgi?id=58061

--- Comment #5 from Miliardo  ---
(In reply to Sagawa from comment #4)
> This issue may have been fixed by my commit,
> 42b0d6c682916ae3daceffff91ceae32115722ac.
> Could you retest with the latest git or the upcoming 10.6 release?

I would love to try it now but I can't compile wine from source, it always
fails

[Bug 58061] [FL Studio] When holding CTRL to zoom in the playlist, it also scrolls vertically - possible regression

[WineHQ Bugzilla]

http://bugs.winehq.org/show_bug.cgi?id=58061

--- Comment #6 from Miliardo  ---
(In reply to Sagawa from comment #4)
> This issue may have been fixed by my commit,
> 42b0d6c682916ae3daceffff91ceae32115722ac.
> Could you retest with the latest git or the upcoming 10.6 release?

hey I've managed to test the latest wine git and it works now, the issue
disappeared!

I'm wondering about what caused the issue in the first place, can you tell me?

[Bug 58061] [FL Studio] When holding CTRL to zoom in the playlist, it also scrolls vertically - possible regression

[WineHQ Bugzilla]

http://bugs.winehq.org/show_bug.cgi?id=58061

--- Comment #7 from Sagawa  ---
That sounds great. Thanks for testing.

In WM_MOUSEWHEEL messages of the Windows API, the wheel rotation amount is
encoded in the high-order word of wparam, while the low-order word contains key
press flags. The original code added the two wparam values together,
inadvertently merging the wheel delta with key state data and risking
inaccurate scroll behavior. The patch resolves this by extracting only the
wheel delta from each wparam.

Lastly, please don't forget to update the status as RESOLVED FIXED.

[Bug 58061] [FL Studio] When holding CTRL to zoom in the playlist, it also scrolls vertically - possible regression

[WineHQ Bugzilla]

http://bugs.winehq.org/show_bug.cgi?id=58061

Miliardo  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|---                         |FIXED

--- Comment #8 from Miliardo  ---
(In reply to Sagawa from comment #7)
> That sounds great. Thanks for testing.
>
> In WM_MOUSEWHEEL messages of the Windows API, the wheel rotation amount is
> encoded in the high-order word of wparam, while the low-order word contains
> key press flags. The original code added the two wparam values together,
> inadvertently merging the wheel delta with key state data and risking
> inaccurate scroll behavior. The patch resolves this by extracting only the
> wheel delta from each wparam.
>
> Lastly, please don't forget to update the status as RESOLVED FIXED.

Thank you for the fix and the explanation

[Bug 58061] [FL Studio] When holding CTRL to zoom in the playlist, it also scrolls vertically - possible regression

[WineHQ Bugzilla]

http://bugs.winehq.org/show_bug.cgi?id=58061

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #9 from Alexandre Julliard  ---
Closing bugs fixed in 10.6.