winehq.org
Sign In
Sign Up
Sign In
Sign Up
Manage this list
×
Keyboard Shortcuts
Thread View
j
: Next unread message
k
: Previous unread message
j a
: Jump to all threads
j l
: Jump to MailingList overview
2025
April
March
February
January
2024
December
November
October
September
August
July
June
May
April
March
February
January
2023
December
November
October
September
August
July
June
May
April
March
February
January
2022
December
November
October
September
August
July
June
May
April
March
February
January
2021
December
November
October
September
August
July
June
May
April
March
February
January
2020
December
November
October
September
August
July
June
May
April
March
February
January
2019
December
November
October
September
August
July
June
May
April
March
February
January
2018
December
November
October
September
August
July
June
May
April
March
February
January
2017
December
November
October
September
August
July
June
May
April
March
February
January
2016
December
November
October
September
August
July
June
May
April
March
February
January
2015
December
November
October
September
August
July
June
May
April
March
February
January
2014
December
November
October
September
August
July
June
May
April
March
February
January
2013
December
November
October
September
August
July
June
May
April
March
February
January
2012
December
November
October
September
August
July
June
May
April
March
February
January
2011
December
November
October
September
August
July
June
May
April
March
February
January
2010
December
November
October
September
August
July
June
May
April
March
February
January
2009
December
November
October
September
August
July
June
May
April
March
February
January
2008
December
November
October
September
August
July
June
May
April
March
February
January
2007
December
November
October
September
August
July
June
May
April
March
February
January
2006
December
November
October
September
August
July
June
May
April
March
February
January
2005
December
November
October
September
August
July
June
May
April
March
February
January
2004
December
November
October
September
August
July
June
May
April
March
February
January
2003
December
November
October
September
August
July
June
May
April
March
February
January
2002
December
November
October
September
August
July
June
May
April
March
February
January
2001
December
November
October
September
August
July
June
May
April
March
February
List overview
wine-commits
July 2009
----- 2025 -----
April 2025
March 2025
February 2025
January 2025
----- 2024 -----
December 2024
November 2024
October 2024
September 2024
August 2024
July 2024
June 2024
May 2024
April 2024
March 2024
February 2024
January 2024
----- 2023 -----
December 2023
November 2023
October 2023
September 2023
August 2023
July 2023
June 2023
May 2023
April 2023
March 2023
February 2023
January 2023
----- 2022 -----
December 2022
November 2022
October 2022
September 2022
August 2022
July 2022
June 2022
May 2022
April 2022
March 2022
February 2022
January 2022
----- 2021 -----
December 2021
November 2021
October 2021
September 2021
August 2021
July 2021
June 2021
May 2021
April 2021
March 2021
February 2021
January 2021
----- 2020 -----
December 2020
November 2020
October 2020
September 2020
August 2020
July 2020
June 2020
May 2020
April 2020
March 2020
February 2020
January 2020
----- 2019 -----
December 2019
November 2019
October 2019
September 2019
August 2019
July 2019
June 2019
May 2019
April 2019
March 2019
February 2019
January 2019
----- 2018 -----
December 2018
November 2018
October 2018
September 2018
August 2018
July 2018
June 2018
May 2018
April 2018
March 2018
February 2018
January 2018
----- 2017 -----
December 2017
November 2017
October 2017
September 2017
August 2017
July 2017
June 2017
May 2017
April 2017
March 2017
February 2017
January 2017
----- 2016 -----
December 2016
November 2016
October 2016
September 2016
August 2016
July 2016
June 2016
May 2016
April 2016
March 2016
February 2016
January 2016
----- 2015 -----
December 2015
November 2015
October 2015
September 2015
August 2015
July 2015
June 2015
May 2015
April 2015
March 2015
February 2015
January 2015
----- 2014 -----
December 2014
November 2014
October 2014
September 2014
August 2014
July 2014
June 2014
May 2014
April 2014
March 2014
February 2014
January 2014
----- 2013 -----
December 2013
November 2013
October 2013
September 2013
August 2013
July 2013
June 2013
May 2013
April 2013
March 2013
February 2013
January 2013
----- 2012 -----
December 2012
November 2012
October 2012
September 2012
August 2012
July 2012
June 2012
May 2012
April 2012
March 2012
February 2012
January 2012
----- 2011 -----
December 2011
November 2011
October 2011
September 2011
August 2011
July 2011
June 2011
May 2011
April 2011
March 2011
February 2011
January 2011
----- 2010 -----
December 2010
November 2010
October 2010
September 2010
August 2010
July 2010
June 2010
May 2010
April 2010
March 2010
February 2010
January 2010
----- 2009 -----
December 2009
November 2009
October 2009
September 2009
August 2009
July 2009
June 2009
May 2009
April 2009
March 2009
February 2009
January 2009
----- 2008 -----
December 2008
November 2008
October 2008
September 2008
August 2008
July 2008
June 2008
May 2008
April 2008
March 2008
February 2008
January 2008
----- 2007 -----
December 2007
November 2007
October 2007
September 2007
August 2007
July 2007
June 2007
May 2007
April 2007
March 2007
February 2007
January 2007
----- 2006 -----
December 2006
November 2006
October 2006
September 2006
August 2006
July 2006
June 2006
May 2006
April 2006
March 2006
February 2006
January 2006
----- 2005 -----
December 2005
November 2005
October 2005
September 2005
August 2005
July 2005
June 2005
May 2005
April 2005
March 2005
February 2005
January 2005
----- 2004 -----
December 2004
November 2004
October 2004
September 2004
August 2004
July 2004
June 2004
May 2004
April 2004
March 2004
February 2004
January 2004
----- 2003 -----
December 2003
November 2003
October 2003
September 2003
August 2003
July 2003
June 2003
May 2003
April 2003
March 2003
February 2003
January 2003
----- 2002 -----
December 2002
November 2002
October 2002
September 2002
August 2002
July 2002
June 2002
May 2002
April 2002
March 2002
February 2002
January 2002
----- 2001 -----
December 2001
November 2001
October 2001
September 2001
August 2001
July 2001
June 2001
May 2001
April 2001
March 2001
February 2001
wine-commits@winehq.org
4 participants
1067 discussions
Start a n
N
ew thread
Alexander Nicolaysen Sørnes : commentview.php: Don't allow unset or 0 versionId
by Alexander Nicolaysen Sørnes
30 Jul '09
30 Jul '09
Module: appdb Branch: master Commit: b8be6a22ce6e76489a745877fcc8c160143ac776 URL:
http://source.winehq.org/git/appdb.git/?a=commit;h=b8be6a22ce6e76489a745877…
Author: Alexander Nicolaysen Sørnes <alex(a)thehandofagony.com> Date: Thu Jul 30 21:53:49 2009 +0200 commentview.php: Don't allow unset or 0 versionId --- commentview.php | 8 +++++++- 1 files changed, 7 insertions(+), 1 deletions(-) diff --git a/commentview.php b/commentview.php index 7f2e87f..e25774d 100644 --- a/commentview.php +++ b/commentview.php @@ -12,9 +12,15 @@ require("path.php"); require(BASE."include/incl.php"); require_once(BASE."include/comment.php"); +$iVersionId = getInput('iVersionId', $aClean); +$iThreadId = getInput('iThreadId', $aClean); + +if(!$iVersionId) + util_show_error_page_and_exit('No versionId defined'); + apidb_header("Comments"); -Comment::view_app_comments($aClean['iVersionId'], $aClean['iThreadId']); +Comment::view_app_comments($iVersionId, $iThreadId); apidb_footer(); ?>
1
0
0
0
Alexander Nicolaysen Sørnes : objectManager: Prevent accessing an undefined variable
by Alexander Nicolaysen Sørnes
30 Jul '09
30 Jul '09
Module: appdb Branch: master Commit: b8ac180e11b97701d3976401cc85f043255802cb URL:
http://source.winehq.org/git/appdb.git/?a=commit;h=b8ac180e11b97701d3976401…
Author: Alexander Nicolaysen Sørnes <alex(a)thehandofagony.com> Date: Thu Jul 30 18:28:50 2009 +0200 objectManager: Prevent accessing an undefined variable --- include/objectManager.php | 5 ++--- 1 files changed, 2 insertions(+), 3 deletions(-) diff --git a/include/objectManager.php b/include/objectManager.php index 3af090c..6b324f7 100644 --- a/include/objectManager.php +++ b/include/objectManager.php @@ -104,13 +104,12 @@ class ObjectManager public function setSortInfo($aClean = null) { + $this->oSortInfo = new TableSortInfo($this->makeUrl().'&'); + /* No use to continue if there are no sortable fields */ if(!$this->getOptionalSetting("objectGetSortableFields", FALSE)) return; - $this->oSortInfo = null; - $this->oSortInfo = new TableSortInfo($this->makeUrl().'&'); - if($aClean) $this->oSortInfo->ParseArray($aClean, $this->getObject()->objectGetSortableFields()); }
1
0
0
0
Alexander Nicolaysen Sørnes : bug: Correct casing for an SQL column
by Alexander Nicolaysen Sørnes
30 Jul '09
30 Jul '09
Module: appdb Branch: master Commit: 5cce3b1c5f5252209c5707d66785928a1a6be372 URL:
http://source.winehq.org/git/appdb.git/?a=commit;h=5cce3b1c5f5252209c5707d6…
Author: Alexander Nicolaysen Sørnes <alex(a)thehandofagony.com> Date: Thu Jul 30 18:22:10 2009 +0200 bug: Correct casing for an SQL column --- include/bugs.php | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/include/bugs.php b/include/bugs.php index 45a3887..4318c46 100644 --- a/include/bugs.php +++ b/include/bugs.php @@ -36,7 +36,7 @@ class Bug if(!$oRow) { $sQuery = "SELECT * FROM buglinks - WHERE linkid = '?'"; + WHERE linkId = '?'"; if($hResult = query_parameters($sQuery, $iLinkId)) { $oRow = query_fetch_object($hResult);
1
0
0
0
Alexander Nicolaysen Sørnes : bug: Prevent duplicates when moving bug links
by Alexander Nicolaysen Sørnes
30 Jul '09
30 Jul '09
Module: appdb Branch: master Commit: 68d43b73d24f51839efd3d3d97323507e11ff3ea URL:
http://source.winehq.org/git/appdb.git/?a=commit;h=68d43b73d24f51839efd3d3d…
Author: Alexander Nicolaysen Sørnes <alex(a)thehandofagony.com> Date: Thu Jul 30 16:58:53 2009 +0200 bug: Prevent duplicates when moving bug links --- include/bugs.php | 5 +++++ 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/include/bugs.php b/include/bugs.php index 9c38fa8..45a3887 100644 --- a/include/bugs.php +++ b/include/bugs.php @@ -181,6 +181,11 @@ class Bug { $oBug = new bug($this->iLinkId); + // There is no need to have two links to a bug. The update is still + // considered successful + if($this->isDuplicate()) + return $this->delete(); + if($this->iVersionId && $this->iVersionId != $oBug->iVersionId) { $hResult = query_parameters("UPDATE buglinks SET versionId = '?'
1
0
0
0
Alexander Nicolaysen Sørnes : bug: Move duplicate detection to a separate function
by Alexander Nicolaysen Sørnes
30 Jul '09
30 Jul '09
Module: appdb Branch: master Commit: 8e9122b6f5ae4cb35359b0569fdf96ae674e0692 URL:
http://source.winehq.org/git/appdb.git/?a=commit;h=8e9122b6f5ae4cb35359b056…
Author: Alexander Nicolaysen Sørnes <alex(a)thehandofagony.com> Date: Thu Jul 30 16:52:42 2009 +0200 bug: Move duplicate detection to a separate function --- include/bugs.php | 35 +++++++++++++++++++++-------------- 1 files changed, 21 insertions(+), 14 deletions(-) diff --git a/include/bugs.php b/include/bugs.php index ed22aaf..9c38fa8 100644 --- a/include/bugs.php +++ b/include/bugs.php @@ -106,21 +106,11 @@ class Bug return false; } - /* Check for Duplicates */ - - $sQuery = "SELECT * - FROM buglinks - WHERE versionId = '?'"; - if($hResult = query_parameters($sQuery, $this->iVersionId)) + /* Check for duplicates */ + if($this->isDuplicate()) { - while($oRow = query_fetch_object($hResult)) - { - if($oRow->bug_id == $this->iBug_id) - { - addmsg("The Bug link has already been submitted.", "red"); - return false; - } - } + addmsg("The Bug link has already been submitted.", "red"); + return false; } /* passed the checks so lets insert the puppy! */ @@ -204,6 +194,23 @@ class Bug return true; } + /* Checks whether the version already has a link for this bug */ + public function isDuplicate() + { + $sQuery = "SELECT COUNT(linkId) as count + FROM buglinks + WHERE versionId = '?' + AND bug_id = '?'"; + if($hResult = query_parameters($sQuery, $this->iVersionId, $this->iBug_id)) + { + if(($oRow = query_fetch_object($hResult))) + { + return $oRow->count > 0; + } + } + return false; + } + function mailSubmitter($bRejected=false) { global $aClean;
1
0
0
0
Alexander Nicolaysen Sørnes : testData: Remove the 'test data modified' screen message
by Alexander Nicolaysen Sørnes
30 Jul '09
30 Jul '09
Module: appdb Branch: master Commit: a083c9eb0e576fb0a5330b0894891e0e134afd5e URL:
http://source.winehq.org/git/appdb.git/?a=commit;h=a083c9eb0e576fb0a5330b08…
Author: Alexander Nicolaysen Sørnes <alex(a)thehandofagony.com> Date: Thu Jul 30 16:44:45 2009 +0200 testData: Remove the 'test data modified' screen message --- include/testData.php | 1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/include/testData.php b/include/testData.php index d2d4b36..33661b1 100644 --- a/include/testData.php +++ b/include/testData.php @@ -501,7 +501,6 @@ class testData{ case "edit": $sSubject = "Test Results modified for version ".$oVersion->sName." of ".$oApp->sName." by ".$_SESSION['current']->sRealname; $sMsg .= $sBacklink; - addmsg("test data modified.", "green"); break; case "reject": $sSubject = "Test Results rejected for version ".$oVersion->sName." of ".$oApp->sName." by ".$_SESSION['current']->sRealname;
1
0
0
0
Alexander Nicolaysen Sørnes : Only show 'create new parent' link for applications
by Alexander Nicolaysen Sørnes
30 Jul '09
30 Jul '09
Module: appdb Branch: master Commit: 8fbe27e679793f29c99bd581d10f7562fb65c74b URL:
http://source.winehq.org/git/appdb.git/?a=commit;h=8fbe27e679793f29c99bd581…
Author: Alexander Nicolaysen Sørnes <alex(a)thehandofagony.com> Date: Thu Jul 30 16:06:15 2009 +0200 Only show 'create new parent' link for applications --- include/application.php | 5 +++++ include/objectManager.php | 3 ++- 2 files changed, 7 insertions(+), 1 deletions(-) diff --git a/include/application.php b/include/application.php index 4112c0b..2a1a704 100644 --- a/include/application.php +++ b/include/application.php @@ -1439,6 +1439,11 @@ class Application { return $iCount; } + public static function objectAllowMovingToNewParent() + { + return TRUE; + } + public static function allowAnonymousSubmissions() { return FALSE; diff --git a/include/objectManager.php b/include/objectManager.php index 4235279..3af090c 100644 --- a/include/objectManager.php +++ b/include/objectManager.php @@ -921,7 +921,8 @@ class ObjectManager $sClassDisplayName = $oParentOM->GetOptionalSetting('objectGetClassDisplayName', 'parent entry'); - echo '<p><a href="'.$this->makeUrl('moveToNewParent', $this->iId)."\">Create and move to a new $sClassDisplayName</a></p>\n"; + if($this->GetOptionalSetting('objectAllowMovingToNewParent', false)) + echo '<p><a href="'.$this->makeUrl('moveToNewParent', $this->iId)."\">Create and move to a new $sClassDisplayName</a></p>\n"; /* Display some help text */ echo "<p>Move ".$oObject->objectMakeLink()." to the $sClassDisplayName ";
1
0
0
0
Alexander Nicolaysen Sørnes : note: Allow moving from app to version, fix some mail texts
by Alexander Nicolaysen Sørnes
30 Jul '09
30 Jul '09
Module: appdb Branch: master Commit: 6f1de3983796ec23dcc29e79b77aab26c2bdc5b3 URL:
http://source.winehq.org/git/appdb.git/?a=commit;h=6f1de3983796ec23dcc29e79…
Author: Alexander Nicolaysen Sørnes <alexander(a)linux-xqqm.(none)> Date: Thu Jul 30 00:51:52 2009 +0200 note: Allow moving from app to version, fix some mail texts --- include/note.php | 68 +++++++++++++++++++++++++++++++++++++++++++++-------- 1 files changed, 57 insertions(+), 11 deletions(-) diff --git a/include/note.php b/include/note.php index 3be1b94..57f92a4 100644 --- a/include/note.php +++ b/include/note.php @@ -10,6 +10,7 @@ require_once(BASE."include/version.php"); define('APPNOTE_SHOW_FOR_ALL', -1); define('APPNOTE_SHOW_FOR_VERSIONS', -2); define('APPNOTE_SHOW_FOR_APP', -3); +define('DISPLAYMODE_COUNT', 3); /** * Note class for handling notes @@ -121,17 +122,28 @@ class Note { $this->iVersionId, $this->iNoteId)) return false; - if(!$this->iAppId) + if(!$this->iAppId && !$oNote->iAppId) // Changed version only { $sVersionBefore = Version::lookup_name($oNote->iVersionId); $sVersionAfter = Version::lookup_name($this->iVersionId); $sWhatChanged .= "Version was changed from ".$sVersionBefore." to ".$sVersionAfter.".\n\n"; - } else + } else if(!$this->iAppId) // Moved from app to version + { + $sVersionAfter = Version::fullName($this->iVersionId); + $oApp = new application($oNote->iAppId); + $sOldApp = $oApp->sName; + $sWhatChanged .= "Moved from application $sOldApp to version $sVersionAfter.\n\n"; + } else if($oNote->hasRealVersionId()) // Moved from version to app { $oApp = new application($this->iAppId); $sNewApp = $oApp->sName; $sVersionBefore = version::fullName($oNote->iVersionId); $sWhatChanged .= "Moved from version $sVersionBefore to application $sNewApp.\n\n"; + } else // Change display mode for app note + { + $sOldMode = $oNote->getDisplayModeName(); + $sNewMode = $this->getDisplayModeName(); + $sWhatChanged .= "Display mode was changed from '$sOldMode' to '$sNewMode'.\n\n"; } } if (($this->iAppId || $this->iVersionId) && $this->iAppId!=$oNote->iAppId) @@ -336,6 +348,34 @@ class Note { return note::isRealVersionId($this->iVersionId); } + public static function getDisplayModeIds() + { + return array(APPNOTE_SHOW_FOR_ALL, APPNOTE_SHOW_FOR_VERSIONS, APPNOTE_SHOW_FOR_APP); + } + + public static function getDisplayModeNames() + { + return array('Show on both application and version pages', 'Show on all version pages only', 'Show on application page only'); + } + + public function getDisplayModeName($iModeId = null) + { + if(!$iModeId) + $iModeId = $this->iVersionId; + + $aNames = note::getDisplayModeNames(); + $iIndex = 0; + + foreach(note::getDisplayModeIds() as $iId) + { + if($iId == $iModeId) + return $aNames[$iIndex]; + $iIndex++; + } + + return ''; + } + function outputEditor($aValues = null) { if($aValues) @@ -377,21 +417,27 @@ class Note { echo '</p>'; echo '</td></tr>'."\n"; - if($this->iAppId); - $oApp = new application($this->iAppId); if($this->iAppId || $oApp->canEdit()) { + $oApp = new application($this->iAppId); + $aIds = $this->getDisplayModeIds(); + $aOptions = $this->getDisplayModeNames(); + + echo '<tr><td class="color1">Display mode</td>'."\n"; + echo '<td class="color0">'.html_radiobuttons($aIds, $aOptions, 'iVersionId', $this->iVersionId); + + /* Allow the note to be moved to a single version */ $aIds = array(); $aOptions = array(); - if($this->isRealVersionId($this->iVersionId)) + echo 'Show on one of the following version pages only:<br />'; + foreach($oApp->getVersions(true) as $oAppVersion) // Only accepted versions { - $aIds[] = $this->iVersionId; - $aOptions[] = 'Show for this version only'; + + $aIds[] = $oAppVersion->objectGetId(); + $aOptions[] = $oAppVersion->objectMakeLink(); } - $aIds = array_merge($aIds, array(APPNOTE_SHOW_FOR_ALL, APPNOTE_SHOW_FOR_VERSIONS, APPNOTE_SHOW_FOR_APP)); - $aOptions = array_merge($aOptions, array('Show on both application and version pages', 'Show on all version pages only', 'Show on application page only'));; - echo '<tr><td class="color1">Display mode</td>'."\n"; - echo '<td class="color0">'.html_radiobuttons($aIds, $aOptions, 'iVersionId', $this->iVersionId); + echo html_radiobuttons($aIds, $aOptions, 'iVersionId', $this->iVersionId); + echo '</td></tr>'; } else if(!$this->iAppId) {
1
0
0
0
Alexander Nicolaysen Sørnes : Misc. capitalization changes
by Alexander Nicolaysen Sørnes
29 Jul '09
29 Jul '09
Module: appdb Branch: master Commit: 295ff345ba456dc0a7b92fe4aad9752e13521fcc URL:
http://source.winehq.org/git/appdb.git/?a=commit;h=295ff345ba456dc0a7b92fe4…
Author: Alexander Nicolaysen Sørnes <alex(a)thehandofagony.com> Date: Wed Jul 29 21:21:11 2009 +0200 Misc. capitalization changes --- include/bugs.php | 10 +++++----- include/comment.php | 4 ++-- include/note.php | 2 +- include/testData.php | 4 ++-- include/version.php | 2 +- 5 files changed, 11 insertions(+), 11 deletions(-) diff --git a/include/bugs.php b/include/bugs.php index 48fbb4e..ed22aaf 100644 --- a/include/bugs.php +++ b/include/bugs.php @@ -587,12 +587,12 @@ function view_version_bugs($iVersionId = null, $aBuglinkIds) echo " <td>Description</td>\n"; echo " <td align=center width=\"80\">Status</td>\n"; echo " <td align=center width=\"80\">Resolution</td>\n"; - echo " <td align=center width=\"80\">Other Apps affected</td>\n"; + echo " <td align=center width=\"80\">Other apps affected</td>\n"; if($bCanEdit == true) { - echo " <td align=center width=\"80\">delete</td>\n"; - echo " <td align=center width=\"80\">checked</td>\n"; + echo " <td align=center width=\"80\">Delete</td>\n"; + echo " <td align=center width=\"80\">Checked</td>\n"; } echo "</tr>\n\n"; @@ -658,13 +658,13 @@ function view_version_bugs($iVersionId = null, $aBuglinkIds) if ( isset( $aClean['sAllBugs'] ) ) { $sURL = str_replace( '&sAllBugs', '', $_SERVER['REQUEST_URI'] ); - $sLink = '<a href="' . htmlentities($sURL) . '">Show Open Bugs</a>'; + $sLink = '<a href="' . htmlentities($sURL) . '">Show open bugs</a>'; } // show all link else { $sURL = $_SERVER['REQUEST_URI'] . '&sAllBugs'; - $sLink = '<a href="' . htmlentities($sURL) . '">Show All Bugs</a>'; + $sLink = '<a href="' . htmlentities($sURL) . '">Show all bugs</a>'; } echo '<div style="text-align:right;">' . $sLink .'</div>'; diff --git a/include/comment.php b/include/comment.php index 6a1716a..a999e41 100644 --- a/include/comment.php +++ b/include/comment.php @@ -617,8 +617,8 @@ class Comment { $sel[$_SESSION['current']->getPref("comments:mode", "threaded")] = 'selected'; echo '<td><form method="post" name="sMode" action="'. $oVersion->objectMakeUrl().'">',"\n"; - echo "<b>Application Comments</b> $messageCount total comments "; - echo '<b>Mode</b> <select name="sCmode" onchange="document.sMode.submit();">',"\n"; + echo "<b>Application comments:</b> $messageCount total comments "; + echo '<b>Mode:</b> <select name="sCmode" onchange="document.sMode.submit();">',"\n"; echo ' <option value="flat" '.$sel['flat'].'>Flat</option>',"\n"; echo ' <option value="threaded" '.$sel['threaded'].'>Threaded</option>',"\n"; echo ' <option value="nested" '.$sel['nested'].'>Nested</option>',"\n"; diff --git a/include/note.php b/include/note.php index 4233ac3..3be1b94 100644 --- a/include/note.php +++ b/include/note.php @@ -270,7 +270,7 @@ class Note { { $shOutput .= "<tr class=\"color1\" align=\"center\" valign=\"top\"><td>"; $shOutput .= "<form method=\"post\" name=\"message\" action=\"objectManager.php?sClass=note&sAction=edit&iId=".$this->iNoteId."&sReturnTo=".urlencode($shReturnTo)."\">"; - $shOutput .= '<input type="submit" value="Edit Note" class="button">'; + $shOutput .= '<input type="submit" value="Edit note" class="button">'; $shOutput .= '</form></td></tr>'; } diff --git a/include/testData.php b/include/testData.php index 23aff30..d2d4b36 100644 --- a/include/testData.php +++ b/include/testData.php @@ -696,10 +696,10 @@ class testData{ if($rowsUsed >= $iDisplayLimit && $bShowAll) { - $sShowButtonText = "Limit to $iDisplayLimit Tests"; + $sShowButtonText = "Limit to $iDisplayLimit tests"; } else { - $sShowButtonText = "Show All Tests"; + $sShowButtonText = "Show all tests"; echo '<input type="hidden" name="bShowAll" value="true">'; } diff --git a/include/version.php b/include/version.php index 4e3ecd2..5afa0b5 100644 --- a/include/version.php +++ b/include/version.php @@ -1111,7 +1111,7 @@ class version { echo "<div class='info_container'>\n"; echo "\t<div class='title_class'>\n"; - echo "\t\tSelected test results <small><small>(selected in 'Test Results' table below)</small></small>\n"; + echo "\t\tSelected Test Results <small><small>(selected in 'Test Results' table below)</small></small>\n"; echo "\t</div>\n"; echo "<div class='info_contents'>\n";
1
0
0
0
Alexander Nicolaysen Sørnes : version: Use consistent capitalizatin of button texxts
by Alexander Nicolaysen Sørnes
29 Jul '09
29 Jul '09
Module: appdb Branch: master Commit: 6c1f52c7644699fc6c16570f1901f4fcfcbefbd9 URL:
http://source.winehq.org/git/appdb.git/?a=commit;h=6c1f52c7644699fc6c16570f…
Author: Alexander Nicolaysen Sørnes <alex(a)thehandofagony.com> Date: Wed Jul 29 21:10:37 2009 +0200 version: Use consistent capitalizatin of button texxts --- include/version.php | 20 ++++++++++---------- 1 files changed, 10 insertions(+), 10 deletions(-) diff --git a/include/version.php b/include/version.php index f54eeb2..4e3ecd2 100644 --- a/include/version.php +++ b/include/version.php @@ -958,8 +958,8 @@ class version { echo "</form>\n"; } else /* nope */ { - echo '<form method="post" name="sMessage" action="objectManager.php?sClass=maintainer&sAction=add&iVersionId='.$this->iVersionId.'&sTitle='.urlencode("Be a Maintainer of ".version::fullName($this->iVersionId)).'&sReturnTo='.urlencode($this->objectMakeUrl()).'">'."\n"; - echo "\t".'<input type="submit" value="Be a Maintainer of This Version" class="button" title="Click here to know more about maintainers.">'."\n"; + echo '<form method="post" name="sMessage" action="objectManager.php?sClass=maintainer&sAction=add&iVersionId='.$this->iVersionId.'&sTitle='.urlencode("Be a maintainer of ".version::fullName($this->iVersionId)).'&sReturnTo='.urlencode($this->objectMakeUrl()).'">'."\n"; + echo "\t".'<input type="submit" value="Be a maintainer of this version" class="button" title="Click here to know more about maintainers.">'."\n"; echo "\t"."<input type=hidden name=\"iAppId\" value=\"".$oApp->iAppId."\">\n"; echo "\t"."<input type=hidden name=\"iVersionId\" value=\"".$this->iVersionId."\">\n"; echo "</form>\n"; @@ -977,7 +977,7 @@ class version { echo "\t<input type=\"hidden\" name=\"sClass\" value=\"monitor\" >\n"; echo "\t<input type=\"hidden\" name=\"sReturnTo\" value=\"". $this->objectMakeUrl()."\" >\n"; - echo "\t".'<input type=submit value="Monitor Changes" class="button">'."\n"; + echo "\t".'<input type=submit value="Monitor changes" class="button">'."\n"; echo "</form>\n"; } } @@ -1000,20 +1000,20 @@ class version { echo '<form method="post" name="sMessage" action="admin/editAppVersion.php">'."\n"; echo "\t".'<input type="hidden" name="iAppId" value="'.$oApp->iAppId.'">'."\n"; echo "\t".'<input type="hidden" name="iVersionId" value="'.$this->iVersionId.'">'."\n"; - echo "\t".'<input type=submit value="Edit Version" class="button">'."\n"; + echo "\t".'<input type=submit value="Edit version" class="button">'."\n"; echo '</form>'."\n"; $url = BASE."objectManager.php?sClass=version&sAction=delete&bQueued=false&iId=".$this->iVersionId; echo "<form method=\"post\" name=\"sDelete\" action=\"javascript:self.location = '".$url."'\">\n"; - echo "\t".'<input type=submit value="Delete Version" class="button">'."\n"; + echo "\t".'<input type=submit value="Delete version" class="button">'."\n"; echo '</form>'."\n"; echo $shAdd.'" />'; - echo "\t".'<input type="submit" value="Add Note" class="button">'."\n"; + echo "\t".'<input type="submit" value="Add note" class="button">'."\n"; echo '</form>'."\n"; echo $shAdd.'&sNoteTitle=HOWTO" />'; - echo "\t".'<input type=submit value="Add How To" class="button">'."\n"; + echo "\t".'<input type=submit value="Add how-to" class="button">'."\n"; echo '</form>'."\n"; echo $shAdd.'&sNoteTitle=WARNING" />'; - echo "\t".'<input type=submit value="Add Warning" class="button">'."\n"; + echo "\t".'<input type=submit value="Add warning" class="button">'."\n"; echo '</form>'; echo "</td></tr>"; } @@ -1031,7 +1031,7 @@ class version { echo "\t<input type=\"hidden\" name=\"sClass\" value=\"monitor\">\n"; echo "\t<input type=\"hidden\" name=\"sReturnTo\" value=\"". $this->objectMakeUrl()."\">\n"; - echo '<input type=submit value="Stop Monitoring Version" class="button" >'."\n"; + echo '<input type=submit value="Stop monitoring version" class="button" >'."\n"; echo "</form>\n"; echo "</td></tr>\n"; } @@ -1158,7 +1158,7 @@ class version { 'sClass=testData_queue&sAction=add&iVersionId='.$this->iVersionId. '&sTitle=Add+Test+Data&sReturnTo='. urlencode($this->objectMakeUrl()).'>'."\n"; - echo "\t".'<input type=submit value="Add Test Data" class="button" >'."\n"; + echo "\t".'<input type=submit value="Add test data" class="button" >'."\n"; echo '</form>'."\n"; } else {
1
0
0
0
← Newer
1
2
3
4
...
107
Older →
Jump to page:
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
Results per page:
10
25
50
100
200