winehq.org
Sign In
Sign Up
Sign In
Sign Up
Manage this list
×
Keyboard Shortcuts
Thread View
j
: Next unread message
k
: Previous unread message
j a
: Jump to all threads
j l
: Jump to MailingList overview
2025
July
June
May
April
March
February
January
2024
December
November
October
September
August
July
June
May
April
March
February
January
2023
December
November
October
September
August
July
June
May
April
March
February
January
2022
December
November
October
September
August
July
June
May
April
March
February
January
2021
December
November
October
September
August
July
June
May
April
March
February
January
2020
December
November
October
September
August
July
June
May
April
March
February
January
2019
December
November
October
September
August
July
June
May
April
March
February
January
2018
December
November
October
September
August
July
June
May
April
March
February
January
2017
December
November
October
September
August
July
June
May
April
March
February
January
2016
December
November
October
September
August
July
June
May
April
March
February
January
2015
December
November
October
September
August
July
June
May
April
March
February
January
2014
December
November
October
September
August
July
June
May
April
March
February
January
2013
December
November
October
September
August
July
June
May
April
March
February
January
2012
December
November
October
September
August
July
June
May
April
March
February
January
2011
December
November
October
September
August
July
June
May
April
March
February
January
2010
December
November
October
September
August
July
June
May
April
March
February
January
2009
December
November
October
September
August
July
June
May
April
March
February
January
2008
December
November
October
September
August
July
June
May
April
March
February
January
2007
December
November
October
September
August
July
June
May
April
March
February
January
2006
December
November
October
September
August
July
June
May
April
March
February
January
2005
December
November
October
September
August
July
June
May
April
March
February
January
2004
December
November
October
September
August
July
June
May
April
March
February
January
2003
December
November
October
September
August
July
June
May
April
March
February
January
2002
December
November
October
September
August
July
June
May
April
March
February
January
2001
December
November
October
September
August
July
June
May
April
March
February
List overview
wine-commits
July 2009
----- 2025 -----
July 2025
June 2025
May 2025
April 2025
March 2025
February 2025
January 2025
----- 2024 -----
December 2024
November 2024
October 2024
September 2024
August 2024
July 2024
June 2024
May 2024
April 2024
March 2024
February 2024
January 2024
----- 2023 -----
December 2023
November 2023
October 2023
September 2023
August 2023
July 2023
June 2023
May 2023
April 2023
March 2023
February 2023
January 2023
----- 2022 -----
December 2022
November 2022
October 2022
September 2022
August 2022
July 2022
June 2022
May 2022
April 2022
March 2022
February 2022
January 2022
----- 2021 -----
December 2021
November 2021
October 2021
September 2021
August 2021
July 2021
June 2021
May 2021
April 2021
March 2021
February 2021
January 2021
----- 2020 -----
December 2020
November 2020
October 2020
September 2020
August 2020
July 2020
June 2020
May 2020
April 2020
March 2020
February 2020
January 2020
----- 2019 -----
December 2019
November 2019
October 2019
September 2019
August 2019
July 2019
June 2019
May 2019
April 2019
March 2019
February 2019
January 2019
----- 2018 -----
December 2018
November 2018
October 2018
September 2018
August 2018
July 2018
June 2018
May 2018
April 2018
March 2018
February 2018
January 2018
----- 2017 -----
December 2017
November 2017
October 2017
September 2017
August 2017
July 2017
June 2017
May 2017
April 2017
March 2017
February 2017
January 2017
----- 2016 -----
December 2016
November 2016
October 2016
September 2016
August 2016
July 2016
June 2016
May 2016
April 2016
March 2016
February 2016
January 2016
----- 2015 -----
December 2015
November 2015
October 2015
September 2015
August 2015
July 2015
June 2015
May 2015
April 2015
March 2015
February 2015
January 2015
----- 2014 -----
December 2014
November 2014
October 2014
September 2014
August 2014
July 2014
June 2014
May 2014
April 2014
March 2014
February 2014
January 2014
----- 2013 -----
December 2013
November 2013
October 2013
September 2013
August 2013
July 2013
June 2013
May 2013
April 2013
March 2013
February 2013
January 2013
----- 2012 -----
December 2012
November 2012
October 2012
September 2012
August 2012
July 2012
June 2012
May 2012
April 2012
March 2012
February 2012
January 2012
----- 2011 -----
December 2011
November 2011
October 2011
September 2011
August 2011
July 2011
June 2011
May 2011
April 2011
March 2011
February 2011
January 2011
----- 2010 -----
December 2010
November 2010
October 2010
September 2010
August 2010
July 2010
June 2010
May 2010
April 2010
March 2010
February 2010
January 2010
----- 2009 -----
December 2009
November 2009
October 2009
September 2009
August 2009
July 2009
June 2009
May 2009
April 2009
March 2009
February 2009
January 2009
----- 2008 -----
December 2008
November 2008
October 2008
September 2008
August 2008
July 2008
June 2008
May 2008
April 2008
March 2008
February 2008
January 2008
----- 2007 -----
December 2007
November 2007
October 2007
September 2007
August 2007
July 2007
June 2007
May 2007
April 2007
March 2007
February 2007
January 2007
----- 2006 -----
December 2006
November 2006
October 2006
September 2006
August 2006
July 2006
June 2006
May 2006
April 2006
March 2006
February 2006
January 2006
----- 2005 -----
December 2005
November 2005
October 2005
September 2005
August 2005
July 2005
June 2005
May 2005
April 2005
March 2005
February 2005
January 2005
----- 2004 -----
December 2004
November 2004
October 2004
September 2004
August 2004
July 2004
June 2004
May 2004
April 2004
March 2004
February 2004
January 2004
----- 2003 -----
December 2003
November 2003
October 2003
September 2003
August 2003
July 2003
June 2003
May 2003
April 2003
March 2003
February 2003
January 2003
----- 2002 -----
December 2002
November 2002
October 2002
September 2002
August 2002
July 2002
June 2002
May 2002
April 2002
March 2002
February 2002
January 2002
----- 2001 -----
December 2001
November 2001
October 2001
September 2001
August 2001
July 2001
June 2001
May 2001
April 2001
March 2001
February 2001
wine-commits@winehq.org
4 participants
1067 discussions
Start a n
N
ew thread
Alexander Nicolaysen Sørnes : note: Remove obsolete line from update()
by Alexander Nicolaysen Sørnes
23 Jul '09
23 Jul '09
Module: appdb Branch: master Commit: 0f82fb839c1311a274f07a266564ac2ce570cf82 URL:
http://source.winehq.org/git/appdb.git/?a=commit;h=0f82fb839c1311a274f07a26…
Author: Alexander Nicolaysen Sørnes <alex(a)thehandofagony.com> Date: Thu Jul 23 16:24:08 2009 +0200 note: Remove obsolete line from update() --- include/note.php | 1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/include/note.php b/include/note.php index b6153d5..ea4098b 100644 --- a/include/note.php +++ b/include/note.php @@ -117,7 +117,6 @@ class Note { $sVersionBefore = Version::lookup_name($oNote->iVersionId); $sVersionAfter = Version::lookup_name($this->iVersionId); $sWhatChanged .= "Version was changed from ".$sVersionBefore." to ".$sVersionAfter.".\n\n"; - $this->iVersionId = $iVersionId; } if($sWhatChanged) $this->SendNotificationMail("edit",$sWhatChanged);
1
0
0
0
Alexander Nicolaysen Sørnes : url: Fix moving to a new version
by Alexander Nicolaysen Sørnes
23 Jul '09
23 Jul '09
Module: appdb Branch: master Commit: 8be4e24864a190c5885f8d730fba1c07a9d3e37c URL:
http://source.winehq.org/git/appdb.git/?a=commit;h=8be4e24864a190c5885f8d73…
Author: Alexander Nicolaysen Sørnes <alex(a)thehandofagony.com> Date: Thu Jul 23 15:33:47 2009 +0200 url: Fix moving to a new version --- include/url.php | 12 +++++++++--- 1 files changed, 9 insertions(+), 3 deletions(-) diff --git a/include/url.php b/include/url.php index 93e11ae..0419168 100644 --- a/include/url.php +++ b/include/url.php @@ -138,6 +138,10 @@ class Url { if(!$this->iUrlId) return FALSE; + $oUrl = new url($this->iUrlId); + + if($this->iVersionId && !$iVersionId) + $iVersionId = $this->iVersionId; $sWhatChanged = ""; @@ -159,7 +163,7 @@ class Url { $this->sUrl = $sUrl; } - if ($iVersionId && $iVersionId!=$this->iVersionId) + if ($iVersionId && $iVersionId!=$oUrl->iVersionId) { if (!query_parameters("UPDATE appData SET versionId = '?' WHERE id = '?'", $iVersionId, $this->iUrlId)) @@ -519,8 +523,10 @@ class Url { public function objectSetParent($iNewId, $sClass = '') { - $oAppData = new appData($this->iUrlId, null, $this); - return $oAppData->objectSetParent($iNewId, $sClass); + if($this->iVersionId) + $this->iVersionId = $iNewId; + else + $this->iAppId = $iNewId; } function objectGetChildren($bIncludeDeleted = false)
1
0
0
0
Alexander Nicolaysen Sørnes : downloadurl: Fix moving to a new version
by Alexander Nicolaysen Sørnes
23 Jul '09
23 Jul '09
Module: appdb Branch: master Commit: a2cedc2edcf178e18053f690df685ff37450ba88 URL:
http://source.winehq.org/git/appdb.git/?a=commit;h=a2cedc2edcf178e18053f690…
Author: Alexander Nicolaysen Sørnes <alex(a)thehandofagony.com> Date: Thu Jul 23 15:31:11 2009 +0200 downloadurl: Fix moving to a new version --- include/downloadurl.php | 10 ++++++---- 1 files changed, 6 insertions(+), 4 deletions(-) diff --git a/include/downloadurl.php b/include/downloadurl.php index 152fbc4..9883fc0 100644 --- a/include/downloadurl.php +++ b/include/downloadurl.php @@ -71,8 +71,10 @@ class downloadurl public function objectSetParent($iNewId, $sClass = '') { - $oAppData = new appData($this->iId, null, $this); - return $oAppData->objectSetParent($iNewId, $sClass); + if($this->iVersionId) + $this->iVersionId = $iNewId; + else + $this->iAppId = $iNewId; } function objectGetChildren($bIncludeDeleted = false) @@ -365,8 +367,8 @@ class downloadurl } $hResult = query_parameters("UPDATE appData SET - description = '?', url = '?' WHERE id = '?'", - $this->sDescription, $this->sUrl, $this->iId); + description = '?', url = '?', versionId = '?' WHERE id = '?'", + $this->sDescription, $this->sUrl, $this->iVersionId, $this->iId); if(!$hResult) return FALSE;
1
0
0
0
Alexander Nicolaysen Sørnes : screenshot : Fix objectSetParent()
by Alexander Nicolaysen Sørnes
23 Jul '09
23 Jul '09
Module: appdb Branch: master Commit: 62b1c7406db3f3a623379dfa8fb3bd7feab8050e URL:
http://source.winehq.org/git/appdb.git/?a=commit;h=62b1c7406db3f3a623379dfa…
Author: Alexander Nicolaysen Sørnes <alex(a)thehandofagony.com> Date: Thu Jul 23 15:23:49 2009 +0200 screenshot: Fix objectSetParent() --- include/screenshot.php | 6 ++++-- 1 files changed, 4 insertions(+), 2 deletions(-) diff --git a/include/screenshot.php b/include/screenshot.php index 97e393c..2f542f5 100644 --- a/include/screenshot.php +++ b/include/screenshot.php @@ -302,8 +302,10 @@ class screenshot public function objectSetParent($iNewId, $sClass = '') { - $oAppData = new appData($this->iScreenshotId, null, $this); - return $oAppData->objectSetParent($iNewId, $sClass); + if($this->iVersionId) + $this->iVersionId = $iNewId; + else + $this->iAppId = $iNewId; } function objectGetChildren($bIncludeDeleted = false)
1
0
0
0
Alexander Nicolaysen Sørnes : Implement version::objectMoveChildren() on top of version:: objectGetChildren()
by Alexander Nicolaysen Sørnes
23 Jul '09
23 Jul '09
Module: appdb Branch: master Commit: e9c4d2ef169894438c86f0c79aec46a6d168b993 URL:
http://source.winehq.org/git/appdb.git/?a=commit;h=e9c4d2ef169894438c86f0c7…
Author: Alexander Nicolaysen Sørnes <alex(a)thehandofagony.com> Date: Thu Jul 23 01:40:25 2009 +0200 Implement version::objectMoveChildren() on top of version::objectGetChildren() --- include/appData.php | 16 ++++++++++ include/bugs.php | 24 ++++++++++++++- include/comment.php | 35 +++++++++++++++++++++- include/downloadurl.php | 11 ++++++- include/maintainer.php | 41 ++++++++++++++++++++++++- include/monitor.php | 39 ++++++++++++++++++++++++- include/note.php | 16 ++++++++++ include/screenshot.php | 12 +++++++ include/url.php | 12 +++++++ include/version.php | 74 +++++++++++++++++++++------------------------- 10 files changed, 232 insertions(+), 48 deletions(-) Diff:
http://source.winehq.org/git/appdb.git/?a=commitdiff;h=e9c4d2ef169894438c86…
1
0
0
0
Alexander Nicolaysen Sørnes : screenshot : Link to the actual image in notification mails
by Alexander Nicolaysen Sørnes
22 Jul '09
22 Jul '09
Module: appdb Branch: master Commit: bd7081ebb457dcba46782cbe085c0d78379df8e7 URL:
http://source.winehq.org/git/appdb.git/?a=commit;h=bd7081ebb457dcba46782cbe…
Author: Alexander Nicolaysen Sørnes <alex(a)thehandofagony.com> Date: Wed Jul 22 22:06:14 2009 +0200 screenshot: Link to the actual image in notification mails --- include/screenshot.php | 10 +++++++--- 1 files changed, 7 insertions(+), 3 deletions(-) diff --git a/include/screenshot.php b/include/screenshot.php index e4ecf4b..e906899 100644 --- a/include/screenshot.php +++ b/include/screenshot.php @@ -406,7 +406,12 @@ class screenshot { $oVersion = new version($this->iVersionId); $sAppName = version::fullName($this->iVersionId); - $sMsg = $oVersion->objectMakeUrl()."\n"; + + if(!$bDeleted) + $sMsg = $this->objectMakeUrl()."\n"; + else + $sMsg = $oVersion->objectMakeUrl()."\n"; + if(!$bDeleted) { if(!$this->bQueued) @@ -771,8 +776,7 @@ class screenshot function objectMakeUrl() { - /* STUB */ - return TRUE; + return APPDB_ROOT."appimage.php?iId={$this->iScreenshotId}"; } function allowAnonymousSubmissions()
1
0
0
0
Alexander Nicolaysen Sørnes : voteInspector: Show e-mail addresses
by Alexander Nicolaysen Sørnes
22 Jul '09
22 Jul '09
Module: appdb Branch: master Commit: 1de14734d08e582fa4cedd1396490ec00a93cde3 URL:
http://source.winehq.org/git/appdb.git/?a=commit;h=1de14734d08e582fa4cedd13…
Author: Alexander Nicolaysen Sørnes <alex(a)thehandofagony.com> Date: Wed Jul 22 22:00:12 2009 +0200 voteInspector: Show e-mail addresses --- include/vote.php | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/include/vote.php b/include/vote.php index bc293bb..c19874f 100644 --- a/include/vote.php +++ b/include/vote.php @@ -310,6 +310,7 @@ class voteInspector $oTableRow->AddTextCell('Delete account'); $oTableRow->AddTextCell('User'); $oTableRow->AddTextCell('ID'); + $oTableRow->AddTextCell('E-mail'); $oTableRow->AddTextCell('Created'); $oTableRow->AddTextCell('Votes'); $oTableRow->AddTextCell('Privileges'); @@ -331,6 +332,7 @@ class voteInspector $oTableRow->AddTextCell($shDelete); $oTableRow->AddTextCell($oVoter->objectMakeLink()); $oTableRow->AddTextCell($oVoter->iUserId); + $oTableRow->AddTextCell($oVoter->sEmail); $oTableRow->AddTextCell($oVoter->sDateCreated); $oTableRow->AddTextCell($oRow->count);
1
0
0
0
Alexander Nicolaysen Sørnes : voteInspector: Make it possible to delete user accounts
by Alexander Nicolaysen Sørnes
22 Jul '09
22 Jul '09
Module: appdb Branch: master Commit: 5062357ff96f6622a8335ec7ce658bee4cc65c80 URL:
http://source.winehq.org/git/appdb.git/?a=commit;h=5062357ff96f6622a8335ec7…
Author: Alexander Nicolaysen Sørnes <alex(a)thehandofagony.com> Date: Wed Jul 22 21:42:14 2009 +0200 voteInspector: Make it possible to delete user accounts --- include/vote.php | 73 +++++++++++++++++++++++++++++++++++++++++++++++++---- 1 files changed, 67 insertions(+), 6 deletions(-) diff --git a/include/vote.php b/include/vote.php index 4f486b6..bc293bb 100644 --- a/include/vote.php +++ b/include/vote.php @@ -233,11 +233,14 @@ class voteManager class voteInspector { private $iVersionId; + private $aDeleteVoters; function voteInspector($iVersionId = null) { if(is_numeric($iVersionId)) $this->iVersionId = $iVersionId; + + $this->aDeleteVoters = array(); } public function objectGetId() @@ -255,16 +258,37 @@ class voteInspector return $_SESSION['current']->hasPriv('admin'); } + public function objectGetSubmitterId() + { + return -1; + } + + public function getVotes() + { + return query_parameters("SELECT userId, COUNT(userId) as count FROM appVotes WHERE + versionId = '?' + GROUP BY userId", $this->iVersionId); + } + + public function getVoteCount() + { + return vote_count_version_total($this->iVersionId); + } + + public function getVoterCount() + { + return mysql_num_rows($this->getVotes()); + } + public function outputEditor() { $oVersion = new version($this->iVersionId); - echo 'Inspecting votes for ' . version::fullNameLink($this->iVersionId); - echo '<br /><br />'; + echo 'Inspecting votes for ' . version::fullNameLink($this->iVersionId).'<br />'; + echo 'Total votes: '.$this->getVoteCount().'<br />'; + echo 'To delete bogus user accounts, select them and press the Delete button below.<br /><br />'; - $hResult = query_parameters("SELECT userId, COUNT(userId) as count FROM appVotes WHERE - versionId = '?' - GROUP BY userId", $this->iVersionId); + $hResult = $this->getVotes(); if(!$hResult) { @@ -283,6 +307,7 @@ class voteInspector $oTableRow = new TableRow(); $oTableRow->setClass('color4'); + $oTableRow->AddTextCell('Delete account'); $oTableRow->AddTextCell('User'); $oTableRow->AddTextCell('ID'); $oTableRow->AddTextCell('Created'); @@ -297,6 +322,13 @@ class voteInspector $oVoter = new user($oRow->userId); $oTableRow = new TableRow(); $oTableRow->setClass(($i % 2) ? 'color0' : 'color1'); + + if($oVoter->hasPriv('admin')) + $shDelete = ''; + else + $shDelete = "<input type=\"checkbox\" name=\"iDelSlot$i\" value=\"{$oVoter->iUserId}\" />"; + + $oTableRow->AddTextCell($shDelete); $oTableRow->AddTextCell($oVoter->objectMakeLink()); $oTableRow->AddTextCell($oVoter->iUserId); $oTableRow->AddTextCell($oVoter->sDateCreated); @@ -342,7 +374,14 @@ class voteInspector public function getOutputEditorValues($aValues) { - + $iVoters = $this->getVoterCount(); + $this->aDeleteVoters = array(); + + for($i = 0; $i < $iVoters; $i++) + { + if(($iVoterId = getInput("iDelSlot$i", $aValues))) + $this->aDeleteVoters[] = new user($iVoterId); + } } public function create() @@ -354,6 +393,28 @@ class voteInspector { return true; } + + public function objectGetMail($sAction, $bMailSubmitter, $bParentAction) + { + $sSubject = ''; + $sMsg = ''; + $aMailTo = null; + + return array($sSubject, $sMsg, $aMailTo); + } + + public function delete() + { + $bSuccess = true; + + foreach($this->aDeleteVoters as $oVoter) + { + if(!$oVoter->delete()) + $bSuccess = false; + } + + return $bSuccess; + } } /**
1
0
0
0
Alexander Nicolaysen Sørnes : voteInspector: Show number of comments
by Alexander Nicolaysen Sørnes
22 Jul '09
22 Jul '09
Module: appdb Branch: master Commit: f5498d7d79e7b79a19312cf39cbd3c5fe872a8eb URL:
http://source.winehq.org/git/appdb.git/?a=commit;h=f5498d7d79e7b79a19312cf3…
Author: Alexander Nicolaysen Sørnes <alex(a)thehandofagony.com> Date: Wed Jul 22 20:57:35 2009 +0200 voteInspector: Show number of comments --- include/vote.php | 12 +++++++++++- 1 files changed, 11 insertions(+), 1 deletions(-) diff --git a/include/vote.php b/include/vote.php index 53ad01c..4f486b6 100644 --- a/include/vote.php +++ b/include/vote.php @@ -288,7 +288,8 @@ class voteInspector $oTableRow->AddTextCell('Created'); $oTableRow->AddTextCell('Votes'); $oTableRow->AddTextCell('Privileges'); - $oTableRow->AddTextCell('# of test results'); + $oTableRow->AddTextCell('Test data'); + $oTableRow->AddTextcell('Comments'); $oTable->AddRow($oTableRow); for($i = 0; $oRow = mysql_fetch_object($hResult); $i++) @@ -324,6 +325,15 @@ class voteInspector $sSubmitted = 'DB failure'; $oTableRow->AddTextCell($sSubmitted); + + $hSubResult = query_parameters("SELECT COUNT(commentId) as count FROM appComments WHERE userId = '?'", $oVoter->iUserId); + + if($hSubResult && ($oSubRow = mysql_fetch_object($hSubResult))) + $sSubmitted = $oSubRow->count; + else + $sSubmitted = 'DB failure'; + + $oTableRow->AddTextCell($sSubmitted); $oTable->AddRow($oTableRow); }
1
0
0
0
Alexander Nicolaysen Sørnes : voteInspector: Show number of test results per user
by Alexander Nicolaysen Sørnes
22 Jul '09
22 Jul '09
Module: appdb Branch: master Commit: 8b561a2ccec9f0cddbf39bddce681d792e189639 URL:
http://source.winehq.org/git/appdb.git/?a=commit;h=8b561a2ccec9f0cddbf39bdd…
Author: Alexander Nicolaysen Sørnes <alex(a)thehandofagony.com> Date: Wed Jul 22 20:44:14 2009 +0200 voteInspector: Show number of test results per user --- include/vote.php | 10 ++++++++++ 1 files changed, 10 insertions(+), 0 deletions(-) diff --git a/include/vote.php b/include/vote.php index 692c2ab..53ad01c 100644 --- a/include/vote.php +++ b/include/vote.php @@ -288,6 +288,7 @@ class voteInspector $oTableRow->AddTextCell('Created'); $oTableRow->AddTextCell('Votes'); $oTableRow->AddTextCell('Privileges'); + $oTableRow->AddTextCell('# of test results'); $oTable->AddRow($oTableRow); for($i = 0; $oRow = mysql_fetch_object($hResult); $i++) @@ -314,6 +315,15 @@ class voteInspector } $oTableRow->AddTextCell($sPrivs); + + $hSubResult = query_parameters("SELECT COUNT(testingId) AS count FROM testResults WHERE submitterId = '?' AND state != 'deleted'", $oVoter->iUserId); + + if($hSubResult && ($oSubRow = mysql_fetch_object($hSubResult))) + $sSubmitted = $oSubRow->count; + else + $sSubmitted = 'DB failure'; + + $oTableRow->AddTextCell($sSubmitted); $oTable->AddRow($oTableRow); }
1
0
0
0
← Newer
1
...
13
14
15
16
17
18
19
...
107
Older →
Jump to page:
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
Results per page:
10
25
50
100
200