winehq.org
Sign In
Sign Up
Sign In
Sign Up
Manage this list
×
Keyboard Shortcuts
Thread View
j
: Next unread message
k
: Previous unread message
j a
: Jump to all threads
j l
: Jump to MailingList overview
2025
July
June
May
April
March
February
January
2024
December
November
October
September
August
July
June
May
April
March
February
January
2023
December
November
October
September
August
July
June
May
April
March
February
January
2022
December
November
October
September
August
July
June
May
April
March
February
January
2021
December
November
October
September
August
July
June
May
April
March
February
January
2020
December
November
October
September
August
July
June
May
April
March
February
January
2019
December
November
October
September
August
July
June
May
April
March
February
January
2018
December
November
October
September
August
July
June
May
April
March
February
January
2017
December
November
October
September
August
July
June
May
April
March
February
January
2016
December
November
October
September
August
July
June
May
April
March
February
January
2015
December
November
October
September
August
July
June
May
April
March
February
January
2014
December
November
October
September
August
July
June
May
April
March
February
January
2013
December
November
October
September
August
July
June
May
April
March
February
January
2012
December
November
October
September
August
July
June
May
April
March
February
January
2011
December
November
October
September
August
July
June
May
April
March
February
January
2010
December
November
October
September
August
July
June
May
April
March
February
January
2009
December
November
October
September
August
July
June
May
April
March
February
January
2008
December
November
October
September
August
July
June
May
April
March
February
January
2007
December
November
October
September
August
July
June
May
April
March
February
January
2006
December
November
October
September
August
July
June
May
April
March
February
January
2005
December
November
October
September
August
July
June
May
April
March
February
January
2004
December
November
October
September
August
July
June
May
April
March
February
January
2003
December
November
October
September
August
July
June
May
April
March
February
January
2002
December
November
October
September
August
July
June
May
April
March
February
January
2001
December
November
October
September
August
July
June
May
April
March
February
List overview
wine-commits
August 2012
----- 2025 -----
July 2025
June 2025
May 2025
April 2025
March 2025
February 2025
January 2025
----- 2024 -----
December 2024
November 2024
October 2024
September 2024
August 2024
July 2024
June 2024
May 2024
April 2024
March 2024
February 2024
January 2024
----- 2023 -----
December 2023
November 2023
October 2023
September 2023
August 2023
July 2023
June 2023
May 2023
April 2023
March 2023
February 2023
January 2023
----- 2022 -----
December 2022
November 2022
October 2022
September 2022
August 2022
July 2022
June 2022
May 2022
April 2022
March 2022
February 2022
January 2022
----- 2021 -----
December 2021
November 2021
October 2021
September 2021
August 2021
July 2021
June 2021
May 2021
April 2021
March 2021
February 2021
January 2021
----- 2020 -----
December 2020
November 2020
October 2020
September 2020
August 2020
July 2020
June 2020
May 2020
April 2020
March 2020
February 2020
January 2020
----- 2019 -----
December 2019
November 2019
October 2019
September 2019
August 2019
July 2019
June 2019
May 2019
April 2019
March 2019
February 2019
January 2019
----- 2018 -----
December 2018
November 2018
October 2018
September 2018
August 2018
July 2018
June 2018
May 2018
April 2018
March 2018
February 2018
January 2018
----- 2017 -----
December 2017
November 2017
October 2017
September 2017
August 2017
July 2017
June 2017
May 2017
April 2017
March 2017
February 2017
January 2017
----- 2016 -----
December 2016
November 2016
October 2016
September 2016
August 2016
July 2016
June 2016
May 2016
April 2016
March 2016
February 2016
January 2016
----- 2015 -----
December 2015
November 2015
October 2015
September 2015
August 2015
July 2015
June 2015
May 2015
April 2015
March 2015
February 2015
January 2015
----- 2014 -----
December 2014
November 2014
October 2014
September 2014
August 2014
July 2014
June 2014
May 2014
April 2014
March 2014
February 2014
January 2014
----- 2013 -----
December 2013
November 2013
October 2013
September 2013
August 2013
July 2013
June 2013
May 2013
April 2013
March 2013
February 2013
January 2013
----- 2012 -----
December 2012
November 2012
October 2012
September 2012
August 2012
July 2012
June 2012
May 2012
April 2012
March 2012
February 2012
January 2012
----- 2011 -----
December 2011
November 2011
October 2011
September 2011
August 2011
July 2011
June 2011
May 2011
April 2011
March 2011
February 2011
January 2011
----- 2010 -----
December 2010
November 2010
October 2010
September 2010
August 2010
July 2010
June 2010
May 2010
April 2010
March 2010
February 2010
January 2010
----- 2009 -----
December 2009
November 2009
October 2009
September 2009
August 2009
July 2009
June 2009
May 2009
April 2009
March 2009
February 2009
January 2009
----- 2008 -----
December 2008
November 2008
October 2008
September 2008
August 2008
July 2008
June 2008
May 2008
April 2008
March 2008
February 2008
January 2008
----- 2007 -----
December 2007
November 2007
October 2007
September 2007
August 2007
July 2007
June 2007
May 2007
April 2007
March 2007
February 2007
January 2007
----- 2006 -----
December 2006
November 2006
October 2006
September 2006
August 2006
July 2006
June 2006
May 2006
April 2006
March 2006
February 2006
January 2006
----- 2005 -----
December 2005
November 2005
October 2005
September 2005
August 2005
July 2005
June 2005
May 2005
April 2005
March 2005
February 2005
January 2005
----- 2004 -----
December 2004
November 2004
October 2004
September 2004
August 2004
July 2004
June 2004
May 2004
April 2004
March 2004
February 2004
January 2004
----- 2003 -----
December 2003
November 2003
October 2003
September 2003
August 2003
July 2003
June 2003
May 2003
April 2003
March 2003
February 2003
January 2003
----- 2002 -----
December 2002
November 2002
October 2002
September 2002
August 2002
July 2002
June 2002
May 2002
April 2002
March 2002
February 2002
January 2002
----- 2001 -----
December 2001
November 2001
October 2001
September 2001
August 2001
July 2001
June 2001
May 2001
April 2001
March 2001
February 2001
wine-commits@winehq.org
2 participants
541 discussions
Start a n
N
ew thread
Rico Schüller : d3dx9: Silence missing function handling in the effect interface.
by Alexandre Julliard
20 Aug '12
20 Aug '12
Module: wine Branch: master Commit: 9c1c96413942f75dd69c73a7ff8ff715c155fcea URL:
http://source.winehq.org/git/wine.git/?a=commit;h=9c1c96413942f75dd69c73a7f…
Author: Rico Schüller <kgbricola(a)web.de> Date: Sat Aug 18 14:59:05 2012 +0200 d3dx9: Silence missing function handling in the effect interface. --- dlls/d3dx9_36/effect.c | 14 ++++++++++---- 1 files changed, 10 insertions(+), 4 deletions(-) diff --git a/dlls/d3dx9_36/effect.c b/dlls/d3dx9_36/effect.c index f4a3b86..13c7f8a 100644 --- a/dlls/d3dx9_36/effect.c +++ b/dlls/d3dx9_36/effect.c @@ -1522,7 +1522,7 @@ static D3DXHANDLE WINAPI ID3DXBaseEffectImpl_GetAnnotation(ID3DXBaseEffect *ifac UINT annotation_count = 0; D3DXHANDLE *annotation_handles = NULL; - FIXME("iface %p, object %p, index %u partial stub\n", This, object, index); + TRACE("iface %p, object %p, index %u\n", This, object, index); if (pass) { @@ -1539,7 +1539,10 @@ static D3DXHANDLE WINAPI ID3DXBaseEffectImpl_GetAnnotation(ID3DXBaseEffect *ifac annotation_count = param->annotation_count; annotation_handles = param->annotation_handles; } - /* Todo: add funcs */ + else + { + FIXME("Functions are not handled, yet!\n"); + } if (index < annotation_count) { @@ -1562,7 +1565,7 @@ static D3DXHANDLE WINAPI ID3DXBaseEffectImpl_GetAnnotationByName(ID3DXBaseEffect UINT annotation_count = 0; D3DXHANDLE *annotation_handles = NULL; - FIXME("iface %p, object %p, name %s partial stub\n", This, object, debugstr_a(name)); + TRACE("iface %p, object %p, name %s\n", This, object, debugstr_a(name)); if (!name) { @@ -1585,7 +1588,10 @@ static D3DXHANDLE WINAPI ID3DXBaseEffectImpl_GetAnnotationByName(ID3DXBaseEffect annotation_count = param->annotation_count; annotation_handles = param->annotation_handles; } - /* Todo: add funcs */ + else + { + FIXME("Functions are not handled, yet!\n"); + } anno = get_annotation_by_name(annotation_count, annotation_handles, name); if (anno)
1
0
0
0
Rico Schüller : d3dx9: Make annotation handling more generic for techniques and passes.
by Alexandre Julliard
20 Aug '12
20 Aug '12
Module: wine Branch: master Commit: 24ee16de099823e496b4bd1638855316e998ea8a URL:
http://source.winehq.org/git/wine.git/?a=commit;h=24ee16de099823e496b4bd163…
Author: Rico Schüller <kgbricola(a)web.de> Date: Sat Aug 18 14:59:01 2012 +0200 d3dx9: Make annotation handling more generic for techniques and passes. --- dlls/d3dx9_36/effect.c | 29 +++++++++++++---------------- 1 files changed, 13 insertions(+), 16 deletions(-) diff --git a/dlls/d3dx9_36/effect.c b/dlls/d3dx9_36/effect.c index dec2f77..f4a3b86 100644 --- a/dlls/d3dx9_36/effect.c +++ b/dlls/d3dx9_36/effect.c @@ -190,7 +190,7 @@ struct ID3DXEffectCompilerImpl static struct d3dx_parameter *get_parameter_by_name(struct ID3DXBaseEffectImpl *base, struct d3dx_parameter *parameter, LPCSTR name); -static struct d3dx_parameter *get_parameter_annotation_by_name(struct d3dx_parameter *parameter, LPCSTR name); +static struct d3dx_parameter *get_annotation_by_name(UINT handlecount, D3DXHANDLE *handles, LPCSTR name); static HRESULT d3dx9_parse_state(struct d3dx_state *state, const char *data, const char **ptr, D3DXHANDLE *objects); static void free_parameter_state(D3DXHANDLE handle, BOOL element, BOOL child, enum STATE_TYPE st); @@ -986,7 +986,7 @@ static struct d3dx_parameter *get_parameter_element_by_name(struct d3dx_paramete return get_parameter_by_name(NULL, temp_parameter, part); case '@': - return get_parameter_annotation_by_name(temp_parameter, part); + return get_annotation_by_name(temp_parameter->annotation_count, temp_parameter->annotation_handles, part); case '\0': TRACE("Returning parameter %p\n", temp_parameter); @@ -1002,22 +1002,22 @@ static struct d3dx_parameter *get_parameter_element_by_name(struct d3dx_paramete return NULL; } -static struct d3dx_parameter *get_parameter_annotation_by_name(struct d3dx_parameter *parameter, LPCSTR name) +static struct d3dx_parameter *get_annotation_by_name(UINT handlecount, D3DXHANDLE *handles, LPCSTR name) { UINT i, length; struct d3dx_parameter *temp_parameter; LPCSTR part; - TRACE("parameter %p, name %s\n", parameter, debugstr_a(name)); + TRACE("handlecount %u, handles %p, name %s\n", handlecount, handles, debugstr_a(name)); if (!name || !*name) return NULL; length = strcspn( name, "[.@" ); part = name + length; - for (i = 0; i < parameter->annotation_count; ++i) + for (i = 0; i < handlecount; ++i) { - temp_parameter = get_parameter_struct(parameter->annotation_handles[i]); + temp_parameter = get_parameter_struct(handles[i]); if (!strcmp(temp_parameter->name, name)) { @@ -1088,7 +1088,7 @@ static struct d3dx_parameter *get_parameter_by_name(struct ID3DXBaseEffectImpl * return get_parameter_by_name(NULL, temp_parameter, part); case '@': - return get_parameter_annotation_by_name(temp_parameter, part); + return get_annotation_by_name(temp_parameter->annotation_count, temp_parameter->annotation_handles, part); case '[': return get_parameter_element_by_name(temp_parameter, part); @@ -1558,7 +1558,8 @@ static D3DXHANDLE WINAPI ID3DXBaseEffectImpl_GetAnnotationByName(ID3DXBaseEffect struct d3dx_parameter *param = get_valid_parameter(This, object); struct d3dx_pass *pass = is_valid_pass(This, object); struct d3dx_technique *technique = is_valid_technique(This, object); - UINT annotation_count = 0, i; + struct d3dx_parameter *anno = NULL; + UINT annotation_count = 0; D3DXHANDLE *annotation_handles = NULL; FIXME("iface %p, object %p, name %s partial stub\n", This, object, debugstr_a(name)); @@ -1586,15 +1587,11 @@ static D3DXHANDLE WINAPI ID3DXBaseEffectImpl_GetAnnotationByName(ID3DXBaseEffect } /* Todo: add funcs */ - for (i = 0; i < annotation_count; i++) + anno = get_annotation_by_name(annotation_count, annotation_handles, name); + if (anno) { - struct d3dx_parameter *anno = get_parameter_struct(annotation_handles[i]); - - if (!strcmp(anno->name, name)) - { - TRACE("Returning parameter %p\n", anno); - return get_parameter_handle(anno); - } + TRACE("Returning parameter %p\n", anno); + return get_parameter_handle(anno); } WARN("Invalid argument specified\n");
1
0
0
0
Rico Schüller : d3dx9: Improve check for empty braces for elements.
by Alexandre Julliard
20 Aug '12
20 Aug '12
Module: wine Branch: master Commit: 607c76a165c7c948f87c33052abb16c146b7ae65 URL:
http://source.winehq.org/git/wine.git/?a=commit;h=607c76a165c7c948f87c33052…
Author: Rico Schüller <kgbricola(a)web.de> Date: Sat Aug 18 14:58:52 2012 +0200 d3dx9: Improve check for empty braces for elements. --- dlls/d3dx9_36/effect.c | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/dlls/d3dx9_36/effect.c b/dlls/d3dx9_36/effect.c index 2a0b01c..dec2f77 100644 --- a/dlls/d3dx9_36/effect.c +++ b/dlls/d3dx9_36/effect.c @@ -975,7 +975,8 @@ static struct d3dx_parameter *get_parameter_element_by_name(struct d3dx_paramete element = atoi(name); part = strchr(name, ']') + 1; - if (parameter->element_count > element) + /* check for empty [] && element range */ + if ((part - name) > 1 && parameter->element_count > element) { temp_parameter = get_parameter_struct(parameter->member_handles[element]);
1
0
0
0
Rico Schüller : d3dx9: Return NULL if name is not given.
by Alexandre Julliard
20 Aug '12
20 Aug '12
Module: wine Branch: master Commit: 07ae14ad4c2acf8fe2d1250dd0faa4cad464bc6a URL:
http://source.winehq.org/git/wine.git/?a=commit;h=07ae14ad4c2acf8fe2d1250dd…
Author: Rico Schüller <kgbricola(a)web.de> Date: Sat Aug 18 14:58:40 2012 +0200 d3dx9: Return NULL if name is not given. --- dlls/d3dx9_36/effect.c | 6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/dlls/d3dx9_36/effect.c b/dlls/d3dx9_36/effect.c index 80f7549..2a0b01c 100644 --- a/dlls/d3dx9_36/effect.c +++ b/dlls/d3dx9_36/effect.c @@ -970,7 +970,7 @@ static struct d3dx_parameter *get_parameter_element_by_name(struct d3dx_paramete TRACE("parameter %p, name %s\n", parameter, debugstr_a(name)); - if (!name || !*name) return parameter; + if (!name || !*name) return NULL; element = atoi(name); part = strchr(name, ']') + 1; @@ -1009,7 +1009,7 @@ static struct d3dx_parameter *get_parameter_annotation_by_name(struct d3dx_param TRACE("parameter %p, name %s\n", parameter, debugstr_a(name)); - if (!name || !*name) return parameter; + if (!name || !*name) return NULL; length = strcspn( name, "[.@" ); part = name + length; @@ -1054,7 +1054,7 @@ static struct d3dx_parameter *get_parameter_by_name(struct ID3DXBaseEffectImpl * TRACE("base %p, parameter %p, name %s\n", base, parameter, debugstr_a(name)); - if (!name || !*name) return parameter; + if (!name || !*name) return NULL; if (!parameter) {
1
0
0
0
Marek Chmiel : dssenh/tests: Added signature tests on the DSSENH cryptographic service provider.
by Alexandre Julliard
20 Aug '12
20 Aug '12
Module: wine Branch: master Commit: 681af11ee15c885f3698a69bde5fef1550667830 URL:
http://source.winehq.org/git/wine.git/?a=commit;h=681af11ee15c885f3698a69bd…
Author: Marek Chmiel <kcmark(a)gmail.com> Date: Fri Aug 17 18:15:43 2012 -0500 dssenh/tests: Added signature tests on the DSSENH cryptographic service provider. --- dlls/dssenh/tests/dssenh.c | 251 ++++++++++++++++++++++++++++++++++++++++++++ 1 files changed, 251 insertions(+), 0 deletions(-) Diff:
http://source.winehq.org/git/wine.git/?a=commitdiff;h=681af11ee15c885f3698a…
1
0
0
0
Marek Chmiel : dssenh/tests: Fixed failing block cipher mode tests on the DSSENH cryptographic service provider .
by Alexandre Julliard
20 Aug '12
20 Aug '12
Module: wine Branch: master Commit: 0dab059797840d1ae4121a1d355d556c6ea691c6 URL:
http://source.winehq.org/git/wine.git/?a=commit;h=0dab059797840d1ae4121a1d3…
Author: Marek Chmiel <kcmark(a)gmail.com> Date: Fri Aug 17 16:44:22 2012 -0500 dssenh/tests: Fixed failing block cipher mode tests on the DSSENH cryptographic service provider. --- dlls/dssenh/tests/dssenh.c | 7 +++---- 1 files changed, 3 insertions(+), 4 deletions(-) diff --git a/dlls/dssenh/tests/dssenh.c b/dlls/dssenh/tests/dssenh.c index c3bea3b..1553ed1 100644 --- a/dlls/dssenh/tests/dssenh.c +++ b/dlls/dssenh/tests/dssenh.c @@ -649,15 +649,15 @@ struct ciphermode_test { static const BYTE encryptedCFB[] = { 0x51,0x15,0x77,0xab,0x62,0x1f,0x7d,0xcb, 0x35,0x1e,0xd8,0xd3,0x2a,0x00,0xf0,0x94, -0x7c,0xa5,0x28,0xda,0xb8,0x81,0x15,0x99, 0xd1,0xd5,0x06,0x18,0xb8,0x85,0xfc,0xc9 +0x7c,0xa5,0x28,0xda,0xb8,0x81,0x15,0x99, 0xd1,0xd5,0x06,0x1d,0xd3,0x46,0x7e,0xca }; static const BYTE encryptedCBC[] = { 0x8f,0x7b,0x56,0xeb,0xad,0x4d,0x76,0xc2, 0xd5,0x1d,0xf0,0x60,0x9d,0xde,0x96,0xe8, -0xb7,0x7b,0xeb,0x4b,0xee,0x3f,0xae,0x05, 0xdd,0x3b,0x62,0x47,0x7f,0x6f,0x79,0x6c +0xb7,0x7b,0xeb,0x4b,0xee,0x3f,0xae,0x05, 0x20,0xf5,0xe0,0x75,0xa0,0x1d,0xf9,0x39 }; static const BYTE encryptedECB[] = { 0x8f,0x7b,0x56,0xeb,0xad,0x4d,0x76,0xc2, 0x8b,0xe0,0x4e,0xe4,0x98,0x4f,0xb8,0x3b, -0xf3,0xeb,0x6f,0x0a,0x57,0x91,0xdd,0xc7, 0x64,0x8b,0xb9,0x50,0xe6,0x5e,0x76,0x72 +0xf3,0xeb,0x6f,0x0a,0x57,0x91,0xdd,0xc7, 0x34,0x5d,0x4c,0xa3,0x7e,0x97,0xbf,0xee }; static const struct ciphermode_test ciphermode_data[] = { @@ -742,7 +742,6 @@ static void test_cipher_modes(const struct ciphermode_test *tests, int testLen) ok(result, "Expected release of the provider.\n"); } - START_TEST(dssenh) { test_acquire_context();
1
0
0
0
Henri Verbeet : wined3d: Also issue any queries for index buffers in drawPrimitive().
by Alexandre Julliard
20 Aug '12
20 Aug '12
Module: wine Branch: master Commit: e35f773b0bbeb12e4af88c35fcacd25221f44505 URL:
http://source.winehq.org/git/wine.git/?a=commit;h=e35f773b0bbeb12e4af88c35f…
Author: Henri Verbeet <hverbeet(a)codeweavers.com> Date: Mon Aug 20 08:12:09 2012 +0200 wined3d: Also issue any queries for index buffers in drawPrimitive(). --- dlls/wined3d/drawprim.c | 8 +++++++- 1 files changed, 7 insertions(+), 1 deletions(-) diff --git a/dlls/wined3d/drawprim.c b/dlls/wined3d/drawprim.c index 8df04a3..2aea660 100644 --- a/dlls/wined3d/drawprim.c +++ b/dlls/wined3d/drawprim.c @@ -580,6 +580,7 @@ static void remove_vbos(const struct wined3d_gl_info *gl_info, void drawPrimitive(struct wined3d_device *device, UINT index_count, UINT StartIdx, BOOL indexed, const void *idxData) { const struct wined3d_state *state = &device->stateBlock->state; + struct wined3d_event_query *ib_query = NULL; const struct wined3d_gl_info *gl_info; struct wined3d_context *context; unsigned int i; @@ -683,7 +684,10 @@ void drawPrimitive(struct wined3d_device *device, UINT index_count, UINT StartId if (!index_buffer->buffer_object || !stream_info->all_vbo) idxData = index_buffer->resource.allocatedMemory; else + { + ib_query = index_buffer->query; idxData = NULL; + } } if (state->index_format == WINED3DFMT_R16_UINT) @@ -764,7 +768,9 @@ void drawPrimitive(struct wined3d_device *device, UINT index_count, UINT StartId /* Finished updating the screen, restore lock */ LEAVE_GL(); - for(i = 0; i < device->num_buffer_queries; ++i) + if (ib_query) + wined3d_event_query_issue(ib_query, device); + for (i = 0; i < device->num_buffer_queries; ++i) { wined3d_event_query_issue(device->buffer_queries[i], device); }
1
0
0
0
Henri Verbeet : wined3d: Use a slightly shorter timeout in wined3d_event_query_finish().
by Alexandre Julliard
20 Aug '12
20 Aug '12
Module: wine Branch: master Commit: 54976a033b85f5ad37813dd739ea8ec990e410f8 URL:
http://source.winehq.org/git/wine.git/?a=commit;h=54976a033b85f5ad37813dd73…
Author: Henri Verbeet <hverbeet(a)codeweavers.com> Date: Mon Aug 20 08:12:08 2012 +0200 wined3d: Use a slightly shorter timeout in wined3d_event_query_finish(). --- dlls/wined3d/query.c | 5 ++++- 1 files changed, 4 insertions(+), 1 deletions(-) diff --git a/dlls/wined3d/query.c b/dlls/wined3d/query.c index 4a3d7a7..2ee14a3 100644 --- a/dlls/wined3d/query.c +++ b/dlls/wined3d/query.c @@ -141,7 +141,10 @@ enum wined3d_event_query_result wined3d_event_query_finish(const struct wined3d_ ENTER_GL(); if (gl_info->supported[ARB_SYNC]) { - GLenum gl_ret = GL_EXTCALL(glClientWaitSync(query->object.sync, 0, ~(GLuint64)0)); + /* Apple seems to be into arbitrary limits, and timeouts larger than + * 0xfffffffffffffbff immediately return GL_TIMEOUT_EXPIRED. We don't + * really care and can live with waiting a few μs less. (OS X 10.7.4). */ + GLenum gl_ret = GL_EXTCALL(glClientWaitSync(query->object.sync, GL_SYNC_FLUSH_COMMANDS_BIT, ~(GLuint64)0xffff)); checkGLcall("glClientWaitSync"); switch (gl_ret)
1
0
0
0
Henri Verbeet : winex11: Try harder to get usable RandR screen resources.
by Alexandre Julliard
20 Aug '12
20 Aug '12
Module: wine Branch: master Commit: e426fa9cb9fce2219dc6099b4d0ca7ab27b3150c URL:
http://source.winehq.org/git/wine.git/?a=commit;h=e426fa9cb9fce2219dc6099b4…
Author: Henri Verbeet <hverbeet(a)codeweavers.com> Date: Mon Aug 20 08:12:07 2012 +0200 winex11: Try harder to get usable RandR screen resources. --- dlls/winex11.drv/xrandr.c | 28 ++++++++++++++++++++-------- 1 files changed, 20 insertions(+), 8 deletions(-) diff --git a/dlls/winex11.drv/xrandr.c b/dlls/winex11.drv/xrandr.c index 16b5d9a..e17150b 100644 --- a/dlls/winex11.drv/xrandr.c +++ b/dlls/winex11.drv/xrandr.c @@ -53,8 +53,9 @@ MAKE_FUNCPTR(XRRFreeOutputInfo) MAKE_FUNCPTR(XRRFreeScreenResources) MAKE_FUNCPTR(XRRGetCrtcInfo) MAKE_FUNCPTR(XRRGetOutputInfo) +MAKE_FUNCPTR(XRRGetScreenResources) MAKE_FUNCPTR(XRRSetCrtcConfig) -static typeof(XRRGetScreenResources) *xrandr_get_screen_resources; +static typeof(XRRGetScreenResources) *pXRRGetScreenResourcesCurrent; static RRMode *xrandr12_modes; #endif @@ -96,6 +97,7 @@ static int load_xrandr(void) LOAD_FUNCPTR(XRRFreeScreenResources) LOAD_FUNCPTR(XRRGetCrtcInfo) LOAD_FUNCPTR(XRRGetOutputInfo) + LOAD_FUNCPTR(XRRGetScreenResources) LOAD_FUNCPTR(XRRSetCrtcConfig) r = 2; #endif @@ -267,7 +269,7 @@ static int xrandr12_get_current_mode(void) XRRCrtcInfo *crtc_info; int i, ret = -1; - if (!(resources = xrandr_get_screen_resources( gdi_display, root_window ))) + if (!(resources = pXRRGetScreenResourcesCurrent( gdi_display, root_window ))) { ERR("Failed to get screen resources.\n"); return 0; @@ -312,7 +314,7 @@ static LONG xrandr12_set_current_mode( int mode ) mode = mode % xrandr_mode_count; - if (!(resources = xrandr_get_screen_resources( gdi_display, root_window ))) + if (!(resources = pXRRGetScreenResourcesCurrent( gdi_display, root_window ))) { ERR("Failed to get screen resources.\n"); return DISP_CHANGE_FAILED; @@ -352,12 +354,22 @@ static int xrandr12_init_modes(void) int ret = -1; int i, j; - if (!(resources = xrandr_get_screen_resources( gdi_display, root_window ))) + if (!(resources = pXRRGetScreenResourcesCurrent( gdi_display, root_window ))) { ERR("Failed to get screen resources.\n"); return ret; } + if (!resources->ncrtc) + { + pXRRFreeScreenResources( resources ); + if (!(resources = pXRRGetScreenResources( gdi_display, root_window ))) + { + ERR("Failed to get screen resources.\n"); + return ret; + } + } + if (!resources->ncrtc || !(crtc_info = pXRRGetCrtcInfo( gdi_display, resources, resources->crtcs[0] ))) { pXRRFreeScreenResources( resources ); @@ -450,12 +462,12 @@ void X11DRV_XRandR_Init(void) if (ret >= 2 && (major > 1 || (major == 1 && minor >= 2))) { if (major > 1 || (major == 1 && minor >= 3)) - xrandr_get_screen_resources = wine_dlsym( xrandr_handle, "XRRGetScreenResourcesCurrent", NULL, 0 ); - if (!xrandr_get_screen_resources) - xrandr_get_screen_resources = wine_dlsym( xrandr_handle, "XRRGetScreenResources", NULL, 0 ); + pXRRGetScreenResourcesCurrent = wine_dlsym( xrandr_handle, "XRRGetScreenResourcesCurrent", NULL, 0 ); + if (!pXRRGetScreenResourcesCurrent) + pXRRGetScreenResourcesCurrent = pXRRGetScreenResources; } - if (!xrandr_get_screen_resources || xrandr12_init_modes() < 0) + if (!pXRRGetScreenResourcesCurrent || xrandr12_init_modes() < 0) #endif xrandr10_init_modes(); }
1
0
0
0
Henri Verbeet : winex11: Try XRandR 1.0 if 1.2 fails.
by Alexandre Julliard
20 Aug '12
20 Aug '12
Module: wine Branch: master Commit: 28a9b39372ab05a4df42890f295a06306e4fb490 URL:
http://source.winehq.org/git/wine.git/?a=commit;h=28a9b39372ab05a4df42890f2…
Author: Henri Verbeet <hverbeet(a)codeweavers.com> Date: Mon Aug 20 08:12:06 2012 +0200 winex11: Try XRandR 1.0 if 1.2 fails. --- dlls/winex11.drv/xrandr.c | 15 ++++++++------- 1 files changed, 8 insertions(+), 7 deletions(-) diff --git a/dlls/winex11.drv/xrandr.c b/dlls/winex11.drv/xrandr.c index 9eef8f5..16b5d9a 100644 --- a/dlls/winex11.drv/xrandr.c +++ b/dlls/winex11.drv/xrandr.c @@ -344,24 +344,25 @@ static LONG xrandr12_set_current_mode( int mode ) return DISP_CHANGE_SUCCESSFUL; } -static void xrandr12_init_modes(void) +static int xrandr12_init_modes(void) { XRRScreenResources *resources; XRROutputInfo *output_info; XRRCrtcInfo *crtc_info; + int ret = -1; int i, j; if (!(resources = xrandr_get_screen_resources( gdi_display, root_window ))) { ERR("Failed to get screen resources.\n"); - return; + return ret; } if (!resources->ncrtc || !(crtc_info = pXRRGetCrtcInfo( gdi_display, resources, resources->crtcs[0] ))) { pXRRFreeScreenResources( resources ); ERR("Failed to get CRTC info.\n"); - return; + return ret; } TRACE("CRTC 0: mode %#lx, %ux%u+%d+%d.\n", crtc_info->mode, @@ -372,7 +373,7 @@ static void xrandr12_init_modes(void) pXRRFreeCrtcInfo( crtc_info ); pXRRFreeScreenResources( resources ); ERR("Failed to get output info.\n"); - return; + return ret; } TRACE("OUTPUT 0: name %s.\n", debugstr_a(output_info->name)); @@ -415,11 +416,13 @@ static void xrandr12_init_modes(void) } X11DRV_Settings_AddDepthModes(); + ret = 0; done: pXRRFreeOutputInfo( output_info ); pXRRFreeCrtcInfo( crtc_info ); pXRRFreeScreenResources( resources ); + return ret; } #endif /* HAVE_XRRGETSCREENRESOURCES */ @@ -452,9 +455,7 @@ void X11DRV_XRandR_Init(void) xrandr_get_screen_resources = wine_dlsym( xrandr_handle, "XRRGetScreenResources", NULL, 0 ); } - if (xrandr_get_screen_resources) - xrandr12_init_modes(); - else + if (!xrandr_get_screen_resources || xrandr12_init_modes() < 0) #endif xrandr10_init_modes(); }
1
0
0
0
← Newer
1
...
20
21
22
23
24
25
26
...
55
Older →
Jump to page:
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
Results per page:
10
25
50
100
200