winehq.org
Sign In
Sign Up
Sign In
Sign Up
Manage this list
×
Keyboard Shortcuts
Thread View
j
: Next unread message
k
: Previous unread message
j a
: Jump to all threads
j l
: Jump to MailingList overview
2025
July
June
May
April
March
February
January
2024
December
November
October
September
August
July
June
May
April
March
February
January
2023
December
November
October
September
August
July
June
May
April
March
February
January
2022
December
November
October
September
August
July
June
May
April
March
February
January
2021
December
November
October
September
August
July
June
May
April
March
February
January
2020
December
November
October
September
August
July
June
May
April
March
February
January
2019
December
November
October
September
August
July
June
May
April
March
February
January
2018
December
November
October
September
August
July
June
May
April
March
February
January
2017
December
November
October
September
August
July
June
May
April
March
February
January
2016
December
November
October
September
August
July
June
May
April
March
February
January
2015
December
November
October
September
August
July
June
May
April
March
February
January
2014
December
November
October
September
August
July
June
May
April
March
February
January
2013
December
November
October
September
August
July
June
May
April
March
February
January
2012
December
November
October
September
August
July
June
May
April
March
February
January
2011
December
November
October
September
August
July
June
May
April
March
February
January
2010
December
November
October
September
August
July
June
May
April
March
February
January
2009
December
November
October
September
August
July
June
May
April
March
February
January
2008
December
November
October
September
August
July
June
May
April
March
February
January
2007
December
November
October
September
August
July
June
May
April
March
February
January
2006
December
November
October
September
August
July
June
May
April
March
February
January
2005
December
November
October
September
August
July
June
May
April
March
February
January
2004
December
November
October
September
August
July
June
May
April
March
February
January
2003
December
November
October
September
August
July
June
May
April
March
February
January
2002
December
November
October
September
August
July
June
May
April
March
February
January
2001
December
November
October
September
August
July
June
May
April
March
February
List overview
wine-commits
August 2013
----- 2025 -----
July 2025
June 2025
May 2025
April 2025
March 2025
February 2025
January 2025
----- 2024 -----
December 2024
November 2024
October 2024
September 2024
August 2024
July 2024
June 2024
May 2024
April 2024
March 2024
February 2024
January 2024
----- 2023 -----
December 2023
November 2023
October 2023
September 2023
August 2023
July 2023
June 2023
May 2023
April 2023
March 2023
February 2023
January 2023
----- 2022 -----
December 2022
November 2022
October 2022
September 2022
August 2022
July 2022
June 2022
May 2022
April 2022
March 2022
February 2022
January 2022
----- 2021 -----
December 2021
November 2021
October 2021
September 2021
August 2021
July 2021
June 2021
May 2021
April 2021
March 2021
February 2021
January 2021
----- 2020 -----
December 2020
November 2020
October 2020
September 2020
August 2020
July 2020
June 2020
May 2020
April 2020
March 2020
February 2020
January 2020
----- 2019 -----
December 2019
November 2019
October 2019
September 2019
August 2019
July 2019
June 2019
May 2019
April 2019
March 2019
February 2019
January 2019
----- 2018 -----
December 2018
November 2018
October 2018
September 2018
August 2018
July 2018
June 2018
May 2018
April 2018
March 2018
February 2018
January 2018
----- 2017 -----
December 2017
November 2017
October 2017
September 2017
August 2017
July 2017
June 2017
May 2017
April 2017
March 2017
February 2017
January 2017
----- 2016 -----
December 2016
November 2016
October 2016
September 2016
August 2016
July 2016
June 2016
May 2016
April 2016
March 2016
February 2016
January 2016
----- 2015 -----
December 2015
November 2015
October 2015
September 2015
August 2015
July 2015
June 2015
May 2015
April 2015
March 2015
February 2015
January 2015
----- 2014 -----
December 2014
November 2014
October 2014
September 2014
August 2014
July 2014
June 2014
May 2014
April 2014
March 2014
February 2014
January 2014
----- 2013 -----
December 2013
November 2013
October 2013
September 2013
August 2013
July 2013
June 2013
May 2013
April 2013
March 2013
February 2013
January 2013
----- 2012 -----
December 2012
November 2012
October 2012
September 2012
August 2012
July 2012
June 2012
May 2012
April 2012
March 2012
February 2012
January 2012
----- 2011 -----
December 2011
November 2011
October 2011
September 2011
August 2011
July 2011
June 2011
May 2011
April 2011
March 2011
February 2011
January 2011
----- 2010 -----
December 2010
November 2010
October 2010
September 2010
August 2010
July 2010
June 2010
May 2010
April 2010
March 2010
February 2010
January 2010
----- 2009 -----
December 2009
November 2009
October 2009
September 2009
August 2009
July 2009
June 2009
May 2009
April 2009
March 2009
February 2009
January 2009
----- 2008 -----
December 2008
November 2008
October 2008
September 2008
August 2008
July 2008
June 2008
May 2008
April 2008
March 2008
February 2008
January 2008
----- 2007 -----
December 2007
November 2007
October 2007
September 2007
August 2007
July 2007
June 2007
May 2007
April 2007
March 2007
February 2007
January 2007
----- 2006 -----
December 2006
November 2006
October 2006
September 2006
August 2006
July 2006
June 2006
May 2006
April 2006
March 2006
February 2006
January 2006
----- 2005 -----
December 2005
November 2005
October 2005
September 2005
August 2005
July 2005
June 2005
May 2005
April 2005
March 2005
February 2005
January 2005
----- 2004 -----
December 2004
November 2004
October 2004
September 2004
August 2004
July 2004
June 2004
May 2004
April 2004
March 2004
February 2004
January 2004
----- 2003 -----
December 2003
November 2003
October 2003
September 2003
August 2003
July 2003
June 2003
May 2003
April 2003
March 2003
February 2003
January 2003
----- 2002 -----
December 2002
November 2002
October 2002
September 2002
August 2002
July 2002
June 2002
May 2002
April 2002
March 2002
February 2002
January 2002
----- 2001 -----
December 2001
November 2001
October 2001
September 2001
August 2001
July 2001
June 2001
May 2001
April 2001
March 2001
February 2001
wine-commits@winehq.org
2 participants
461 discussions
Start a n
N
ew thread
Henri Verbeet : d3dx9: Get rid of some unused vtbl forward declarations.
by Alexandre Julliard
22 Aug '13
22 Aug '13
Module: wine Branch: master Commit: c2eabf9e684251a14f85d130d55d0f5629a37be0 URL:
http://source.winehq.org/git/wine.git/?a=commit;h=c2eabf9e684251a14f85d130d…
Author: Henri Verbeet <hverbeet(a)codeweavers.com> Date: Thu Aug 22 09:48:42 2013 +0200 d3dx9: Get rid of some unused vtbl forward declarations. --- dlls/d3dx9_36/effect.c | 2 -- dlls/d3dx9_36/line.c | 2 -- dlls/d3dx9_36/shader.c | 2 -- 3 files changed, 0 insertions(+), 6 deletions(-) diff --git a/dlls/d3dx9_36/effect.c b/dlls/d3dx9_36/effect.c index 7a64cb4..757833b 100644 --- a/dlls/d3dx9_36/effect.c +++ b/dlls/d3dx9_36/effect.c @@ -5423,8 +5423,6 @@ HRESULT WINAPI D3DXCreateEffectCompiler(const char *srcdata, UINT srcdatalen, co return D3D_OK; } -static const struct ID3DXEffectPoolVtbl ID3DXEffectPool_Vtbl; - struct ID3DXEffectPoolImpl { ID3DXEffectPool ID3DXEffectPool_iface; diff --git a/dlls/d3dx9_36/line.c b/dlls/d3dx9_36/line.c index e305eb9..a9f53a7 100644 --- a/dlls/d3dx9_36/line.c +++ b/dlls/d3dx9_36/line.c @@ -22,8 +22,6 @@ WINE_DEFAULT_DEBUG_CHANNEL(d3dx); -static const struct ID3DXLineVtbl ID3DXLine_Vtbl; - typedef struct ID3DXLineImpl { ID3DXLine ID3DXLine_iface; LONG ref; diff --git a/dlls/d3dx9_36/shader.c b/dlls/d3dx9_36/shader.c index 16395e8..8e5236d 100644 --- a/dlls/d3dx9_36/shader.c +++ b/dlls/d3dx9_36/shader.c @@ -567,8 +567,6 @@ struct ctab_constant { struct ctab_constant *constants; }; -static const struct ID3DXConstantTableVtbl ID3DXConstantTable_Vtbl; - struct ID3DXConstantTableImpl { ID3DXConstantTable ID3DXConstantTable_iface; LONG ref;
1
0
0
0
Henri Verbeet : wined3d: Read from stateBlock instead of updateStateBlock in wined3d_device_get_texture_stage_state ().
by Alexandre Julliard
22 Aug '13
22 Aug '13
Module: wine Branch: master Commit: 6501f2e21522158a4e4908b41a1f20434509af57 URL:
http://source.winehq.org/git/wine.git/?a=commit;h=6501f2e21522158a4e4908b41…
Author: Henri Verbeet <hverbeet(a)codeweavers.com> Date: Thu Aug 22 09:48:41 2013 +0200 wined3d: Read from stateBlock instead of updateStateBlock in wined3d_device_get_texture_stage_state(). --- dlls/wined3d/device.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/dlls/wined3d/device.c b/dlls/wined3d/device.c index 7122006..a4a06a9 100644 --- a/dlls/wined3d/device.c +++ b/dlls/wined3d/device.c @@ -3665,7 +3665,7 @@ DWORD CDECL wined3d_device_get_texture_stage_state(const struct wined3d_device * return 0; } - return device->updateStateBlock->state.texture_states[stage][state]; + return device->stateBlock->state.texture_states[stage][state]; } HRESULT CDECL wined3d_device_set_texture(struct wined3d_device *device,
1
0
0
0
Henri Verbeet : wined3d: Read from stateBlock instead of updateStateBlock in wined3d_device_get_scissor_rect ().
by Alexandre Julliard
22 Aug '13
22 Aug '13
Module: wine Branch: master Commit: 9b721da9a504eaeb87d5eabcc8c184a8fdf63f5e URL:
http://source.winehq.org/git/wine.git/?a=commit;h=9b721da9a504eaeb87d5eabcc…
Author: Henri Verbeet <hverbeet(a)codeweavers.com> Date: Thu Aug 22 09:48:40 2013 +0200 wined3d: Read from stateBlock instead of updateStateBlock in wined3d_device_get_scissor_rect(). --- dlls/wined3d/device.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/dlls/wined3d/device.c b/dlls/wined3d/device.c index c949a9c..7122006 100644 --- a/dlls/wined3d/device.c +++ b/dlls/wined3d/device.c @@ -2340,7 +2340,7 @@ void CDECL wined3d_device_get_scissor_rect(const struct wined3d_device *device, { TRACE("device %p, rect %p.\n", device, rect); - *rect = device->updateStateBlock->state.scissor_rect; + *rect = device->stateBlock->state.scissor_rect; TRACE("Returning rect %s.\n", wine_dbgstr_rect(rect)); }
1
0
0
0
Henri Verbeet : wined3d: Read from stateBlock instead of updateStateBlock in wined3d_device_get_material ().
by Alexandre Julliard
22 Aug '13
22 Aug '13
Module: wine Branch: master Commit: 7638e550b9e6377204d7916822d4cc7526082dfb URL:
http://source.winehq.org/git/wine.git/?a=commit;h=7638e550b9e6377204d791682…
Author: Henri Verbeet <hverbeet(a)codeweavers.com> Date: Thu Aug 22 09:48:39 2013 +0200 wined3d: Read from stateBlock instead of updateStateBlock in wined3d_device_get_material(). --- dlls/wined3d/device.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/dlls/wined3d/device.c b/dlls/wined3d/device.c index e16a4b8..c949a9c 100644 --- a/dlls/wined3d/device.c +++ b/dlls/wined3d/device.c @@ -2098,7 +2098,7 @@ void CDECL wined3d_device_get_material(const struct wined3d_device *device, stru { TRACE("device %p, material %p.\n", device, material); - *material = device->updateStateBlock->state.material; + *material = device->stateBlock->state.material; TRACE("diffuse {%.8e, %.8e, %.8e, %.8e}\n", material->diffuse.r, material->diffuse.g,
1
0
0
0
Jacek Caban : crypt32: Added a test showing that CertGetCertificateChain should use global store.
by Alexandre Julliard
21 Aug '13
21 Aug '13
Module: wine Branch: master Commit: 8ef3a142263e6db11f1514f77b3de84c8b08d7a0 URL:
http://source.winehq.org/git/wine.git/?a=commit;h=8ef3a142263e6db11f1514f77…
Author: Jacek Caban <jacek(a)codeweavers.com> Date: Wed Aug 21 18:57:29 2013 +0200 crypt32: Added a test showing that CertGetCertificateChain should use global store. --- dlls/crypt32/tests/chain.c | 166 ++++++++++++++++++++++++++++++++++++++++++++ 1 files changed, 166 insertions(+), 0 deletions(-) Diff:
http://source.winehq.org/git/wine.git/?a=commitdiff;h=8ef3a142263e6db11f151…
1
0
0
0
Andrew Eikum : dsound: For capture, use MMDevAPI event API instead of timers.
by Alexandre Julliard
21 Aug '13
21 Aug '13
Module: wine Branch: master Commit: d5e648dc2f497a424d8cb289a7bbd7025c84d441 URL:
http://source.winehq.org/git/wine.git/?a=commit;h=d5e648dc2f497a424d8cb289a…
Author: Andrew Eikum <aeikum(a)codeweavers.com> Date: Wed Aug 21 10:16:08 2013 -0500 dsound: For capture, use MMDevAPI event API instead of timers. --- dlls/dsound/capture.c | 98 ++++++++++++++++++++++++++++++------------ dlls/dsound/dsound.c | 24 ---------- dlls/dsound/dsound_private.h | 1 - 3 files changed, 70 insertions(+), 53 deletions(-) diff --git a/dlls/dsound/capture.c b/dlls/dsound/capture.c index 63bda55..40f1702 100644 --- a/dlls/dsound/capture.c +++ b/dlls/dsound/capture.c @@ -59,6 +59,8 @@ typedef struct IDirectSoundCaptureBufferImpl /* IDirectSoundNotify fields */ DSBPOSITIONNOTIFY *notifies; int nrofnotifies; + HANDLE thread; + HANDLE sleepev; } IDirectSoundCaptureBufferImpl; /* DirectSoundCaptureDevice implementation structure */ @@ -72,7 +74,6 @@ struct DirectSoundCaptureDevice WAVEFORMATEX *pwfx; IDirectSoundCaptureBufferImpl *capture_buffer; DWORD state; - UINT timerID; CRITICAL_SECTION lock; IMMDevice *mmdevice; IAudioClient *client; @@ -80,12 +81,20 @@ struct DirectSoundCaptureDevice struct list entry; }; +static DWORD WINAPI DSOUND_capture_thread(void *user); static void capturebuffer_destroy(IDirectSoundCaptureBufferImpl *This) { if (This->device->state == STATE_CAPTURING) This->device->state = STATE_STOPPING; + if(This->thread){ + SetEvent(This->sleepev); + WaitForSingleObject(This->thread, INFINITE); + CloseHandle(This->thread); + } + CloseHandle(This->sleepev); + HeapFree(GetProcessHeap(),0, This->pdscbd); if (This->device->client) { @@ -739,8 +748,8 @@ static HRESULT IDirectSoundCaptureBufferImpl_Create( } err = IAudioClient_Initialize(device->client, - AUDCLNT_SHAREMODE_SHARED, AUDCLNT_STREAMFLAGS_NOPERSIST, - 200 * 100000, 50000, device->pwfx, NULL); + AUDCLNT_SHAREMODE_SHARED, AUDCLNT_STREAMFLAGS_NOPERSIST | AUDCLNT_STREAMFLAGS_EVENTCALLBACK, + 200 * 100000, 0, device->pwfx, NULL); if(FAILED(err)){ WARN("Initialize failed: %08x\n", err); IAudioClient_Release(device->client); @@ -753,12 +762,27 @@ static HRESULT IDirectSoundCaptureBufferImpl_Create( return err; } + This->sleepev = CreateEventW(NULL, 0, 0, NULL); + + err = IAudioClient_SetEventHandle(device->client, This->sleepev); + if(FAILED(err)){ + WARN("SetEventHandle failed: %08x\n", err); + IAudioClient_Release(device->client); + device->client = NULL; + CloseHandle(This->sleepev); + HeapFree(GetProcessHeap(), 0, This->pdscbd); + This->device->capture_buffer = 0; + HeapFree( GetProcessHeap(), 0, This ); + return err; + } + err = IAudioClient_GetService(device->client, &IID_IAudioCaptureClient, (void**)&device->capture); if(FAILED(err)){ WARN("GetService failed: %08x\n", err); IAudioClient_Release(device->client); device->client = NULL; + CloseHandle(This->sleepev); HeapFree(GetProcessHeap(), 0, This->pdscbd); This->device->capture_buffer = 0; HeapFree( GetProcessHeap(), 0, This ); @@ -776,6 +800,7 @@ static HRESULT IDirectSoundCaptureBufferImpl_Create( device->client = NULL; IAudioCaptureClient_Release(device->capture); device->capture = NULL; + CloseHandle(This->sleepev); HeapFree(GetProcessHeap(), 0, This->pdscbd); This->device->capture_buffer = 0; HeapFree( GetProcessHeap(), 0, This ); @@ -783,6 +808,7 @@ static HRESULT IDirectSoundCaptureBufferImpl_Create( } device->buffer = newbuf; device->buflen = buflen; + This->thread = CreateThread(NULL, 0, DSOUND_capture_thread, This, 0, NULL); } IDirectSoundCaptureBuffer_AddRef(&This->IDirectSoundCaptureBuffer8_iface); @@ -830,9 +856,6 @@ static ULONG DirectSoundCaptureDevice_Release( if (!ref) { TRACE("deleting object\n"); - timeKillEvent(device->timerID); - timeEndPeriod(DS_TIME_RES); - EnterCriticalSection(&DSOUND_capturers_lock); list_remove(&device->entry); LeaveCriticalSection(&DSOUND_capturers_lock); @@ -851,29 +874,19 @@ static ULONG DirectSoundCaptureDevice_Release( return ref; } -static void CALLBACK DSOUND_capture_timer(UINT timerID, UINT msg, DWORD_PTR user, - DWORD_PTR dw1, DWORD_PTR dw2) +static HRESULT DSOUND_capture_data(DirectSoundCaptureDevice *device) { - DirectSoundCaptureDevice *device = (DirectSoundCaptureDevice*)user; + HRESULT hr; UINT32 packet_frames, packet_bytes, avail_bytes, skip_bytes = 0; DWORD flags; BYTE *buf; - HRESULT hr; - - if(!device->ref) - return; - EnterCriticalSection(&device->lock); - - if(!device->capture_buffer || device->state == STATE_STOPPED){ - LeaveCriticalSection(&device->lock); - return; - } + if(!device->capture_buffer || device->state == STATE_STOPPED) + return S_FALSE; if(device->state == STATE_STOPPING){ device->state = STATE_STOPPED; - LeaveCriticalSection(&device->lock); - return; + return S_FALSE; } if(device->state == STATE_STARTING) @@ -882,9 +895,8 @@ static void CALLBACK DSOUND_capture_timer(UINT timerID, UINT msg, DWORD_PTR user hr = IAudioCaptureClient_GetBuffer(device->capture, &buf, &packet_frames, &flags, NULL, NULL); if(FAILED(hr)){ - LeaveCriticalSection(&device->lock); WARN("GetBuffer failed: %08x\n", hr); - return; + return hr; } packet_bytes = packet_frames * device->pwfx->nBlockAlign; @@ -917,12 +929,44 @@ static void CALLBACK DSOUND_capture_timer(UINT timerID, UINT msg, DWORD_PTR user hr = IAudioCaptureClient_ReleaseBuffer(device->capture, packet_frames); if(FAILED(hr)){ - LeaveCriticalSection(&device->lock); WARN("ReleaseBuffer failed: %08x\n", hr); - return; + return hr; } - LeaveCriticalSection(&device->lock); + return S_OK; +} + +static DWORD WINAPI DSOUND_capture_thread(void *user) +{ + IDirectSoundCaptureBufferImpl *buffer = user; + HRESULT hr; + DWORD ret, wait_ms; + REFERENCE_TIME period; + + hr = IAudioClient_GetDevicePeriod(buffer->device->client, &period, NULL); + if(FAILED(hr)){ + WARN("GetDevicePeriod failed: %08x\n", hr); + wait_ms = 5; + }else + wait_ms = MulDiv(5, period, 10000); + + while(buffer->ref){ + ret = WaitForSingleObject(buffer->sleepev, wait_ms); + + if(!buffer->device->ref) + break; + + if(ret == WAIT_OBJECT_0){ + EnterCriticalSection(&buffer->device->lock); + + DSOUND_capture_data(buffer->device); + + LeaveCriticalSection(&buffer->device->lock); + }else if(ret != WAIT_TIMEOUT) + WARN("WaitForSingleObject failed: %u\n", GetLastError()); + } + + return 0; } static struct _TestFormat { @@ -1020,8 +1064,6 @@ static HRESULT DirectSoundCaptureDevice_Initialize( } IAudioClient_Release(client); - device->timerID = DSOUND_create_timer(DSOUND_capture_timer, (DWORD_PTR)device); - list_add_tail(&DSOUND_capturers, &device->entry); *ppDevice = device; diff --git a/dlls/dsound/dsound.c b/dlls/dsound/dsound.c index 381d0e1..986168b 100644 --- a/dlls/dsound/dsound.c +++ b/dlls/dsound/dsound.c @@ -735,30 +735,6 @@ BOOL DSOUND_check_supported(IAudioClient *client, DWORD rate, return hr == S_OK; } -UINT DSOUND_create_timer(LPTIMECALLBACK cb, DWORD_PTR user) -{ - UINT triggertime = DS_TIME_DEL, res = DS_TIME_RES, id; - TIMECAPS time; - - timeGetDevCaps(&time, sizeof(TIMECAPS)); - TRACE("Minimum timer resolution: %u, max timer: %u\n", time.wPeriodMin, time.wPeriodMax); - if (triggertime < time.wPeriodMin) - triggertime = time.wPeriodMin; - if (res < time.wPeriodMin) - res = time.wPeriodMin; - if (timeBeginPeriod(res) == TIMERR_NOCANDO) - WARN("Could not set minimum resolution, don't expect sound\n"); - id = timeSetEvent(triggertime, res, cb, user, TIME_PERIODIC | TIME_KILL_SYNCHRONOUS); - if (!id) - { - WARN("Timer not created! Retrying without TIME_KILL_SYNCHRONOUS\n"); - id = timeSetEvent(triggertime, res, cb, user, TIME_PERIODIC); - if (!id) - ERR("Could not create timer, sound playback will not occur\n"); - } - return id; -} - HRESULT DirectSoundDevice_Initialize(DirectSoundDevice ** ppDevice, LPCGUID lpcGUID) { HRESULT hr = DS_OK; diff --git a/dlls/dsound/dsound_private.h b/dlls/dsound/dsound_private.h index 1a3900c..a8f5f42 100644 --- a/dlls/dsound/dsound_private.h +++ b/dlls/dsound/dsound_private.h @@ -261,6 +261,5 @@ HRESULT get_mmdevice(EDataFlow flow, const GUID *tgt, IMMDevice **device) DECLSP BOOL DSOUND_check_supported(IAudioClient *client, DWORD rate, DWORD depth, WORD channels) DECLSPEC_HIDDEN; -UINT DSOUND_create_timer(LPTIMECALLBACK cb, DWORD_PTR user) DECLSPEC_HIDDEN; HRESULT enumerate_mmdevices(EDataFlow flow, GUID *guids, LPDSENUMCALLBACKW cb, void *user) DECLSPEC_HIDDEN;
1
0
0
0
Andrew Eikum : winecoreaudio.drv: Rewrite capture mode.
by Alexandre Julliard
21 Aug '13
21 Aug '13
Module: wine Branch: master Commit: 927324ce8ffcf5acc9ba4c215f5d8ffad61dddcd URL:
http://source.winehq.org/git/wine.git/?a=commit;h=927324ce8ffcf5acc9ba4c215…
Author: Andrew Eikum <aeikum(a)codeweavers.com> Date: Wed Aug 21 10:16:05 2013 -0500 winecoreaudio.drv: Rewrite capture mode. --- dlls/winecoreaudio.drv/mmdevdrv.c | 202 +++++++++++++++++++------------------ 1 files changed, 104 insertions(+), 98 deletions(-) Diff:
http://source.winehq.org/git/wine.git/?a=commitdiff;h=927324ce8ffcf5acc9ba4…
1
0
0
0
Andrew Eikum : winmm: Increase mmdevapi buffer sizes.
by Alexandre Julliard
21 Aug '13
21 Aug '13
Module: wine Branch: master Commit: fdfff7cf6013a030f2b240b13b02831e502d49e7 URL:
http://source.winehq.org/git/wine.git/?a=commit;h=fdfff7cf6013a030f2b240b13…
Author: Andrew Eikum <aeikum(a)codeweavers.com> Date: Wed Aug 21 10:14:59 2013 -0500 winmm: Increase mmdevapi buffer sizes. The tiny buffer size caused audio capture glitches on OSX, where the OS often returns audio in half-second chunks. --- dlls/winmm/waveform.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/dlls/winmm/waveform.c b/dlls/winmm/waveform.c index 97849ff..23adfc0 100644 --- a/dlls/winmm/waveform.c +++ b/dlls/winmm/waveform.c @@ -68,8 +68,8 @@ static const WCHAR muteW[] = {'M','u','t','e',0}; * - We must be able to identify bad devices without crashing. */ -/* buffer size = 10 * 100000 (100 ns) = 0.1 seconds */ -#define AC_BUFLEN (10 * 100000) +/* buffer size = 100 * 100000 (100 ns) = 1 second */ +#define AC_BUFLEN (100 * 100000) #define MAX_DEVICES 256 #define MAPPER_INDEX 0x3F
1
0
0
0
Stefan Dösinger : wined3d: Move volume booleans into a flags field.
by Alexandre Julliard
21 Aug '13
21 Aug '13
Module: wine Branch: master Commit: 7e7ee524864c4d24c02148061d1160cba63eda18 URL:
http://source.winehq.org/git/wine.git/?a=commit;h=7e7ee524864c4d24c02148061…
Author: Stefan Dösinger <stefan(a)codeweavers.com> Date: Wed Aug 21 15:15:50 2013 +0200 wined3d: Move volume booleans into a flags field. --- dlls/wined3d/volume.c | 10 +++------- dlls/wined3d/wined3d_private.h | 8 +++++--- 2 files changed, 8 insertions(+), 10 deletions(-) diff --git a/dlls/wined3d/volume.c b/dlls/wined3d/volume.c index cdc7125..4c6bd4d 100644 --- a/dlls/wined3d/volume.c +++ b/dlls/wined3d/volume.c @@ -49,7 +49,6 @@ static void volume_bind_and_dirtify(const struct wined3d_volume *volume, struct void volume_add_dirty_box(struct wined3d_volume *volume, const struct wined3d_box *dirty_box) { - volume->dirty = TRUE; if (dirty_box) { volume->lockedBox.left = min(volume->lockedBox.left, dirty_box->left); @@ -233,7 +232,7 @@ HRESULT CDECL wined3d_volume_map(struct wined3d_volume *volume, wined3d_texture_set_dirty(volume->container, TRUE); } - volume->locked = TRUE; + volume->flags |= WINED3D_VFLAG_LOCKED; TRACE("Returning memory %p, row pitch %d, slice pitch %d.\n", map_desc->data, map_desc->row_pitch, map_desc->slice_pitch); @@ -250,13 +249,13 @@ HRESULT CDECL wined3d_volume_unmap(struct wined3d_volume *volume) { TRACE("volume %p.\n", volume); - if (!volume->locked) + if (!(volume->flags & WINED3D_VFLAG_LOCKED)) { WARN("Trying to unlock unlocked volume %p.\n", volume); return WINED3DERR_INVALIDCALL; } - volume->locked = FALSE; + volume->flags &= ~WINED3D_VFLAG_LOCKED; memset(&volume->lockedBox, 0, sizeof(volume->lockedBox)); return WINED3D_OK; @@ -293,10 +292,7 @@ static HRESULT volume_init(struct wined3d_volume *volume, struct wined3d_device return hr; } - volume->lockable = TRUE; - volume->locked = FALSE; memset(&volume->lockedBox, 0, sizeof(volume->lockedBox)); - volume->dirty = TRUE; volume_add_dirty_box(volume, NULL); diff --git a/dlls/wined3d/wined3d_private.h b/dlls/wined3d/wined3d_private.h index b96defb..7ed32ae 100644 --- a/dlls/wined3d/wined3d_private.h +++ b/dlls/wined3d/wined3d_private.h @@ -2050,15 +2050,17 @@ void wined3d_texture_apply_state_changes(struct wined3d_texture *texture, const struct wined3d_gl_info *gl_info) DECLSPEC_HIDDEN; void wined3d_texture_set_dirty(struct wined3d_texture *texture, BOOL dirty) DECLSPEC_HIDDEN; +#define WINED3D_VFLAG_LOCKED 0x00000001 + struct wined3d_volume { struct wined3d_resource resource; struct wined3d_texture *container; - BOOL lockable; - BOOL locked; + struct wined3d_box lockedBox; struct wined3d_box dirtyBox; - BOOL dirty; + + DWORD flags; }; static inline struct wined3d_volume *volume_from_resource(struct wined3d_resource *resource)
1
0
0
0
Stefan Dösinger : wined3d: Properly allocate heap memory for volumes.
by Alexandre Julliard
21 Aug '13
21 Aug '13
Module: wine Branch: master Commit: 6e4e1ad392871f9f67fbd69dd9c71eb5d74763ba URL:
http://source.winehq.org/git/wine.git/?a=commit;h=6e4e1ad392871f9f67fbd69dd…
Author: Stefan Dösinger <stefan(a)codeweavers.com> Date: Wed Aug 21 15:15:49 2013 +0200 wined3d: Properly allocate heap memory for volumes. --- dlls/wined3d/volume.c | 11 ++++++++++- 1 files changed, 10 insertions(+), 1 deletions(-) diff --git a/dlls/wined3d/volume.c b/dlls/wined3d/volume.c index 50d9a75..cdc7125 100644 --- a/dlls/wined3d/volume.c +++ b/dlls/wined3d/volume.c @@ -184,7 +184,16 @@ HRESULT CDECL wined3d_volume_map(struct wined3d_volume *volume, volume, map_desc, box, flags); if (!volume->resource.allocatedMemory) - volume->resource.allocatedMemory = HeapAlloc(GetProcessHeap(), HEAP_ZERO_MEMORY, volume->resource.size); + { + volume->resource.heap_memory = wined3d_resource_allocate_sysmem(volume->resource.size); + if (!volume->resource.heap_memory) + { + WARN("Out of memory.\n"); + map_desc->data = NULL; + return E_OUTOFMEMORY; + } + volume->resource.allocatedMemory = volume->resource.heap_memory; + } TRACE("allocatedMemory %p.\n", volume->resource.allocatedMemory);
1
0
0
0
← Newer
1
...
18
19
20
21
22
23
24
...
47
Older →
Jump to page:
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
Results per page:
10
25
50
100
200