winehq.org
Sign In
Sign Up
Sign In
Sign Up
Manage this list
×
Keyboard Shortcuts
Thread View
j
: Next unread message
k
: Previous unread message
j a
: Jump to all threads
j l
: Jump to MailingList overview
2025
July
June
May
April
March
February
January
2024
December
November
October
September
August
July
June
May
April
March
February
January
2023
December
November
October
September
August
July
June
May
April
March
February
January
2022
December
November
October
September
August
July
June
May
April
March
February
January
2021
December
November
October
September
August
July
June
May
April
March
February
January
2020
December
November
October
September
August
July
June
May
April
March
February
January
2019
December
November
October
September
August
July
June
May
April
March
February
January
2018
December
November
October
September
August
July
June
May
April
March
February
January
2017
December
November
October
September
August
July
June
May
April
March
February
January
2016
December
November
October
September
August
July
June
May
April
March
February
January
2015
December
November
October
September
August
July
June
May
April
March
February
January
2014
December
November
October
September
August
July
June
May
April
March
February
January
2013
December
November
October
September
August
July
June
May
April
March
February
January
2012
December
November
October
September
August
July
June
May
April
March
February
January
2011
December
November
October
September
August
July
June
May
April
March
February
January
2010
December
November
October
September
August
July
June
May
April
March
February
January
2009
December
November
October
September
August
July
June
May
April
March
February
January
2008
December
November
October
September
August
July
June
May
April
March
February
January
2007
December
November
October
September
August
July
June
May
April
March
February
January
2006
December
November
October
September
August
July
June
May
April
March
February
January
2005
December
November
October
September
August
July
June
May
April
March
February
January
2004
December
November
October
September
August
July
June
May
April
March
February
January
2003
December
November
October
September
August
July
June
May
April
March
February
January
2002
December
November
October
September
August
July
June
May
April
March
February
January
2001
December
November
October
September
August
July
June
May
April
March
February
List overview
wine-commits
March 2015
----- 2025 -----
July 2025
June 2025
May 2025
April 2025
March 2025
February 2025
January 2025
----- 2024 -----
December 2024
November 2024
October 2024
September 2024
August 2024
July 2024
June 2024
May 2024
April 2024
March 2024
February 2024
January 2024
----- 2023 -----
December 2023
November 2023
October 2023
September 2023
August 2023
July 2023
June 2023
May 2023
April 2023
March 2023
February 2023
January 2023
----- 2022 -----
December 2022
November 2022
October 2022
September 2022
August 2022
July 2022
June 2022
May 2022
April 2022
March 2022
February 2022
January 2022
----- 2021 -----
December 2021
November 2021
October 2021
September 2021
August 2021
July 2021
June 2021
May 2021
April 2021
March 2021
February 2021
January 2021
----- 2020 -----
December 2020
November 2020
October 2020
September 2020
August 2020
July 2020
June 2020
May 2020
April 2020
March 2020
February 2020
January 2020
----- 2019 -----
December 2019
November 2019
October 2019
September 2019
August 2019
July 2019
June 2019
May 2019
April 2019
March 2019
February 2019
January 2019
----- 2018 -----
December 2018
November 2018
October 2018
September 2018
August 2018
July 2018
June 2018
May 2018
April 2018
March 2018
February 2018
January 2018
----- 2017 -----
December 2017
November 2017
October 2017
September 2017
August 2017
July 2017
June 2017
May 2017
April 2017
March 2017
February 2017
January 2017
----- 2016 -----
December 2016
November 2016
October 2016
September 2016
August 2016
July 2016
June 2016
May 2016
April 2016
March 2016
February 2016
January 2016
----- 2015 -----
December 2015
November 2015
October 2015
September 2015
August 2015
July 2015
June 2015
May 2015
April 2015
March 2015
February 2015
January 2015
----- 2014 -----
December 2014
November 2014
October 2014
September 2014
August 2014
July 2014
June 2014
May 2014
April 2014
March 2014
February 2014
January 2014
----- 2013 -----
December 2013
November 2013
October 2013
September 2013
August 2013
July 2013
June 2013
May 2013
April 2013
March 2013
February 2013
January 2013
----- 2012 -----
December 2012
November 2012
October 2012
September 2012
August 2012
July 2012
June 2012
May 2012
April 2012
March 2012
February 2012
January 2012
----- 2011 -----
December 2011
November 2011
October 2011
September 2011
August 2011
July 2011
June 2011
May 2011
April 2011
March 2011
February 2011
January 2011
----- 2010 -----
December 2010
November 2010
October 2010
September 2010
August 2010
July 2010
June 2010
May 2010
April 2010
March 2010
February 2010
January 2010
----- 2009 -----
December 2009
November 2009
October 2009
September 2009
August 2009
July 2009
June 2009
May 2009
April 2009
March 2009
February 2009
January 2009
----- 2008 -----
December 2008
November 2008
October 2008
September 2008
August 2008
July 2008
June 2008
May 2008
April 2008
March 2008
February 2008
January 2008
----- 2007 -----
December 2007
November 2007
October 2007
September 2007
August 2007
July 2007
June 2007
May 2007
April 2007
March 2007
February 2007
January 2007
----- 2006 -----
December 2006
November 2006
October 2006
September 2006
August 2006
July 2006
June 2006
May 2006
April 2006
March 2006
February 2006
January 2006
----- 2005 -----
December 2005
November 2005
October 2005
September 2005
August 2005
July 2005
June 2005
May 2005
April 2005
March 2005
February 2005
January 2005
----- 2004 -----
December 2004
November 2004
October 2004
September 2004
August 2004
July 2004
June 2004
May 2004
April 2004
March 2004
February 2004
January 2004
----- 2003 -----
December 2003
November 2003
October 2003
September 2003
August 2003
July 2003
June 2003
May 2003
April 2003
March 2003
February 2003
January 2003
----- 2002 -----
December 2002
November 2002
October 2002
September 2002
August 2002
July 2002
June 2002
May 2002
April 2002
March 2002
February 2002
January 2002
----- 2001 -----
December 2001
November 2001
October 2001
September 2001
August 2001
July 2001
June 2001
May 2001
April 2001
March 2001
February 2001
wine-commits@winehq.org
2 participants
775 discussions
Start a n
N
ew thread
Francois Gouget : opengl32: Mark internal symbols with hidden visibility.
by Alexandre Julliard
26 Mar '15
26 Mar '15
Module: wine Branch: master Commit: 04b09dd68c1100ee0171b287dcb52bb1e85626f5 URL:
http://source.winehq.org/git/wine.git/?a=commit;h=04b09dd68c1100ee0171b287d…
Author: Francois Gouget <fgouget(a)free.fr> Date: Thu Mar 26 15:30:26 2015 +0100 opengl32: Mark internal symbols with hidden visibility. --- dlls/opengl32/opengl_ext.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/dlls/opengl32/opengl_ext.h b/dlls/opengl32/opengl_ext.h index 5748e0c..2e49d4a 100644 --- a/dlls/opengl32/opengl_ext.h +++ b/dlls/opengl32/opengl_ext.h @@ -28,9 +28,9 @@ typedef struct { void *func; /* pointer to the Wine function for this extension */ } OpenGL_extension; -extern const OpenGL_extension extension_registry[]; -extern const int extension_registry_size; +extern const OpenGL_extension extension_registry[] DECLSPEC_HIDDEN; +extern const int extension_registry_size DECLSPEC_HIDDEN; -extern BOOL WINAPI wglSetPixelFormatWINE( HDC hdc, int format ); +extern BOOL WINAPI wglSetPixelFormatWINE( HDC hdc, int format ) DECLSPEC_HIDDEN; #endif /* __DLLS_OPENGL32_OPENGL_EXT_H */
1
0
0
0
Francois Gouget : oleaut32: Mark internal symbols with hidden visibility.
by Alexandre Julliard
26 Mar '15
26 Mar '15
Module: wine Branch: master Commit: deb988e52aad39e4c065a2fdfb47afd31a370d4d URL:
http://source.winehq.org/git/wine.git/?a=commit;h=deb988e52aad39e4c065a2fdf…
Author: Francois Gouget <fgouget(a)free.fr> Date: Thu Mar 26 15:30:13 2015 +0100 oleaut32: Mark internal symbols with hidden visibility. --- dlls/oleaut32/variant.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dlls/oleaut32/variant.h b/dlls/oleaut32/variant.h index e5d9a56..9436cb3 100644 --- a/dlls/oleaut32/variant.h +++ b/dlls/oleaut32/variant.h @@ -114,7 +114,7 @@ typedef struct tagVARIANT_NUMBER_CHARS WCHAR cCurrencyDigitSeparator; } VARIANT_NUMBER_CHARS; -unsigned int get_type_size(ULONG*, VARTYPE); +unsigned int get_type_size(ULONG*, VARTYPE) DECLSPEC_HIDDEN; BOOL VARIANT_GetLocalisedText(LANGID, DWORD, WCHAR *) DECLSPEC_HIDDEN; HRESULT VARIANT_ClearInd(VARIANTARG *) DECLSPEC_HIDDEN; BOOL get_date_format(LCID, DWORD, const SYSTEMTIME *,
1
0
0
0
Francois Gouget : mshtml: Mark internal symbols with hidden visibility.
by Alexandre Julliard
26 Mar '15
26 Mar '15
Module: wine Branch: master Commit: 45f5e5d74686364eb3cf6e9d0dd79102a6d95ed3 URL:
http://source.winehq.org/git/wine.git/?a=commit;h=45f5e5d74686364eb3cf6e9d0…
Author: Francois Gouget <fgouget(a)free.fr> Date: Thu Mar 26 15:30:04 2015 +0100 mshtml: Mark internal symbols with hidden visibility. --- dlls/mshtml/mshtml_private.h | 16 ++++++++-------- dlls/mshtml/pluginhost.h | 2 +- 2 files changed, 9 insertions(+), 9 deletions(-) diff --git a/dlls/mshtml/mshtml_private.h b/dlls/mshtml/mshtml_private.h index 6d39a72..22b8397 100644 --- a/dlls/mshtml/mshtml_private.h +++ b/dlls/mshtml/mshtml_private.h @@ -268,12 +268,12 @@ typedef struct { DEFINE_GUID(IID_nsXPCOMCycleCollectionParticipant, 0x9674489b,0x1f6f,0x4550,0xa7,0x30, 0xcc,0xae,0xdd,0x10,0x4c,0xf9); -nsrefcnt (__cdecl *ccref_incr)(nsCycleCollectingAutoRefCnt*,nsISupports*); -nsrefcnt (__cdecl *ccref_decr)(nsCycleCollectingAutoRefCnt*,nsISupports*,ExternalCycleCollectionParticipant*); -void (__cdecl *ccref_init)(nsCycleCollectingAutoRefCnt*,nsrefcnt); -void (__cdecl *ccp_init)(ExternalCycleCollectionParticipant*,const CCObjCallback*); -void (__cdecl *describe_cc_node)(nsCycleCollectingAutoRefCnt*,const char*,nsCycleCollectionTraversalCallback*); -void (__cdecl *note_cc_edge)(nsISupports*,const char*,nsCycleCollectionTraversalCallback*); +nsrefcnt (__cdecl *ccref_incr)(nsCycleCollectingAutoRefCnt*,nsISupports*) DECLSPEC_HIDDEN; +nsrefcnt (__cdecl *ccref_decr)(nsCycleCollectingAutoRefCnt*,nsISupports*,ExternalCycleCollectionParticipant*) DECLSPEC_HIDDEN; +void (__cdecl *ccref_init)(nsCycleCollectingAutoRefCnt*,nsrefcnt) DECLSPEC_HIDDEN; +void (__cdecl *ccp_init)(ExternalCycleCollectionParticipant*,const CCObjCallback*) DECLSPEC_HIDDEN; +void (__cdecl *describe_cc_node)(nsCycleCollectingAutoRefCnt*,const char*,nsCycleCollectionTraversalCallback*) DECLSPEC_HIDDEN; +void (__cdecl *note_cc_edge)(nsISupports*,const char*,nsCycleCollectionTraversalCallback*) DECLSPEC_HIDDEN; void init_dispex(DispatchEx*,IUnknown*,dispex_static_data_t*) DECLSPEC_HIDDEN; void release_dispex(DispatchEx*) DECLSPEC_HIDDEN; @@ -699,9 +699,9 @@ typedef struct { IHTMLElement3_tid, \ IHTMLElement4_tid -extern cp_static_data_t HTMLElementEvents2_data; +extern cp_static_data_t HTMLElementEvents2_data DECLSPEC_HIDDEN; #define HTMLELEMENT_CPC {&DIID_HTMLElementEvents2, &HTMLElementEvents2_data} -extern const cpc_entry_t HTMLElement_cpc[]; +extern const cpc_entry_t HTMLElement_cpc[] DECLSPEC_HIDDEN; typedef struct { HTMLElement element; diff --git a/dlls/mshtml/pluginhost.h b/dlls/mshtml/pluginhost.h index 46a1535..0460c3c 100644 --- a/dlls/mshtml/pluginhost.h +++ b/dlls/mshtml/pluginhost.h @@ -72,5 +72,5 @@ HRESULT create_ip_frame(IOleInPlaceFrame**) DECLSPEC_HIDDEN; HRESULT get_plugin_disp(HTMLPluginContainer*,IDispatch**) DECLSPEC_HIDDEN; HRESULT get_plugin_dispid(HTMLPluginContainer*,WCHAR*,DISPID*) DECLSPEC_HIDDEN; HRESULT invoke_plugin_prop(HTMLPluginContainer*,DISPID,LCID,WORD,DISPPARAMS*,VARIANT*,EXCEPINFO*) DECLSPEC_HIDDEN; -void notif_container_change(HTMLPluginContainer*,DISPID); +void notif_container_change(HTMLPluginContainer*,DISPID) DECLSPEC_HIDDEN; void bind_activex_event(HTMLDocumentNode*,HTMLPluginContainer*,WCHAR*,IDispatch*) DECLSPEC_HIDDEN;
1
0
0
0
Francois Gouget : windowscodecs: Remove unneeded NONAMELESSXXX directives.
by Alexandre Julliard
26 Mar '15
26 Mar '15
Module: wine Branch: master Commit: 0d80651e95b8f6a5a20adfe5aaec15f1167d9a59 URL:
http://source.winehq.org/git/wine.git/?a=commit;h=0d80651e95b8f6a5a20adfe5a…
Author: Francois Gouget <fgouget(a)free.fr> Date: Thu Mar 26 15:29:53 2015 +0100 windowscodecs: Remove unneeded NONAMELESSXXX directives. --- dlls/windowscodecs/proxy.c | 1 - dlls/windowscodecs/regsvr.c | 2 -- 2 files changed, 3 deletions(-) diff --git a/dlls/windowscodecs/proxy.c b/dlls/windowscodecs/proxy.c index 38f076f..10d34e3 100644 --- a/dlls/windowscodecs/proxy.c +++ b/dlls/windowscodecs/proxy.c @@ -23,7 +23,6 @@ #include <stdarg.h> #define COBJMACROS -#define NONAMELESSUNION #include "windef.h" #include "winbase.h" diff --git a/dlls/windowscodecs/regsvr.c b/dlls/windowscodecs/regsvr.c index 91df294..28469c7 100644 --- a/dlls/windowscodecs/regsvr.c +++ b/dlls/windowscodecs/regsvr.c @@ -16,8 +16,6 @@ * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301, USA */ -#define NONAMELESSUNION -#define NONAMELESSSTRUCT #define COBJMACROS #include <stdarg.h> #include <string.h>
1
0
0
0
Francois Gouget : user32: Remove an unneeded NONAMELESSSTRUCT directive.
by Alexandre Julliard
26 Mar '15
26 Mar '15
Module: wine Branch: master Commit: 68264c2da700434f26d54ecdde5af2761111bb25 URL:
http://source.winehq.org/git/wine.git/?a=commit;h=68264c2da700434f26d54ecdd…
Author: Francois Gouget <fgouget(a)free.fr> Date: Thu Mar 26 15:29:46 2015 +0100 user32: Remove an unneeded NONAMELESSSTRUCT directive. --- dlls/user32/input.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dlls/user32/input.c b/dlls/user32/input.c index 1f05f34..0ed4218 100644 --- a/dlls/user32/input.c +++ b/dlls/user32/input.c @@ -33,7 +33,7 @@ #include <assert.h> #define NONAMELESSUNION -#define NONAMELESSSTRUCT + #include "ntstatus.h" #define WIN32_NO_STATUS #include "windef.h"
1
0
0
0
Francois Gouget : usbd.sys: Remove an unneeded NONAMELESSSTRUCT directive.
by Alexandre Julliard
26 Mar '15
26 Mar '15
Module: wine Branch: master Commit: de896a39538e934cdbb86891348f5b1d47edd830 URL:
http://source.winehq.org/git/wine.git/?a=commit;h=de896a39538e934cdbb868913…
Author: Francois Gouget <fgouget(a)free.fr> Date: Thu Mar 26 15:29:38 2015 +0100 usbd.sys: Remove an unneeded NONAMELESSSTRUCT directive. --- dlls/usbd.sys/usbd.c | 1 - 1 file changed, 1 deletion(-) diff --git a/dlls/usbd.sys/usbd.c b/dlls/usbd.sys/usbd.c index fbec22e..1cb2525 100644 --- a/dlls/usbd.sys/usbd.c +++ b/dlls/usbd.sys/usbd.c @@ -19,7 +19,6 @@ #include <stdarg.h> #define NONAMELESSUNION -#define NONAMELESSSTRUCT #include "ntstatus.h" #define WIN32_NO_STATUS
1
0
0
0
Francois Gouget : wineoss.drv: Remove an uneeded NONAMELESSUNION directive.
by Alexandre Julliard
26 Mar '15
26 Mar '15
Module: wine Branch: master Commit: 0ca3c64e92fe72c7ac81dade2946b2dd30316b39 URL:
http://source.winehq.org/git/wine.git/?a=commit;h=0ca3c64e92fe72c7ac81dade2…
Author: Francois Gouget <fgouget(a)free.fr> Date: Thu Mar 26 15:29:30 2015 +0100 wineoss.drv: Remove an uneeded NONAMELESSUNION directive. --- dlls/wineoss.drv/mmdevdrv.c | 1 - 1 file changed, 1 deletion(-) diff --git a/dlls/wineoss.drv/mmdevdrv.c b/dlls/wineoss.drv/mmdevdrv.c index 0688f9a..cbaf1b2 100644 --- a/dlls/wineoss.drv/mmdevdrv.c +++ b/dlls/wineoss.drv/mmdevdrv.c @@ -16,7 +16,6 @@ * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301, USA */ -#define NONAMELESSUNION #define COBJMACROS #include "config.h"
1
0
0
0
Francois Gouget : urlmon: Remove unneeded NONAMELESSXXX directives.
by Alexandre Julliard
26 Mar '15
26 Mar '15
Module: wine Branch: master Commit: 16960a425f9a40e62a9e02477bbe77ede217b77c URL:
http://source.winehq.org/git/wine.git/?a=commit;h=16960a425f9a40e62a9e02477…
Author: Francois Gouget <fgouget(a)free.fr> Date: Thu Mar 26 15:29:22 2015 +0100 urlmon: Remove unneeded NONAMELESSXXX directives. Also put them in the files that need them. --- dlls/urlmon/binding.c | 2 ++ dlls/urlmon/http.c | 2 ++ dlls/urlmon/tests/sec_mgr.c | 1 - dlls/urlmon/urlmon_main.c | 2 ++ dlls/urlmon/urlmon_main.h | 2 -- 5 files changed, 6 insertions(+), 3 deletions(-) diff --git a/dlls/urlmon/binding.c b/dlls/urlmon/binding.c index 306e9b3..9b78582 100644 --- a/dlls/urlmon/binding.c +++ b/dlls/urlmon/binding.c @@ -16,6 +16,8 @@ * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301, USA */ +#define NONAMELESSUNION + #include "urlmon_main.h" #include "winreg.h" #include "shlwapi.h" diff --git a/dlls/urlmon/http.c b/dlls/urlmon/http.c index 16e5fad..b0c7d2a 100644 --- a/dlls/urlmon/http.c +++ b/dlls/urlmon/http.c @@ -17,6 +17,8 @@ * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301, USA */ +#define NONAMELESSUNION + #include "urlmon_main.h" #include "wininet.h" diff --git a/dlls/urlmon/tests/sec_mgr.c b/dlls/urlmon/tests/sec_mgr.c index e41f0b6..4092842 100644 --- a/dlls/urlmon/tests/sec_mgr.c +++ b/dlls/urlmon/tests/sec_mgr.c @@ -20,7 +20,6 @@ #define COBJMACROS #define CONST_VTABLE -#define NONAMELESSUNION /* needed for IInternetZoneManagerEx2 */ #define _WIN32_IE 0x0700 diff --git a/dlls/urlmon/urlmon_main.c b/dlls/urlmon/urlmon_main.c index 1204a62..c4f1cec 100644 --- a/dlls/urlmon/urlmon_main.c +++ b/dlls/urlmon/urlmon_main.c @@ -20,6 +20,8 @@ #include <stdarg.h> +#define NONAMELESSUNION + #include "urlmon_main.h" #include "winreg.h" diff --git a/dlls/urlmon/urlmon_main.h b/dlls/urlmon/urlmon_main.h index 12be0ed..fd13279 100644 --- a/dlls/urlmon/urlmon_main.h +++ b/dlls/urlmon/urlmon_main.h @@ -23,8 +23,6 @@ #include <stdarg.h> #define COBJMACROS -#define NONAMELESSUNION -#define NONAMELESSSTRUCT #include "windef.h" #include "winbase.h"
1
0
0
0
Pierre Schweitzer : setupapi/tests: Add tests for the SetupOpenLog(), SetupLogErrorA(), SetupCloseLog() functions.
by Alexandre Julliard
26 Mar '15
26 Mar '15
Module: wine Branch: master Commit: a1edebefdf47cab4effa0324c0d4ea2218b031c4 URL:
http://source.winehq.org/git/wine.git/?a=commit;h=a1edebefdf47cab4effa0324c…
Author: Pierre Schweitzer <pierre(a)reactos.org> Date: Wed Mar 25 21:25:40 2015 +0100 setupapi/tests: Add tests for the SetupOpenLog(), SetupLogErrorA(), SetupCloseLog() functions. --- dlls/setupapi/tests/misc.c | 35 +++++++++++++++++++++++++++++++++++ 1 file changed, 35 insertions(+) diff --git a/dlls/setupapi/tests/misc.c b/dlls/setupapi/tests/misc.c index cfe888b..7423738 100644 --- a/dlls/setupapi/tests/misc.c +++ b/dlls/setupapi/tests/misc.c @@ -776,6 +776,39 @@ static void test_defaultcallback(void) SetupTermDefaultQueueCallback(ctxt); } +static void test_SetupLogError(void) +{ + BOOL ret; + DWORD error; + + SetLastError(0xdeadbeef); + ret = SetupLogErrorA("Test without opening\r\n", LogSevInformation); + error = GetLastError(); + ok(!ret, "SetupLogError succeeded\n"); + ok(error == ERROR_FILE_INVALID, "got wrong error: %d\n", error); + + ret = SetupOpenLog(FALSE); + ok(ret, "SetupOpenLog failed\n"); + + SetLastError(0xdeadbeef); + ret = SetupLogErrorA("Test with wrong log severity\r\n", LogSevMaximum); + error = GetLastError(); + ok(!ret, "SetupLogError succeeded\n"); + ok(error == 0xdeadbeef, "got wrong error: %d\n", error); + ret = SetupLogErrorA("Test without EOL", LogSevInformation); + ok(ret, "SetupLogError failed\n"); + + SetLastError(0xdeadbeef); + ret = SetupLogErrorA(NULL, LogSevInformation); + ok(ret || broken(!ret && GetLastError() == ERROR_INVALID_PARAMETER /* Win Vista+ */), + "SetupLogError failed: %08x\n", GetLastError()); + + ret = SetupOpenLog(FALSE); + ok(ret, "SetupOpenLog failed\n"); + + SetupCloseLog(); +} + START_TEST(misc) { HMODULE hsetupapi = GetModuleHandleA("setupapi.dll"); @@ -807,4 +840,6 @@ START_TEST(misc) win_skip("SetupUninstallOEMInfA is not available\n"); test_defaultcallback(); + + test_SetupLogError(); }
1
0
0
0
Pierre Schweitzer : setupapi: Implement SetupLogErrorA(), SetupLogErrorW() .
by Alexandre Julliard
26 Mar '15
26 Mar '15
Module: wine Branch: master Commit: a851aaa4248b9f38c0c6e3b1c04e54f95de163b3 URL:
http://source.winehq.org/git/wine.git/?a=commit;h=a851aaa4248b9f38c0c6e3b1c…
Author: Pierre Schweitzer <pierre(a)reactos.org> Date: Wed Mar 25 21:18:48 2015 +0100 setupapi: Implement SetupLogErrorA(), SetupLogErrorW(). --- dlls/setupapi/misc.c | 72 +++++++++++++++++++++++++++++++++++++++++++++ dlls/setupapi/setupapi.spec | 2 +- dlls/setupapi/stubs.c | 9 ------ 3 files changed, 73 insertions(+), 10 deletions(-) diff --git a/dlls/setupapi/misc.c b/dlls/setupapi/misc.c index f294821..de73966 100644 --- a/dlls/setupapi/misc.c +++ b/dlls/setupapi/misc.c @@ -1679,3 +1679,75 @@ BOOL WINAPI SetupOpenLog(BOOL reserved) return TRUE; } + +/*********************************************************************** + * SetupLogErrorA(SETUPAPI.@) + */ +BOOL WINAPI SetupLogErrorA(LPCSTR message, LogSeverity severity) +{ + static const char null[] = "(null)"; + BOOL ret; + DWORD written; + DWORD len; + + EnterCriticalSection(&setupapi_cs); + + if (setupact == INVALID_HANDLE_VALUE || setuperr == INVALID_HANDLE_VALUE) + { + SetLastError(ERROR_FILE_INVALID); + ret = FALSE; + goto done; + } + + if (message == NULL) + message = null; + + len = lstrlenA(message); + + ret = WriteFile(setupact, message, len, &written, NULL); + if (!ret) + goto done; + + if (severity >= LogSevMaximum) + { + ret = FALSE; + goto done; + } + + if (severity > LogSevInformation) + ret = WriteFile(setuperr, message, len, &written, NULL); + +done: + LeaveCriticalSection(&setupapi_cs); + return ret; +} + +/*********************************************************************** + * SetupLogErrorW(SETUPAPI.@) + */ +BOOL WINAPI SetupLogErrorW(LPCWSTR message, LogSeverity severity) +{ + LPSTR msg = NULL; + DWORD len; + BOOL ret; + + if (message) + { + len = WideCharToMultiByte(CP_ACP, 0, message, -1, NULL, 0, NULL, NULL); + msg = HeapAlloc(GetProcessHeap(), 0, len); + if (msg == NULL) + { + SetLastError(ERROR_NOT_ENOUGH_MEMORY); + return FALSE; + } + WideCharToMultiByte(CP_ACP, 0, message, -1, msg, len, NULL, NULL); + } + + /* This is the normal way to proceed. The log files are ASCII files + * and W is to be converted. + */ + ret = SetupLogErrorA(msg, severity); + + HeapFree(GetProcessHeap(), 0, msg); + return ret; +} diff --git a/dlls/setupapi/setupapi.spec b/dlls/setupapi/setupapi.spec index 4fcf298..c1dbed5 100644 --- a/dlls/setupapi/setupapi.spec +++ b/dlls/setupapi/setupapi.spec @@ -459,7 +459,7 @@ @ stdcall SetupInstallServicesFromInfSectionW(long wstr long) @ stdcall SetupIterateCabinetA(str long ptr ptr) @ stdcall SetupIterateCabinetW(wstr long ptr ptr) -@ stub SetupLogErrorA +@ stdcall SetupLogErrorA(str long) @ stdcall SetupLogErrorW(wstr long) @ stdcall SetupLogFileA(ptr str str str long str str str long) @ stdcall SetupLogFileW(ptr wstr wstr wstr long wstr wstr wstr long) diff --git a/dlls/setupapi/stubs.c b/dlls/setupapi/stubs.c index 66bd5d4..a57f5fe 100644 --- a/dlls/setupapi/stubs.c +++ b/dlls/setupapi/stubs.c @@ -189,15 +189,6 @@ BOOL WINAPI RegistryDelnode(DWORD x, DWORD y) } /*********************************************************************** - * SetupLogErrorW(SETUPAPI.@) - */ -BOOL WINAPI SetupLogErrorW(LPCWSTR MessageString, LogSeverity Severity) -{ - FIXME("(%s, %d) stub\n", debugstr_w(MessageString), Severity); - return TRUE; -} - -/*********************************************************************** * SetupPromptReboot(SETUPAPI.@) */ INT WINAPI SetupPromptReboot( HSPFILEQ file_queue, HWND owner, BOOL scan_only )
1
0
0
0
← Newer
1
...
9
10
11
12
13
14
15
...
78
Older →
Jump to page:
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
Results per page:
10
25
50
100
200