winehq.org
Sign In
Sign Up
Sign In
Sign Up
Manage this list
×
Keyboard Shortcuts
Thread View
j
: Next unread message
k
: Previous unread message
j a
: Jump to all threads
j l
: Jump to MailingList overview
2025
July
June
May
April
March
February
January
2024
December
November
October
September
August
July
June
May
April
March
February
January
2023
December
November
October
September
August
July
June
May
April
March
February
January
2022
December
November
October
September
August
July
June
May
April
March
February
January
2021
December
November
October
September
August
July
June
May
April
March
February
January
2020
December
November
October
September
August
July
June
May
April
March
February
January
2019
December
November
October
September
August
July
June
May
April
March
February
January
2018
December
November
October
September
August
July
June
May
April
March
February
January
2017
December
November
October
September
August
July
June
May
April
March
February
January
2016
December
November
October
September
August
July
June
May
April
March
February
January
2015
December
November
October
September
August
July
June
May
April
March
February
January
2014
December
November
October
September
August
July
June
May
April
March
February
January
2013
December
November
October
September
August
July
June
May
April
March
February
January
2012
December
November
October
September
August
July
June
May
April
March
February
January
2011
December
November
October
September
August
July
June
May
April
March
February
January
2010
December
November
October
September
August
July
June
May
April
March
February
January
2009
December
November
October
September
August
July
June
May
April
March
February
January
2008
December
November
October
September
August
July
June
May
April
March
February
January
2007
December
November
October
September
August
July
June
May
April
March
February
January
2006
December
November
October
September
August
July
June
May
April
March
February
January
2005
December
November
October
September
August
July
June
May
April
March
February
January
2004
December
November
October
September
August
July
June
May
April
March
February
January
2003
December
November
October
September
August
July
June
May
April
March
February
January
2002
December
November
October
September
August
July
June
May
April
March
February
January
2001
December
November
October
September
August
July
June
May
April
March
February
List overview
wine-commits
March 2015
----- 2025 -----
July 2025
June 2025
May 2025
April 2025
March 2025
February 2025
January 2025
----- 2024 -----
December 2024
November 2024
October 2024
September 2024
August 2024
July 2024
June 2024
May 2024
April 2024
March 2024
February 2024
January 2024
----- 2023 -----
December 2023
November 2023
October 2023
September 2023
August 2023
July 2023
June 2023
May 2023
April 2023
March 2023
February 2023
January 2023
----- 2022 -----
December 2022
November 2022
October 2022
September 2022
August 2022
July 2022
June 2022
May 2022
April 2022
March 2022
February 2022
January 2022
----- 2021 -----
December 2021
November 2021
October 2021
September 2021
August 2021
July 2021
June 2021
May 2021
April 2021
March 2021
February 2021
January 2021
----- 2020 -----
December 2020
November 2020
October 2020
September 2020
August 2020
July 2020
June 2020
May 2020
April 2020
March 2020
February 2020
January 2020
----- 2019 -----
December 2019
November 2019
October 2019
September 2019
August 2019
July 2019
June 2019
May 2019
April 2019
March 2019
February 2019
January 2019
----- 2018 -----
December 2018
November 2018
October 2018
September 2018
August 2018
July 2018
June 2018
May 2018
April 2018
March 2018
February 2018
January 2018
----- 2017 -----
December 2017
November 2017
October 2017
September 2017
August 2017
July 2017
June 2017
May 2017
April 2017
March 2017
February 2017
January 2017
----- 2016 -----
December 2016
November 2016
October 2016
September 2016
August 2016
July 2016
June 2016
May 2016
April 2016
March 2016
February 2016
January 2016
----- 2015 -----
December 2015
November 2015
October 2015
September 2015
August 2015
July 2015
June 2015
May 2015
April 2015
March 2015
February 2015
January 2015
----- 2014 -----
December 2014
November 2014
October 2014
September 2014
August 2014
July 2014
June 2014
May 2014
April 2014
March 2014
February 2014
January 2014
----- 2013 -----
December 2013
November 2013
October 2013
September 2013
August 2013
July 2013
June 2013
May 2013
April 2013
March 2013
February 2013
January 2013
----- 2012 -----
December 2012
November 2012
October 2012
September 2012
August 2012
July 2012
June 2012
May 2012
April 2012
March 2012
February 2012
January 2012
----- 2011 -----
December 2011
November 2011
October 2011
September 2011
August 2011
July 2011
June 2011
May 2011
April 2011
March 2011
February 2011
January 2011
----- 2010 -----
December 2010
November 2010
October 2010
September 2010
August 2010
July 2010
June 2010
May 2010
April 2010
March 2010
February 2010
January 2010
----- 2009 -----
December 2009
November 2009
October 2009
September 2009
August 2009
July 2009
June 2009
May 2009
April 2009
March 2009
February 2009
January 2009
----- 2008 -----
December 2008
November 2008
October 2008
September 2008
August 2008
July 2008
June 2008
May 2008
April 2008
March 2008
February 2008
January 2008
----- 2007 -----
December 2007
November 2007
October 2007
September 2007
August 2007
July 2007
June 2007
May 2007
April 2007
March 2007
February 2007
January 2007
----- 2006 -----
December 2006
November 2006
October 2006
September 2006
August 2006
July 2006
June 2006
May 2006
April 2006
March 2006
February 2006
January 2006
----- 2005 -----
December 2005
November 2005
October 2005
September 2005
August 2005
July 2005
June 2005
May 2005
April 2005
March 2005
February 2005
January 2005
----- 2004 -----
December 2004
November 2004
October 2004
September 2004
August 2004
July 2004
June 2004
May 2004
April 2004
March 2004
February 2004
January 2004
----- 2003 -----
December 2003
November 2003
October 2003
September 2003
August 2003
July 2003
June 2003
May 2003
April 2003
March 2003
February 2003
January 2003
----- 2002 -----
December 2002
November 2002
October 2002
September 2002
August 2002
July 2002
June 2002
May 2002
April 2002
March 2002
February 2002
January 2002
----- 2001 -----
December 2001
November 2001
October 2001
September 2001
August 2001
July 2001
June 2001
May 2001
April 2001
March 2001
February 2001
wine-commits@winehq.org
2 participants
775 discussions
Start a n
N
ew thread
Piotr Caban : msvcrt/tests: Use NAN and INFINITY definitions from port.h in printf tests.
by Alexandre Julliard
25 Mar '15
25 Mar '15
Module: wine Branch: master Commit: 248bd63b53a2fd407794c253d414e2eabeed9631 URL:
http://source.winehq.org/git/wine.git/?a=commit;h=248bd63b53a2fd407794c253d…
Author: Piotr Caban <piotr(a)codeweavers.com> Date: Wed Mar 25 14:22:16 2015 +0100 msvcrt/tests: Use NAN and INFINITY definitions from port.h in printf tests. --- dlls/msvcrt/tests/printf.c | 55 +++++++++++++++++++++++++++++++++++----------- 1 file changed, 42 insertions(+), 13 deletions(-) diff --git a/dlls/msvcrt/tests/printf.c b/dlls/msvcrt/tests/printf.c index 0606c25..7f734ea 100644 --- a/dlls/msvcrt/tests/printf.c +++ b/dlls/msvcrt/tests/printf.c @@ -27,7 +27,6 @@ #include <stdio.h> #include <errno.h> -#include <math.h> #include "windef.h" #include "winbase.h" @@ -35,6 +34,27 @@ #include "wine/test.h" +static inline float __port_infinity(void) +{ + static const unsigned __inf_bytes = 0x7f800000; + return *(const float *)&__inf_bytes; +} +#define INFINITY __port_infinity() + +static inline float __port_nan(void) +{ + static const unsigned __nan_bytes = 0x7fc00000; + return *(const float *)&__nan_bytes; +} +#define NAN __port_nan() + +static inline float __port_ind(void) +{ + static const unsigned __ind_bytes = 0xffc00000; + return *(const float *)&__ind_bytes; +} +#define IND __port_ind() + static int (__cdecl *p__vscprintf)(const char *format, __ms_va_list valist); static int (__cdecl *p__vscwprintf)(const wchar_t *format, __ms_va_list valist); static int (__cdecl *p__vsnwprintf_s)(wchar_t *str, size_t sizeOfBuffer, @@ -82,7 +102,7 @@ static void test_sprintf( void ) { char buffer[100]; const char *format; - double pnumber=789456123, inf, nan; + double pnumber=789456123; int x, r; WCHAR wide[] = { 'w','i','d','e',0}; @@ -675,38 +695,47 @@ static void test_sprintf( void ) r = sprintf(buffer, format, 0x12345); ok(!strcmp(buffer,"2345"), "failed \"%s\"\n", buffer); - nan = 0.0; - inf = 1.0/nan; - nan = sqrt(-1); format = "%lf"; - r = sprintf(buffer, format, nan); + r = sprintf(buffer, format, IND); ok(r==9, "r = %d\n", r); ok(!strcmp(buffer, "-1.#IND00"), "failed: \"%s\"\n", buffer); - r = sprintf(buffer, format, inf); + r = sprintf(buffer, format, NAN); + ok(r==8, "r = %d\n", r); + ok(!strcmp(buffer, "1.#QNAN0"), "failed: \"%s\"\n", buffer); + r = sprintf(buffer, format, INFINITY); ok(r==8, "r = %d\n", r); ok(!strcmp(buffer, "1.#INF00"), "failed: \"%s\"\n", buffer); format = "%le"; - r = sprintf(buffer, format, nan); + r = sprintf(buffer, format, IND); ok(r==14, "r = %d\n", r); ok(!strcmp(buffer, "-1.#IND00e+000"), "failed: \"%s\"\n", buffer); - r = sprintf(buffer, format, inf); + r = sprintf(buffer, format, NAN); + ok(r==13, "r = %d\n", r); + ok(!strcmp(buffer, "1.#QNAN0e+000"), "failed: \"%s\"\n", buffer); + r = sprintf(buffer, format, INFINITY); ok(r==13, "r = %d\n", r); ok(!strcmp(buffer, "1.#INF00e+000"), "failed: \"%s\"\n", buffer); format = "%lg"; - r = sprintf(buffer, format, nan); + r = sprintf(buffer, format, IND); ok(r==7, "r = %d\n", r); ok(!strcmp(buffer, "-1.#IND"), "failed: \"%s\"\n", buffer); - r = sprintf(buffer, format, inf); + r = sprintf(buffer, format, NAN); + ok(r==7, "r = %d\n", r); + ok(!strcmp(buffer, "1.#QNAN"), "failed: \"%s\"\n", buffer); + r = sprintf(buffer, format, INFINITY); ok(r==6, "r = %d\n", r); ok(!strcmp(buffer, "1.#INF"), "failed: \"%s\"\n", buffer); format = "%010.2lf"; - r = sprintf(buffer, format, nan); + r = sprintf(buffer, format, IND); ok(r==10, "r = %d\n", r); ok(!strcmp(buffer, "-000001.#J"), "failed: \"%s\"\n", buffer); - r = sprintf(buffer, format, inf); + r = sprintf(buffer, format, NAN); + ok(r==10, "r = %d\n", r); + ok(!strcmp(buffer, "0000001.#R"), "failed: \"%s\"\n", buffer); + r = sprintf(buffer, format, INFINITY); ok(r==10, "r = %d\n", r); ok(!strcmp(buffer, "0000001.#J"), "failed: \"%s\"\n", buffer); }
1
0
0
0
Piotr Caban : msvcrt: Fix NAN handling in printf.
by Alexandre Julliard
25 Mar '15
25 Mar '15
Module: wine Branch: master Commit: 46db64ce1b0b0c729fed3e4737505da4d22c0e71 URL:
http://source.winehq.org/git/wine.git/?a=commit;h=46db64ce1b0b0c729fed3e473…
Author: Piotr Caban <piotr(a)codeweavers.com> Date: Wed Mar 25 14:22:02 2015 +0100 msvcrt: Fix NAN handling in printf. --- dlls/msvcrt/printf.h | 43 +++++++++++++++++++++++++++++++++---------- 1 file changed, 33 insertions(+), 10 deletions(-) diff --git a/dlls/msvcrt/printf.h b/dlls/msvcrt/printf.h index 80133d6..4757931 100644 --- a/dlls/msvcrt/printf.h +++ b/dlls/msvcrt/printf.h @@ -26,6 +26,10 @@ #define FUNC_NAME(func) func ## _a #endif +#ifndef signbit +#define signbit(x) ((x) < 0) +#endif + typedef struct FUNC_NAME(pf_flags_t) { APICHAR Sign, LeftAlign, Alternate, PadZero; @@ -539,19 +543,23 @@ int FUNC_NAME(pf_printf)(FUNC_NAME(puts_clbk) pf_puts, void *puts_ctx, const API int len = flags.Precision + 10; double val = pf_args(args_ctx, pos, VT_R8, valist).get_double; int r; - BOOL inf = FALSE, nan = FALSE; + BOOL inf = FALSE, nan = FALSE, ind = FALSE; if(isinf(val)) inf = TRUE; - else if(isnan(val)) - nan = TRUE; /* FIXME: NaN value may be displayed as #IND or #QNAN */ + else if(isnan(val)) { + if(!signbit(val)) + nan = TRUE; + else + ind = TRUE; + } - if(inf || nan) { - if(nan || val<0) + if(inf || nan || ind) { + if(ind || val<0) flags.Sign = '-'; if(flags.Format=='g' || flags.Format=='G') - val = 1.1234; /* fraction will be overwritten with #INF or #IND string */ + val = (nan ? 1.12345 : 1.1234); /* fraction will be overwritten with #INF, #IND or #QNAN string */ else val = 1; @@ -592,18 +600,33 @@ int FUNC_NAME(pf_printf)(FUNC_NAME(puts_clbk) pf_puts, void *puts_ctx, const API if(decimal_point) { *decimal_point = *locinfo->lconv->decimal_point; - if(inf || nan) { + if(inf || nan || ind) { static const char inf_str[] = "#INF"; static const char ind_str[] = "#IND"; + static const char nan_str[] = "#QNAN"; + + const char *str; + int size; + + if(inf) { + str = inf_str; + size = sizeof(inf_str); + }else if(ind) { + str = ind_str; + size = sizeof(ind_str); + }else { + str = nan_str; + size = sizeof(nan_str); + } - for(i=1; i<(inf ? sizeof(inf_str) : sizeof(ind_str)); i++) { + for(i=1; i<size; i++) { if(decimal_point[i]<'0' || decimal_point[i]>'9') break; - decimal_point[i] = inf ? inf_str[i-1] : ind_str[i-1]; + decimal_point[i] = str[i-1]; } - if(i!=sizeof(inf_str) && i!=1) + if(i!=size && i!=1) decimal_point[i-1]++; } }
1
0
0
0
Piotr Caban : msvcrt/tests: Add atan, tanh and exp tests on invalid arguments.
by Alexandre Julliard
25 Mar '15
25 Mar '15
Module: wine Branch: master Commit: 6de6e42a36d0bce0fa88b54b28a95bdb802d3237 URL:
http://source.winehq.org/git/wine.git/?a=commit;h=6de6e42a36d0bce0fa88b54b2…
Author: Piotr Caban <piotr(a)codeweavers.com> Date: Wed Mar 25 13:13:57 2015 +0100 msvcrt/tests: Add atan, tanh and exp tests on invalid arguments. --- dlls/msvcrt/tests/misc.c | 64 ++++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 64 insertions(+) diff --git a/dlls/msvcrt/tests/misc.c b/dlls/msvcrt/tests/misc.c index a4c5c8c..ab14e04 100644 --- a/dlls/msvcrt/tests/misc.c +++ b/dlls/msvcrt/tests/misc.c @@ -21,8 +21,29 @@ #include "wine/test.h" #include <errno.h> #include <stdio.h> +#include <math.h> #include "msvcrt.h" +static inline float __port_infinity(void) +{ + static const unsigned __inf_bytes = 0x7f800000; + return *(const float *)&__inf_bytes; +} +#define INFINITY __port_infinity() + +static inline float __port_nan(void) +{ + static const unsigned __nan_bytes = 0x7fc00000; + return *(const float *)&__nan_bytes; +} +#define NAN __port_nan() + +static inline BOOL almost_equal(double d1, double d2) { + if(d1-d2>-1e-30 && d1-d2<1e-30) + return TRUE; + return FALSE; +} + static int (__cdecl *prand_s)(unsigned int *); static int (__cdecl *pI10_OUTPUT)(long double, int, int, void*); static int (__cdecl *pstrerror_s)(char *, MSVCRT_size_t, int); @@ -34,6 +55,9 @@ static void (__cdecl *p__invalid_parameter)(const wchar_t*, const wchar_t*, const wchar_t*, unsigned int, uintptr_t); static void (__cdecl *p_qsort_s)(void*, MSVCRT_size_t, MSVCRT_size_t, int (__cdecl*)(void*, const void*, const void*), void*); +static double (__cdecl *p_atan)(double); +static double (__cdecl *p_exp)(double); +static double (__cdecl *p_tanh)(double); static void init(void) { @@ -48,6 +72,9 @@ static void init(void) p_set_errno = (void *)GetProcAddress(hmod, "_set_errno"); p__invalid_parameter = (void *)GetProcAddress(hmod, "_invalid_parameter"); p_qsort_s = (void *)GetProcAddress(hmod, "qsort_s"); + p_atan = (void *)GetProcAddress(hmod, "atan"); + p_exp = (void *)GetProcAddress(hmod, "exp"); + p_tanh = (void *)GetProcAddress(hmod, "tanh"); } static void test_rand_s(void) @@ -477,6 +504,42 @@ static void test_qsort_s(void) ok(tab[i] == i, "data sorted incorrectly on position %d: %d\n", i, tab[i]); } +static void test_math_functions(void) +{ + double ret; + + errno = 0xdeadbeef; + p_atan(NAN); + ok(errno == EDOM, "errno = %d\n", errno); + + errno = 0xdeadbeef; + ret = p_atan(INFINITY); + ok(almost_equal(ret, 1.57079632679489661923), "ret = %lf\n", ret); + ok(errno == 0xdeadbeef, "errno = %d\n", errno); + + errno = 0xdeadbeef; + ret = p_atan(-INFINITY); + ok(almost_equal(ret, -1.57079632679489661923), "ret = %lf\n", ret); + ok(errno == 0xdeadbeef, "errno = %d\n", errno); + + errno = 0xdeadbeef; + p_tanh(NAN); + ok(errno == EDOM, "errno = %d\n", errno); + + errno = 0xdeadbeef; + ret = p_tanh(INFINITY); + ok(almost_equal(ret, 1.0), "ret = %lf\n", ret); + ok(errno == 0xdeadbeef, "errno = %d\n", errno); + + errno = 0xdeadbeef; + p_exp(NAN); + ok(errno == EDOM, "errno = %d\n", errno); + + errno = 0xdeadbeef; + p_exp(INFINITY); + ok(errno == 0xdeadbeef, "errno = %d\n", errno); +} + START_TEST(misc) { int arg_c; @@ -504,4 +567,5 @@ START_TEST(misc) test__popen(arg_v[0]); test__invalid_parameter(); test_qsort_s(); + test_math_functions(); }
1
0
0
0
Jacek Caban : wininet: Pass timeout as DWORD in setsockopt calls.
by Alexandre Julliard
25 Mar '15
25 Mar '15
Module: wine Branch: master Commit: b720e42fcfbf148f9d2d0606549a805745fbc90c URL:
http://source.winehq.org/git/wine.git/?a=commit;h=b720e42fcfbf148f9d2d06065…
Author: Jacek Caban <jacek(a)codeweavers.com> Date: Wed Mar 25 13:10:14 2015 +0100 wininet: Pass timeout as DWORD in setsockopt calls. --- dlls/wininet/netconnection.c | 16 ++-------------- 1 file changed, 2 insertions(+), 14 deletions(-) diff --git a/dlls/wininet/netconnection.c b/dlls/wininet/netconnection.c index a268aa7..9f64cb9 100644 --- a/dlls/wininet/netconnection.c +++ b/dlls/wininet/netconnection.c @@ -949,22 +949,10 @@ int NETCON_GetCipherStrength(netconn_t *connection) DWORD NETCON_set_timeout(netconn_t *connection, BOOL send, DWORD value) { int result; - struct timeval tv; - /* value is in milliseconds, convert to struct timeval */ - if (value == INFINITE) - { - tv.tv_sec = 0; - tv.tv_usec = 0; - } - else - { - tv.tv_sec = value / 1000; - tv.tv_usec = (value % 1000) * 1000; - } result = setsockopt(connection->socket, SOL_SOCKET, - send ? SO_SNDTIMEO : SO_RCVTIMEO, (void*)&tv, - sizeof(tv)); + send ? SO_SNDTIMEO : SO_RCVTIMEO, (void*)&value, + sizeof(value)); if (result == -1) { WARN("setsockopt failed\n");
1
0
0
0
Alexandre Julliard : server: Fix the string type in traces for I/ O completion names.
by Alexandre Julliard
25 Mar '15
25 Mar '15
Module: wine Branch: master Commit: 9fc48b28662414afe1ea7c60a6b08f2103bc8439 URL:
http://source.winehq.org/git/wine.git/?a=commit;h=9fc48b28662414afe1ea7c60a…
Author: Alexandre Julliard <julliard(a)winehq.org> Date: Wed Mar 25 20:30:30 2015 +0900 server: Fix the string type in traces for I/O completion names. --- include/wine/server_protocol.h | 4 ++-- server/protocol.def | 4 ++-- server/trace.c | 4 ++-- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/include/wine/server_protocol.h b/include/wine/server_protocol.h index 1b7831e..0205131 100644 --- a/include/wine/server_protocol.h +++ b/include/wine/server_protocol.h @@ -4845,7 +4845,7 @@ struct create_completion_request unsigned int attributes; unsigned int concurrent; obj_handle_t rootdir; - /* VARARG(filename,string); */ + /* VARARG(filename,unicode_str); */ char __pad_28[4]; }; struct create_completion_reply @@ -4863,7 +4863,7 @@ struct open_completion_request unsigned int access; unsigned int attributes; obj_handle_t rootdir; - /* VARARG(filename,string); */ + /* VARARG(filename,unicode_str); */ }; struct open_completion_reply { diff --git a/server/protocol.def b/server/protocol.def index 2cd8272..a34dde9 100644 --- a/server/protocol.def +++ b/server/protocol.def @@ -3366,7 +3366,7 @@ enum coords_relative unsigned int attributes; /* object attributes */ unsigned int concurrent; /* max number of concurrent active threads */ obj_handle_t rootdir; /* root directory */ - VARARG(filename,string); /* port name */ + VARARG(filename,unicode_str); /* port name */ @REPLY obj_handle_t handle; /* port handle */ @END @@ -3377,7 +3377,7 @@ enum coords_relative unsigned int access; /* desired access to a port */ unsigned int attributes; /* object attributes */ obj_handle_t rootdir; /* root directory */ - VARARG(filename,string); /* port name */ + VARARG(filename,unicode_str); /* port name */ @REPLY obj_handle_t handle; /* port handle */ @END diff --git a/server/trace.c b/server/trace.c index c7f4921..e5d3cd3 100644 --- a/server/trace.c +++ b/server/trace.c @@ -3951,7 +3951,7 @@ static void dump_create_completion_request( const struct create_completion_reque fprintf( stderr, ", attributes=%08x", req->attributes ); fprintf( stderr, ", concurrent=%08x", req->concurrent ); fprintf( stderr, ", rootdir=%04x", req->rootdir ); - dump_varargs_string( ", filename=", cur_size ); + dump_varargs_unicode_str( ", filename=", cur_size ); } static void dump_create_completion_reply( const struct create_completion_reply *req ) @@ -3964,7 +3964,7 @@ static void dump_open_completion_request( const struct open_completion_request * fprintf( stderr, " access=%08x", req->access ); fprintf( stderr, ", attributes=%08x", req->attributes ); fprintf( stderr, ", rootdir=%04x", req->rootdir ); - dump_varargs_string( ", filename=", cur_size ); + dump_varargs_unicode_str( ", filename=", cur_size ); } static void dump_open_completion_reply( const struct open_completion_reply *req )
1
0
0
0
Michael Stefaniuc : mshtml/tests: Actually test the return of IHTMLTable_get_width().
by Alexandre Julliard
25 Mar '15
25 Mar '15
Module: wine Branch: master Commit: 0cce9200d95b62fd2a3bba5168ff1c4528820ef4 URL:
http://source.winehq.org/git/wine.git/?a=commit;h=0cce9200d95b62fd2a3bba516…
Author: Michael Stefaniuc <mstefani(a)redhat.de> Date: Wed Mar 25 11:49:12 2015 +0100 mshtml/tests: Actually test the return of IHTMLTable_get_width(). --- dlls/mshtml/tests/dom.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/dlls/mshtml/tests/dom.c b/dlls/mshtml/tests/dom.c index 29356d7..c8ab19d 100644 --- a/dlls/mshtml/tests/dom.c +++ b/dlls/mshtml/tests/dom.c @@ -6823,7 +6823,7 @@ static void test_table_elem(IHTMLElement *elem) hres = IHTMLTable_put_width(table, v); ok(hres == S_OK, "put_width = %08x\n", hres); VariantClear(&v); - IHTMLTable_get_width(table, &v); + hres = IHTMLTable_get_width(table, &v); ok(hres == S_OK, "get_width = %08x\n", hres); ok(!strcmp_wa(V_BSTR(&v), "11"), "Expected 11, got %s\n", wine_dbgstr_w(V_BSTR(&v))); VariantClear(&v); @@ -6833,7 +6833,7 @@ static void test_table_elem(IHTMLElement *elem) hres = IHTMLTable_put_width(table, v); ok(hres == S_OK, "put_width = %08x\n", hres); VariantClear(&v); - IHTMLTable_get_width(table, &v); + hres = IHTMLTable_get_width(table, &v); ok(hres == S_OK, "get_width = %08x\n", hres); ok(!strcmp_wa(V_BSTR(&v), "11"), "Expected 11, got %s\n", wine_dbgstr_w(V_BSTR(&v))); VariantClear(&v); @@ -6843,7 +6843,7 @@ static void test_table_elem(IHTMLElement *elem) hres = IHTMLTable_put_width(table, v); ok(hres == S_OK, "put_width = %08x\n", hres); VariantClear(&v); - IHTMLTable_get_width(table, &v); + hres = IHTMLTable_get_width(table, &v); ok(hres == S_OK, "get_width = %08x\n", hres); ok(!strcmp_wa(V_BSTR(&v), "40.2%"), "Expected 40.2%%, got %s\n", wine_dbgstr_w(V_BSTR(&v))); VariantClear(&v); @@ -6852,7 +6852,7 @@ static void test_table_elem(IHTMLElement *elem) V_I4(&v) = 11; hres = IHTMLTable_put_width(table, v); ok(hres == S_OK, "put_width = %08x\n", hres); - IHTMLTable_get_width(table, &v); + hres = IHTMLTable_get_width(table, &v); ok(hres == S_OK, "get_width = %08x\n", hres); ok(!strcmp_wa(V_BSTR(&v), "11"), "Expected 11, got %s\n", wine_dbgstr_w(V_BSTR(&v))); VariantClear(&v); @@ -6861,7 +6861,7 @@ static void test_table_elem(IHTMLElement *elem) V_R8(&v) = 11.9; hres = IHTMLTable_put_width(table, v); ok(hres == S_OK, "put_width = %08x\n", hres); - IHTMLTable_get_width(table, &v); + hres = IHTMLTable_get_width(table, &v); ok(hres == S_OK, "get_width = %08x\n", hres); ok(!strcmp_wa(V_BSTR(&v), "11"), "Expected 11, got %s\n", wine_dbgstr_w(V_BSTR(&v))); VariantClear(&v);
1
0
0
0
Michael Stefaniuc : taskschd/tests: Test the correct return value.
by Alexandre Julliard
25 Mar '15
25 Mar '15
Module: wine Branch: master Commit: 39f1184ee12bc12c27b6a56b4a5598a802eb9de7 URL:
http://source.winehq.org/git/wine.git/?a=commit;h=39f1184ee12bc12c27b6a56b4…
Author: Michael Stefaniuc <mstefani(a)redhat.de> Date: Wed Mar 25 11:47:31 2015 +0100 taskschd/tests: Test the correct return value. --- dlls/taskschd/tests/scheduler.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dlls/taskschd/tests/scheduler.c b/dlls/taskschd/tests/scheduler.c index 5e906ce..9a745b8 100644 --- a/dlls/taskschd/tests/scheduler.c +++ b/dlls/taskschd/tests/scheduler.c @@ -345,7 +345,7 @@ todo_wine hr = ITaskFolder_DeleteFolder(folder, Wine_Folder1_Folder2, 0); ok(hr == S_OK, "DeleteFolder error %#x\n", hr); - ITaskFolder_DeleteFolder(folder, Wine_Folder1+1, 0); + hr = ITaskFolder_DeleteFolder(folder, Wine_Folder1+1, 0); ok(hr == S_OK, "DeleteFolder error %#x\n", hr); hr = ITaskFolder_DeleteFolder(folder, Wine+1, 0); ok(hr == S_OK, "DeleteFolder error %#x\n", hr);
1
0
0
0
Vincent Povirk : gdiplus: Fix blend_colors when alpha channel differs.
by Alexandre Julliard
25 Mar '15
25 Mar '15
Module: wine Branch: master Commit: 9c579023f0750539bdf7815f8545c4620540387a URL:
http://source.winehq.org/git/wine.git/?a=commit;h=9c579023f0750539bdf7815f8…
Author: Vincent Povirk <vincent(a)codeweavers.com> Date: Tue Mar 24 12:50:18 2015 -0500 gdiplus: Fix blend_colors when alpha channel differs. When picking a color halfway between 100% white (0xffffffff) and fully transparent (0x00000000), the result was 50% opaque 50% grey (0x80808080) when it should really be 50% opaque white (0x80ffffff). This had a tendency to create grey fringes on things. The fix is to weight the non-alpha components based on how much they contribute to the final alpha value. --- dlls/gdiplus/graphics.c | 22 ++++++++++++---------- 1 file changed, 12 insertions(+), 10 deletions(-) diff --git a/dlls/gdiplus/graphics.c b/dlls/gdiplus/graphics.c index ae530a9..580390f 100644 --- a/dlls/gdiplus/graphics.c +++ b/dlls/gdiplus/graphics.c @@ -521,20 +521,22 @@ static GpStatus alpha_blend_pixels(GpGraphics *graphics, INT dst_x, INT dst_y, static ARGB blend_colors(ARGB start, ARGB end, REAL position) { - ARGB result=0; - ARGB i; - INT a1, a2, a3; + INT start_a, end_a, final_a; + INT pos; - a1 = (start >> 24) & 0xff; - a2 = (end >> 24) & 0xff; + pos = gdip_round(position * 0xff); - a3 = (int)(a1*(1.0f - position)+a2*(position)); + start_a = ((start >> 24) & 0xff) * (pos ^ 0xff); + end_a = ((end >> 24) & 0xff) * pos; - result |= a3 << 24; + final_a = start_a + end_a; - for (i=0xff; i<=0xff0000; i = i << 8) - result |= (int)((start&i)*(1.0f - position)+(end&i)*(position))&i; - return result; + if (final_a < 0xff) return 0; + + return (final_a / 0xff) << 24 | + ((((start >> 16) & 0xff) * start_a + (((end >> 16) & 0xff) * end_a)) / final_a) << 16 | + ((((start >> 8) & 0xff) * start_a + (((end >> 8) & 0xff) * end_a)) / final_a) << 8 | + (((start & 0xff) * start_a + ((end & 0xff) * end_a)) / final_a); } static ARGB blend_line_gradient(GpLineGradient* brush, REAL position)
1
0
0
0
Zheng Chen : msvcrt: Correct atan/exp/tanh errno setting.
by Alexandre Julliard
25 Mar '15
25 Mar '15
Module: wine Branch: master Commit: e95dbb3b747dcd92b614578b3ca4b1c2dbfdaece URL:
http://source.winehq.org/git/wine.git/?a=commit;h=e95dbb3b747dcd92b614578b3…
Author: Zheng Chen <chanchengcc(a)gmail.com> Date: Tue Mar 24 18:09:50 2015 +0800 msvcrt: Correct atan/exp/tanh errno setting. --- dlls/msvcrt/math.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/dlls/msvcrt/math.c b/dlls/msvcrt/math.c index acac35d..73f01aa 100644 --- a/dlls/msvcrt/math.c +++ b/dlls/msvcrt/math.c @@ -363,7 +363,7 @@ double CDECL MSVCRT_asin( double x ) */ double CDECL MSVCRT_atan( double x ) { - if (!isfinite(x)) *MSVCRT__errno() = MSVCRT_EDOM; + if (isnan(x)) *MSVCRT__errno() = MSVCRT_EDOM; return atan(x); } @@ -399,7 +399,7 @@ double CDECL MSVCRT_cosh( double x ) */ double CDECL MSVCRT_exp( double x ) { - if (!isfinite(x)) *MSVCRT__errno() = MSVCRT_EDOM; + if (isnan(x)) *MSVCRT__errno() = MSVCRT_EDOM; return exp(x); } @@ -484,7 +484,7 @@ double CDECL MSVCRT_tan( double x ) */ double CDECL MSVCRT_tanh( double x ) { - if (!isfinite(x)) *MSVCRT__errno() = MSVCRT_EDOM; + if (isnan(x)) *MSVCRT__errno() = MSVCRT_EDOM; return tanh(x); }
1
0
0
0
Henri Verbeet : d2d1: Implement d2d_state_block_SetDescription().
by Alexandre Julliard
25 Mar '15
25 Mar '15
Module: wine Branch: master Commit: 1b93c01048e2394194cc088ab1fd0efb9f5fbf4a URL:
http://source.winehq.org/git/wine.git/?a=commit;h=1b93c01048e2394194cc088ab…
Author: Henri Verbeet <hverbeet(a)codeweavers.com> Date: Wed Mar 25 10:05:31 2015 +0100 d2d1: Implement d2d_state_block_SetDescription(). --- dlls/d2d1/state_block.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/dlls/d2d1/state_block.c b/dlls/d2d1/state_block.c index e893264..28da331 100644 --- a/dlls/d2d1/state_block.c +++ b/dlls/d2d1/state_block.c @@ -94,7 +94,11 @@ static void STDMETHODCALLTYPE d2d_state_block_GetDescription(ID2D1DrawingStateBl static void STDMETHODCALLTYPE d2d_state_block_SetDescription(ID2D1DrawingStateBlock *iface, const D2D1_DRAWING_STATE_DESCRIPTION *desc) { - FIXME("iface %p, desc %p stub!\n", iface, desc); + struct d2d_state_block *state_block = impl_from_ID2D1DrawingStateBlock(iface); + + TRACE("iface %p, desc %p.\n", iface, desc); + + state_block->drawing_state = *desc; } static void STDMETHODCALLTYPE d2d_state_block_SetTextRenderingParams(ID2D1DrawingStateBlock *iface,
1
0
0
0
← Newer
1
...
13
14
15
16
17
18
19
...
78
Older →
Jump to page:
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
Results per page:
10
25
50
100
200