wine-commits March 2015

wine-commits@winehq.org

2 participants
775 discussions

Stefan Dösinger : ddraw/tests: Add a DDBLT_COLORFILL test.
by Alexandre Julliard 17 Mar '15

17 Mar '15

Module: wine Branch: master Commit: 1d8e92c170652f449243e10c20b21f532a94e71c URL: http://source.winehq.org/git/wine.git/?a=commit;h=1d8e92c170652f449243e10c2… Author: Stefan Dösinger <stefan(a)codeweavers.com> Date: Mon Mar 16 14:48:53 2015 +0100 ddraw/tests: Add a DDBLT_COLORFILL test. --- dlls/ddraw/tests/ddraw7.c | 340 ++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 340 insertions(+) Diff: http://source.winehq.org/git/wine.git/?a=commitdiff;h=1d8e92c170652f449243e…

1 0

Stefan Dösinger : ddraw: Add DDBLT_COLORFILL validation.
by Alexandre Julliard 17 Mar '15

17 Mar '15

Module: wine Branch: master Commit: 6cb795b4b6879a9a023229fe07d8301447c515cc URL: http://source.winehq.org/git/wine.git/?a=commit;h=6cb795b4b6879a9a023229fe0… Author: Stefan Dösinger <stefan(a)codeweavers.com> Date: Mon Mar 16 14:48:52 2015 +0100 ddraw: Add DDBLT_COLORFILL validation. --- dlls/ddraw/surface.c | 22 ++++++++++++++++++++++ 1 file changed, 22 insertions(+) diff --git a/dlls/ddraw/surface.c b/dlls/ddraw/surface.c index cbf11da..8b25cb9 100644 --- a/dlls/ddraw/surface.c +++ b/dlls/ddraw/surface.c @@ -1537,6 +1537,28 @@ static HRESULT WINAPI ddraw_surface7_Blt(IDirectDrawSurface7 *iface, RECT *DestR wined3d_mutex_lock(); + if (Flags & DDBLT_COLORFILL) + { + if (src_surface) + { + wined3d_mutex_unlock(); + WARN("DDBLT_COLORFILL is not compatible with source surfaces, returning DDERR_INVALIDPARAMS\n"); + return DDERR_INVALIDPARAMS; + } + if (!DDBltFx) + { + wined3d_mutex_unlock(); + WARN("DDBLT_COLORFILL used with DDBltFx = NULL, returning DDERR_INVALIDPARAMS.\n"); + return DDERR_INVALIDPARAMS; + } + if (dst_surface->surface_desc.ddsCaps.dwCaps & DDSCAPS_ZBUFFER) + { + wined3d_mutex_unlock(); + WARN("DDBLT_COLORFILL used on a depth buffer, returning DDERR_INVALIDPARAMS.\n"); + return DDERR_INVALIDPARAMS; + } + } + if (Flags & DDBLT_KEYSRC && (!src_surface || !(src_surface->surface_desc.dwFlags & DDSD_CKSRCBLT))) { WARN("DDBLT_KEYDEST blit without color key in surface, returning DDERR_INVALIDPARAMS\n");

1 0

Sebastian Lackner : ntdll: RtlFindActivationContextSectionString should accept a NULL pointer as data.
by Alexandre Julliard 17 Mar '15

17 Mar '15

Module: wine Branch: master Commit: ab91c011121b76bcc46fc7e3b3addefd1b3acca2 URL: http://source.winehq.org/git/wine.git/?a=commit;h=ab91c011121b76bcc46fc7e3b… Author: Sebastian Lackner <sebastian(a)fds-team.de> Date: Mon Mar 16 03:38:58 2015 +0100 ntdll: RtlFindActivationContextSectionString should accept a NULL pointer as data. --- dlls/kernel32/actctx.c | 8 ++++- dlls/kernel32/tests/actctx.c | 10 ++++-- dlls/ntdll/actctx.c | 81 ++++++++++++++++++++++++-------------------- 3 files changed, 59 insertions(+), 40 deletions(-) diff --git a/dlls/kernel32/actctx.c b/dlls/kernel32/actctx.c index bcf95ec..2eb1c2a 100644 --- a/dlls/kernel32/actctx.c +++ b/dlls/kernel32/actctx.c @@ -227,7 +227,7 @@ BOOL WINAPI FindActCtxSectionStringA(DWORD dwFlags, const GUID* lpExtGuid, TRACE("%08x %s %u %s %p\n", dwFlags, debugstr_guid(lpExtGuid), ulId, debugstr_a(lpSearchStr), pInfo); - if (!lpSearchStr) + if (!lpSearchStr || !pInfo) { SetLastError(ERROR_INVALID_PARAMETER); return FALSE; @@ -255,6 +255,12 @@ BOOL WINAPI FindActCtxSectionStringW(DWORD dwFlags, const GUID* lpExtGuid, UNICODE_STRING us; NTSTATUS status; + if (!pInfo) + { + SetLastError(ERROR_INVALID_PARAMETER); + return FALSE; + } + RtlInitUnicodeString(&us, lpSearchStr); if ((status = RtlFindActivationContextSectionString(dwFlags, lpExtGuid, ulId, &us, pInfo))) { diff --git a/dlls/kernel32/tests/actctx.c b/dlls/kernel32/tests/actctx.c index 887c6b0..7512aed 100644 --- a/dlls/kernel32/tests/actctx.c +++ b/dlls/kernel32/tests/actctx.c @@ -2148,9 +2148,13 @@ static void ntdll_find(ULONG section, const char *string_to_find, BOOL should_fi "RtlFindActivationContextSectionString: unexpected status 0x%x\n", ret); ret = pRtlFindActivationContextSectionString(0, NULL, section, &string_to_findW, NULL); - todo_wine - ok_(__FILE__, line)(ret == (should_find ? STATUS_SUCCESS : STATUS_SXS_KEY_NOT_FOUND), - "RtlFindActivationContextSectionString: unexpected status 0x%x\n", ret); + if (todo) + todo_wine + ok_(__FILE__, line)(ret == (should_find ? STATUS_SUCCESS : STATUS_SXS_KEY_NOT_FOUND), + "RtlFindActivationContextSectionString: unexpected status 0x%x\n", ret); + else + ok_(__FILE__, line)(ret == (should_find ? STATUS_SUCCESS : STATUS_SXS_KEY_NOT_FOUND), + "RtlFindActivationContextSectionString: unexpected status 0x%x\n", ret); pRtlFreeUnicodeString(&string_to_findW); } diff --git a/dlls/ntdll/actctx.c b/dlls/ntdll/actctx.c index 6ea7b54..4552e40 100644 --- a/dlls/ntdll/actctx.c +++ b/dlls/ntdll/actctx.c @@ -3133,19 +3133,22 @@ static NTSTATUS find_dll_redirection(ACTIVATION_CONTEXT* actctx, const UNICODE_S index = find_string_index(actctx->dllredirect_section, name); if (!index) return STATUS_SXS_KEY_NOT_FOUND; - dll = get_dllredirect_data(actctx, index); + if (data) + { + dll = get_dllredirect_data(actctx, index); - data->ulDataFormatVersion = 1; - data->lpData = dll; - data->ulLength = dll->size; - data->lpSectionGlobalData = NULL; - data->ulSectionGlobalDataLength = 0; - data->lpSectionBase = actctx->dllredirect_section; - data->ulSectionTotalLength = RtlSizeHeap( GetProcessHeap(), 0, actctx->dllredirect_section ); - data->hActCtx = NULL; + data->ulDataFormatVersion = 1; + data->lpData = dll; + data->ulLength = dll->size; + data->lpSectionGlobalData = NULL; + data->ulSectionGlobalDataLength = 0; + data->lpSectionBase = actctx->dllredirect_section; + data->ulSectionTotalLength = RtlSizeHeap( GetProcessHeap(), 0, actctx->dllredirect_section ); + data->hActCtx = NULL; - if (data->cbSize >= FIELD_OFFSET(ACTCTX_SECTION_KEYED_DATA, ulAssemblyRosterIndex) + sizeof(ULONG)) - data->ulAssemblyRosterIndex = index->rosterindex; + if (data->cbSize >= FIELD_OFFSET(ACTCTX_SECTION_KEYED_DATA, ulAssemblyRosterIndex) + sizeof(ULONG)) + data->ulAssemblyRosterIndex = index->rosterindex; + } return STATUS_SUCCESS; } @@ -3342,20 +3345,23 @@ static NTSTATUS find_window_class(ACTIVATION_CONTEXT* actctx, const UNICODE_STRI if (!index) return STATUS_SXS_KEY_NOT_FOUND; - class = get_wndclass_data(actctx, index); + if (data) + { + class = get_wndclass_data(actctx, index); - data->ulDataFormatVersion = 1; - data->lpData = class; - /* full length includes string length with nulls */ - data->ulLength = class->size + class->name_len + class->module_len + 2*sizeof(WCHAR); - data->lpSectionGlobalData = NULL; - data->ulSectionGlobalDataLength = 0; - data->lpSectionBase = actctx->wndclass_section; - data->ulSectionTotalLength = RtlSizeHeap( GetProcessHeap(), 0, actctx->wndclass_section ); - data->hActCtx = NULL; + data->ulDataFormatVersion = 1; + data->lpData = class; + /* full length includes string length with nulls */ + data->ulLength = class->size + class->name_len + class->module_len + 2*sizeof(WCHAR); + data->lpSectionGlobalData = NULL; + data->ulSectionGlobalDataLength = 0; + data->lpSectionBase = actctx->wndclass_section; + data->ulSectionTotalLength = RtlSizeHeap( GetProcessHeap(), 0, actctx->wndclass_section ); + data->hActCtx = NULL; - if (data->cbSize >= FIELD_OFFSET(ACTCTX_SECTION_KEYED_DATA, ulAssemblyRosterIndex) + sizeof(ULONG)) - data->ulAssemblyRosterIndex = index->rosterindex; + if (data->cbSize >= FIELD_OFFSET(ACTCTX_SECTION_KEYED_DATA, ulAssemblyRosterIndex) + sizeof(ULONG)) + data->ulAssemblyRosterIndex = index->rosterindex; + } return STATUS_SUCCESS; } @@ -4397,19 +4403,22 @@ static NTSTATUS find_progid_redirection(ACTIVATION_CONTEXT* actctx, const UNICOD index = find_string_index(actctx->progid_section, name); if (!index) return STATUS_SXS_KEY_NOT_FOUND; - progid = get_progid_data(actctx, index); + if (data) + { + progid = get_progid_data(actctx, index); - data->ulDataFormatVersion = 1; - data->lpData = progid; - data->ulLength = progid->size; - data->lpSectionGlobalData = (BYTE*)actctx->progid_section + actctx->progid_section->global_offset; - data->ulSectionGlobalDataLength = actctx->progid_section->global_len; - data->lpSectionBase = actctx->progid_section; - data->ulSectionTotalLength = RtlSizeHeap( GetProcessHeap(), 0, actctx->progid_section ); - data->hActCtx = NULL; + data->ulDataFormatVersion = 1; + data->lpData = progid; + data->ulLength = progid->size; + data->lpSectionGlobalData = (BYTE*)actctx->progid_section + actctx->progid_section->global_offset; + data->ulSectionGlobalDataLength = actctx->progid_section->global_len; + data->lpSectionBase = actctx->progid_section; + data->ulSectionTotalLength = RtlSizeHeap( GetProcessHeap(), 0, actctx->progid_section ); + data->hActCtx = NULL; - if (data->cbSize >= FIELD_OFFSET(ACTCTX_SECTION_KEYED_DATA, ulAssemblyRosterIndex) + sizeof(ULONG)) - data->ulAssemblyRosterIndex = index->rosterindex; + if (data->cbSize >= FIELD_OFFSET(ACTCTX_SECTION_KEYED_DATA, ulAssemblyRosterIndex) + sizeof(ULONG)) + data->ulAssemblyRosterIndex = index->rosterindex; + } return STATUS_SUCCESS; } @@ -4441,7 +4450,7 @@ static NTSTATUS find_string(ACTIVATION_CONTEXT* actctx, ULONG section_kind, if (status != STATUS_SUCCESS) return status; - if (flags & FIND_ACTCTX_SECTION_KEY_RETURN_HACTCTX) + if (data && (flags & FIND_ACTCTX_SECTION_KEY_RETURN_HACTCTX)) { actctx_addref(actctx); data->hActCtx = actctx; @@ -5008,7 +5017,7 @@ NTSTATUS WINAPI RtlFindActivationContextSectionString( ULONG flags, const GUID * FIXME("unknown flags %08x\n", flags); return STATUS_INVALID_PARAMETER; } - if (!data || data->cbSize < offsetof(ACTCTX_SECTION_KEYED_DATA, ulAssemblyRosterIndex) || + if ((data && data->cbSize < offsetof(ACTCTX_SECTION_KEYED_DATA, ulAssemblyRosterIndex)) || !section_name || !section_name->Buffer) { WARN("invalid parameter\n");

1 0

Mark Jansen : kernel32/tests: Parameter validation tests for FindActCtxSectionString.
by Alexandre Julliard 17 Mar '15

17 Mar '15

Module: wine Branch: master Commit: f091ff5851d2d1e2a9088c59eabba7b17152c5d4 URL: http://source.winehq.org/git/wine.git/?a=commit;h=f091ff5851d2d1e2a9088c59e… Author: Mark Jansen <learn0more(a)gmail.com> Date: Sun Mar 15 23:39:09 2015 +0100 kernel32/tests: Parameter validation tests for FindActCtxSectionString. --- dlls/kernel32/tests/actctx.c | 150 ++++++++++++++++++++++++++++++++++++++++++- 1 file changed, 148 insertions(+), 2 deletions(-) diff --git a/dlls/kernel32/tests/actctx.c b/dlls/kernel32/tests/actctx.c index 60763b1..887c6b0 100644 --- a/dlls/kernel32/tests/actctx.c +++ b/dlls/kernel32/tests/actctx.c @@ -16,6 +16,8 @@ * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301, USA */ +#include "ntstatus.h" +#define WIN32_NO_STATUS #include "wine/test.h" #include <winbase.h> #include <windef.h> @@ -39,6 +41,10 @@ static BOOL (WINAPI *pQueryActCtxW)(DWORD,HANDLE,PVOID,ULONG,PVOID,SIZE_T,SIZE static VOID (WINAPI *pReleaseActCtx)(HANDLE); static BOOL (WINAPI *pFindActCtxSectionGuid)(DWORD,const GUID*,ULONG,const GUID*,PACTCTX_SECTION_KEYED_DATA); +static NTSTATUS(NTAPI *pRtlFindActivationContextSectionString)(DWORD,const GUID *,ULONG,PUNICODE_STRING,PACTCTX_SECTION_KEYED_DATA); +static BOOLEAN (NTAPI *pRtlCreateUnicodeStringFromAsciiz)(PUNICODE_STRING, PCSZ); +static VOID (NTAPI *pRtlFreeUnicodeString)(PUNICODE_STRING); + static const char* strw(LPCWSTR x) { static char buffer[1024]; @@ -2048,6 +2054,140 @@ static void test_app_manifest(void) } } +static HANDLE create_manifest(const char *filename, const char *data, int line) +{ + HANDLE handle; + create_manifest_file(filename, data, -1, NULL, NULL); + + handle = test_create(filename); + ok_(__FILE__, line)(handle != INVALID_HANDLE_VALUE, + "handle == INVALID_HANDLE_VALUE, error %u\n", GetLastError()); + + DeleteFileA(filename); + return handle; +} + +static void kernel32_find(ULONG section, const char *string_to_find, BOOL should_find, BOOL todo, int line) +{ + UNICODE_STRING string_to_findW; + ACTCTX_SECTION_KEYED_DATA data; + BOOL ret; + DWORD err; + + pRtlCreateUnicodeStringFromAsciiz(&string_to_findW, string_to_find); + + memset(&data, 0xfe, sizeof(data)); + data.cbSize = sizeof(data); + + SetLastError(0); + ret = pFindActCtxSectionStringA(0, NULL, section, string_to_find, &data); + err = GetLastError(); + ok_(__FILE__, line)(ret == should_find, + "FindActCtxSectionStringA: expected ret = %u, got %u\n", should_find, ret); + if (todo) + todo_wine + ok_(__FILE__, line)(err == (should_find ? ERROR_SUCCESS : ERROR_SXS_KEY_NOT_FOUND), + "FindActCtxSectionStringA: unexpected error %u\n", err); + else + ok_(__FILE__, line)(err == (should_find ? ERROR_SUCCESS : ERROR_SXS_KEY_NOT_FOUND), + "FindActCtxSectionStringA: unexpected error %u\n", err); + + memset(&data, 0xfe, sizeof(data)); + data.cbSize = sizeof(data); + + SetLastError(0); + ret = pFindActCtxSectionStringW(0, NULL, section, string_to_findW.Buffer, &data); + err = GetLastError(); + ok_(__FILE__, line)(ret == should_find, + "FindActCtxSectionStringW: expected ret = %u, got %u\n", should_find, ret); + if (todo) + todo_wine + ok_(__FILE__, line)(err == (should_find ? ERROR_SUCCESS : ERROR_SXS_KEY_NOT_FOUND), + "FindActCtxSectionStringW: unexpected error %u\n", err); + else + ok_(__FILE__, line)(err == (should_find ? ERROR_SUCCESS : ERROR_SXS_KEY_NOT_FOUND), + "FindActCtxSectionStringW: unexpected error %u\n", err); + + SetLastError(0); + ret = pFindActCtxSectionStringA(0, NULL, section, string_to_find, NULL); + err = GetLastError(); + ok_(__FILE__, line)(!ret, + "FindActCtxSectionStringA: expected failure, got %u\n", ret); + ok_(__FILE__, line)(err == ERROR_INVALID_PARAMETER, + "FindActCtxSectionStringA: unexpected error %u\n", err); + + SetLastError(0); + ret = pFindActCtxSectionStringW(0, NULL, section, string_to_findW.Buffer, NULL); + err = GetLastError(); + ok_(__FILE__, line)(!ret, + "FindActCtxSectionStringW: expected failure, got %u\n", ret); + ok_(__FILE__, line)(err == ERROR_INVALID_PARAMETER, + "FindActCtxSectionStringW: unexpected error %u\n", err); + + pRtlFreeUnicodeString(&string_to_findW); +} + +static void ntdll_find(ULONG section, const char *string_to_find, BOOL should_find, BOOL todo, int line) +{ + UNICODE_STRING string_to_findW; + ACTCTX_SECTION_KEYED_DATA data; + NTSTATUS ret; + + pRtlCreateUnicodeStringFromAsciiz(&string_to_findW, string_to_find); + + memset(&data, 0xfe, sizeof(data)); + data.cbSize = sizeof(data); + + ret = pRtlFindActivationContextSectionString(0, NULL, section, &string_to_findW, &data); + if (todo) + todo_wine + ok_(__FILE__, line)(ret == (should_find ? STATUS_SUCCESS : STATUS_SXS_KEY_NOT_FOUND), + "RtlFindActivationContextSectionString: unexpected status 0x%x\n", ret); + else + ok_(__FILE__, line)(ret == (should_find ? STATUS_SUCCESS : STATUS_SXS_KEY_NOT_FOUND), + "RtlFindActivationContextSectionString: unexpected status 0x%x\n", ret); + + ret = pRtlFindActivationContextSectionString(0, NULL, section, &string_to_findW, NULL); + todo_wine + ok_(__FILE__, line)(ret == (should_find ? STATUS_SUCCESS : STATUS_SXS_KEY_NOT_FOUND), + "RtlFindActivationContextSectionString: unexpected status 0x%x\n", ret); + + pRtlFreeUnicodeString(&string_to_findW); +} + +static void test_findsectionstring(void) +{ + HANDLE handle; + BOOL ret; + ULONG_PTR cookie; + + handle = create_manifest("test.manifest", testdep_manifest3, __LINE__); + ret = pActivateActCtx(handle, &cookie); + ok(ret, "ActivateActCtx failed: %u\n", GetLastError()); + + /* first we show the parameter validation from kernel32 */ + kernel32_find(ACTIVATION_CONTEXT_SECTION_ASSEMBLY_INFORMATION, "testdep", FALSE, TRUE, __LINE__); + kernel32_find(ACTIVATION_CONTEXT_SECTION_DLL_REDIRECTION, "testlib.dll", TRUE, FALSE, __LINE__); + kernel32_find(ACTIVATION_CONTEXT_SECTION_DLL_REDIRECTION, "testlib2.dll", TRUE, FALSE, __LINE__); + kernel32_find(ACTIVATION_CONTEXT_SECTION_DLL_REDIRECTION, "testlib3.dll", FALSE, FALSE, __LINE__); + kernel32_find(ACTIVATION_CONTEXT_SECTION_WINDOW_CLASS_REDIRECTION, "wndClass", TRUE, FALSE, __LINE__); + kernel32_find(ACTIVATION_CONTEXT_SECTION_WINDOW_CLASS_REDIRECTION, "wndClass2", TRUE, FALSE, __LINE__); + kernel32_find(ACTIVATION_CONTEXT_SECTION_WINDOW_CLASS_REDIRECTION, "wndClass3", FALSE, FALSE, __LINE__); + + /* then we show that ntdll plays by different rules */ + ntdll_find(ACTIVATION_CONTEXT_SECTION_ASSEMBLY_INFORMATION, "testdep", FALSE, TRUE, __LINE__); + ntdll_find(ACTIVATION_CONTEXT_SECTION_DLL_REDIRECTION, "testlib.dll", TRUE, FALSE, __LINE__); + ntdll_find(ACTIVATION_CONTEXT_SECTION_DLL_REDIRECTION, "testlib2.dll", TRUE, FALSE, __LINE__); + ntdll_find(ACTIVATION_CONTEXT_SECTION_DLL_REDIRECTION, "testlib3.dll", FALSE, FALSE, __LINE__); + ntdll_find(ACTIVATION_CONTEXT_SECTION_WINDOW_CLASS_REDIRECTION, "wndClass", TRUE, FALSE, __LINE__); + ntdll_find(ACTIVATION_CONTEXT_SECTION_WINDOW_CLASS_REDIRECTION, "wndClass2", TRUE, FALSE, __LINE__); + ntdll_find(ACTIVATION_CONTEXT_SECTION_WINDOW_CLASS_REDIRECTION, "wndClass3", FALSE, FALSE, __LINE__); + + ret = pDeactivateActCtx(0, cookie); + ok(ret, "DeactivateActCtx failed: %u\n", GetLastError()); + pReleaseActCtx(handle); +} + static void run_child_process(void) { char cmdline[MAX_PATH]; @@ -2263,9 +2403,9 @@ todo_wine static BOOL init_funcs(void) { - HMODULE hKernel32 = GetModuleHandleA("kernel32.dll"); + HMODULE hLibrary = GetModuleHandleA("kernel32.dll"); -#define X(f) if (!(p##f = (void*)GetProcAddress(hKernel32, #f))) return FALSE; +#define X(f) if (!(p##f = (void*)GetProcAddress(hLibrary, #f))) return FALSE; X(ActivateActCtx); X(CreateActCtxA); X(CreateActCtxW); @@ -2277,6 +2417,11 @@ static BOOL init_funcs(void) X(QueryActCtxW); X(ReleaseActCtx); X(FindActCtxSectionGuid); + + hLibrary = GetModuleHandleA("ntdll.dll"); + X(RtlFindActivationContextSectionString); + X(RtlCreateUnicodeStringFromAsciiz); + X(RtlFreeUnicodeString); #undef X return TRUE; @@ -2303,5 +2448,6 @@ START_TEST(actctx) test_actctx(); test_CreateActCtx(); + test_findsectionstring(); run_child_process(); }

1 0

Sebastian Lackner : user32/tests: Add tests for removing already seen messages from the queue.
by Alexandre Julliard 17 Mar '15

17 Mar '15

Module: wine Branch: master Commit: 1acf20779f93603907ff2c816509a30f7e1d34d5 URL: http://source.winehq.org/git/wine.git/?a=commit;h=1acf20779f93603907ff2c816… Author: Sebastian Lackner <sebastian(a)fds-team.de> Date: Tue Mar 17 04:26:33 2015 +0100 user32/tests: Add tests for removing already seen messages from the queue. --- dlls/user32/tests/msg.c | 119 ++++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 119 insertions(+) diff --git a/dlls/user32/tests/msg.c b/dlls/user32/tests/msg.c index f1236cf..5f10a89 100644 --- a/dlls/user32/tests/msg.c +++ b/dlls/user32/tests/msg.c @@ -10440,6 +10440,124 @@ done: flush_events(); } +static void test_PeekMessage3(void) +{ + HWND hwnd; + BOOL ret; + MSG msg; + + hwnd = CreateWindowA("TestWindowClass", "PeekMessage3", WS_OVERLAPPEDWINDOW, + 10, 10, 800, 800, NULL, NULL, NULL, NULL); + ok(hwnd != NULL, "expected hwnd != NULL\n"); + flush_events(); + + /* GetMessage() and PeekMessage(..., PM_REMOVE) should prefer messages which + * were already seen. */ + + SetTimer(hwnd, 1, 0, NULL); + while (!PeekMessageA(&msg, NULL, 0, 0, PM_NOREMOVE)); + ok(msg.message == WM_TIMER, "msg.message = %u instead of WM_TIMER\n", msg.message); + PostMessageA(hwnd, WM_USER, 0, 0); + ret = PeekMessageA(&msg, NULL, 0, 0, PM_NOREMOVE); + todo_wine + ok(ret && msg.message == WM_TIMER, "msg.message = %u instead of WM_TIMER\n", msg.message); + ret = GetMessageA(&msg, NULL, 0, 0); + todo_wine + ok(ret && msg.message == WM_TIMER, "msg.message = %u instead of WM_TIMER\n", msg.message); + ret = GetMessageA(&msg, NULL, 0, 0); + todo_wine + ok(ret && msg.message == WM_USER, "msg.message = %u instead of WM_USER\n", msg.message); + ret = PeekMessageA(&msg, NULL, 0, 0, 0); + ok(!ret, "expected PeekMessage to return FALSE, got %u\n", ret); + + SetTimer(hwnd, 1, 0, NULL); + while (!PeekMessageA(&msg, NULL, 0, 0, PM_NOREMOVE)); + ok(msg.message == WM_TIMER, "msg.message = %u instead of WM_TIMER\n", msg.message); + PostMessageA(hwnd, WM_USER, 0, 0); + ret = PeekMessageA(&msg, NULL, 0, 0, PM_REMOVE); + todo_wine + ok(ret && msg.message == WM_TIMER, "msg.message = %u instead of WM_TIMER\n", msg.message); + ret = PeekMessageA(&msg, NULL, 0, 0, PM_REMOVE); + todo_wine + ok(ret && msg.message == WM_USER, "msg.message = %u instead of WM_USER\n", msg.message); + ret = PeekMessageA(&msg, NULL, 0, 0, 0); + ok(!ret, "expected PeekMessage to return FALSE, got %u\n", ret); + + /* It doesn't matter if a message range is specified or not. */ + + SetTimer(hwnd, 1, 0, NULL); + while (!PeekMessageA(&msg, NULL, WM_TIMER, WM_TIMER, PM_NOREMOVE)); + ok(msg.message == WM_TIMER, "msg.message = %u instead of WM_TIMER\n", msg.message); + PostMessageA(hwnd, WM_USER, 0, 0); + ret = GetMessageA(&msg, NULL, 0, 0); + todo_wine + ok(ret && msg.message == WM_TIMER, "msg.message = %u instead of WM_TIMER\n", msg.message); + ret = GetMessageA(&msg, NULL, 0, 0); + todo_wine + ok(ret && msg.message == WM_USER, "msg.message = %u instead of WM_USER\n", msg.message); + ret = PeekMessageA(&msg, NULL, 0, 0, 0); + ok(!ret, "expected PeekMessage to return FALSE, got %u\n", ret); + + /* But not if the post messages were added before the PeekMessage() call. */ + + PostMessageA(hwnd, WM_USER, 0, 0); + SetTimer(hwnd, 1, 0, NULL); + while (!PeekMessageA(&msg, NULL, WM_TIMER, WM_TIMER, PM_NOREMOVE)); + ok(msg.message == WM_TIMER, "msg.message = %u instead of WM_TIMER\n", msg.message); + ret = GetMessageA(&msg, NULL, 0, 0); + ok(ret && msg.message == WM_USER, "msg.message = %u instead of WM_USER\n", msg.message); + ret = GetMessageA(&msg, NULL, 0, 0); + ok(ret && msg.message == WM_TIMER, "msg.message = %u instead of WM_TIMER\n", msg.message); + ret = PeekMessageA(&msg, NULL, 0, 0, 0); + ok(!ret, "expected PeekMessage to return FALSE, got %u\n", ret); + + /* More complicated test with multiple messages. */ + + PostMessageA(hwnd, WM_USER, 0, 0); + SetTimer(hwnd, 1, 0, NULL); + while (!PeekMessageA(&msg, NULL, WM_TIMER, WM_TIMER, PM_NOREMOVE)); + ok(msg.message == WM_TIMER, "msg.message = %u instead of WM_TIMER\n", msg.message); + PostMessageA(hwnd, WM_USER + 1, 0, 0); + ret = GetMessageA(&msg, NULL, 0, 0); + ok(ret && msg.message == WM_USER, "msg.message = %u instead of WM_USER\n", msg.message); + ret = GetMessageA(&msg, NULL, 0, 0); + todo_wine + ok(ret && msg.message == WM_TIMER, "msg.message = %u instead of WM_TIMER\n", msg.message); + ret = GetMessageA(&msg, NULL, 0, 0); + todo_wine + ok(ret && msg.message == WM_USER + 1, "msg.message = %u instead of WM_USER + 1\n", msg.message); + ret = PeekMessageA(&msg, NULL, 0, 0, 0); + ok(!ret, "expected PeekMessage to return FALSE, got %u\n", ret); + + /* Also works for posted messages, but the situation is a bit different, + * because both messages are in the same queue. */ + + PostMessageA(hwnd, WM_TIMER, 0, 0); + while (!PeekMessageA(&msg, NULL, WM_TIMER, WM_TIMER, PM_NOREMOVE)); + ok(msg.message == WM_TIMER, "msg.message = %u instead of WM_TIMER\n", msg.message); + PostMessageA(hwnd, WM_USER, 0, 0); + ret = GetMessageA(&msg, NULL, 0, 0); + ok(ret && msg.message == WM_TIMER, "msg.message = %u instead of WM_TIMER\n", msg.message); + ret = GetMessageA(&msg, NULL, 0, 0); + ok(ret && msg.message == WM_USER, "msg.message = %u instead of WM_USER\n", msg.message); + ret = PeekMessageA(&msg, NULL, 0, 0, 0); + ok(!ret, "expected PeekMessage to return FALSE, got %u\n", ret); + + PostMessageA(hwnd, WM_USER, 0, 0); + PostMessageA(hwnd, WM_TIMER, 0, 0); + while (!PeekMessageA(&msg, NULL, WM_TIMER, WM_TIMER, PM_NOREMOVE)); + ok(msg.message == WM_TIMER, "msg.message = %u instead of WM_TIMER\n", msg.message); + ret = GetMessageA(&msg, NULL, 0, 0); + ok(ret && msg.message == WM_USER, "msg.message = %u instead of WM_USER\n", msg.message); + ret = GetMessageA(&msg, NULL, 0, 0); + ok(ret && msg.message == WM_TIMER, "msg.message = %u instead of WM_TIMER\n", msg.message); + ret = PeekMessageA(&msg, NULL, 0, 0, 0); + ok(!ret, "expected PeekMessage to return FALSE, got %u\n", ret); + + DestroyWindow(hwnd); + flush_events(); +} + static INT_PTR CALLBACK wm_quit_dlg_proc(HWND hwnd, UINT message, WPARAM wp, LPARAM lp) { struct recvd_message msg; @@ -14563,6 +14681,7 @@ START_TEST(msg) test_ShowWindow(); test_PeekMessage(); test_PeekMessage2(); + test_PeekMessage3(); test_WaitForInputIdle( test_argv[0] ); test_scrollwindowex(); test_messages();

1 0

Sebastian Lackner : kernel32: Fix leak of dynamic_buffer in QueryFullProcessImageNameW (Coverity).
by Alexandre Julliard 17 Mar '15

17 Mar '15

Module: wine Branch: master Commit: 5bab75166c2beeb2d3d3aead3e508c98c73c26ed URL: http://source.winehq.org/git/wine.git/?a=commit;h=5bab75166c2beeb2d3d3aead3… Author: Sebastian Lackner <sebastian(a)fds-team.de> Date: Tue Mar 17 06:34:03 2015 +0100 kernel32: Fix leak of dynamic_buffer in QueryFullProcessImageNameW (Coverity). --- dlls/kernel32/process.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/dlls/kernel32/process.c b/dlls/kernel32/process.c index 199b2f3..2c8074b 100644 --- a/dlls/kernel32/process.c +++ b/dlls/kernel32/process.c @@ -3568,8 +3568,8 @@ BOOL WINAPI QueryFullProcessImageNameW(HANDLE hProcess, DWORD dwFlags, LPWSTR lp ntlen = devlen + (result->Length/sizeof(WCHAR) - 2); if (ntlen + 1 > *pdwSize) { - SetLastError(ERROR_INSUFFICIENT_BUFFER); - return FALSE; + status = STATUS_BUFFER_TOO_SMALL; + goto cleanup; } *pdwSize = ntlen;

1 0

Sebastian Lackner : kernel32: Fix file handle leak in exec_process ( Coverity).
by Alexandre Julliard 17 Mar '15

17 Mar '15

Module: wine Branch: master Commit: d48e3a0bead8d5bcc0ea348f392e5dbca60320e7 URL: http://source.winehq.org/git/wine.git/?a=commit;h=d48e3a0bead8d5bcc0ea348f3… Author: Sebastian Lackner <sebastian(a)fds-team.de> Date: Tue Mar 17 06:23:57 2015 +0100 kernel32: Fix file handle leak in exec_process (Coverity). --- dlls/kernel32/process.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/dlls/kernel32/process.c b/dlls/kernel32/process.c index b371e73..199b2f3 100644 --- a/dlls/kernel32/process.c +++ b/dlls/kernel32/process.c @@ -2493,7 +2493,12 @@ static void exec_process( LPCWSTR name ) /* Determine executable type */ - if (binary_info.flags & BINARY_FLAG_DLL) return; + if (binary_info.flags & BINARY_FLAG_DLL) + { + CloseHandle( hFile ); + return; + } + switch (binary_info.type) { case BINARY_PE:

1 0

Sebastian Lackner : user32: Fix invalid memory access and leak if alloc_user_handle fails (Coverity).
by Alexandre Julliard 17 Mar '15

17 Mar '15

Module: wine Branch: master Commit: a9ff334976e78808a36659df24d8b3e6a38f3b26 URL: http://source.winehq.org/git/wine.git/?a=commit;h=a9ff334976e78808a36659df2… Author: Sebastian Lackner <sebastian(a)fds-team.de> Date: Tue Mar 17 06:14:45 2015 +0100 user32: Fix invalid memory access and leak if alloc_user_handle fails (Coverity). --- dlls/user32/cursoricon.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/dlls/user32/cursoricon.c b/dlls/user32/cursoricon.c index 8504bdc..f7b6bca 100644 --- a/dlls/user32/cursoricon.c +++ b/dlls/user32/cursoricon.c @@ -123,12 +123,14 @@ static HICON alloc_icon_handle( BOOL is_ani, UINT num_steps ) { struct cursoricon_object *obj; int icon_size; + HICON handle; if (is_ani) icon_size = FIELD_OFFSET( struct animated_cursoricon_object, frames[num_steps] ); else icon_size = sizeof( struct static_cursoricon_object ); obj = HeapAlloc( GetProcessHeap(), HEAP_ZERO_MEMORY, icon_size ); + if (!obj) return NULL; obj->delay = 0; obj->is_ani = is_ani; @@ -139,7 +141,10 @@ static HICON alloc_icon_handle( BOOL is_ani, UINT num_steps ) ani_icon_data->num_steps = num_steps; ani_icon_data->num_frames = num_steps; /* changed later for some animated cursors */ } - return alloc_user_handle( &obj->obj, USER_ICON ); + + if (!(handle = alloc_user_handle( &obj->obj, USER_ICON ))) + HeapFree( GetProcessHeap(), 0, obj ); + return handle; } static struct cursoricon_object *get_icon_ptr( HICON handle )

1 0

Sebastian Lackner : ntdll: Move all structs and definitions to the beginning in threadpool.c.
by Alexandre Julliard 17 Mar '15

17 Mar '15

Module: wine Branch: master Commit: 41b24f216843653709964bdac19f084c0dcf5a04 URL: http://source.winehq.org/git/wine.git/?a=commit;h=41b24f216843653709964bdac… Author: Sebastian Lackner <sebastian(a)fds-team.de> Date: Wed Mar 11 03:24:59 2015 +0100 ntdll: Move all structs and definitions to the beginning in threadpool.c. --- dlls/ntdll/threadpool.c | 89 ++++++++++++++++++++++++------------------------- 1 file changed, 44 insertions(+), 45 deletions(-) diff --git a/dlls/ntdll/threadpool.c b/dlls/ntdll/threadpool.c index 7f2ed65..513c13d 100644 --- a/dlls/ntdll/threadpool.c +++ b/dlls/ntdll/threadpool.c @@ -37,7 +37,9 @@ WINE_DEFAULT_DEBUG_CHANNEL(threadpool); -#define WORKER_TIMEOUT 30000 /* 30 seconds */ +#define OLD_WORKER_TIMEOUT 30000 /* 30 seconds */ +#define EXPIRE_NEVER (~(ULONGLONG)0) +#define TIMER_QUEUE_MAGIC 0x516d6954 /* TimQ */ static RTL_CRITICAL_SECTION_DEBUG critsect_debug; static RTL_CRITICAL_SECTION_DEBUG critsect_compl_debug; @@ -87,6 +89,44 @@ struct work_item PVOID context; }; +struct wait_work_item +{ + HANDLE Object; + HANDLE CancelEvent; + WAITORTIMERCALLBACK Callback; + PVOID Context; + ULONG Milliseconds; + ULONG Flags; + HANDLE CompletionEvent; + LONG DeleteCount; + BOOLEAN CallbackInProgress; +}; + +struct timer_queue; +struct queue_timer +{ + struct timer_queue *q; + struct list entry; + ULONG runcount; /* number of callbacks pending execution */ + RTL_WAITORTIMERCALLBACKFUNC callback; + PVOID param; + DWORD period; + ULONG flags; + ULONGLONG expire; + BOOL destroy; /* timer should be deleted; once set, never unset */ + HANDLE event; /* removal event */ +}; + +struct timer_queue +{ + DWORD magic; + RTL_CRITICAL_SECTION cs; + struct list timers; /* sorted by expiration time */ + BOOL quit; /* queue should be deleted; once set, never unset */ + HANDLE event; + HANDLE thread; +}; + static inline LONG interlocked_inc( PLONG dest ) { return interlocked_xchg_add( dest, 1 ) + 1; @@ -102,7 +142,7 @@ static void WINAPI worker_thread_proc(void * param) struct list *item; struct work_item *work_item_ptr, work_item; LARGE_INTEGER timeout; - timeout.QuadPart = -(WORKER_TIMEOUT * (ULONGLONG)10000); + timeout.QuadPart = -(OLD_WORKER_TIMEOUT * (ULONGLONG)10000); RtlEnterCriticalSection( &old_threadpool.threadpool_cs ); old_threadpool.num_workers++; @@ -311,19 +351,6 @@ static inline PLARGE_INTEGER get_nt_timeout( PLARGE_INTEGER pTime, ULONG timeout return pTime; } -struct wait_work_item -{ - HANDLE Object; - HANDLE CancelEvent; - WAITORTIMERCALLBACK Callback; - PVOID Context; - ULONG Milliseconds; - ULONG Flags; - HANDLE CompletionEvent; - LONG DeleteCount; - BOOLEAN CallbackInProgress; -}; - static void delete_wait_work_item(struct wait_work_item *wait_work_item) { NtClose( wait_work_item->CancelEvent ); @@ -526,34 +553,6 @@ NTSTATUS WINAPI RtlDeregisterWait(HANDLE WaitHandle) /************************** Timer Queue Impl **************************/ -struct timer_queue; -struct queue_timer -{ - struct timer_queue *q; - struct list entry; - ULONG runcount; /* number of callbacks pending execution */ - RTL_WAITORTIMERCALLBACKFUNC callback; - PVOID param; - DWORD period; - ULONG flags; - ULONGLONG expire; - BOOL destroy; /* timer should be deleted; once set, never unset */ - HANDLE event; /* removal event */ -}; - -struct timer_queue -{ - DWORD magic; - RTL_CRITICAL_SECTION cs; - struct list timers; /* sorted by expiration time */ - BOOL quit; /* queue should be deleted; once set, never unset */ - HANDLE event; - HANDLE thread; -}; - -#define EXPIRE_NEVER (~(ULONGLONG) 0) -#define TIMER_QUEUE_MAGIC 0x516d6954 /* TimQ */ - static void queue_remove_timer(struct queue_timer *t) { /* We MUST hold the queue cs while calling this function. This ensures @@ -861,10 +860,10 @@ NTSTATUS WINAPI RtlDeleteTimerQueueEx(HANDLE TimerQueue, HANDLE CompletionEvent) return status; } -static struct timer_queue *default_timer_queue; - static struct timer_queue *get_timer_queue(HANDLE TimerQueue) { + static struct timer_queue *default_timer_queue; + if (TimerQueue) return TimerQueue; else

1 0

Alexandre Julliard : msvcp60: Share locale functions implementation with msvcp90.
by Alexandre Julliard 17 Mar '15

17 Mar '15

Module: wine Branch: master Commit: 1d965de1bcf2a7958041f2791fcf293b6d39a752 URL: http://source.winehq.org/git/wine.git/?a=commit;h=1d965de1bcf2a7958041f2791… Author: Alexandre Julliard <julliard(a)winehq.org> Date: Tue Mar 17 14:23:38 2015 +0900 msvcp60: Share locale functions implementation with msvcp90. --- dlls/msvcp60/Makefile.in | 1 - dlls/msvcp60/locale.c | 8858 --------------------------------------------- dlls/msvcp60/main.c | 2 + dlls/msvcp60/msvcp60.spec | 78 +- dlls/msvcp90/locale.c | 306 +- 5 files changed, 307 insertions(+), 8938 deletions(-) Diff: http://source.winehq.org/git/wine.git/?a=commitdiff;h=1d965de1bcf2a7958041f…

1 0

← Newer
1
...
33
34
35
36
37
38
39
...
78
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-commits March 2015