wine-commits March 2015

wine-commits@winehq.org

2 participants
775 discussions

Francois Gouget : services: Fix compilation on systems that don' t support nameless unions.
by Alexandre Julliard 02 Mar '15

02 Mar '15

Module: wine Branch: master Commit: 123cfee93c5dcc5f286f73f6d4ebe162c93178e9 URL: http://source.winehq.org/git/wine.git/?a=commit;h=123cfee93c5dcc5f286f73f6d… Author: Francois Gouget <fgouget(a)free.fr> Date: Sat Feb 28 17:30:54 2015 +0100 services: Fix compilation on systems that don't support nameless unions. --- programs/services/rpc.c | 15 ++++++++------- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/programs/services/rpc.c b/programs/services/rpc.c index 9ecc09c..a3d5a24 100644 --- a/programs/services/rpc.c +++ b/programs/services/rpc.c @@ -19,6 +19,7 @@ */ #define WIN32_LEAN_AND_MEAN +#define NONAMELESSUNION #include <stdarg.h> #include <windows.h> @@ -797,9 +798,9 @@ DWORD __cdecl svcctl_ChangeServiceConfig2W( SC_RPC_HANDLE hService, SC_RPC_CONFI { WCHAR *descr = NULL; - if (config.descr->lpDescription[0]) + if (config.u.descr->lpDescription[0]) { - if (!(descr = strdupW( config.descr->lpDescription ))) + if (!(descr = strdupW( config.u.descr->lpDescription ))) return ERROR_NOT_ENOUGH_MEMORY; } @@ -813,15 +814,15 @@ DWORD __cdecl svcctl_ChangeServiceConfig2W( SC_RPC_HANDLE hService, SC_RPC_CONFI break; case SERVICE_CONFIG_FAILURE_ACTIONS: WINE_FIXME( "SERVICE_CONFIG_FAILURE_ACTIONS not implemented: period %u msg %s cmd %s\n", - config.actions->dwResetPeriod, - wine_dbgstr_w(config.actions->lpRebootMsg), - wine_dbgstr_w(config.actions->lpCommand) ); + config.u.actions->dwResetPeriod, + wine_dbgstr_w(config.u.actions->lpRebootMsg), + wine_dbgstr_w(config.u.actions->lpCommand) ); break; case SERVICE_CONFIG_PRESHUTDOWN_INFO: WINE_TRACE( "changing service %p preshutdown timeout to %d\n", - service, config.preshutdown->dwPreshutdownTimeout ); + service, config.u.preshutdown->dwPreshutdownTimeout ); service_lock_exclusive( service->service_entry ); - service->service_entry->preshutdown_timeout = config.preshutdown->dwPreshutdownTimeout; + service->service_entry->preshutdown_timeout = config.u.preshutdown->dwPreshutdownTimeout; save_service_config( service->service_entry ); service_unlock( service->service_entry ); break;

1 0

Francois Gouget : include/ddk: Make ntddk.h compatible with systems that don't support nameless unions.
by Alexandre Julliard 02 Mar '15

02 Mar '15

Module: wine Branch: master Commit: fa01fdc3219974f97a642a10889baf33fdba2ec6 URL: http://source.winehq.org/git/wine.git/?a=commit;h=fa01fdc3219974f97a642a108… Author: Francois Gouget <fgouget(a)free.fr> Date: Sat Feb 28 17:30:51 2015 +0100 include/ddk: Make ntddk.h compatible with systems that don't support nameless unions. --- include/ddk/ntddk.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/include/ddk/ntddk.h b/include/ddk/ntddk.h index e9c3fba..bccfd39 100644 --- a/include/ddk/ntddk.h +++ b/include/ddk/ntddk.h @@ -119,8 +119,8 @@ typedef struct _IMAGE_INFO ULONG ImageMappedToAllPids : 1; ULONG ExtendedInfoPresent : 1; ULONG Reserved : 21; - }; - }; + } DUMMYSTRUCTNAME; + } DUMMYUNIONNAME; PVOID ImageBase; ULONG ImageSelector; SIZE_T ImageSize;

1 0

Francois Gouget : dbghelp: Fix compilation on systems that don' t support nameless unions.
by Alexandre Julliard 02 Mar '15

02 Mar '15

Module: wine Branch: master Commit: 11f985541a68239556adc51d227a7f5f662c0637 URL: http://source.winehq.org/git/wine.git/?a=commit;h=11f985541a68239556adc51d2… Author: Francois Gouget <fgouget(a)free.fr> Date: Sat Feb 28 17:30:04 2015 +0100 dbghelp: Fix compilation on systems that don't support nameless unions. --- dlls/dbghelp/cpu_x86_64.c | 50 +++++++++++++++++++++++------------------------ 1 file changed, 25 insertions(+), 25 deletions(-) diff --git a/dlls/dbghelp/cpu_x86_64.c b/dlls/dbghelp/cpu_x86_64.c index 94f561c..a5aa03f 100644 --- a/dlls/dbghelp/cpu_x86_64.c +++ b/dlls/dbghelp/cpu_x86_64.c @@ -53,7 +53,7 @@ typedef union _UNWIND_CODE BYTE CodeOffset; BYTE UnwindOp : 4; BYTE OpInfo : 4; - }; + } u; USHORT FrameOffset; } UNWIND_CODE, *PUNWIND_CODE; @@ -158,14 +158,14 @@ static void dump_unwind_info(struct cpu_stack_walk* csw, ULONG64 base, RUNTIME_F for (i = 0; i < info->CountOfCodes; i++) { - TRACE(" 0x%x: ", info->UnwindCode[i].CodeOffset); - switch (info->UnwindCode[i].UnwindOp) + TRACE(" 0x%x: ", info->UnwindCode[i].u.CodeOffset); + switch (info->UnwindCode[i].u.UnwindOp) { case UWOP_PUSH_NONVOL: - TRACE("pushq %%%s\n", reg_names[info->UnwindCode[i].OpInfo]); + TRACE("pushq %%%s\n", reg_names[info->UnwindCode[i].u.OpInfo]); break; case UWOP_ALLOC_LARGE: - if (info->UnwindCode[i].OpInfo) + if (info->UnwindCode[i].u.OpInfo) { count = *(DWORD*)&info->UnwindCode[i+1]; i += 2; @@ -178,7 +178,7 @@ static void dump_unwind_info(struct cpu_stack_walk* csw, ULONG64 base, RUNTIME_F TRACE("subq $0x%x,%%rsp\n", count); break; case UWOP_ALLOC_SMALL: - count = (info->UnwindCode[i].OpInfo + 1) * 8; + count = (info->UnwindCode[i].u.OpInfo + 1) * 8; TRACE("subq $0x%x,%%rsp\n", count); break; case UWOP_SET_FPREG: @@ -187,29 +187,29 @@ static void dump_unwind_info(struct cpu_stack_walk* csw, ULONG64 base, RUNTIME_F break; case UWOP_SAVE_NONVOL: count = *(USHORT*)&info->UnwindCode[i+1] * 8; - TRACE("movq %%%s,0x%x(%%rsp)\n", reg_names[info->UnwindCode[i].OpInfo], count); + TRACE("movq %%%s,0x%x(%%rsp)\n", reg_names[info->UnwindCode[i].u.OpInfo], count); i++; break; case UWOP_SAVE_NONVOL_FAR: count = *(DWORD*)&info->UnwindCode[i+1]; - TRACE("movq %%%s,0x%x(%%rsp)\n", reg_names[info->UnwindCode[i].OpInfo], count); + TRACE("movq %%%s,0x%x(%%rsp)\n", reg_names[info->UnwindCode[i].u.OpInfo], count); i += 2; break; case UWOP_SAVE_XMM128: count = *(USHORT*)&info->UnwindCode[i+1] * 16; - TRACE("movaps %%xmm%u,0x%x(%%rsp)\n", info->UnwindCode[i].OpInfo, count); + TRACE("movaps %%xmm%u,0x%x(%%rsp)\n", info->UnwindCode[i].u.OpInfo, count); i++; break; case UWOP_SAVE_XMM128_FAR: count = *(DWORD*)&info->UnwindCode[i+1]; - TRACE("movaps %%xmm%u,0x%x(%%rsp)\n", info->UnwindCode[i].OpInfo, count); + TRACE("movaps %%xmm%u,0x%x(%%rsp)\n", info->UnwindCode[i].u.OpInfo, count); i += 2; break; case UWOP_PUSH_MACHFRAME: - TRACE("PUSH_MACHFRAME %u\n", info->UnwindCode[i].OpInfo); + TRACE("PUSH_MACHFRAME %u\n", info->UnwindCode[i].u.OpInfo); break; default: - FIXME("unknown code %u\n", info->UnwindCode[i].UnwindOp); + FIXME("unknown code %u\n", info->UnwindCode[i].u.UnwindOp); break; } } @@ -261,10 +261,10 @@ static void set_float_reg(CONTEXT *context, int reg, M128A val) static int get_opcode_size(UNWIND_CODE op) { - switch (op.UnwindOp) + switch (op.u.UnwindOp) { case UWOP_ALLOC_LARGE: - return 2 + (op.OpInfo != 0); + return 2 + (op.u.OpInfo != 0); case UWOP_SAVE_NONVOL: case UWOP_SAVE_XMM128: return 2; @@ -515,21 +515,21 @@ static BOOL interpret_function_table_entry(struct cpu_stack_walk* csw, for (i = 0; i < info->CountOfCodes; i += get_opcode_size(info->UnwindCode[i])) { - if (prolog_offset < info->UnwindCode[i].CodeOffset) continue; /* skip it */ + if (prolog_offset < info->UnwindCode[i].u.CodeOffset) continue; /* skip it */ - switch (info->UnwindCode[i].UnwindOp) + switch (info->UnwindCode[i].u.UnwindOp) { case UWOP_PUSH_NONVOL: /* pushq %reg */ if (!sw_read_mem(csw, context->Rsp, &value, sizeof(DWORD64))) return FALSE; - set_int_reg(context, info->UnwindCode[i].OpInfo, value); + set_int_reg(context, info->UnwindCode[i].u.OpInfo, value); context->Rsp += sizeof(ULONG64); break; case UWOP_ALLOC_LARGE: /* subq $nn,%rsp */ - if (info->UnwindCode[i].OpInfo) context->Rsp += *(DWORD*)&info->UnwindCode[i+1]; + if (info->UnwindCode[i].u.OpInfo) context->Rsp += *(DWORD*)&info->UnwindCode[i+1]; else context->Rsp += *(USHORT*)&info->UnwindCode[i+1] * 8; break; case UWOP_ALLOC_SMALL: /* subq $n,%rsp */ - context->Rsp += (info->UnwindCode[i].OpInfo + 1) * 8; + context->Rsp += (info->UnwindCode[i].u.OpInfo + 1) * 8; break; case UWOP_SET_FPREG: /* leaq nn(%rsp),%framereg */ context->Rsp = newframe; @@ -537,28 +537,28 @@ static BOOL interpret_function_table_entry(struct cpu_stack_walk* csw, case UWOP_SAVE_NONVOL: /* movq %reg,n(%rsp) */ off = newframe + *(USHORT*)&info->UnwindCode[i+1] * 8; if (!sw_read_mem(csw, off, &value, sizeof(DWORD64))) return FALSE; - set_int_reg(context, info->UnwindCode[i].OpInfo, value); + set_int_reg(context, info->UnwindCode[i].u.OpInfo, value); break; case UWOP_SAVE_NONVOL_FAR: /* movq %reg,nn(%rsp) */ off = newframe + *(DWORD*)&info->UnwindCode[i+1]; if (!sw_read_mem(csw, off, &value, sizeof(DWORD64))) return FALSE; - set_int_reg(context, info->UnwindCode[i].OpInfo, value); + set_int_reg(context, info->UnwindCode[i].u.OpInfo, value); break; case UWOP_SAVE_XMM128: /* movaps %xmmreg,n(%rsp) */ off = newframe + *(USHORT*)&info->UnwindCode[i+1] * 16; if (!sw_read_mem(csw, off, &floatvalue, sizeof(M128A))) return FALSE; - set_float_reg(context, info->UnwindCode[i].OpInfo, floatvalue); + set_float_reg(context, info->UnwindCode[i].u.OpInfo, floatvalue); break; case UWOP_SAVE_XMM128_FAR: /* movaps %xmmreg,nn(%rsp) */ off = newframe + *(DWORD*)&info->UnwindCode[i+1]; if (!sw_read_mem(csw, off, &floatvalue, sizeof(M128A))) return FALSE; - set_float_reg(context, info->UnwindCode[i].OpInfo, floatvalue); + set_float_reg(context, info->UnwindCode[i].u.OpInfo, floatvalue); break; case UWOP_PUSH_MACHFRAME: - FIXME("PUSH_MACHFRAME %u\n", info->UnwindCode[i].OpInfo); + FIXME("PUSH_MACHFRAME %u\n", info->UnwindCode[i].u.OpInfo); break; default: - FIXME("unknown code %u\n", info->UnwindCode[i].UnwindOp); + FIXME("unknown code %u\n", info->UnwindCode[i].u.UnwindOp); break; } }

1 0

Francois Gouget : advapi32: Fix compilation on systems that don' t support nameless unions.
by Alexandre Julliard 02 Mar '15

02 Mar '15

Module: wine Branch: master Commit: fbc59357644b7eb75d71e62698c206e884c13c54 URL: http://source.winehq.org/git/wine.git/?a=commit;h=fbc59357644b7eb75d71e6269… Author: Francois Gouget <fgouget(a)free.fr> Date: Sat Feb 28 11:24:54 2015 +0100 advapi32: Fix compilation on systems that don't support nameless unions. --- dlls/advapi32/service.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/dlls/advapi32/service.c b/dlls/advapi32/service.c index f9b370b..0eb0a47 100644 --- a/dlls/advapi32/service.c +++ b/dlls/advapi32/service.c @@ -28,6 +28,8 @@ #include <time.h> #include <assert.h> +#define NONAMELESSUNION + #include "ntstatus.h" #define WIN32_NO_STATUS #include "windef.h" @@ -2214,7 +2216,7 @@ BOOL WINAPI ChangeServiceConfig2W( SC_HANDLE hService, DWORD dwInfoLevel, SC_RPC_CONFIG_INFOW info; info.dwInfoLevel = dwInfoLevel; - info.descr = lpInfo; + info.u.descr = lpInfo; err = svcctl_ChangeServiceConfig2W( hService, info ); } __EXCEPT(rpc_filter)

1 0

Mark Harmstone : include: Add definition of GUID_All_Objects.
by Alexandre Julliard 02 Mar '15

02 Mar '15

Module: wine Branch: master Commit: fa64a7d842fdc271541c12f11262b0e83e554948 URL: http://source.winehq.org/git/wine.git/?a=commit;h=fa64a7d842fdc271541c12f11… Author: Mark Harmstone <hellas(a)burntcomma.com> Date: Fri Feb 27 21:32:16 2015 +0000 include: Add definition of GUID_All_Objects. --- include/dsound.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/include/dsound.h b/include/dsound.h index 9dd9671..c7a2bd5 100644 --- a/include/dsound.h +++ b/include/dsound.h @@ -668,6 +668,8 @@ DECLARE_INTERFACE_(IDirectSoundBuffer8,IUnknown) }; #undef INTERFACE +DEFINE_GUID(GUID_All_Objects, 0xaa114de5, 0xc262, 0x4169, 0xa1, 0xc8, 0x23, 0xd6, 0x98, 0xcc, 0x73, 0xb5); + #if !defined(__cplusplus) || defined(CINTERFACE) /*** IUnknown methods ***/ #define IDirectSoundBuffer8_QueryInterface(p,a,b) (p)->lpVtbl->QueryInterface(p,a,b)

1 0

Jacek Caban : mshtml: Use return_nsstr helper in IHTMLDocument5:: get_compatMode.
by Alexandre Julliard 02 Mar '15

02 Mar '15

Module: wine Branch: master Commit: 25b4d6be68f84c9810c79e932e5f5543e373894f URL: http://source.winehq.org/git/wine.git/?a=commit;h=25b4d6be68f84c9810c79e932… Author: Jacek Caban <jacek(a)codeweavers.com> Date: Fri Feb 27 17:31:48 2015 +0100 mshtml: Use return_nsstr helper in IHTMLDocument5::get_compatMode. --- dlls/mshtml/htmldoc.c | 11 +++-------- 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/dlls/mshtml/htmldoc.c b/dlls/mshtml/htmldoc.c index a9ef3d9..977e2cb 100644 --- a/dlls/mshtml/htmldoc.c +++ b/dlls/mshtml/htmldoc.c @@ -2882,7 +2882,7 @@ static HRESULT WINAPI HTMLDocument5_get_compatMode(IHTMLDocument5 *iface, BSTR * { HTMLDocument *This = impl_from_IHTMLDocument5(iface); nsAString mode_str; - const PRUnichar *mode; + nsresult nsres; TRACE("(%p)->(%p)\n", This, p); @@ -2892,13 +2892,8 @@ static HRESULT WINAPI HTMLDocument5_get_compatMode(IHTMLDocument5 *iface, BSTR * } nsAString_Init(&mode_str, NULL); - nsIDOMHTMLDocument_GetCompatMode(This->doc_node->nsdoc, &mode_str); - - nsAString_GetData(&mode_str, &mode); - *p = SysAllocString(mode); - nsAString_Finish(&mode_str); - - return S_OK; + nsres = nsIDOMHTMLDocument_GetCompatMode(This->doc_node->nsdoc, &mode_str); + return return_nsstr(nsres, &mode_str, p); } static const IHTMLDocument5Vtbl HTMLDocument5Vtbl = {

1 0

Andrew Eikum : shell32: Use a helper function to allocate strings from the registry.
by Alexandre Julliard 02 Mar '15

02 Mar '15

Module: wine Branch: master Commit: e56e9c11fac2efb85641879ada222dbce92ff13b URL: http://source.winehq.org/git/wine.git/?a=commit;h=e56e9c11fac2efb85641879ad… Author: Andrew Eikum <aeikum(a)codeweavers.com> Date: Fri Feb 27 09:01:43 2015 -0600 shell32: Use a helper function to allocate strings from the registry. --- dlls/shell32/shellpath.c | 37 ++++++++++++++++++++++++------------- 1 file changed, 24 insertions(+), 13 deletions(-) diff --git a/dlls/shell32/shellpath.c b/dlls/shell32/shellpath.c index caf6777..d33091d 100644 --- a/dlls/shell32/shellpath.c +++ b/dlls/shell32/shellpath.c @@ -3194,6 +3194,29 @@ static HRESULT get_known_folder_registry_path( return hr; } +static HRESULT get_known_folder_wstr(const WCHAR *regpath, const WCHAR *value, WCHAR **out) +{ + DWORD size = 0; + HRESULT hr; + + size = 0; + hr = HRESULT_FROM_WIN32(RegGetValueW(HKEY_LOCAL_MACHINE, regpath, value, RRF_RT_REG_SZ, NULL, NULL, &size)); + if(FAILED(hr)) + return hr; + + *out = CoTaskMemAlloc(size); + if(!*out) + return E_OUTOFMEMORY; + + hr = HRESULT_FROM_WIN32(RegGetValueW(HKEY_LOCAL_MACHINE, regpath, value, RRF_RT_REG_SZ, NULL, *out, &size)); + if(FAILED(hr)){ + CoTaskMemFree(*out); + *out = NULL; + } + + return hr; +} + static HRESULT get_known_folder_dword(const WCHAR *registryPath, const WCHAR *value, DWORD *out) { DWORD dwSize = sizeof(DWORD); @@ -3660,7 +3683,6 @@ static HRESULT WINAPI knownfolder_GetFolderDefinition( { struct knownfolder *knownfolder = impl_from_IKnownFolder( iface ); HRESULT hr; - DWORD dwSize; TRACE("(%p, %p)\n", knownfolder, pKFD); if(!pKFD) return E_INVALIDARG; @@ -3671,21 +3693,10 @@ static HRESULT WINAPI knownfolder_GetFolderDefinition( if(FAILED(hr)) return hr; - hr = HRESULT_FROM_WIN32(RegGetValueW(HKEY_LOCAL_MACHINE, knownfolder->registryPath, szName, RRF_RT_REG_SZ, NULL, NULL, &dwSize)); + hr = get_known_folder_wstr(knownfolder->registryPath, szName, &pKFD->pszName); if(FAILED(hr)) return hr; - pKFD->pszName = CoTaskMemAlloc(dwSize); - if(!pKFD->pszName) - return E_OUTOFMEMORY; - - hr = HRESULT_FROM_WIN32(RegGetValueW(HKEY_LOCAL_MACHINE, knownfolder->registryPath, szName, RRF_RT_REG_SZ, NULL, pKFD->pszName, &dwSize)); - if(FAILED(hr)){ - CoTaskMemFree(pKFD->pszName); - pKFD->pszName = NULL; - return hr; - } - return S_OK; }

1 0

Andrew Eikum : shell32: Use a helper function to get DWORDs from registry.
by Alexandre Julliard 02 Mar '15

02 Mar '15

Module: wine Branch: master Commit: b5c12cf9f3679a799c81cd66e63ae916dc74c40d URL: http://source.winehq.org/git/wine.git/?a=commit;h=b5c12cf9f3679a799c81cd66e… Author: Andrew Eikum <aeikum(a)codeweavers.com> Date: Fri Feb 27 09:01:35 2015 -0600 shell32: Use a helper function to get DWORDs from registry. --- dlls/shell32/shellpath.c | 43 ++++++++++++++++++------------------------- 1 file changed, 18 insertions(+), 25 deletions(-) diff --git a/dlls/shell32/shellpath.c b/dlls/shell32/shellpath.c index 84ac7d5..caf6777 100644 --- a/dlls/shell32/shellpath.c +++ b/dlls/shell32/shellpath.c @@ -768,6 +768,12 @@ VOID WINAPI PathSetDlgItemPathAW(HWND hDlg, int id, LPCVOID pszPath) PathSetDlgItemPathA(hDlg, id, pszPath); } +static const WCHAR szCategory[] = {'C','a','t','e','g','o','r','y',0}; +static const WCHAR szAttributes[] = {'A','t','t','r','i','b','u','t','e','s',0}; +static const WCHAR szName[] = {'N','a','m','e',0}; +static const WCHAR szRelativePath[] = {'R','e','l','a','t','i','v','e','P','a','t','h',0}; +static const WCHAR szParentFolder[] = {'P','a','r','e','n','t','F','o','l','d','e','r',0}; + static const WCHAR szCurrentVersion[] = {'S','o','f','t','w','a','r','e','\\','M','i','c','r','o','s','o','f','t','\\','W','i','n','d','o','w','s','\\','C','u','r','r','e','n','t','V','e','r','s','i','o','n','\0'}; static const WCHAR Administrative_ToolsW[] = {'A','d','m','i','n','i','s','t','r','a','t','i','v','e',' ','T','o','o','l','s','\0'}; static const WCHAR AppDataW[] = {'A','p','p','D','a','t','a','\0'}; @@ -2816,7 +2822,6 @@ static HRESULT set_folder_attributes(void) static const WCHAR wfparsingW[] = {'W','a','n','t','s','F','O','R','P','A','R','S','I','N','G',0}; static const WCHAR wfdisplayW[] = {'W','a','n','t','s','F','O','R','D','I','S','P','L','A','Y',0}; static const WCHAR hideasdeleteW[] = {'H','i','d','e','A','s','D','e','l','e','t','e','P','e','r','U','s','e','r',0}; - static const WCHAR attributesW[] = {'A','t','t','r','i','b','u','t','e','s',0}; static const WCHAR cfattributesW[] = {'C','a','l','l','F','o','r','A','t','t','r','i','b','u','t','e','s',0}; static const WCHAR emptyW[] = {0}; @@ -2864,7 +2869,7 @@ static HRESULT set_folder_attributes(void) if (folders[i].hideasdel) res = RegSetValueExW( hkey, hideasdeleteW, 0, REG_SZ, (const BYTE *)emptyW, sizeof(emptyW) ); if (folders[i].attr) - res = RegSetValueExW( hkey, attributesW, 0, REG_DWORD, + res = RegSetValueExW( hkey, szAttributes, 0, REG_DWORD, (const BYTE *)&folders[i].attr, sizeof(DWORD)); if (folders[i].call_for_attr) res = RegSetValueExW( hkey, cfattributesW, 0, REG_DWORD, @@ -3147,12 +3152,6 @@ HRESULT WINAPI SHGetFolderPathEx(REFKNOWNFOLDERID rfid, DWORD flags, HANDLE toke return hr; } -/* constant values used by known folder functions */ -static const WCHAR szCategory[] = {'C','a','t','e','g','o','r','y',0}; -static const WCHAR szName[] = {'N','a','m','e',0}; -static const WCHAR szRelativePath[] = {'R','e','l','a','t','i','v','e','P','a','t','h',0}; -static const WCHAR szParentFolder[] = {'P','a','r','e','n','t','F','o','l','d','e','r',0}; - /* * Internal function to convert known folder identifier to path of registry key * associated with known folder. @@ -3195,6 +3194,13 @@ static HRESULT get_known_folder_registry_path( return hr; } +static HRESULT get_known_folder_dword(const WCHAR *registryPath, const WCHAR *value, DWORD *out) +{ + DWORD dwSize = sizeof(DWORD); + DWORD dwType; + return HRESULT_FROM_WIN32(RegGetValueW(HKEY_LOCAL_MACHINE, registryPath, value, RRF_RT_DWORD, &dwType, out, &dwSize)); +} + /* * Internal function to get place where folder redirection information are stored. * @@ -3212,16 +3218,12 @@ static HRESULT get_known_folder_redirection_place( HRESULT hr; LPWSTR lpRegistryPath = NULL; KF_CATEGORY category; - DWORD dwSize; /* first, get known folder's category */ hr = get_known_folder_registry_path(rfid, NULL, &lpRegistryPath); if(SUCCEEDED(hr)) - { - dwSize = sizeof(category); - hr = HRESULT_FROM_WIN32(RegGetValueW(HKEY_LOCAL_MACHINE, lpRegistryPath, szCategory, RRF_RT_DWORD, NULL, &category, &dwSize)); - } + hr = get_known_folder_dword(lpRegistryPath, szCategory, &category); if(SUCCEEDED(hr)) { @@ -3245,15 +3247,6 @@ static HRESULT get_known_folder_redirection_place( static HRESULT get_known_folder_path_by_id(REFKNOWNFOLDERID folderId, LPWSTR lpRegistryPath, DWORD dwFlags, LPWSTR *ppszPath); -static HRESULT get_known_folder_category( - LPWSTR registryPath, - KF_CATEGORY* pCategory) -{ - DWORD dwSize = sizeof(DWORD); - DWORD dwType; - return HRESULT_FROM_WIN32(RegGetValueW(HKEY_LOCAL_MACHINE, registryPath, szCategory, RRF_RT_DWORD, &dwType, pCategory, &dwSize)); -} - static HRESULT redirect_known_folder( REFKNOWNFOLDERID rfid, HWND hwnd, @@ -3460,7 +3453,7 @@ static HRESULT WINAPI knownfolder_GetCategory( hr = E_FAIL; if(SUCCEEDED(hr)) - hr = get_known_folder_category(knownfolder->registryPath, pCategory); + hr = get_known_folder_dword(knownfolder->registryPath, szCategory, pCategory); return hr; } @@ -3518,7 +3511,7 @@ static HRESULT get_known_folder_path( /* check, if folder was redirected */ if(SUCCEEDED(hr)) - hr = HRESULT_FROM_WIN32(RegGetValueW(HKEY_LOCAL_MACHINE, registryPath, szCategory, RRF_RT_REG_DWORD, NULL, &category, &dwSize)); + hr = get_known_folder_dword(registryPath, szCategory, &category); if(SUCCEEDED(hr)) { @@ -3674,7 +3667,7 @@ static HRESULT WINAPI knownfolder_GetFolderDefinition( ZeroMemory(pKFD, sizeof(*pKFD)); - hr = get_known_folder_category(knownfolder->registryPath, &pKFD->category); + hr = get_known_folder_dword(knownfolder->registryPath, szCategory, &pKFD->category); if(FAILED(hr)) return hr;

1 0

Andrew Eikum : shell32: Rearrange error handling in IKnownFolder:: GetFolderDefinition.
by Alexandre Julliard 02 Mar '15

02 Mar '15

Module: wine Branch: master Commit: d7d058482ce86c6e0c1a64c7e73a3f56f25f4523 URL: http://source.winehq.org/git/wine.git/?a=commit;h=d7d058482ce86c6e0c1a64c7e… Author: Andrew Eikum <aeikum(a)codeweavers.com> Date: Fri Feb 27 09:01:26 2015 -0600 shell32: Rearrange error handling in IKnownFolder::GetFolderDefinition. --- dlls/shell32/shellpath.c | 25 +++++++++++++++---------- 1 file changed, 15 insertions(+), 10 deletions(-) diff --git a/dlls/shell32/shellpath.c b/dlls/shell32/shellpath.c index 0cdc409..84ac7d5 100644 --- a/dlls/shell32/shellpath.c +++ b/dlls/shell32/shellpath.c @@ -3675,20 +3675,25 @@ static HRESULT WINAPI knownfolder_GetFolderDefinition( ZeroMemory(pKFD, sizeof(*pKFD)); hr = get_known_folder_category(knownfolder->registryPath, &pKFD->category); + if(FAILED(hr)) + return hr; - if(SUCCEEDED(hr)) - hr = HRESULT_FROM_WIN32(RegGetValueW(HKEY_LOCAL_MACHINE, knownfolder->registryPath, szName, RRF_RT_REG_SZ, NULL, NULL, &dwSize)); + hr = HRESULT_FROM_WIN32(RegGetValueW(HKEY_LOCAL_MACHINE, knownfolder->registryPath, szName, RRF_RT_REG_SZ, NULL, NULL, &dwSize)); + if(FAILED(hr)) + return hr; - if(SUCCEEDED(hr)) - { - pKFD->pszName = CoTaskMemAlloc(dwSize); - if(!pKFD->pszName) hr = E_OUTOFMEMORY; - } + pKFD->pszName = CoTaskMemAlloc(dwSize); + if(!pKFD->pszName) + return E_OUTOFMEMORY; - if(SUCCEEDED(hr)) - hr = HRESULT_FROM_WIN32(RegGetValueW(HKEY_LOCAL_MACHINE, knownfolder->registryPath, szName, RRF_RT_REG_SZ, NULL, pKFD->pszName, &dwSize)); + hr = HRESULT_FROM_WIN32(RegGetValueW(HKEY_LOCAL_MACHINE, knownfolder->registryPath, szName, RRF_RT_REG_SZ, NULL, pKFD->pszName, &dwSize)); + if(FAILED(hr)){ + CoTaskMemFree(pKFD->pszName); + pKFD->pszName = NULL; + return hr; + } - return hr; + return S_OK; } static const struct IKnownFolderVtbl knownfolder_vtbl =

1 0

Matteo Bruni : d3d9: Pack structures to 4-bytes alignment on x86.
by Alexandre Julliard 02 Mar '15

02 Mar '15

Module: wine Branch: master Commit: 41556170f231aa6ae6a5e227d8e030cf941817e0 URL: http://source.winehq.org/git/wine.git/?a=commit;h=41556170f231aa6ae6a5e227d… Author: Matteo Bruni <mbruni(a)codeweavers.com> Date: Fri Feb 27 13:18:23 2015 +0100 d3d9: Pack structures to 4-bytes alignment on x86. Reported by Christoph von Wittich. --- include/d3d9caps.h | 8 ++++++++ include/d3d9types.h | 8 ++++++++ 2 files changed, 16 insertions(+) diff --git a/include/d3d9caps.h b/include/d3d9caps.h index 838e1f3..5cc757b 100644 --- a/include/d3d9caps.h +++ b/include/d3d9caps.h @@ -20,6 +20,10 @@ #ifndef __WINE_D3D9CAPS_H #define __WINE_D3D9CAPS_H +#ifdef __i386__ +#include <pshpack4.h> +#endif + /* * Definitions */ @@ -392,4 +396,8 @@ typedef struct _D3DCAPS9 { } D3DCAPS9; +#ifdef __i386__ +#include <poppack.h> +#endif + #endif diff --git a/include/d3d9types.h b/include/d3d9types.h index fd7c4ce..3afcf89 100644 --- a/include/d3d9types.h +++ b/include/d3d9types.h @@ -21,6 +21,10 @@ #ifndef __WINE_D3D9TYPES_H #define __WINE_D3D9TYPES_H +#ifdef __i386__ +#include <pshpack4.h> +#endif + /***************************************************************************** * Direct 3D v9 #defines */ @@ -1580,4 +1584,8 @@ typedef enum _D3DSHADER_COMPARISON D3DSPC_RESERVED1, } D3DSHADER_COMPARISON; +#ifdef __i386__ +#include <poppack.h> +#endif + #endif /* __WINE_D3D9TYPES_H */

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-commits March 2015