wine-commits September 2016

wine-commits@winehq.org

2 participants
430 discussions

Sebastian Lackner : jscript: Properly handle \0 characters in String indexOf method.
by Alexandre Julliard 09 Sep '16

09 Sep '16

Module: wine Branch: master Commit: 1c3e0dd3d5ae6a4ba1cb2e5cc47f452a7115b803 URL: http://source.winehq.org/git/wine.git/?a=commit;h=1c3e0dd3d5ae6a4ba1cb2e5cc… Author: Sebastian Lackner <sebastian(a)fds-team.de> Date: Thu Sep 8 23:53:06 2016 +0200 jscript: Properly handle \0 characters in String indexOf method. Signed-off-by: Sebastian Lackner <sebastian(a)fds-team.de> Signed-off-by: Jacek Caban <jacek(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/jscript/string.c | 20 ++++++++++++-------- dlls/jscript/tests/api.js | 12 ++++++++++++ 2 files changed, 24 insertions(+), 8 deletions(-) diff --git a/dlls/jscript/string.c b/dlls/jscript/string.c index 40aa552..b5c0197 100644 --- a/dlls/jscript/string.c +++ b/dlls/jscript/string.c @@ -486,9 +486,9 @@ static HRESULT String_fontsize(script_ctx_t *ctx, vdisp_t *jsthis, WORD flags, u static HRESULT String_indexOf(script_ctx_t *ctx, vdisp_t *jsthis, WORD flags, unsigned argc, jsval_t *argv, jsval_t *r) { + unsigned pos = 0, search_len, length; jsstr_t *search_jsstr, *jsstr; const WCHAR *search_str, *str; - int length, pos = 0; INT ret = -1; HRESULT hres; @@ -498,7 +498,6 @@ static HRESULT String_indexOf(script_ctx_t *ctx, vdisp_t *jsthis, WORD flags, un if(FAILED(hres)) return hres; - length = jsstr_length(jsstr); if(!argc) { if(r) *r = jsval_number(-1); @@ -512,6 +511,9 @@ static HRESULT String_indexOf(script_ctx_t *ctx, vdisp_t *jsthis, WORD flags, un return hres; } + search_len = jsstr_length(search_jsstr); + length = jsstr_length(jsstr); + if(argc >= 2) { double d; @@ -520,14 +522,16 @@ static HRESULT String_indexOf(script_ctx_t *ctx, vdisp_t *jsthis, WORD flags, un pos = is_int32(d) ? min(length, d) : length; } - if(SUCCEEDED(hres)) { + if(SUCCEEDED(hres) && length >= search_len) { + const WCHAR *end = str+length-search_len; const WCHAR *ptr; - ptr = strstrW(str+pos, search_str); - if(ptr) - ret = ptr - str; - else - ret = -1; + for(ptr = str+pos; ptr <= end; ptr++) { + if(!memcmp(ptr, search_str, search_len*sizeof(WCHAR))) { + ret = ptr-str; + break; + } + } } jsstr_release(search_jsstr); diff --git a/dlls/jscript/tests/api.js b/dlls/jscript/tests/api.js index e7b55fc..43f7a19 100644 --- a/dlls/jscript/tests/api.js +++ b/dlls/jscript/tests/api.js @@ -629,6 +629,12 @@ tmp = "abcd".indexOf(); ok(tmp == -1, "indexOf = " + tmp); tmp = "abcd".indexOf("b", bigInt); ok(tmp == -1, "indexOf = " + tmp); +tmp = "abcd".indexOf("abcd",0); +ok(tmp === 0, "indexOf = " + tmp); +tmp = "abcd".indexOf("abcd",1); +ok(tmp === -1, "indexOf = " + tmp); +tmp = ("ab" + String.fromCharCode(0) + "cd").indexOf(String.fromCharCode(0)); +ok(tmp === 2, "indexOf = " + tmp); tmp = "abcd".lastIndexOf("bc",1); ok(tmp === 1, "lastIndexOf = " + tmp); @@ -650,6 +656,12 @@ tmp = strObj.lastIndexOf("b"); ok(tmp === 1, "lastIndexOf = " + tmp); tmp = "bbb".lastIndexOf("b", bigInt); ok(tmp === 2, "lastIndexOf = " + tmp); +tmp = "abcd".lastIndexOf("abcd",4); +ok(tmp === 0, "lastIndexOf = " + tmp); +tmp = "abcd".lastIndexOf("abcd",0); +ok(tmp === 0, "lastIndexOf = " + tmp); +tmp = ("ab" + String.fromCharCode(0) + "cd").lastIndexOf(String.fromCharCode(0)); +ok(tmp === 2, "lastIndexOf = " + tmp); tmp = "".toLowerCase(); ok(tmp === "", "''.toLowerCase() = " + tmp);

1 0

Sebastian Lackner : jscript: Properly handle \0 characters in String to{Lower, Upper}Case methods.
by Alexandre Julliard 09 Sep '16

09 Sep '16

Module: wine Branch: master Commit: 54e6736032c59a3978918c3d3ac2ea8347f5d3a7 URL: http://source.winehq.org/git/wine.git/?a=commit;h=54e6736032c59a3978918c3d3… Author: Sebastian Lackner <sebastian(a)fds-team.de> Date: Thu Sep 8 23:52:19 2016 +0200 jscript: Properly handle \0 characters in String to{Lower,Upper}Case methods. Signed-off-by: Sebastian Lackner <sebastian(a)fds-team.de> Signed-off-by: Jacek Caban <jacek(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/jscript/string.c | 12 ++++++++---- dlls/jscript/tests/api.js | 4 ++++ 2 files changed, 12 insertions(+), 4 deletions(-) diff --git a/dlls/jscript/string.c b/dlls/jscript/string.c index 80c3dd8..40aa552 100644 --- a/dlls/jscript/string.c +++ b/dlls/jscript/string.c @@ -1402,17 +1402,19 @@ static HRESULT String_toLowerCase(script_ctx_t *ctx, vdisp_t *jsthis, WORD flags return hres; if(r) { + unsigned len = jsstr_length(str); jsstr_t *ret; WCHAR *buf; - ret = jsstr_alloc_buf(jsstr_length(str), &buf); + ret = jsstr_alloc_buf(len, &buf); if(!ret) { jsstr_release(str); return E_OUTOFMEMORY; } jsstr_flush(str, buf); - strlwrW(buf); + for (; len--; buf++) *buf = tolowerW(*buf); + *r = jsval_string(ret); } jsstr_release(str); @@ -1432,17 +1434,19 @@ static HRESULT String_toUpperCase(script_ctx_t *ctx, vdisp_t *jsthis, WORD flags return hres; if(r) { + unsigned len = jsstr_length(str); jsstr_t *ret; WCHAR *buf; - ret = jsstr_alloc_buf(jsstr_length(str), &buf); + ret = jsstr_alloc_buf(len, &buf); if(!ret) { jsstr_release(str); return E_OUTOFMEMORY; } jsstr_flush(str, buf); - struprW(buf); + for (; len--; buf++) *buf = toupperW(*buf); + *r = jsval_string(ret); } jsstr_release(str); diff --git a/dlls/jscript/tests/api.js b/dlls/jscript/tests/api.js index c7f2bcd..e7b55fc 100644 --- a/dlls/jscript/tests/api.js +++ b/dlls/jscript/tests/api.js @@ -661,6 +661,8 @@ tmp = "tEsT".toLowerCase(); ok(tmp === "test", "''.toLowerCase() = " + tmp); tmp = "tEsT".toLowerCase(3); ok(tmp === "test", "''.toLowerCase(3) = " + tmp); +tmp = ("tE" + String.fromCharCode(0) + "sT").toLowerCase(); +ok(tmp === "te" + String.fromCharCode(0) + "st", "''.toLowerCase() = " + tmp); tmp = "".toUpperCase(); ok(tmp === "", "''.toUpperCase() = " + tmp); @@ -672,6 +674,8 @@ tmp = "tEsT".toUpperCase(); ok(tmp === "TEST", "''.toUpperCase() = " + tmp); tmp = "tEsT".toUpperCase(3); ok(tmp === "TEST", "''.toUpperCase(3) = " + tmp); +tmp = ("tE" + String.fromCharCode(0) + "sT").toUpperCase(); +ok(tmp === "TE" + String.fromCharCode(0) + "ST", "''.toUpperCase() = " + tmp); tmp = "".anchor(); ok(tmp === "<A NAME=\"undefined\"></A>", "''.anchor() = " + tmp);

1 0

Sebastian Lackner : jscript/tests: Remove an invalid win2k broken() check.
by Alexandre Julliard 09 Sep '16

09 Sep '16

Module: wine Branch: master Commit: cd5ea7612e9a4fc8ec70dce96776dd6b3c372896 URL: http://source.winehq.org/git/wine.git/?a=commit;h=cd5ea7612e9a4fc8ec70dce96… Author: Sebastian Lackner <sebastian(a)fds-team.de> Date: Thu Sep 8 19:16:51 2016 +0200 jscript/tests: Remove an invalid win2k broken() check. Signed-off-by: Sebastian Lackner <sebastian(a)fds-team.de> Signed-off-by: Jacek Caban <jacek(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/jscript/tests/jscript.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dlls/jscript/tests/jscript.c b/dlls/jscript/tests/jscript.c index f949b9d..4c5aa6c 100644 --- a/dlls/jscript/tests/jscript.c +++ b/dlls/jscript/tests/jscript.c @@ -659,7 +659,7 @@ static void test_aggregation(void) hres = CoCreateInstance(&CLSID_JScript, (IUnknown*)0xdeadbeef, CLSCTX_INPROC_SERVER|CLSCTX_INPROC_HANDLER, &IID_IUnknown, (void**)&unk); - ok(hres == CLASS_E_NOAGGREGATION || broken(E_INVALIDARG) /* win2k */, + ok(hres == CLASS_E_NOAGGREGATION, "CoCreateInstance failed: %08x, expected CLASS_E_NOAGGREGATION\n", hres); ok(!unk || broken(unk != NULL), "unk = %p\n", unk); }

1 0

Alistair Leslie-Hughes : comdlg: Select all text when enter is pressed.
by Alexandre Julliard 09 Sep '16

09 Sep '16

Module: wine Branch: master Commit: 326a9ea1375591a81ac5f8c0dc68a568f71825ee URL: http://source.winehq.org/git/wine.git/?a=commit;h=326a9ea1375591a81ac5f8c0d… Author: Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> Date: Tue Aug 30 08:00:21 2016 +0000 comdlg: Select all text when enter is pressed. Signed-off-by: Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/comdlg32/filedlg.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/dlls/comdlg32/filedlg.c b/dlls/comdlg32/filedlg.c index c4bced9..95eacd3 100644 --- a/dlls/comdlg32/filedlg.c +++ b/dlls/comdlg32/filedlg.c @@ -2552,6 +2552,13 @@ BOOL FILEDLG95_OnOpen(HWND hwnd) COMDLG32_SHFree(pidlCurrent); if (filename_is_edit( fodInfos )) SendMessageW(fodInfos->DlgInfos.hwndFileName, EM_SETSEL, 0, -1); + else + { + HWND hwnd; + + hwnd = (HWND)SendMessageA(fodInfos->DlgInfos.hwndFileName, CBEM_GETEDITCONTROL, 0, 0); + SendMessageW(hwnd, EM_SETSEL, 0, -1); + } } } ret = FALSE;

1 0

Alistair Leslie-Hughes : comdlg32: Clear the filename text on OPEN_BROWSE.
by Alexandre Julliard 09 Sep '16

09 Sep '16

Module: wine Branch: master Commit: b11d7f7482b6ce3c421848a092a4a2646c6bbaa4 URL: http://source.winehq.org/git/wine.git/?a=commit;h=b11d7f7482b6ce3c421848a09… Author: Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> Date: Tue Aug 30 08:00:09 2016 +0000 comdlg32: Clear the filename text on OPEN_BROWSE. Signed-off-by: Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/comdlg32/filedlg.c | 1 + 1 file changed, 1 insertion(+) diff --git a/dlls/comdlg32/filedlg.c b/dlls/comdlg32/filedlg.c index 0fbb621..c4bced9 100644 --- a/dlls/comdlg32/filedlg.c +++ b/dlls/comdlg32/filedlg.c @@ -2541,6 +2541,7 @@ BOOL FILEDLG95_OnOpen(HWND hwnd) && fodInfos->ofnInfos->Flags & OFN_EXPLORER) { SendCustomDlgNotificationMessage(hwnd, CDN_FOLDERCHANGE); + SendMessageA(fodInfos->DlgInfos.hwndFileName, WM_SETTEXT, 0, (LPARAM)""); } } else if( nOpenAction == ONOPEN_SEARCH )

1 0

André Hentschel : loader/wine.inf: Open pdf files using winebrowser.
by Alexandre Julliard 09 Sep '16

09 Sep '16

Module: wine Branch: master Commit: 3e997a75d3cae811e0f90c760c1d5f0616ba3558 URL: http://source.winehq.org/git/wine.git/?a=commit;h=3e997a75d3cae811e0f90c760… Author: André Hentschel <nerv(a)dawncrow.de> Date: Mon Sep 5 22:56:31 2016 +0200 loader/wine.inf: Open pdf files using winebrowser. Signed-off-by: André Hentschel <nerv(a)dawncrow.de> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- loader/wine.inf.in | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/loader/wine.inf.in b/loader/wine.inf.in index 4e29026..0c58d6a 100644 --- a/loader/wine.inf.in +++ b/loader/wine.inf.in @@ -179,6 +179,7 @@ HKCR,.ini,,2,"inifile" HKCR,.lnk,,2,"lnkfile" HKCR,.msi,,2,"Msi.Package" HKCR,.msp,,2,"Msi.Patch" +HKCR,.pdf,,2,"pdffile" HKCR,.rtf,,2,"rtffile" HKCR,.wri,,2,"wrifile" HKCR,*\shellex\ContextMenuHandlers,,16 @@ -223,6 +224,12 @@ HKCR,Msi.Package\shell\Uninstall\command,,2,"%11%\msiexec.exe /x ""%1""" HKCR,Msi.Patch,,2,"Windows Installer Patch" HKCR,Msi.Patch\DefaultIcon,,2,"msiexec.exe" HKCR,Msi.Patch\shell\Open\command,,2,"%11%\msiexec.exe /p ""%1""" +HKCR,pdffile,,2,"PDF Document" +HKCR,pdffile\shell\open\command,,2,"""%11%\winebrowser.exe"" -nohome" +HKCR,pdffile\shell\open\ddeexec,,2,"""%1"",,-1,0,,,," +HKCR,pdffile\shell\open\ddeexec,"NoActivateHandler",2,"" +HKCR,pdffile\shell\open\ddeexec\Application,,2,"IExplore" +HKCR,pdffile\shell\open\ddeexec\Topic,,2,"WWW_OpenURL" HKCR,rtffile,,2,"Rich Text Document" HKCR,rtffile\shell\open\command,,2,"""%16422%\Windows NT\Accessories\wordpad.exe"" %1" HKCR,rtffile\shell\print\command,,2,"""%16422%\Windows NT\Accessories\wordpad.exe"" /p %1"

1 0

Michael Stefaniuc : urlmon: Avoid a cast from a COM object to an iface.
by Alexandre Julliard 09 Sep '16

09 Sep '16

Module: wine Branch: master Commit: 1bf7c738d9554b7c05d7498a2b0b4401b3d9a71b URL: http://source.winehq.org/git/wine.git/?a=commit;h=1bf7c738d9554b7c05d7498a2… Author: Michael Stefaniuc <mstefani(a)redhat.de> Date: Thu Sep 8 22:20:33 2016 +0200 urlmon: Avoid a cast from a COM object to an iface. Signed-off-by: Michael Stefaniuc <mstefani(a)redhat.de> Signed-off-by: Jacek Caban <jacek(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/urlmon/sec_mgr.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dlls/urlmon/sec_mgr.c b/dlls/urlmon/sec_mgr.c index 0c20562..eab155d 100644 --- a/dlls/urlmon/sec_mgr.c +++ b/dlls/urlmon/sec_mgr.c @@ -1831,7 +1831,7 @@ HRESULT ZoneMgrImpl_Construct(IUnknown *pUnkOuter, LPVOID *ppobj) TRACE("(%p %p)\n", pUnkOuter, ppobj); ret->IInternetZoneManagerEx2_iface.lpVtbl = &ZoneMgrImplVtbl; ret->ref = 1; - *ppobj = (IInternetZoneManagerEx*)ret; + *ppobj = &ret->IInternetZoneManagerEx2_iface; URLMON_LockModule();

1 0

Michael Stefaniuc : oleaut32: Avoid casts from COM objects to interfaces.
by Alexandre Julliard 09 Sep '16

09 Sep '16

Module: wine Branch: master Commit: a3c5c50bdd066b2e5196f79db93c4918f5d5ec1b URL: http://source.winehq.org/git/wine.git/?a=commit;h=a3c5c50bdd066b2e5196f79db… Author: Michael Stefaniuc <mstefani(a)redhat.de> Date: Thu Sep 8 22:19:47 2016 +0200 oleaut32: Avoid casts from COM objects to interfaces. Signed-off-by: Michael Stefaniuc <mstefani(a)redhat.de> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/oleaut32/olefont.c | 6 ++++-- dlls/oleaut32/olepicture.c | 3 ++- 2 files changed, 6 insertions(+), 3 deletions(-) diff --git a/dlls/oleaut32/olefont.c b/dlls/oleaut32/olefont.c index 4b3411e..c20093c 100644 --- a/dlls/oleaut32/olefont.c +++ b/dlls/oleaut32/olefont.c @@ -1014,8 +1014,10 @@ static HRESULT WINAPI OLEFontImpl_Clone( newObject->pPropertyNotifyCP = NULL; newObject->pFontEventsCP = NULL; - CreateConnectionPoint((IUnknown*)newObject, &IID_IPropertyNotifySink, &newObject->pPropertyNotifyCP); - CreateConnectionPoint((IUnknown*)newObject, &IID_IFontEventsDisp, &newObject->pFontEventsCP); + CreateConnectionPoint((IUnknown*)&newObject->IFont_iface, &IID_IPropertyNotifySink, + &newObject->pPropertyNotifyCP); + CreateConnectionPoint((IUnknown*)&newObject->IFont_iface, &IID_IFontEventsDisp, + &newObject->pFontEventsCP); if (!newObject->pPropertyNotifyCP || !newObject->pFontEventsCP) { diff --git a/dlls/oleaut32/olepicture.c b/dlls/oleaut32/olepicture.c index 96c109a..bfca22f 100644 --- a/dlls/oleaut32/olepicture.c +++ b/dlls/oleaut32/olepicture.c @@ -299,7 +299,8 @@ static OLEPictureImpl* OLEPictureImpl_Construct(LPPICTDESC pictDesc, BOOL fOwn) newObject->IConnectionPointContainer_iface.lpVtbl = &OLEPictureImpl_IConnectionPointContainer_VTable; newObject->pCP = NULL; - CreateConnectionPoint((IUnknown*)newObject,&IID_IPropertyNotifySink,&newObject->pCP); + CreateConnectionPoint((IUnknown*)&newObject->IPicture_iface, &IID_IPropertyNotifySink, + &newObject->pCP); if (!newObject->pCP) { HeapFree(GetProcessHeap(), 0, newObject);

1 0

Michael Stefaniuc : msdaps: Use the proper COM method wrappers.
by Alexandre Julliard 09 Sep '16

09 Sep '16

Module: wine Branch: master Commit: 502b9e9aa7390209a2ff5858b69830863b27a33b URL: http://source.winehq.org/git/wine.git/?a=commit;h=502b9e9aa7390209a2ff5858b… Author: Michael Stefaniuc <mstefani(a)redhat.de> Date: Thu Sep 8 22:21:33 2016 +0200 msdaps: Use the proper COM method wrappers. Signed-off-by: Michael Stefaniuc <mstefani(a)redhat.de> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/msdaps/row_server.c | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/dlls/msdaps/row_server.c b/dlls/msdaps/row_server.c index 784ade8..2b496be 100644 --- a/dlls/msdaps/row_server.c +++ b/dlls/msdaps/row_server.c @@ -757,19 +757,19 @@ static const IRowVtbl row_vtbl = static HRESULT WINAPI row_change_QueryInterface(IRowChange *iface, REFIID iid, void **obj) { row_proxy *This = impl_from_IRowChange(iface); - return IUnknown_QueryInterface((IUnknown *)This, iid, obj); + return IRow_QueryInterface(&This->IRow_iface, iid, obj); } static ULONG WINAPI row_change_AddRef(IRowChange *iface) { row_proxy *This = impl_from_IRowChange(iface); - return IUnknown_AddRef((IUnknown*)This); + return IRow_AddRef(&This->IRow_iface); } static ULONG WINAPI row_change_Release(IRowChange *iface) { row_proxy *This = impl_from_IRowChange(iface); - return IUnknown_Release((IUnknown*)This); + return IRow_Release(&This->IRow_iface); } static HRESULT WINAPI row_change_SetColumns(IRowChange *iface, DBORDINAL cColumns, @@ -1110,19 +1110,19 @@ static const IRowsetLocateVtbl rowsetlocate_vtbl = static HRESULT WINAPI rowsetinfo_QueryInterface(IRowsetInfo *iface, REFIID iid, void **obj) { rowset_proxy *This = impl_from_IRowsetInfo(iface); - return IUnknown_QueryInterface((IUnknown *)This, iid, obj); + return IRowsetLocate_QueryInterface(&This->IRowsetLocate_iface, iid, obj); } static ULONG WINAPI rowsetinfo_AddRef(IRowsetInfo *iface) { rowset_proxy *This = impl_from_IRowsetInfo(iface); - return IUnknown_AddRef((IUnknown *)This); + return IRowsetLocate_AddRef(&This->IRowsetLocate_iface); } static ULONG WINAPI rowsetinfo_Release(IRowsetInfo *iface) { rowset_proxy *This = impl_from_IRowsetInfo(iface); - return IUnknown_Release((IUnknown *)This); + return IRowsetLocate_Release(&This->IRowsetLocate_iface); } static HRESULT WINAPI rowsetinfo_GetProperties(IRowsetInfo *iface, const ULONG cPropertyIDSets, @@ -1167,19 +1167,19 @@ static const IRowsetInfoVtbl rowsetinfo_vtbl = static HRESULT WINAPI accessor_QueryInterface(IAccessor *iface, REFIID iid, void **obj) { rowset_proxy *This = impl_from_IAccessor(iface); - return IUnknown_QueryInterface((IUnknown *)This, iid, obj); + return IRowsetLocate_QueryInterface(&This->IRowsetLocate_iface, iid, obj); } static ULONG WINAPI accessor_AddRef(IAccessor *iface) { rowset_proxy *This = impl_from_IAccessor(iface); - return IUnknown_AddRef((IUnknown *)This); + return IRowsetLocate_AddRef(&This->IRowsetLocate_iface); } static ULONG WINAPI accessor_Release(IAccessor *iface) { rowset_proxy *This = impl_from_IAccessor(iface); - return IUnknown_Release((IUnknown *)This); + return IRowsetLocate_Release(&This->IRowsetLocate_iface); } static HRESULT WINAPI accessor_AddRefAccessor(IAccessor *iface, HACCESSOR hAccessor, DBREFCOUNT *pcRefCount)

1 0

Sebastian Lackner : mshtml/tests: Fix incorrect usage of broken() function.
by Alexandre Julliard 08 Sep '16

08 Sep '16

Module: wine Branch: master Commit: 01581bfc48161c3c55027334b1ecb9e909873a6b URL: http://source.winehq.org/git/wine.git/?a=commit;h=01581bfc48161c3c55027334b… Author: Sebastian Lackner <sebastian(a)fds-team.de> Date: Thu Sep 8 11:17:15 2016 +0200 mshtml/tests: Fix incorrect usage of broken() function. Signed-off-by: Sebastian Lackner <sebastian(a)fds-team.de> Signed-off-by: Jacek Caban<jacek(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/mshtml/tests/script.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dlls/mshtml/tests/script.c b/dlls/mshtml/tests/script.c index 92a6f67..e8b3d19 100644 --- a/dlls/mshtml/tests/script.c +++ b/dlls/mshtml/tests/script.c @@ -1968,7 +1968,7 @@ static void test_func(IDispatchEx *obj) memset(&ei, 0, sizeof(ei)); VariantInit(&var); hres = IDispatchEx_Invoke(dispex, DISPID_VALUE, &IID_NULL, LOCALE_NEUTRAL, DISPATCH_METHOD, &dp, &var, &ei, NULL); - ok(hres == S_OK || broken(E_ACCESSDENIED), "InvokeEx failed: %08x\n", hres); + ok(hres == S_OK || broken(hres == E_ACCESSDENIED), "InvokeEx failed: %08x\n", hres); if(SUCCEEDED(hres)) { DISPID named_args[2] = { DISPID_THIS, 0xdeadbeef }; VARIANT args[2];

1 0

← Newer
1
...
26
27
28
29
30
31
32
...
43
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-commits September 2016