Rémi Bernon : dmsynth: Implement IDirectMusicSynthSink_SetDirectSound semi-stub.

[Alexandre Julliard]

Module: wine
Branch: master
Commit: be2cdd3cb278bd84c95556ed945199c1aa2fe615
URL:    https://gitlab.winehq.org/wine/wine/-/commit/be2cdd3cb278bd84c95556ed945199c...

Author: Rémi Bernon 
Date:   Sun Aug 27 16:30:15 2023 +0200

dmsynth: Implement IDirectMusicSynthSink_SetDirectSound semi-stub.

---

dlls/dmsynth/synthsink.c     | 13 ++++++++++++-
 dlls/dmsynth/tests/dmsynth.c |  2 +-
 2 files changed, 13 insertions(+), 2 deletions(-)

diff --git a/dlls/dmsynth/synthsink.c b/dlls/dmsynth/synthsink.c
index fce325681ee..cda44e82191 100644
--- a/dlls/dmsynth/synthsink.c
+++ b/dlls/dmsynth/synthsink.c
@@ -34,6 +34,7 @@ struct synth_sink
     IReferenceClock *latency_clock;
     IReferenceClock *master_clock;
     IDirectMusicSynth *synth;   /* No reference hold! */
+    IDirectSound *dsound;
     BOOL active;
 };

@@ -181,7 +182,17 @@ static HRESULT WINAPI synth_sink_SetDirectSound(IDirectMusicSynthSink *iface,
 {
     struct synth_sink *This = impl_from_IDirectMusicSynthSink(iface);

-    FIXME("(%p)->(%p, %p): stub\n", This, dsound, dsound_buffer);
+    TRACE("(%p)->(%p, %p)\n", This, dsound, dsound_buffer);
+
+    if (dsound_buffer) FIXME("Ignoring IDirectSoundBuffer parameter.\n");
+    if (This->active) return DMUS_E_SYNTHACTIVE;
+
+    if (This->dsound) IDirectSound_Release(This->dsound);
+    This->dsound = NULL;
+    if (!dsound) return S_OK;
+
+    if (!This->synth) return DMUS_E_SYNTHNOTCONFIGURED;
+    if ((This->dsound = dsound)) IDirectSound_AddRef(This->dsound);

return S_OK;
 }
diff --git a/dlls/dmsynth/tests/dmsynth.c b/dlls/dmsynth/tests/dmsynth.c
index 6919e22c6d6..f0508bf01d8 100644
--- a/dlls/dmsynth/tests/dmsynth.c
+++ b/dlls/dmsynth/tests/dmsynth.c
@@ -1234,7 +1234,7 @@ static void test_IDirectMusicSynthSink(void)
     hr = IDirectMusicSynthSink_SetDirectSound(sink, NULL, NULL);
     ok(hr == S_OK, "got %#lx\n", hr);
     hr = IDirectMusicSynthSink_SetDirectSound(sink, dsound, NULL);
-    todo_wine ok(hr == DMUS_E_SYNTHNOTCONFIGURED, "got %#lx\n", hr);
+    ok(hr == DMUS_E_SYNTHNOTCONFIGURED, "got %#lx\n", hr);

/* Activate requires a synth, dsound and a clock */
     ref = get_refcount(synth);