ChangeSet ID: 30237 CVSROOT: /opt/cvs-commit Module name: appdb Changes by: wineowner@winehq.org 2006/12/01 23:10:11
Modified files: admin : adminBugs.php editAppFamily.php editAppVersion.php moveAppVersion.php include : note.php
Log message: Alexander Nicolaysen Sørnes alex@thehandofagony.com Add some missing quotes to input tags, to prevent the variables from being assigned garbage values. Also conform the affected tags to newer HTML standards.
Patch: http://cvs.winehq.org/patch.py?id=30237
Old revision New revision Changes Path 1.13 1.14 +3 -3 appdb/admin/adminBugs.php 1.42 1.43 +2 -2 appdb/admin/editAppFamily.php 1.40 1.41 +4 -4 appdb/admin/editAppVersion.php 1.10 1.11 +2 -2 appdb/admin/moveAppVersion.php 1.18 1.19 +3 -3 appdb/include/note.php
Index: appdb/admin/adminBugs.php diff -u -p appdb/admin/adminBugs.php:1.13 appdb/admin/adminBugs.php:1.14 --- appdb/admin/adminBugs.php:1.13 2 Dec 2006 5:10:11 -0000 +++ appdb/admin/adminBugs.php 2 Dec 2006 5:10:11 -0000 @@ -67,7 +67,7 @@ if ($aClean['sSub']) echo '<br />',"\n";
/* display the option to choose how many comments per-page to display */ - echo '<input type=hidden name=iPage value='.$currentPage.'>'; + echo '<input type="hidden" name="iPage" value="'.$currentPage.'" />';
echo '<b>Number of Bug Links per page: </b>'; echo '<select name="iItemsPerPage">'; @@ -76,9 +76,9 @@ if ($aClean['sSub']) foreach($ItemsPerPageArray as $i => $value) { if($ItemsPerPageArray[$i] == $ItemsPerPage) - echo '<option value='.$ItemsPerPageArray[$i].' SELECTED>'.$ItemsPerPageArray[$i],"\n"; + echo '<option value="'.$ItemsPerPageArray[$i].'" selected="selected">'.$ItemsPerPageArray[$i],"\n"; else - echo '<option value='.$ItemsPerPageArray[$i].'>'.$ItemsPerPageArray[$i],"\n"; + echo '<option value="'.$ItemsPerPageArray[$i].'">'.$ItemsPerPageArray[$i],"\n"; } echo '</select>',"\n";
Index: appdb/admin/editAppFamily.php diff -u -p appdb/admin/editAppFamily.php:1.42 appdb/admin/editAppFamily.php:1.43 --- appdb/admin/editAppFamily.php:1.42 2 Dec 2006 5:10:11 -0000 +++ appdb/admin/editAppFamily.php 2 Dec 2006 5:10:11 -0000 @@ -55,7 +55,7 @@ else
// url edit form echo '<form enctype="multipart/form-data" action="editAppFamily.php" method="post">',"\n"; - echo '<input type=hidden name="iAppId" value='.$oApp->iAppId.'>'; + echo '<input type="hidden" name="iAppId" value="'.$oApp->iAppId.'" />'; echo html_frame_start("Edit URL","90%","",0); echo '<table border=0 cellpadding=6 cellspacing=0 width="100%">',"\n";
@@ -77,7 +77,7 @@ else echo '<tr><td class=color3><input type="checkbox" name="'.$temp0.'"></td>',"\n"; echo '<td class=color3><input size=45% type="text" name="'.$temp1.'" value ="'.stripslashes($oRow->description).'"</td>',"\n"; echo '<td class=color3><input size=45% type="text" name="'.$temp2.'" value="'.$oRow->url.'"></td></tr>',"\n"; - echo '<input type=hidden name="'.$temp3.'" value='.$oRow->id.'>'; + echo '<input type="hidden" name="'.$temp3.'" value="'.$oRow->id.'" />'; echo '<input type=hidden name="'.$temp4.'" value="'.stripslashes($oRow->description).'">'; echo '<input type=hidden name="'.$temp5.'" value="'.$oRow->url.'">',"\n"; $i++; Index: appdb/admin/editAppVersion.php diff -u -p appdb/admin/editAppVersion.php:1.40 appdb/admin/editAppVersion.php:1.41 --- appdb/admin/editAppVersion.php:1.40 2 Dec 2006 5:10:11 -0000 +++ appdb/admin/editAppVersion.php 2 Dec 2006 5:10:11 -0000 @@ -47,8 +47,8 @@ if(!empty($aClean['sSubmit']))
// url edit form echo '<form enctype="multipart/form-data" action="editAppVersion.php" method="post">',"\n"; - echo '<input type=hidden name="iAppId" value='.$oVersion->iAppId.'>'; - echo '<input type=hidden name="iVersionId" value='.$oVersion->iVersionId.'>'; + echo '<input type="hidden" name="iAppId" value="'.$oVersion->iAppId.'" />'; + echo '<input type="hidden" name="iVersionId" value="'.$oVersion->iVersionId.'" />'; echo html_frame_start("Edit URL","90%","",0); echo '<table border=0 cellpadding=6 cellspacing=0 width="100%">',"\n";
@@ -96,8 +96,8 @@ if(!empty($aClean['sSubmit'])) { // move version form echo '<form enctype="multipart/form-data" action="moveAppVersion.php" method="post">',"\n"; - echo '<input type=hidden name="iAppId" value='.$oVersion->iAppId.'>'; - echo '<input type=hidden name="iVersionId" value='.$oVersion->iVersionId.'>'; + echo '<input type="hidden" name="iAppId" value="'.$oVersion->iAppId.'" />'; + echo '<input type="hidden" name="iVersionId" value="'.$oVersion->iVersionId.'" />'; echo html_frame_start("Move version to another application","90%","",0); echo '<center><input type="submit" name="sView" value="Move this version"></center>',"\n"; echo html_frame_end(); Index: appdb/admin/moveAppVersion.php diff -u -p appdb/admin/moveAppVersion.php:1.10 appdb/admin/moveAppVersion.php:1.11 --- appdb/admin/moveAppVersion.php:1.10 2 Dec 2006 5:10:11 -0000 +++ appdb/admin/moveAppVersion.php 2 Dec 2006 5:10:11 -0000 @@ -39,8 +39,8 @@ if(!empty($aClean['sAction']))
echo "<form method=post action='moveAppVersion.php'>\n"; echo html_frame_start("Move ".$oApp->sName." ".$oVersion->sName, "90%","",0); - echo '<input type="hidden" name="iAppId" value='.$oVersion->iAppId.' />'; - echo '<input type="hidden" name="iVersionId" value='.$oVersion->iVersionId.' />'; + echo '<input type="hidden" name="iAppId" value="'.$oVersion->iAppId.'" />'; + echo '<input type="hidden" name="iVersionId" value="'.$oVersion->iVersionId.'" />';
/* build a table of applications and their versions */ Index: appdb/include/note.php diff -u -p appdb/include/note.php:1.18 appdb/include/note.php:1.19 --- appdb/include/note.php:1.18 2 Dec 2006 5:10:11 -0000 +++ appdb/include/note.php 2 Dec 2006 5:10:11 -0000 @@ -234,9 +234,9 @@ class Note { echo html_frame_start("Edit Application Note {$aClean['noteId']}", "90%","",0); echo html_table_begin("width='100%' border=0 align=left cellpadding=6 cellspacing=0 class='box-body'");
- echo '<input type="hidden" name="iNoteId" value='.$this->iNoteId.'>'; - echo '<input type="hidden" name="iAppId" value='.$this->iAppId.'>'; - echo '<input type="hidden" name="iVersionId" value='.$this->iVersionId.'>'; + echo '<input type="hidden" name="iNoteId" value="'.$this->iNoteId.'" />'; + echo '<input type="hidden" name="iAppId" value="'.$this->iAppId.'" />'; + echo '<input type="hidden" name="iVersionId" value="'.$this->iVersionId.'" />';
echo '<tr><td class=color1>Title</td>'."\n"; echo ' <td class=color0><input size=80% type="text" name="sNoteTitle" type="text" value="'.$this->sTitle.'"></td></tr>',"\n";