Michael Stefaniuc : mciwave: Simplify the check for an empty string ( PVS-Studio).

[Alexandre Julliard]

Module: wine
Branch: master
Commit: 2ab0bbafe0f8287fd7a77d9dd7cc6daa28d5441a
URL:    http://source.winehq.org/git/wine.git/?a=commit;h=2ab0bbafe0f8287fd7a77d9dd7...

Author: Michael Stefaniuc 
Date:   Wed Nov 12 15:22:05 2014 +0100

mciwave: Simplify the check for an empty string (PVS-Studio).

---

dlls/mciwave/mciwave.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/dlls/mciwave/mciwave.c b/dlls/mciwave/mciwave.c
index 4f24169..c7992fb 100644
--- a/dlls/mciwave/mciwave.c
+++ b/dlls/mciwave/mciwave.c
@@ -444,7 +444,7 @@ static DWORD create_tmp_file(HMMIO* hFile, LPWSTR* pszTmpFileName)

TRACE("%s!\n", debugstr_w(*pszTmpFileName));

-    if (*pszTmpFileName && (strlenW(*pszTmpFileName) > 0)) {
+    if (*pszTmpFileName && (*pszTmpFileName)[0]) {

*hFile = mmioOpenW(*pszTmpFileName, NULL,
                            MMIO_ALLOCBUF | MMIO_READWRITE | MMIO_CREATE);
@@ -470,7 +470,7 @@ static LRESULT WAVE_mciOpenFile(WINE_MCIWAVE* wmw, LPCWSTR filename)
     HeapFree(GetProcessHeap(), 0, wmw->lpFileName);
     wmw->lpFileName = fn;

-    if (strlenW(filename) > 0) {
+    if (filename[0]) {
         /* FIXME : what should be done if wmw->hFile is already != 0, or the driver is playin' */
         TRACE("MCI_OPEN_ELEMENT %s!\n", debugstr_w(filename));