Module: vkd3d Branch: master Commit: 552926cfca64db45e9731f675c65a7214bfa6441 URL: https://gitlab.winehq.org/wine/vkd3d/-/commit/552926cfca64db45e9731f675c65a7...
Author: Giovanni Mascellani gmascellani@codeweavers.com Date: Fri Jan 27 16:45:05 2023 +0100
vkd3d: Do not allow synchronization primitives to fail.
In practice they never fail. If they fail, it means that there is some underlying platform problem and there is little we can do anyway. Under pthreads function prototypes allow returning failure, but that's only used for "error checking" mutexes, which we don't use.
On the other hand, error handling in vkd3d is rather inconsistent: sometimes the errors are ignored, sometimes logged, sometimes passed to the caller. It's hard to handle failures appropriately if you can't even keep your state consistent, so I think it's better to avoid trying, assume that synchronization primitives do not fail and at least have consistent logging if something goes wrong.
---
libs/vkd3d/command.c | 245 +++++++-------------------------------------- libs/vkd3d/device.c | 45 ++------- libs/vkd3d/resource.c | 23 +---- libs/vkd3d/state.c | 39 ++------ libs/vkd3d/utils.c | 21 +--- libs/vkd3d/vkd3d_private.h | 111 ++++++++++++-------- 6 files changed, 129 insertions(+), 355 deletions(-)