Francois Gouget : testbot/bin: HandleBuildNotification() is unused so remove it.

[Alexandre Julliard]

Module: tools
Branch: master
Commit: 72a703d76a4e1d06cdb3f613868ae0fc4dac0437
URL:    http://source.winehq.org/git/tools.git/?a=commit;h=72a703d76a4e1d06cdb3f6138...

Author: Francois Gouget 
Date:   Wed Aug 29 18:34:58 2012 +0200

testbot/bin: HandleBuildNotification() is unused so remove it.

It also depends on the missing XxxRetrieveBuild.pl script anyway.

---

testbot/bin/Engine.pl                    |   32 ------------------------------
 testbot/lib/WineTestBot/Engine/Notify.pm |   19 +----------------
 2 files changed, 1 insertions(+), 50 deletions(-)

diff --git a/testbot/bin/Engine.pl b/testbot/bin/Engine.pl
index 9b57ae6..488c8eb 100755
--- a/testbot/bin/Engine.pl
+++ b/testbot/bin/Engine.pl
@@ -410,34 +410,6 @@ sub HandlePatchRetrieved
   return defined($ErrMessage) ? "0" . $ErrMessage : "1OK";
 }

-sub HandleBuildNotification
-{
-  # Validate build number
-  if ($_[0] !~ m/^(\d+)$/)
-  {
-    return "0Invalid build number";
-  }
-  my $BuildNo = $1;
-
-  $ActiveBackEnds{'WineTestBot'}->PrepareForFork();
-  my $Pid = fork;
-  if (defined($Pid) && ! $Pid)
-  {
-    exec("$BinDir/${ProjectName}RetrieveBuild.pl $BuildNo");
-  }
-  if (defined($Pid) && ! $Pid)
-  {
-    LogMsg "Engine: Unable to exec ${ProjectName}BuildHandler.pl : $!\n";
-    exit;
-  }
-  if (! defined($Pid))
-  {
-    LogMsg "Engine: Unable to fork for ${ProjectName}BuildHandler.pl : $!\n";
-  }
-
-  return "1OK";
-}
-
 sub HandleGetScreenshot
 {
   # Validate VM name
@@ -513,10 +485,6 @@ sub HandleClientCmd
   {
     return HandlePatchRetrieved(@_);
   }
-  if ($Cmd eq "buildnotification")
-  {
-    return HandleBuildNotification(@_);
-  }
   if ($Cmd eq "getscreenshot")
   {
     return HandleGetScreenshot(@_);
diff --git a/testbot/lib/WineTestBot/Engine/Notify.pm b/testbot/lib/WineTestBot/Engine/Notify.pm
index 46cd9cc..e461bb8 100644
--- a/testbot/lib/WineTestBot/Engine/Notify.pm
+++ b/testbot/lib/WineTestBot/Engine/Notify.pm
@@ -36,7 +36,7 @@ require Exporter;
 @EXPORT = qw(&PingEngine &JobSubmit &JobStatusChange &JobCancel &TaskComplete
              &VMStatusChange &ExpectWinetestUpdate &FoundWinetestUpdate
              &NewWinePatchesSubmission &PatchNotification &PatchRetrieved
-             &BuildNotification &GetScreenshot);
+             &GetScreenshot);
 @EXPORT_OK = qw($RunningInEngine);

@@ -249,23 +249,6 @@ sub PatchRetrieved
   return substr($Reply, 1);
 }

-sub BuildNotification
-{
-  my $BuildNo = $_[0];
-
-  my $Reply = SendCmdReceiveReply("buildnotification $BuildNo\n");
-  if (length($Reply) < 1)
-  {
-    return "Unrecognized reply received from engine";
-  }
-  if (substr($Reply, 0, 1) eq "1")
-  {
-    return undef;
-  }
- 
-  return substr($Reply, 1);
-}
-
 sub GetScreenshot
 {
   my $VMName = $_[0];