Hans Leidekker : wininet: Don' t leak the proxy username and password in WININET_SetProxyAuthorization.

[Alexandre Julliard]

Module: wine
Branch: master
Commit: 1126b89360a089b6bd9d72d73e6932edb5cceaa6
URL:    http://source.winehq.org/git/wine.git/?a=commit;h=1126b89360a089b6bd9d72d73e...

Author: Hans Leidekker 
Date:   Thu Jul 23 12:04:59 2009 +0200

wininet: Don't leak the proxy username and password in WININET_SetProxyAuthorization.

---

dlls/wininet/dialogs.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/dlls/wininet/dialogs.c b/dlls/wininet/dialogs.c
index 4a4df92..2235d85 100644
--- a/dlls/wininet/dialogs.c
+++ b/dlls/wininet/dialogs.c
@@ -231,12 +231,14 @@ static BOOL WININET_SetProxyAuthorization( HINTERNET hRequest,
     if( !p )
         goto done;

+    HeapFree(GetProcessHeap(), 0, hIC->lpszProxyUsername);
     hIC->lpszProxyUsername = p;

p = heap_strdupW(password);
     if( !p )
         goto done;

+    HeapFree(GetProcessHeap(), 0, hIC->lpszProxyPassword);
     hIC->lpszProxyPassword = p;

ret = TRUE;