Francois Gouget : testbot/cgi: Simplify link handling in CollectionBlock::GenerateDataCell().

[Alexandre Julliard]

Module: tools
Branch: master
Commit: 819c582b020a2a245228008296d7118872a36984
URL:    https://source.winehq.org/git/tools.git/?a=commit;h=819c582b020a2a2452280082...

Author: Francois Gouget 
Date:   Thu Apr  7 00:31:27 2022 +0200

testbot/cgi: Simplify link handling in CollectionBlock::GenerateDataCell().

Signed-off-by: Francois Gouget 
Signed-off-by: Alexandre Julliard

---

testbot/lib/ObjectModel/CGI/CollectionBlock.pm | 12 +-----------
 1 file changed, 1 insertion(+), 11 deletions(-)

diff --git a/testbot/lib/ObjectModel/CGI/CollectionBlock.pm b/testbot/lib/ObjectModel/CGI/CollectionBlock.pm
index 736c3f8..23825d7 100644
--- a/testbot/lib/ObjectModel/CGI/CollectionBlock.pm
+++ b/testbot/lib/ObjectModel/CGI/CollectionBlock.pm
@@ -278,13 +278,6 @@ sub GenerateDataCell($$$$)
   if ($PropertyDescriptor->GetIsKey() && $DetailsPage)
   {
     $NeedLink = 1;
-  }
-  else
-  {
-    $NeedLink = !1;
-  }
-  if ($NeedLink)
-  {
     my $Query = "$DetailsPage?Key=" . uri_escape($Item->GetKey());
     my ($MasterColNames, $MasterColValues) = $Item->GetMasterCols();
     if (defined($MasterColNames))
@@ -298,10 +291,7 @@ sub GenerateDataCell($$$$)
     print "<a href='", $self->escapeHTML($Query), "'>";
   }
   print $self->GetEscapedDisplayValue($Item, $PropertyDescriptor);
-  if ($NeedLink)
-  {
-    print "</a>";
-  }
+  print "</a>" if ($NeedLink);
   print "</td>\n";
 }