wine-devel June 2006

wine-devel@winehq.org

174 participants
352 discussions

Re: notepad: settings saving code
by Robert Shearman 09 Jun '06

09 Jun '06

Anoni Moose wrote: >/* This table is used to save all of the needed font settings in Notepad. > * It looks quite messy, when in fact it _hugely_ eases loading/setting of settings. Really. ;) > * It is layed out as follows: > * > * [n][0] == pointer to registry subkey name (WCHAR) > * [n][1] == type of registry entry > * [n][2] == pointer to buffer to store setting > * [n][3] == size of data returned > * [n][4] == default value to use if subkey was not found > * [n][5] == registry path to open (ANSI, not including root (HKEY_CURRENT_USER, etc)) > */ >DWORD settings_data[15][6] = { > { (DWORD)&heightW, REG_DWORD, (DWORD)&Globals.lfFont.lfHeight, > sizeof(REG_DWORD), -10, (DWORD)&FONT_SETTINGS_REG_PATH }, > > You should define a proper structure to put this data in rather than casting the values to DWORD (which won't work in 64-bit mode). -- Rob Shearman

1 0

Re: regedit: bug fixes/feature
by Robert Shearman 09 Jun '06

09 Jun '06

Anoni Moose wrote: > These patches save current node on click, and remove items before > opening keys, so if a node has no keys/is invalid, no keys show, which > can lead to problems. Changelog: > > * programs/regedit/main.c, programs/regedit/childwnd.c: > regedit: Save current node to registry on change; load again after > regedit is reopened. > -Don't UpdateWindow() in InitInstance() (unneeded, adds > flicker). > -Delete all items from listview before opening key, so if > key open fails, no items display. > This patch looks good, but I'm not sure about removing the UpdateWindow call. I think it is still necessary, although it might be better to move it to after the getting of the default path, which should remove the flicker. -- Rob Shearman

1 0

Re: regedit: Refresh also refresh registry keys in listview
by James Hawkins 09 Jun '06

09 Jun '06

On 6/8/06, Anoni Moose <moose.anoni(a)gmail.com> wrote: > These patches allow for refreshing of registry keys in listview, when > Refresh menu item is selected. > > Changelog: > > * programs/regedit/framewnd.c, programs/regedit/treeview.c: > regedit: Uncomment RefreshListView() call, comment TVM_SELECTITEM call, > to > let "Refresh" menu item/key also refresh registry values being > shown > in treeview. > One patch per email please. Same goes for all your other submissions. -- James Hawkins

1 0

Re: edit: Fix crashing, bugs
by James Hawkins 09 Jun '06

09 Jun '06

On 6/8/06, Anoni Moose <moose.anoni(a)gmail.com> wrote: > This patch fix an unhandled page fault with MS notepad and Wine Notepad when > loading/editing large files, and some other bugs shown in the Changelog: > > * dlls/user/edit.c: > user: Fixed unhandled page-fault when text length exceeded buffer size. > -Don't gradually continue to highlight text if mouse button is > held in and > it's position moves out of the edit window, and doesn't move while > outside. > -Scroll up/down if mouse is outside of window and moving up/down. > -If a button was clicked in a dialog, therefore setting the focus > to it, and then > an application sent a SETFOCUS message to an editbox, it would > keep the focus on > the button. > You need to submit one fix per patch, one patch per email. -- James Hawkins

1 0

Re: str*casecmpW functions
by Vitaliy Margolen 09 Jun '06

09 Jun '06

Thursday, June 8, 2006, 6:57:36 PM, Anoni Moose wrote: > This patch adds some functions for comparison of WCHAR strings, while ignoring case. Changelog: > * libs/unicode/string.c: > unicode: Added strcasecmpW, strncasecmpW functions. BTW what's wrong with strncmpiW? Vitaliy Margolen

1 0

Re: server: use getopt
by Mike McCormack 09 Jun '06

09 Jun '06

Anoni Moose wrote: > This patch let's the server code use getopt to parse arguments. + while ((optchr = getopt(argc, argv, "d:fhk:p:vw")) != -1 && + optind < argc) { /* 'Tis possible we might have a variable declaration... */ + + switch (optchr) { + case 'd': - if (isdigit(argv[i][2])) debug_level = atoi( argv[i] + 2 ); + if (isdigit(optarg[0])) debug_level = atoi( optarg ); else debug_level++; break; Using getopt() doesn't really gain us anything here. Also, changing the indent and brace style to suit yourself (especially in wineserver) isn't appreciated. Mike

1 0

Re: wcmd: some features/bug fixes
by Mike McCormack 09 Jun '06

09 Jun '06

Anoni Moose wrote: > * programs/wcmd/builtins.c, programs/wcmd/wcmdmain.c, > programs/wcmd/wcmd.h: > wcmd: Clear terminal screen using escape code. > -Fix infinite file-read loop with TYPE command. > -TITLE command use terminal escape code. > -Added FREEDISK command. Please send one patch per email. The patch should be standalone. + /* Clear the _terminal_ screen by giving the correct terminal escape code. */ + printf("%cc", 0x1B); You can't assume that you'll be using any sort of terminal here. If the backend is wineconsole or a non-xterm/vt100 terminal, then this won't work. You have to use the Win32 API. Mike

1 0

Re: str*casecmpW functions
by Mike McCormack 09 Jun '06

09 Jun '06

Anoni Moose wrote: > * libs/unicode/string.c: > unicode: Added strcasecmpW, strncasecmpW functions. You've added a dependency on user32.tolowerW, which cannot be linked from all the places that unicode.h is used. Mike

1 0

Re: notepad: settings saving code
by Mike McCormack 09 Jun '06

09 Jun '06

Anoni Moose wrote: > The following files allow saving and loading of notepad's settings to > the registry. No patch needed... new files. Changelog: Always send a patch, and make sure to create it from your wine/ directory so that the full path of the file that you're modifying is specified. These files won't be compiled unless you add something to the Makefile.in, and can't be used without some kind of change to the existing code. Mike

1 0

xlldrv/keyboard.c: Report of typos
by Andrew Talbot 09 Jun '06

09 Jun '06

I believe there are numerous typos in this file. Starting at line 310, there seem to be several missing double quotes; they break compilation if -Wwrite-strings is specified. I was going to assume the missing quotes to be the only factor and fix things myself. But as there are some non-printing characters in there that I don't understand, I thought I would mention it here, instead, so that someone who knows about keyboard layouts might fix these arrays properly. -- Andy.

3 3

← Newer
1
...
23
24
25
26
27
28
29
...
36
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-devel June 2006