wine-devel November 2007

wine-devel@winehq.org

117 participants
275 discussions

Re: msxml: Implement cloneNode and correct insertBefore
by James Hawkins 14 Nov '07

14 Nov '07

On 11/12/07, Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> wrote: > Hi, > > Changelog: > InsertBefore is allowed to have outNewChild as NULL > Implement cloneNode > One fix per patch please. Also, please add tests for these fixes. > Best Regards > Alistair Leslie-Hughes > > diff --git a/dlls/msxml3/node.c b/dlls/msxml3/node.c > index 61d5ab2..86d7614 100644 > --- a/dlls/msxml3/node.c > +++ b/dlls/msxml3/node.c > @@ -373,7 +373,7 @@ static HRESULT WINAPI xmlnode_insertBefore( > > TRACE("(%p)->(%p,var,%p)\n",This,newChild,outNewChild); > > - if (!(newChild && outNewChild)) > + if (!newChild) > return E_INVALIDARG; > > switch(V_VT(&refChild)) > @@ -412,9 +412,13 @@ static HRESULT WINAPI xmlnode_insertBefore( > xmlAddChild(This->node, new_child_node); > } > > - IXMLDOMNode_Release(new); > IXMLDOMNode_AddRef(newChild); > - *outNewChild = newChild; > + IXMLDOMNode_Release(new); > + if(outNewChild) > + { > + *outNewChild = newChild; > + } > + > TRACE("ret S_OK\n"); > return S_OK; > } > @@ -517,8 +521,36 @@ static HRESULT WINAPI xmlnode_cloneNode( > VARIANT_BOOL deep, > IXMLDOMNode** cloneRoot) > { > - FIXME("\n"); > - return E_NOTIMPL; > + xmlnode *This = impl_from_IXMLDOMNode( iface ); > + xmlNodePtr pClone = NULL; > + IXMLDOMNode *pNode = NULL; > + > + TRACE("%p (%d)\n", This, deep); > + > + if(!cloneRoot) > + return E_INVALIDARG; > + > + pClone = xmlCopyNode(This->node, deep ? 1 : 0); > + if(pClone) > + { > + pClone->doc = This->node->doc; > + > + pNode = create_node(pClone); > + if(!pNode) > + { > + ERR("Copy failed\n"); > + return E_FAIL; > + } > + > + *cloneRoot = pNode; > + } > + else > + { > + ERR("Copy failed\n"); > + return E_FAIL; > + } > + > + return S_OK; > } > > static HRESULT WINAPI xmlnode_get_nodeTypeString( > @@ -832,7 +864,7 @@ static ULONG WINAPI Internal_Release( > if ( ref == 0 ) > { > if( This->node ) > - xmldoc_release( This->node->doc ); > + xmldoc_release( This->node->doc ); > Please don't make random whitespace changes. -- James Hawkins

1 0

svchost Patch Question
by Roy Shea 13 Nov '07

13 Nov '07

Howdy, I'm looking for advice on how to clean up the implementation of svchost. The latest version is available at: http://www.winehq.org/pipermail/wine-patches/2007-November/046467.html If the stopper for this patch is the lack of a DLL using it, I can resend svchost later this week when I have a stub implementation of BITS using svchost ready. Thanks for any pointers! -Roy

2 1

xrun handling in winealsa.drv
by Timofei V. Bondarenko 13 Nov '07

13 Nov '07

Hi. I've noticed the winealsa does not handle alsa XRUNs. In the case of XRUN application hangs. That's happened because return value of snd_pcm_avail_update() is not checked. For example: wavein.c 175 DWORD bytes; 180 /* read all the fragments accumulated so far */ 181 frames = snd_pcm_avail_update(wwi->pcm); 182 bytes = snd_pcm_frames_to_bytes(wwi->pcm, frames); waveout.c 476 DWORD availInQ; 479 availInQ = snd_pcm_avail_update(wwo->pcm); 482 if (availInQ > 0) { The snd_pcm_avail_update() returns a _signed_ type and it really does return negative number -EPIPE in the case of XRUN. More over, any return value of less than period_size may indicate XRUN state too. The snd_pcm_state() may help then. Th dsoutput.c and dscapture.c do exactly the same wrong thigs. BTW, using DWORD type causes problems. Following fragment is from wavein.c too: 177 DWORD read; 181 frames = snd_pcm_avail_update(wwi->pcm); 182 bytes = snd_pcm_frames_to_bytes(wwi->pcm, frames); 193 read = wwi->read(wwi->pcm, lpWaveHdr->lpData + 194 bytesRead = snd_pcm_frames_to_bytes(wwi->pcm, 197 if (bytesRead != (DWORD) -1) This is obviously will not work as expected. I hope someone will fix these issues :) Regards, Tim.

3 5

Grumble. Lost the Valgrind magic.
by Dan Kegel 13 Nov '07

13 Nov '07

I had to reinstall my main valgrind testing machine (I foolishly ran the vmware server install script, and it nuked my wireless), and since then, valgrind isn't giving me stack traces. I guess something's wrong in my recipe, but I'm not sure what, the vg-3.2.3 patch is being applied. Sigh. Is anybody else having luck building a valgrind that gives good stack traces for wine?

2 1

Re: rpcrt4: Implement RpcCancelThread for the ncacn_ip_tcp protocol sequence.
by Hans Leidekker 12 Nov '07

12 Nov '07

On Monday 12 November 2007 21:10:19 Robert Shearman wrote: > +static CRITICAL_SECTION_DEBUG threaddata_cs_debug = > +{ > + 0, 0, &uuid_cs, I smell a copy/paste artifact ;) -Hans

1 0

Too many WM_MOUSEACTIVATE
by Peter Åstrand 12 Nov '07

12 Nov '07

I have lot's of problems with WM_MOUSEACTIVATE messages in "Magna Cura". The effekt is that certain popup dialog doesn't work: After selecting something, say a date, the whole "form" is cleared. After much debugging, I've found out that WM_MOUSEACTIVATE is the problem. If I explicitly stop WM_MOUSEACTIVATE from propagating from dialogs to parents, then things works OK. I do this by addding: case WM_MOUSEACTIVATE: return MA_ACTIVATE; in DefDlgProc{A,W}. I wonder how many things that will brake with a change like this.... Just a long shot, but has anyone else seen anything similiar to this? (It turns out that there are multiple differences compared to Windows; one with two many messages generated when the popup is created, another with too few messages when changing tab in a SysTabControl32 (but zero messages works fine as well.) Rgds, --- Peter Åstrand ThinLinc Chief Developer Cendio AB http://www.cendio.se Wallenbergs gata 4 583 30 Linköping Phone: +46-13-21 46 00 ThinLinc User Group 2007 Höstkonferens --- 15-16 november, Linköping. Program och anmälan: http://www.thinlincusergroup.se/aktiviteter

1 0

Problem with wine + Dreamweaver + VNC
by Francisco José Gallego Durán 12 Nov '07

12 Nov '07

Hello, I am trying to run Dreamweaver.exe and Photoshop.exe in a remote gnome-session through vnc4server. When I try to run it I get the following message: Xlib: extension "XFree86-DRI" missing on display ": 3.0". X Error of failed request: BadValue (integer parameter out of range for operation) Major opcode of failed request: 148 (GLX) Minor opcode of failed request: 3 (X_GLXCreateContext) Value in failed request: 0x24 Serial number of failed request: 11 Current serial number in output stream: 12 Might it be a kind of a bug? I am running wine 0.9.49, Debian etch with latest updates, and vnc4server. Thank you for your help. Francisco Gallego.

1 0

Re: wininet: update test to pass on newer versions of windows
by Alexandre Julliard 12 Nov '07

12 Nov '07

"Lei Zhang" <thestig(a)google.com> writes: > + > + /* sz is 14 on XP SP1 and beyond, 30 on XP and before */ > + todo_wine ok( sz == 14, "sz wrong\n"); The tests have to pass on all Windows versions. If some return 30 and some return 14 the test must accept both. -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: widl [2/9]: Add an option to use Wine exception handlers.
by Alexandre Julliard 12 Nov '07

12 Nov '07

Dan Hipschman <dsh(a)linux.ucla.edu> writes: > This patch adds a --wine-seh option to widl to use Wine's SEH instead of > the Windows one. This should not be a widl option. widl should generate a single version of the C code that works on all compilers, using appropriate macros and #ifdefs. Also you shouldn't use the wine/exception.h macros, since you are generating the code you can output the code directly, in a much more straightforward way than the convoluted __TRY macros. -- Alexandre Julliard julliard(a)winehq.org

1 0

How can we handle undcomented shell functionsAW, that MS declared now (WSTR version only)
by Detlef Riekenberg 12 Nov '07

12 Nov '07

Hi There are a some undocumented Functions in shell32, which have one entrypoint that use STR in win9x, but WSTR in NT: - dlls/shell32/undocshell.h - http://www.geocities.com/SiliconValley/4942/paths.html Some of them are now declared without A/W suffix (include/shobj.h from SDK 2003), but since win9x is no longer supported by MS, it's only for the Wide version. Examples: PathProcessCommend, PathResolve, PathQualify Question for include/shlobj.h: What is the correct way to declare such functions? In undocshell.h, we use functionAW with LPVOID for the first two, but for PathQualify, we use: // BOOL WINAPI PathQualifyA(LPCSTR path); BOOL WINAPI PathQualifyW(LPCWSTR path); #define PathQualify WINELIB_NAME_AW(PathQualify) BOOL WINAPI PathQualifyAW(LPCVOID path); // And PathResolve in exported by name (see shell32.spec) ############################################################# Next question for shell32.spec: Are we fixed to "ptr" for such functions? ("str", "wstr" and "long" are all used and need to be fixed) Is it possible / useful to add support for "awstr" (or a similar name)? What about support for UNICODE-Strings ("ustr")? -- By by ... Detlef

2 1

← Newer
1
...
16
17
18
19
20
21
22
...
28
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-devel November 2007