wine-devel November 2007

wine-devel@winehq.org

117 participants
275 discussions

Bugs in dlls/wsock32/socket.c
by Gerald Pfeifer 08 Nov '07

08 Nov '07

dlls/wsock32/socket.c has the following code: DWORD routeTableSize, numRoutes, ndx, ret; numRoutes = min(routeTableSize - sizeof(MIB_IPFORWARDTABLE), 0) / sizeof(MIB_IPFORWARDROW) + 1; The problem here is that both routeTableSize and sizeof(...) are of an unsigned type, so their difference is also unsigned. Which means that the minimum between that difference and 0 always will be 0, the result of the division will thus always be zero, and the result of the entire expressions is a constant 1. I have a hunch this is not the intendend purpose of this code, is it? Gerald -- Gerald (Jerry) Pfeifer gerald(a)pfeifer.com http://www.pfeifer.com/gerald/

2 2

Re: #winehq admin troubles
by feba thatl 08 Nov '07

08 Nov '07

Tom, you can try to guilt me, but I don't care. There are two sides to this. Either you think that #winehq is a support channel for end users, and should if not cater to them, at least treat them with some respect until they've proved that they deserve none, or you think that #winehq is a channel where people can go for help if some one with an @ isn't in a mood to ban them. If you can honestly say that you fully agree with the latter, and would have no problem getting banned from a random channel when you were seeking help, I don't know what to tell you. If, however, you think the first thing, we're on the same side. I don't think anyone here doesn't want to see #winehq, and the entire project really, become a better place. There might be one or two people exploiting this for personal reasons, but I cannot control that. I posted this in the hopes that #winehq would be made a better place, not for me, but for everyone. Including vitamin and the rest of the ops. I have a question for you, what offends you so much about my comments that you are not only refusing to help me, but also trying to pin me with the blame for your refusal to help others? Is it because you feel that your experience with wine gives you to the right to mistreat users, or because you are offended by what a few other people said in a thread that I started? Do you not want #winehq to be a better place? Or do you not realize the actual point of what I'm saying?

1 0

Re: svchost: Implementation of svchost
by Robert Shearman 08 Nov '07

08 Nov '07

Roy Shea wrote: > Changelog: > * Implementation of svchost > You've got a lot of global functions in this patch that should be static. -- Rob Shearman

1 0

Re: wininet: Fully initialize a variable
by Alexandre Julliard 08 Nov '07

08 Nov '07

"Juan Lang" <juan.lang(a)gmail.com> writes: > static void COOKIE_crackUrlSimple(LPCWSTR lpszUrl, LPWSTR hostName, int hostNameLen, LPWSTR path, int pathLen) > { > - URL_COMPONENTSW UrlComponents; > + URL_COMPONENTSW UrlComponents = { 0 }; > > - UrlComponents.lpszExtraInfo = NULL; > - UrlComponents.lpszPassword = NULL; > - UrlComponents.lpszScheme = NULL; > UrlComponents.lpszUrlPath = path; > - UrlComponents.lpszUserName = NULL; > UrlComponents.lpszHostName = hostName; > UrlComponents.dwHostNameLength = hostNameLen; > UrlComponents.dwUrlPathLength = pathLen; Please avoid that unportable array initialization syntax, and since the code is already explicitly setting the fields you should simply add the ones that are needed and missing. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: wininet: initialize a buffer
by Alexandre Julliard 08 Nov '07

08 Nov '07

"Lei Zhang" <thestig(a)google.com> writes: > Valgrind is complaining we are doing strcmp() on the buffer without > initializing it. You should fix the code to not do the strcmp when we don't have a valid buffer, instead of hiding the bug by clearing memory. -- Alexandre Julliard julliard(a)winehq.org

1 0

Wine LivePC
by T.J. Purtell 07 Nov '07

07 Nov '07

Hey, I've build a Wine LivePC so that people can take a linux operating system capable of running Windows programs on a USB drive. Its great for carrying a portable work environment with you, providing a container for safely running executables you download from the internet, or making an isolated environment for a family member that they can carry with them. http://www.moka5.com/node/1620 Obviously the LivePC is free, but registration on the site is required to download the free engine for using LivePC (Its based off VMware player). It has the latest version of Wine, so using this is an easy way to check if a particular application is well supported in Wine. Cheers, -T.J.

1 0

valgrind results for Oct 7
by Dan Kegel 07 Nov '07

07 Nov '07

This time I filtered out files whose only error was trying to close(-1). http://kegel.com/wine/valgrind/20071107/ Quite a few tests no longer show problems (partly because of the new filtering): comctl32/imagelist crypt32/oid crypt32/store d3d9/visual kernel32/console msi/package oleaut32/vartest rpcrt4/server shell32/shlfileop That leaves 75 tests with problems. - Dan -- Wine for Windows ISVs: http://kegel.com/wine/isv

1 0

Re: advapi32: fix buffer overrun in tests/registry.c:wine_debugstr_wn(), try 3
by Alexandre Julliard 07 Nov '07

07 Nov '07

"Dan Kegel" <dank(a)kegel.com> writes: > Fixes an off-by-one buffer overflow in wine_debugstr_wn() > in which the wchar after the end of the buffer was read. > > This is same as try 2, but is slightly clearer and more correct. > > Found via Valgrind warning: > Conditional jump or move depends on uninitialised value(s) > at 0x45F3219: wine_debugstr_wn (registry.c:151) > by 0x45F34F5: test_hkey_main_Value_W (registry.c:284) > by 0x45F7644: func_registry (registry.c:327) > by 0x460A127: run_test (test.h:387) > > Alexandre, if you don't like this 'un, please tell me why. That function is really supposed to print n chars, not n-1. The terminating null probably needs to be included in the length. -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: ntdll: Architecture may be '*' in lookup_manifest_file so don't rely on the first '*' of the format indiacting where the version number is.
by Alexandre Julliard 07 Nov '07

07 Nov '07

Robert Shearman <rob(a)codeweavers.com> writes: > Instead use the underscores that separate the string fields. Of course the assembly name can contain underscores too... I think that the whole idea of checking the version number from the file name is flawed. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [10/14] WineD3D: Implement the varying map
by Allan Tong 07 Nov '07

07 Nov '07

On 11/6/07, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > + /* Don't do any register mapping magic if it is not needed, or if we can't > + * achive anything anyway > + */ > + if(highest_reg_used < (GL_LIMITS(glsl_varyings) / 4) || > + num_regs_used >= (GL_LIMITS(glsl_varyings) / 4) ) { > + if(num_regs_used >= (GL_LIMITS(glsl_varyings) / 4)) { Should it not be "num_regs_used > (GL_LIMITS(glsl_varyings) / 4)"? - Allan

2 2

← Newer
1
...
20
21
22
23
24
25
26
27
28
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-devel November 2007