wine-devel January 2008

wine-devel@winehq.org

126 participants
290 discussions

Good source for msvcr71?
by Dan Kegel 15 Jan '08

15 Jan '08

I finally ran into an app that wanted msvcr71 but didn't bundle it (supercopyright). After a few minutes of looking, I couldn't find it anywhere on microsoft.com. The best source I could find was the installer for spambayes 1.1, but that's inconvenient. Anyone know a better source, preferably at microsoft.com? I'd like to add it to winetricks. Thanks, Dan

3 4

Re: [advapi32] QueryServiceConfig2 (2nd try)
by Alexandre Julliard 15 Jan '08

15 Jan '08

Stefan Leichter <Stefan.Leichter(a)camline.com> writes: > + * Note > + * observed unter win2k: > + * 1. when the function is called to get the required buffer size, the value of > + * the returned parameter needed is big enough to hold the strings as WCHARs(!) It's not WCHARs, it's two A chars per W char to leave enough room for the conversion. I don't see you doing that in the code. > + case SERVICE_CONFIG_DESCRIPTION: > + { LPSERVICE_DESCRIPTIONA configA = (LPSERVICE_DESCRIPTIONA) buffer; > + LPSERVICE_DESCRIPTIONW configW = (LPSERVICE_DESCRIPTIONW) bufferW; > + *needed = sizeof(SERVICE_DESCRIPTIONA); > + if (configW->lpDescription) { > + DWORD sz; > + configA->lpDescription = (LPSTR)(configA + 1); > + sz = WideCharToMultiByte( CP_ACP, 0, configW->lpDescription, -1, > + configA->lpDescription, size - sizeof(SERVICE_DESCRIPTIONA), NULL, NULL ); > + if (!sz) { > + FIXME("WideCharToMultiByte failed for configW->lpDescription\n"); > + ret = FALSE; > + configA->lpDescription = NULL; > + goto cleanup; You need to update the needed size on buffer overflow. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [take 2] shell32: Check if token references the current user
by Alexandre Julliard 15 Jan '08

15 Jan '08

ge(a)gse.nl writes: > Incorporates feedback by Juan Lang > > Changelog: > Ge van Geldorp <ge(a)thinstall.com> Please either put your full name in the mail headers, or include the full git headers in the body of your message, so that my commit script can grab your name and email automatically. > @@ -1382,14 +1476,15 @@ static HRESULT _SHGetUserProfilePath(HANDLE hToken, DWORD dwFlags, BYTE folder, > return E_INVALIDARG; > > /* Only the current user and the default user are supported right now > - * I'm afraid. > + * I'm afraid. We do handle the case where the token references the > + * current user. > * FIXME: should be able to call GetTokenInformation on the token, > * then call ConvertSidToStringSidW on it to get the user prefix. > * But Wine's registry doesn't store user info by sid, it stores it > * by user name (and I don't know how to convert from a token to a > * user name). This comment is obsolete, we store the registry by sid now, so this is what you should use to open the user's key. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: gdi32: Do not allow to create too large device dependent bitmaps like Windows does
by Robert Shearman 15 Jan '08

15 Jan '08

Dmitry Timoshkov wrote: > + SetLastError(0xdeadbeef); > + hbmp = CreateBitmap(0x7ffffff, 9, 1, 1, NULL); > + ok(!hbmp, "CreateBitmap should fail\n"); > + ok(GetLastError() == ERROR_NOT_ENOUGH_MEMORY, > + "expected ERROR_INVALID_PARAMETER, got %u\n", GetLastError()); > The string here doesn't match the test. -- Rob Shearman

1 0

Re: user32, wined3d: move refresh rate fallback to catch all cases (resend)
by Dmitry Timoshkov 15 Jan '08

15 Jan '08

"Erik Inge Bolsø" <knan-wine(a)anduin.net> wrote: > If requesting a refresh rate that isn't available, but a better one is, > ChangeDisplaySettings fails and some games fail to launch. This does > not seem to match WinXP behaviour with the same graphics card + lcd > monitor combination. If that's not what Windows does then this patch can't be accepted. In any case a test case showing Windows behaviour is required. -- Dmitry.

2 4

Re: [PATCH] check for array index overflows
by H. Verbeet 15 Jan '08

15 Jan '08

On 14/01/2008, Marcus Meissner <marcus(a)jet.franken.de> wrote: > Hi, > > This checks for overflowing the fixed size arrays. > > spotted by Coverity. > > (Submitted some months ago already, but left in my queue.) > > Ciao, Marcus > --- IIRC last time we tested this it was allowed on Windows, and simply causes memory corruption. If we want to prevent this, we should probably just return WINED3D_OK.

2 1

Re: [hlink] Skip tests if hlink couldn't be created
by Robert Shearman 14 Jan '08

14 Jan '08

Dan Kegel wrote: > This makes the test slightly more robust to operator error. > If we're striving to get zero test failures then converting a crash to some failures isn't really much of an improvement. -- Rob Shearman

2 1

Re: [PATCH] check for This->frame
by Jacek Caban 14 Jan '08

14 Jan '08

Hi Marcus, Marcus Meissner wrote: > Hi, > > Coverity 645 spotted missing This->frame > checks. > > Ciao, Marcus > --- > dlls/mshtml/olecmd.c | 5 +++-- > 1 files changed, 3 insertions(+), 2 deletions(-) > > diff --git a/dlls/mshtml/olecmd.c b/dlls/mshtml/olecmd.c > index 326b0b0..02b5e83 100644 > --- a/dlls/mshtml/olecmd.c > +++ b/dlls/mshtml/olecmd.c > @@ -621,7 +621,7 @@ static HRESULT exec_editmode(HTMLDocument *This, DWORD cmdexecopt, VARIANT *in, > if(This->hostui) > IDocHostUIHandler_HideUI(This->hostui); > > - if(This->hostui) > + if(This->hostui && This->frame) > IDocHostUIHandler_ShowUI(This->hostui, DOCHOSTUITYPE_AUTHOR, ACTOBJ(This), CMDTARGET(This), > This->frame, This->ip_window); > There is no reason to test This->frame here (unless you have tested that native MSHTML doesn't call ShowUI with NULL frame). Coverity spotted an other bug, which you've fixed in other part of the patch. Thanks, Jacek

1 0

Improving Default Serial Port Configuration
by Forrest Samuels 14 Jan '08

14 Jan '08

I am looking to fix a bug causing serial ports to not show up in some applications. The problem is due to missing registry entries for the serial ports. I know what entries need to be created but I don't think they should go in wine.inf. They should get created dynamically, preferably on each run, based on what currently exists in .wine/dosdevices/ The bug I am working on is 9902 (http://bugs.winehq.org/show_bug.cgi?id=9902). Does anyone have any insight on where I should start looking to implement this? Implementation suggestions? In the bug, Juan Lang made the suggestion that "Explorer's hal.c should be extended to create new devices for all the ports it finds, using SetupDiCreateDeviceInfo followed by SetupDiRegisterDeviceInfo. For some devices it should also call SetupDiCreateDeviceInterface to register a particular interface." I've looked in programs/explorer/hal.c and I am not sure where to begin hooking something like that in. It was also suggested in #winehackers that this could go in the same place that other hardware like disk drives are detected and configured. I am not sure where that would be either or if that is the same as hal.c. I am new to wine development to please feel free to over explain. Thanks, -- Forrest Samuels (forrest(a)alumni.ncsu.edu)

3 4

WineD3D Spelling Fixes
by Austin English 14 Jan '08

14 Jan '08

Any reason this patch wasn't applied? I didn't see any feedback on wine-patches. http://www.winehq.org/pipermail/wine-patches/2008-January/048933.html -Austin

1 0

← Newer
1
...
12
13
14
15
16
17
18
...
29
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-devel January 2008