wine-devel August 2008

wine-devel@winehq.org

124 participants
304 discussions

re: msvcrt: Don't depend on the system's implementation of acos () & asin().
by Dan Kegel 29 Aug '08

29 Aug '08

Henri wrote: > glibc implements acos() as the FPU equivalent of atan2(sqrt(1 - x ^ 2), x). I just looked, and there are several implementations of acos in glibc, and they all seem to very carefully choose how to do it based on how close x is to 1. > This should be fixed on the glibc side as well Indeed. Have you filed a bug report against glibc yet? I didn't see one at http://sourceware.org/bugzilla/ Please be sure to attach a simple C program that reproduces the problem, or better yet, a patch to add a test case to their test suite.

3 5

Re: [4/4] gdiplus: stub for GdipFlattenPath with tests
by Alexandre Julliard 29 Aug '08

29 Aug '08

Nikolay Sivov <bunglehead(a)gmail.com> writes: > Changelog: > - stub for GdipFlattenPath with tests This fails here: ../../../tools/runtest -q -P wine -M gdiplus.dll -T ../../.. -p gdiplus_test.exe.so graphicspath.c && touch graphicspath.ok graphicspath.c:117: Test succeeded inside todo block: Expected #0: PathPointTypeStart (100.0,25.0) but got PathPointTypeStart (100.0,25.0) graphicspath.c:117: Test succeeded inside todo block: Expected #0: PathPointTypeStart (100.0,25.0) but got PathPointTypeStart (100.0,25.0) make[2]: *** [graphicspath.ok] Error 2 -- Alexandre Julliard julliard(a)winehq.org

2 3

Re: kernel32/winerror [try 3]: Add Russian translation
by Vitaliy Margolen 29 Aug '08

29 Aug '08

Vladimir Pankratov wrote: > Dear Vitaliy. > You wrote: >> The character encoding is wrong. The patch using cp866 while it should be >> cp1251. > > Yes, I know. But I can't understand that: > If I using cp1251, see wrong_codepage.jpg > else cp866, see right_codepage.jpg. > > Please explain. > > Thank you. > > Good question - everything looks right to me. Could it be just a problem with wmc? Vitaliy.

1 0

Re: [advapi32] GetNamedSecurityInfo patch
by Nikolay Sivov 29 Aug '08

29 Aug '08

Fenixk19 wrote: > + PSECURITY_DESCRIPTOR local_descriptor; > + if(!descriptor) > + descriptor = &local_descriptor; Why do you try to return anything if a caller doesn't request it passing NULL?

1 0

Implementing textures functions of d3dx using an extern library.
by Jérôme Gardou 29 Aug '08

29 Aug '08

D3DX supports a wide range of file types for textures. Instead of rewriting everything from scratch, the best would certainly be to use some image processing library to handle them. As a bonus, this would allow lighter code. Some of those library are : SDL_Image : easy to use, but loading an image using a SDL_Surface is quite heavy. Moreover, the files supported are not enough for d3dx. MagickWand/MagickCore, the libraries on which imagemagick is based : Hard to use, and very heavy. Supports every format thet d3dx supports. FreeImage : Quite easy to use, the only files not supported are DIB and PFM... Not so widely represented. I had to recompile it, as packages for it are not available for 32 bits. (I use a 64 bits ubuntu system). Here is an implementation of D3DXGetImageInfoFromFileInMemory using FreeImage. Suggestions and comments are welcomed. PS : Please CC me your potential answers, as I'm not a subscriber of this list.

3 8

Re: ntdll: modify NtDeleteFile to fail on directories (try 2)
by Vincent Povirk 29 Aug '08

29 Aug '08

You should add a test that shows that NtDeleteFile fails in this case. Vincent Povirk On Thu, Aug 28, 2008 at 7:40 PM, Jeff Zaroyko <jeffzaroyko(a)gmail.com> wrote: > > > > >

1 0

Re: ntdll/file.c: Allow to TRACE NtCreateFile return
by Dmitry Timoshkov 29 Aug '08

29 Aug '08

"Markus Hitter" <mah(a)jump-ing.de> wrote: > Providing the file handle allows to map > read/write requests to the corresponding file name. As pointed out by Alexander, you can use an appropriate debug channel for that, +relay or +server. There is no need to pollute the source with additional traces. -- Dmitry.

5 8

Re: cryptuiapi(2/2): Document definitions missing from cryptuiapi.h
by Alexandre Julliard 29 Aug '08

29 Aug '08

"Juan Lang" <juan.lang(a)gmail.com> writes: > +/* Definitions missing from PSDK's cryptuiapi.h, but documented on MSDN. */ If they are on MSDN then it's OK to put them in the header, they will most likely end up there in a future PSDK version. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: Fix for rendering issues when calling GetDepthStencilSurface
by Alexander Dorofeyev 29 Aug '08

29 Aug '08

Any reason this isn't tested? I don't know about this function in particular, but there have been games that were confused by NOT clearing output to NULL on error (not in GetDepthStencilSurface though). Also regardless of setting or not-setting to NULL, the warning may have its uses when reading +d3d log in the process of debugging something. Andrew Fenn wrote: > When IWineD3DDevice_GetDepthStencilSurface returns WINED3DERR_NOTFOUND > it was setting ppZStencilSurface to null. This was the cause of > rendering issues with the 3d models in spore. >

1 0

RE: Spore patch to fix UI and Part descriptions
by Stefan Dösinger 29 Aug '08

29 Aug '08

These changes may be correct, but they need a test. Take a look at dlls/d3d9/tests/device.c to see how the other tests look. I guess the changes are likely to be correct, but they have to be tested

4 3

← Newer
1
2
3
4
5
6
7
...
31
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-devel August 2008