On Sat, Apr 25, 2009 at 9:55 AM, Hib Eris <Hib(a)hiberis.nl> wrote:
> This patch adds a check for the type of INT columns in msi database tables.
>
>
> ---
> dlls/msi/tests/db.c | 5 ++++-
> 1 files changed, 4 insertions(+), 1 deletions(-)
>
>
>
>
Howdy Hib,
You need to wrap failing tests in todo_wine, e.g., for your patch:
diff --git a/dlls/msi/tests/db.c b/dlls/msi/tests/db.c
index b2c7d06..cf74070 100644
--- a/dlls/msi/tests/db.c
+++ b/dlls/msi/tests/db.c
@@ -1128,7 +1128,7 @@ static void test_viewgetcolumninfo(void)
r = run_query( hdb, 0,
"CREATE TABLE `Properties` "
- "( `Property` CHAR(255), `Value` CHAR(1) PRIMARY KEY
`Property`)" );
+ "( `Property` CHAR(255), `Value` CHAR(1), `Intvalue` INT
PRIMARY KEY `Property`)" );
ok( r == ERROR_SUCCESS , "Failed to create table\n" );
/* check the column types */
@@ -1137,12 +1137,14 @@ static void test_viewgetcolumninfo(void)
ok( check_record( rec, 1, "S255"), "wrong record type\n");
ok( check_record( rec, 2, "S1"), "wrong record type\n");
+ ok( check_record( rec, 3, "I2"), "wrong record type\n");
MsiCloseHandle( rec );
/* check the type in _Columns */
ok( 0x3dff == get_columns_table_type(hdb, "Properties", 1 ),
"_columns table wrong\n");
ok( 0x1d01 == get_columns_table_type(hdb, "Properties", 2 ),
"_columns table wrong\n");
+ todo_wine ok( 0x1502 == get_columns_table_type(hdb, "Properties",
3 ), "_columns table wrong\n");
/* now try the names */
rec = get_column_info( hdb, "select * from `Properties`",
MSICOLINFO_NAMES );
@@ -1150,6 +1152,7 @@ static void test_viewgetcolumninfo(void)
ok( check_record( rec, 1, "Property"), "wrong record type\n");
ok( check_record( rec, 2, "Value"), "wrong record type\n");
+ todo_wine ok( check_record( rec, 3, "IntValue"), "wrong record type\n");
MsiCloseHandle( rec );
Then, in your second patch, for whatever you fix, remove the
todo_wine. The test suite should pass before and after every patch.
Thanks for helping Wine!
--
-Austin