wine-devel October 2010

wine-devel@winehq.org

94 participants
301 discussions

Re: [1/5] mscoree: Implement ICLRMetaHost_GetRuntime.
by Alexandre Julliard 06 Oct '10

06 Oct '10

"Vincent Povirk" <vincent(a)codeweavers.com> writes: > This will cause the tests to fail if Mono is not available. We'll have to start providing a Mono package then. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: crypt32(10/10): Set correct error when encountering unsupported critical extensions in the base and SSL policy
by testbot＠testbot.winehq.org 06 Oct '10

06 Oct '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=5874 Your paranoid android. === W98SE (32 bit chain) === chain.c:4117: Test failed: ignoredInvalidDateBasePolicyCheck[0](#0001): expected 800b0101, got 800b0102 chain.c:4117: Test failed: invalidExtensionPolicyCheck[0](#0001): expected 800b0105, got 800b0102 chain.c:4117: Test failed: iTunesPolicyCheckWithoutMatchingName[0](#0004): expected 800b010f, got 800b0109 chain.c:4117: Test failed: googlePolicyCheckWithMatchingName[0](#0004): expected 00000000, got 800b0101 chain.c:4117: Test failed: opensslPolicyCheckWithMatchingName[0](#0004): expected 00000000, got 800b0109 chain.c:4117: Test failed: opensslPolicyCheckWithoutMatchingName[0](#0004): expected 800b010f, got 800b0109 chain.c:4117: Test failed: opensslPolicyCheckWithoutMatchingName[0](#0004): expected 800b010f, got 800b0109 chain.c:4117: Test failed: opensslPolicyCheckWithoutMatchingName[0](#0004): expected 800b010f, got 800b0109 chain.c:4117: Test failed: stanfordPolicyCheckWithMatchingName[0](#0004): expected 00000000, got 800b0109 chain.c:4117: Test failed: stanfordPolicyCheckWithMatchingName[0](#0004): expected 00000000, got 800b0109 chain.c:4117: Test failed: stanfordPolicyCheckWithoutMatchingName[0](#0004): expected 800b010f, got 800b0109 chain.c:2752: Test failed: Chain 31: expected error 00000001, got 00000003. 00000020 is expected if no valid Verisign root certificate is available. chain.c:2674: Test failed: Chain 31, element [0,1]: expected error 00000000, got 00000002. 00000020 is expected if no valid Verisign root certificate is available. chain.c:2674: Test failed: Chain 31, element [0,2]: expected error 00000000, got 00000001. 00000020 is expected if no valid Verisign root certificate is available. chain.c:2752: Test failed: Chain 32: expected error 00000001, got 00010001. 00000020 is expected if no valid Verisign root certificate is available. chain.c:2712: Test failed: Chain 32: expected 3 elements, got 2 === WNT4WSSP6 (32 bit chain) === chain.c:4117: Test failed: invalidExtensionPolicyCheck[0](#0001): expected 800b0105, got 800b0102

1 0

Re: [2/3] ntdll: Implement NtQuerySystemInformation/SystemLogicalProcessorInformation (try 4)
by Mike Kaplinskiy 06 Oct '10

06 Oct '10

There are still a few style issues with your patch. You have inconsistent spacing after ifs ("if (" vs "if("), missing spaces after commas, and a few more "}else{"s. You also create a few blocks for no reason other than to get around the C declarations on top of block rule. Please organize these in tune with the surrounding code. Only create a "useless" block (ie a block without a control flow statement) if there is an #ifdef around it with other implementations. Also please don't do things like "if (x) { do {...} while(x); }". More importantly you seem to be missing the tests for this. (sorry for top posting; mobile gmail doesn't seem to have the ability to bottom post) Mike. On Oct 6, 2010 2:16 AM, "Rudolf Mayerhofer" <rm(a)eightyfive.net> wrote: > Try 2: > - Exchange Patches #2 and #3. > - Fix errors in formatting > - Check that fopen succeeds, return default value otherwise > - default return value is now 0 for all parser functions > > Try 3: > - Add missing checks for valid processor mask and cache values > > Try 4: > - More comments in the parsing code > - Some additional code cleanup > > --- > dlls/ntdll/nt.c | 343 > +++++++++++++++++++++++++++++++++++++++++++++++++++++++ > 1 files changed, 343 insertions(+), 0 deletions(-) >

1 0

Re: crypt32/tests(8/10): Add macros to declare tests
by testbot＠testbot.winehq.org 06 Oct '10

06 Oct '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=5873 Your paranoid android. === W98SE (32 bit chain) === chain.c:4117: Test failed: ignoredInvalidDateBasePolicyCheck[0](#0001): expected 800b0101, got 800b0102 chain.c:4108: Test failed: invalidExtensionPolicyCheck[0](#0001): expected 800b0105, got 800b0102 chain.c:4117: Test failed: iTunesPolicyCheckWithoutMatchingName[0](#0004): expected 800b010f, got 800b0109 chain.c:4117: Test failed: googlePolicyCheckWithMatchingName[0](#0004): expected 00000000, got 800b0101 chain.c:4117: Test failed: opensslPolicyCheckWithMatchingName[0](#0004): expected 00000000, got 800b0109 chain.c:4117: Test failed: opensslPolicyCheckWithoutMatchingName[0](#0004): expected 800b010f, got 800b0109 chain.c:4117: Test failed: opensslPolicyCheckWithoutMatchingName[0](#0004): expected 800b010f, got 800b0109 chain.c:4117: Test failed: opensslPolicyCheckWithoutMatchingName[0](#0004): expected 800b010f, got 800b0109 chain.c:4117: Test failed: stanfordPolicyCheckWithMatchingName[0](#0004): expected 00000000, got 800b0109 chain.c:4117: Test failed: stanfordPolicyCheckWithMatchingName[0](#0004): expected 00000000, got 800b0109 chain.c:4117: Test failed: stanfordPolicyCheckWithoutMatchingName[0](#0004): expected 800b010f, got 800b0109 chain.c:2752: Test failed: Chain 31: expected error 00000001, got 00000003. 00000020 is expected if no valid Verisign root certificate is available. chain.c:2674: Test failed: Chain 31, element [0,1]: expected error 00000000, got 00000002. 00000020 is expected if no valid Verisign root certificate is available. chain.c:2674: Test failed: Chain 31, element [0,2]: expected error 00000000, got 00000001. 00000020 is expected if no valid Verisign root certificate is available. chain.c:2752: Test failed: Chain 32: expected error 00000001, got 00010001. 00000020 is expected if no valid Verisign root certificate is available. chain.c:2712: Test failed: Chain 32: expected 3 elements, got 2 === WNT4WSSP6 (32 bit chain) === chain.c:4108: Test failed: invalidExtensionPolicyCheck[0](#0001): expected 800b0105, got 800b0102

1 0

Re: crypt32/tests(7/10): Add name to test to help identify test failures
by testbot＠testbot.winehq.org 06 Oct '10

06 Oct '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=5872 Your paranoid android. === W98SE (32 bit chain) === chain.c:4117: Test failed: ignoredInvalidDateBasePolicyCheck[0](#0001): expected 800b0101, got 800b0102 chain.c:4108: Test failed: invalidExtensionPolicyCheck[0](#0001): expected 800b0105, got 800b0102 chain.c:4117: Test failed: iTunesPolicyCheckWithoutMatchingName[0](#0004): expected 800b010f, got 800b0109 chain.c:4117: Test failed: googlePolicyCheckWithMatchingName[0](#0004): expected 00000000, got 800b0101 chain.c:4117: Test failed: opensslPolicyCheckWithMatchingName[0](#0004): expected 00000000, got 800b0109 chain.c:4117: Test failed: opensslPolicyCheckWithoutMatchingName[0](#0004): expected 800b010f, got 800b0109 chain.c:4117: Test failed: opensslPolicyCheckWithoutMatchingName[0](#0004): expected 800b010f, got 800b0109 chain.c:4117: Test failed: opensslPolicyCheckWithoutMatchingName[0](#0004): expected 800b010f, got 800b0109 chain.c:4117: Test failed: stanfordPolicyCheckWithMatchingName[0](#0004): expected 00000000, got 800b0109 chain.c:4117: Test failed: stanfordPolicyCheckWithMatchingName[0](#0004): expected 00000000, got 800b0109 chain.c:4117: Test failed: stanfordPolicyCheckWithoutMatchingName[0](#0004): expected 800b010f, got 800b0109 chain.c:2752: Test failed: Chain 31: expected error 00000001, got 00000003. 00000020 is expected if no valid Verisign root certificate is available. chain.c:2674: Test failed: Chain 31, element [0,1]: expected error 00000000, got 00000002. 00000020 is expected if no valid Verisign root certificate is available. chain.c:2674: Test failed: Chain 31, element [0,2]: expected error 00000000, got 00000001. 00000020 is expected if no valid Verisign root certificate is available. chain.c:2752: Test failed: Chain 32: expected error 00000001, got 00010001. 00000020 is expected if no valid Verisign root certificate is available. chain.c:2712: Test failed: Chain 32: expected 3 elements, got 2 === WNT4WSSP6 (32 bit chain) === chain.c:4108: Test failed: invalidExtensionPolicyCheck[0](#0001): expected 800b0105, got 800b0102

1 0

Re: crypt32(6/10): Set CERT_TRUST_HAS_NOT_SUPPORTED_CRITICAL_EXT when appropriate
by testbot＠testbot.winehq.org 06 Oct '10

06 Oct '10

1 0

Re: crypt32/tests(5/10): Test the base and SSL policies against a certificate with an invalid critical extension
by testbot＠testbot.winehq.org 06 Oct '10

06 Oct '10

1 0

Re: crypt32/tests(4/10): Test invalid critical extension in intermediate cert
by testbot＠testbot.winehq.org 06 Oct '10

06 Oct '10

1 0

Re: crypt32(2/10): Improve error checking for the base policy
by testbot＠testbot.winehq.org 06 Oct '10

06 Oct '10

1 0

Re: crypt32/tests(1/10): Add more tests of verifying the base policy, including flags to ignore certain errors
by testbot＠testbot.winehq.org 06 Oct '10

06 Oct '10

1 0

← Newer
1
...
22
23
24
25
26
27
28
...
31
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-devel October 2010