wine-devel April 2014

wine-devel@winehq.org

61 participants
274 discussions

Start a nNew thread

Re: [PATCH] ddraw: add dsurface dimension tests, try 7
by Marvin 03 Apr '14

03 Apr '14

1 0

Re: [PATCH 5/5] ws2_32: Add an interactive test for interface change notifications.
by Marvin 03 Apr '14

03 Apr '14

1 0

Re: [PATCH] ddraw: add dsurface dimension tests, try 6
by Marvin 03 Apr '14

03 Apr '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=6140 Your paranoid android. === w8 (32 bit ddraw4) === No test summary line found Failure running script in VM: network read timed out (wait2:ListSize:0/4) === wvistau64 (64 bit ddraw4) === ddraw4.c:6603: Test failed: Pixelformat D3DFMT_A8R8G8B8, test 9 returned 8007000e ddraw4.c:6603: Test failed: Pixelformat D3DFMT_R5G6B5, test 9 returned 8007000e ddraw4.c:6603: Test failed: Pixelformat D3DFMT_P8, test 9 returned 8007000e ddraw4.c:6603: Test failed: Pixelformat D3DFMT_P8, test 10 returned 00000000 === w2008s64 (64 bit ddraw4) === ddraw4.c:6603: Test failed: Pixelformat D3DFMT_A8R8G8B8, test 9 returned 8007000e ddraw4.c:6603: Test failed: Pixelformat D3DFMT_R5G6B5, test 9 returned 8007000e ddraw4.c:6603: Test failed: Pixelformat D3DFMT_P8, test 9 returned 8007000e ddraw4.c:6603: Test failed: Pixelformat D3DFMT_P8, test 10 returned 00000000 === w7pro64 (64 bit ddraw4) === ddraw4.c:6603: Test failed: Pixelformat D3DFMT_A8R8G8B8, test 9 returned 8007000e ddraw4.c:6603: Test failed: Pixelformat D3DFMT_R5G6B5, test 9 returned 8007000e ddraw4.c:6603: Test failed: Pixelformat D3DFMT_P8, test 9 returned 8007000e ddraw4.c:6603: Test failed: Pixelformat D3DFMT_P8, test 10 returned 00000000 === w8 (32 bit ddraw2) === ddraw2.c:740: Test failed: Got unexpected color 0x00000000. ddraw2.c:3120: Test failed: Got unexpected color 0x000000ff. === wvistau64 (64 bit ddraw2) === ddraw2.c:5744: Test failed: Pixelformat D3DFMT_A8R8G8B8, test 9 returned 8007000e ddraw2.c:5744: Test failed: Pixelformat D3DFMT_R5G6B5, test 9 returned 8007000e ddraw2.c:5744: Test failed: Pixelformat D3DFMT_P8, test 9 returned 8007000e ddraw2.c:5744: Test failed: Pixelformat D3DFMT_P8, test 10 returned 00000000 === w2008s64 (64 bit ddraw2) === ddraw2.c:5744: Test failed: Pixelformat D3DFMT_A8R8G8B8, test 9 returned 8007000e ddraw2.c:5744: Test failed: Pixelformat D3DFMT_R5G6B5, test 9 returned 8007000e ddraw2.c:5744: Test failed: Pixelformat D3DFMT_P8, test 9 returned 8007000e ddraw2.c:5744: Test failed: Pixelformat D3DFMT_P8, test 10 returned 00000000 === w7pro64 (64 bit ddraw2) === ddraw2.c:5744: Test failed: Pixelformat D3DFMT_A8R8G8B8, test 9 returned 8007000e ddraw2.c:5744: Test failed: Pixelformat D3DFMT_R5G6B5, test 9 returned 8007000e ddraw2.c:5744: Test failed: Pixelformat D3DFMT_P8, test 9 returned 8007000e ddraw2.c:5744: Test failed: Pixelformat D3DFMT_P8, test 10 returned 00000000 === w8 (32 bit dsurface) === dsurface.c:310: Test failed: Destination data after blitting is not correct dsurface.c:344: Test failed: Destination data after blitting is not correct dsurface.c:523: Test failed: Surface data after srckey blit does not match dsurface.c:548: Test failed: Surface data after src override key blit does not match dsurface.c:602: Test failed: Surface data after dest key blit does not match dsurface.c:628: Test failed: Surface data after dest key override blit does not match dsurface.c:690: Test failed: Surface data with src key and dest key blit does not match === w8 (32 bit ddraw1) === ddraw1.c:2828: Test failed: Got unexpected color 0x000000ff. ddraw1.c:3968: Test failed: Got unexpected refcount 3. ddraw1.c:3987: Test failed: Got unexpected refcount 3. ddraw1.c:3994: Test failed: Got unexpected hr 0. ddraw1.c:3997: Test failed: Got unexpected refcount 3. ddraw1.c:3999: Test failed: Got unexpected refcount 2. ddraw1.c:4005: Test failed: Got unexpected hr 0. ddraw1.c:4008: Test failed: Got unexpected refcount 2. ddraw1.c:4010: Test failed: Got unexpected refcount 1. === wvistau64 (64 bit ddraw1) === ddraw1.c:4641: Test failed: Pixelformat D3DFMT_A8R8G8B8, test 9 returned 8007000e ddraw1.c:4641: Test failed: Pixelformat D3DFMT_R5G6B5, test 9 returned 8007000e ddraw1.c:4641: Test failed: Pixelformat D3DFMT_P8, test 9 returned 8007000e ddraw1.c:4641: Test failed: Pixelformat D3DFMT_P8, test 10 returned 00000000 === w2008s64 (64 bit ddraw1) === ddraw1.c:4641: Test failed: Pixelformat D3DFMT_A8R8G8B8, test 9 returned 8007000e ddraw1.c:4641: Test failed: Pixelformat D3DFMT_R5G6B5, test 9 returned 8007000e ddraw1.c:4641: Test failed: Pixelformat D3DFMT_P8, test 9 returned 8007000e ddraw1.c:4641: Test failed: Pixelformat D3DFMT_P8, test 10 returned 00000000 === w7pro64 (64 bit ddraw1) === ddraw1.c:4641: Test failed: Pixelformat D3DFMT_A8R8G8B8, test 9 returned 8007000e ddraw1.c:4641: Test failed: Pixelformat D3DFMT_R5G6B5, test 9 returned 8007000e ddraw1.c:4641: Test failed: Pixelformat D3DFMT_P8, test 9 returned 8007000e ddraw1.c:4641: Test failed: Pixelformat D3DFMT_P8, test 10 returned 00000000 === w2000pro (32 bit ddraw7) === Failure running script in VM: timed out waiting for the child process === w8 (32 bit ddraw7) === ddraw7.c:3112: Test failed: Clear with count = 0, rect != NULL has color 0xff0000. ddraw7.c:5604: Test failed: Got unexpected refcount 3. ddraw7.c:5623: Test failed: Got unexpected refcount 3. ddraw7.c:5630: Test failed: Got unexpected hr 0. ddraw7.c:5633: Test failed: Got unexpected refcount 3. ddraw7.c:5635: Test failed: Got unexpected refcount 2. ddraw7.c:5641: Test failed: Got unexpected hr 0. ddraw7.c:5644: Test failed: Got unexpected refcount 2. ddraw7.c:5646: Test failed: Got unexpected refcount 1. ddraw7.c:5648: Test failed: Got unexpected refcount 6. The test timed out === wvistau64 (64 bit ddraw7) === ddraw7.c:6458: Test failed: Pixelformat D3DFMT_A8R8G8B8, test 9 returned 8007000e ddraw7.c:6458: Test failed: Pixelformat D3DFMT_R5G6B5, test 9 returned 8007000e ddraw7.c:6458: Test failed: Pixelformat D3DFMT_P8, test 9 returned 8007000e ddraw7.c:6458: Test failed: Pixelformat D3DFMT_P8, test 10 returned 00000000 === w2008s64 (64 bit ddraw7) === ddraw7.c:6458: Test failed: Pixelformat D3DFMT_A8R8G8B8, test 9 returned 8007000e ddraw7.c:6458: Test failed: Pixelformat D3DFMT_R5G6B5, test 9 returned 8007000e ddraw7.c:6458: Test failed: Pixelformat D3DFMT_P8, test 9 returned 8007000e ddraw7.c:6458: Test failed: Pixelformat D3DFMT_P8, test 10 returned 00000000 === w7pro64 (64 bit ddraw7) === ddraw7.c:6458: Test failed: Pixelformat D3DFMT_A8R8G8B8, test 9 returned 8007000e ddraw7.c:6458: Test failed: Pixelformat D3DFMT_R5G6B5, test 9 returned 8007000e ddraw7.c:6458: Test failed: Pixelformat D3DFMT_P8, test 9 returned 8007000e ddraw7.c:6458: Test failed: Pixelformat D3DFMT_P8, test 10 returned 00000000

1 0

Re: [PATCH 3/3] scrrun: Implement FreeSpace() for a drive
by Marvin 03 Apr '14

03 Apr '14

1 0

Re: [PATCH 2/3] scrrun: Implement Read()
by Marvin 03 Apr '14

03 Apr '14

1 0

Re: [PATCH 1/3] scrrun: Implement ReadAll()
by Marvin 03 Apr '14

03 Apr '14

1 0

Re: apphelp: add a stub for SdbInitDatabase (try 2)
by Dmitry Timoshkov 03 Apr '14

03 Apr '14

Austin English <austinenglish(a)gmail.com> wrote: > + if (path) > + FIXME("stub: flags: %08x, path: \"%s\". Unexpected, please report!\n", flags, debugstr_w(path)); > + else > + FIXME("stub: %08x %s\n", flags, debugstr_w(path)); What's the reason for this if/else? What exactly is not expected and why this matters for a stub? -- Dmitry.

2 2

Re: [3/6] widl: Avoid generating negative offsets for conformant arrays of strings. Take 2.
by Alexandre Julliard 02 Apr '14

02 Apr '14

Dmitry Timoshkov <dmitry(a)baikal.ru> writes: > This version of the patch limits the changes to conformant arrays of > strings in order to avoid unwanted changes to other pointer types. Didn't you say that midl is doing this for all arrays? Why doesn't this work in our case? -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: [6/6] rpcrt4/tests: Add a couple of tests for marshalling an array of strings. Resend.
by Marvin 02 Apr '14

02 Apr '14

1 0

Re: [PATCH] mshtml: Implemented numeral parsing in get_frame_by_name (try 2).
by Jacek Caban 02 Apr '14

02 Apr '14

Hi Qian, On 04/01/14 22:08, Qian Hong wrote: > diff --git a/dlls/mshtml/htmlwindow.c b/dlls/mshtml/htmlwindow.c > index a57dfba..3d6323c 100644 > --- a/dlls/mshtml/htmlwindow.c > +++ b/dlls/mshtml/htmlwindow.c > @@ -379,6 +379,20 @@ HRESULT get_frame_by_name(HTMLOuterWindow *This, const WCHAR *name, BOOL deep, H This is not the right place to do it. See callers of the function. I don't think we want that behaviour in, for example, get_target_window. > UINT32 length, i; > nsresult nsres; > HRESULT hres = S_OK; > + VARIANT v, idx; > + > + V_VT(&v) = VT_BSTR; > + V_BSTR(&v) = SysAllocString(name); > + VariantInit(&idx); > + hres = VariantChangeType(&idx, &v, VARIANT_LOCALBOOL, VT_I4); There are better ways to do that conversion, like strtolW. > + VariantClear(&v); > + if (SUCCEEDED(hres)) > + { > + hres = get_frame_by_index(This, V_I4(&idx), ret); > + VariantClear(&idx); > + return hres; > + } > + VariantClear(&idx); Clearing VARIANT of VT_I4 type is not really useful. Also, as Austin said, this definitely needs a test case. You may write that in JavaScript, if you prefer. See existing tests in *.html files. Cheers, Jacek

2 1

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-devel April 2014