wine-devel March 2017

wine-devel@winehq.org

74 participants
199 discussions

Re: Fabian Maurer : comctl32/taskdialog: Move TaskDialogIndirect and its tests into own source files.
by Fabian Maurer 20 Mar '17

20 Mar '17

Is there a reason you changed that copyright notice from "Copyright 2017 Fabian Maurer for the Wine project" to "Copyright 2017 Fabian Maurer" only in one place? If you wanted that "for the Wine project" part removed, I don't mind that, but I figured you'd do it at both places then. Regards, Fabian Maurer

3 4

Re: [PATCH 1/3] uiautomationcore: Add UiaLookupId stub.
by Jacek Caban 20 Mar '17

20 Mar '17

Hi Andrey, On 19.03.2017 00:13, Andrey Gusev wrote: > Fixes bug 42665 > > Signed-off-by: Andrey Gusev <andrey.goosev(a)gmail.com> > --- > dlls/uiautomationcore/uia_main.c | 10 ++++++++++ > dlls/uiautomationcore/uiautomationcore.spec | 2 +- > include/uiautomationcoreapi.h | 10 ++++++++++ > 3 files changed, 21 insertions(+), 1 deletion(-) > > diff --git a/dlls/uiautomationcore/uia_main.c b/dlls/uiautomationcore/uia_main.c > index 994d8e6..a16d3d1 100644 > --- a/dlls/uiautomationcore/uia_main.c > +++ b/dlls/uiautomationcore/uia_main.c > @@ -17,6 +17,7 @@ > */ > > #include "uiautomationcore.h" > +#include "uiautomationcoreapi.h" Please just use uiautomation.h instead of both includes. Thanks, Jacek

1 0

Re: [PATCH 2/3] uiautomationcore: Add UiaGetReservedMixedAttributeValue stub.
by Alistair Leslie-Hughes 20 Mar '17

20 Mar '17

Hi Andrey, > +HRESULT WINAPI UiaGetReservedMixedAttributeValue(IUnknown **value) > +{ > + FIXME("(%p) stub!\n", value); > + return S_OK; > +} Your returning success but not assigning anything to the out parameter "value". If you have to return S_OK, maybe *value = NULL might be good enough. Same goes for patch 3. Best Regards Alistair Leslie-Hughes

1 0

Re: [PATCH] ntdll: Implement ProcessVmCounters for Linux.
by Alex Henrie 20 Mar '17

20 Mar '17

So, I think Alexandre has been ignoring this patch because it only reports correct information for the current process, even though the Mac implementation has the same problem. I can think of a few ways to fix that: 1. Do nothing if the handle passed to NtQueryInformationProcess is the handle of another process. 2. Add a wineserver call such as get_process_unix_pid to get the process's Unix PID from its handle. Modify the Mac code to use task_for_pid and the Linux code to use /proc/%u/status. 3. Add a wineserver call such as get_process_vm_counters to get all the information that ProcessVmCounters needs without exposing the Unix PID. Move the Mac code into the wineserver and add the Linux code there too. Of those options, I think #3 makes the most sense. Ken, do you think it will cause any problems on Mac? -Alex

2 2

Re: [PATCH v4] msvcrt: Add stub for Concurrency::Alloc
by Gijs Vermeulen 18 Mar '17

18 Mar '17

Hi, What is the difference between this version and my v3? Thank you in advance. Sincerely, Gijs Op 18 mrt. 2017 12:27 p.m. schreef "Piotr Caban" <piotr(a)codeweavers.com>: > From: Gijs Vermeulen <gijsvrm(a)gmail.com> > > Signed-off-by: Gijs Vermeulen <gijsvrm(a)gmail.com> > Signed-off-by: Piotr Caban <piotr(a)codeweavers.com> > --- > dlls/concrt140/concrt140.spec | 4 ++-- > dlls/msvcr100/msvcr100.spec | 4 ++-- > dlls/msvcr110/msvcr110.spec | 4 ++-- > dlls/msvcr120/msvcr120.spec | 4 ++-- > dlls/msvcr120_app/msvcr120_app.spec | 4 ++-- > dlls/msvcrt/heap.c | 9 +++++++++ > 6 files changed, 19 insertions(+), 10 deletions(-) > > > > > >

2 2

Wine | Outreachy Applicant
by Akarsha Sehwag 18 Mar '17

18 Mar '17

Hi everyone I am a second yr Btech student at IIIT Delhi, India. I am a newcomer so I'll need some help to start off. I am really willing to be a part of Wine as an Outreachy intern and upgrade to becoming a regular contributor. Also, I know I am starting very late but I am confident that I'll complete the tasks given by the mentor soon. The projects which attract me the most : 1. Winetest GUI 2. Implement resource editor and/or dialog editor I am well-versed with knowledge of C. Though User interface implementation I have only done in Java as of now. 3. Winetest Scripting Interface. I know C and I have also written many scripts in Python. Apart from scripting and UI, I am also very interested in computer graphics but have no experience with that. I am looking forward to some help regarding the projects and the tasks expected to be done before the application deadline. Also, I would appreciate some suggestions regarding the project choice (since I am starting late and the mentors must have already chosen certain favourites by now) Regards -- Akarsha Sehwag 2015010 CSE Undergrad, IIIT Delhi

2 1

Re: [v2 2/2] msvcrt: Add stub for Concurrency::Free
by Piotr Caban 18 Mar '17

18 Mar '17

Hi, Please also move this code to heap.c and rename the function and argument (e.g. to mem). On 03/16/17 23:12, Gijs Vermeulen wrote: > +/* ?Free@Concurrency@@YAXPAX@Z */ > +/* ?Free@Concurrency@@YAXPEAX@Z */ > +void __cdecl Free(void * _PAllocation) > +{ > + FIXME("(%p) stub\n", _PAllocation); Even so it's a semi-stub it's better to free the memory here. Applications have no guarantee that memory block will be cached anyway. Thanks, Piotr

2 1

Re: [PATCH v2 4/5] user32: Always send WM_CANCELMODE when disabling a window.
by Marvin 17 Mar '17

17 Mar '17

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=29573 Your paranoid android. === w2003std (32 bit msg) === msg.c:5724: Test failed: ShowWindow(SW_SHOWMINNOACTIVE) child with invisible parent: 1: in msg 0x0046 expecting wParam 0x8170 got 0x8160 msg.c:5724: Test failed: ShowWindow(SW_SHOWMINNOACTIVE) child with invisible parent: 4: the msg 0x0047 was expected, but got msg 0x0022 instead msg.c:5724: Test failed: ShowWindow(SW_SHOWMINNOACTIVE) child with invisible parent: 5: the msg 0x0003 was expected, but got msg 0x0047 instead msg.c:5724: Test failed: ShowWindow(SW_SHOWMINNOACTIVE) child with invisible parent: 6: the msg 0x0005 was expected, but got msg 0x0003 instead msg.c:5724: Test failed: ShowWindow(SW_SHOWMINNOACTIVE) child with invisible parent: 11: the msg sequence is not complete: expected 0000 - actual 0005

1 0

Re: [PATCH v2 3/5] user32/tests: Add tests for EnableWindow().
by Marvin 17 Mar '17

17 Mar '17

1 0

Re: [v2 1/2] msvcrt: Add stub for Concurrency::Alloc
by Piotr Caban 17 Mar '17

17 Mar '17

Hi, On 03/16/17 23:12, Gijs Vermeulen wrote: > dlls/msvcrt/lock.c | 9 +++++++++ I think it would be better to implement the function in heap.c file. Could you please move the implementation there. > +void * __cdecl Alloc(MSVCRT_size_t _NumBytes) Please rename the function to Concurrency_Alloc and argument name to size. > + void *p = MSVCRT_malloc(_NumBytes); > + FIXME("(%ld, %p) stub\n", _NumBytes, p); How about changing the FIXME message to something like: FIXME("(%ld) returning %p\n", size, p); (this matches the trace of operator new). Thanks, Piotr

1 0

← Newer
1
...
5
6
7
8
9
10
11
...
20
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-devel March 2017