wine-devel

wine-devel@winehq.org

11 participants
84461 discussions

Re: [PATCH v3 04/30] ntsync: Introduce NTSYNC_IOC_WAIT_ANY.
by Elizabeth Figura 12 Apr '24

12 Apr '24

On Thursday, 11 April 2024 08:34:23 CDT Greg Kroah-Hartman wrote: > On Thu, Mar 28, 2024 at 07:05:55PM -0500, Elizabeth Figura wrote: > > This corresponds to part of the functionality of the NT syscall > > NtWaitForMultipleObjects(). Specifically, it implements the behaviour where > > the third argument (wait_any) is TRUE, and it does not handle alertable waits. > > Those features have been split out into separate patches to ease review. > > > > NTSYNC_IOC_WAIT_ANY is a vectored wait function similar to poll(). Unlike > > poll(), it "consumes" objects when they are signaled. For semaphores, this means > > decreasing one from the internal counter. At most one object can be consumed by > > this function. > > > > Up to 64 objects can be waited on at once. As soon as one is signaled, the > > object with the lowest index is consumed, and that index is returned via the > > "index" field. > > So it's kind of like our internal locks already? Or futex? Striking the right balance of explaining the problem space without inundating the reader with information has been tricky; I'll do my best to try to explain here. The primitives include mutexes and semaphores, like our internal locks. I don't really want to compare them to futexes because futexes don't have internal state. However NT's primitives are *way* more complicated. The big part of it is they consume state in a way that usual wait functions don't, and as if that weren't enough, you can do operations with them like wait-for-all (wait for all objects to be simultaneously signaled and atomically consume them) or pulse (signal an object without changing its state). None of this can be expressed with poll or futex. You can't even express those operations with wait_event() etc. We really need to replace the entire wait queue and use schedule() + wake_up_process() directly. ntsync_q is the wait queue struct in this. They're also really ugly things to do; they only exist for compatibility reasons, and retrofitting support into anything would complicate and slow down hot paths. > > A timeout is supported. The timeout is passed as a u64 nanosecond value, which > > represents absolute time measured against either the MONOTONIC or REALTIME clock > > (controlled by the flags argument). If U64_MAX is passed, the ioctl waits > > indefinitely. > > > > This ioctl validates that all objects belong to the relevant device. This is not > > necessary for any technical reason related to NTSYNC_IOC_WAIT_ANY, but will be > > necessary for NTSYNC_IOC_WAIT_ALL introduced in the following patch. > > > > Two u32s of padding are left in the ntsync_wait_args structure; one will be used > > by a patch later in the series (which is split out to ease review). > > > > Signed-off-by: Elizabeth Figura <zfigura(a)codeweavers.com> > > --- > > drivers/misc/ntsync.c | 250 ++++++++++++++++++++++++++++++++++++ > > include/uapi/linux/ntsync.h | 16 +++ > > 2 files changed, 266 insertions(+) > > > > diff --git a/drivers/misc/ntsync.c b/drivers/misc/ntsync.c > > index 3c2f743c58b0..c6f84a5fc8c0 100644 > > --- a/drivers/misc/ntsync.c > > +++ b/drivers/misc/ntsync.c > > @@ -6,11 +6,16 @@ > > */ > > > > #include <linux/anon_inodes.h> > > +#include <linux/atomic.h> > > #include <linux/file.h> > > #include <linux/fs.h> > > +#include <linux/hrtimer.h> > > +#include <linux/ktime.h> > > #include <linux/miscdevice.h> > > #include <linux/module.h> > > #include <linux/overflow.h> > > +#include <linux/sched.h> > > +#include <linux/sched/signal.h> > > #include <linux/slab.h> > > #include <linux/spinlock.h> > > #include <uapi/linux/ntsync.h> > > @@ -30,6 +35,8 @@ enum ntsync_type { > > * > > * Both rely on struct file for reference counting. Individual > > * ntsync_obj objects take a reference to the device when created. > > + * Wait operations take a reference to each object being waited on for > > + * the duration of the wait. > > */ > > > > struct ntsync_obj { > > @@ -47,12 +54,56 @@ struct ntsync_obj { > > __u32 max; > > } sem; > > } u; > > + > > + struct list_head any_waiters; > > +}; > > + > > +struct ntsync_q_entry { > > + struct list_head node; > > + struct ntsync_q *q; > > + struct ntsync_obj *obj; > > + __u32 index; > > +}; > > + > > +struct ntsync_q { > > + struct task_struct *task; > > + __u32 owner; > > + > > + /* > > + * Protected via atomic_try_cmpxchg(). Only the thread that wins the > > + * compare-and-swap may actually change object states and wake this > > + * task. > > + */ > > + atomic_t signaled; > > This feels odd, why are you duplicating a normal lock functionality > here? ntsync_q represents a single waiter (like struct wait_queue_entry). In short, waiting is a destructive operation; it changes the state of the primitives waited on. If a waiter is woken successfully then it must have consumed the state of exactly one object. Therefore, if task A is waiting on two primitives X and Y, and those primitives are respectively woken at the same time by tasks B and C, we need a way to ensure that B and C don't both wake A and consume the state of X and Y. Only one of them should win. We could do that with a lock on the ntsync_q struct, but having a single variable with atomic-test-and-set achieves the same thing while being lock-free. > > + > > + __u32 count; > > + struct ntsync_q_entry entries[]; > > }; > > > > struct ntsync_device { > > struct file *file; > > }; > > > > +static void try_wake_any_sem(struct ntsync_obj *sem) > > +{ > > + struct ntsync_q_entry *entry; > > + > > + lockdep_assert_held(&sem->lock); > > + > > + list_for_each_entry(entry, &sem->any_waiters, node) { > > + struct ntsync_q *q = entry->q; > > + int signaled = -1; > > + > > + if (!sem->u.sem.count) > > + break; > > + > > + if (atomic_try_cmpxchg(&q->signaled, &signaled, entry->index)) { > > + sem->u.sem.count--; > > + wake_up_process(q->task); > > + } > > You are waking up _all_ "locks" that with the atomic_try_cmpxchg() call, > right? Not just the "first". > > Or am I confused? This is looping over all tasks trying to lock / acquire "sem", and waking them (assuming something else didn't wake them first) while decrementing "sem" state accordingly. > > + } > > +} > > + > > /* > > * Actually change the semaphore state, returning -EOVERFLOW if it is made > > * invalid. > > @@ -88,6 +139,8 @@ static int ntsync_sem_post(struct ntsync_obj *sem, void __user *argp) > > > > prev_count = sem->u.sem.count; > > ret = post_sem_state(sem, args); > > + if (!ret) > > + try_wake_any_sem(sem); > > > > spin_unlock(&sem->lock); > > > > @@ -141,6 +194,7 @@ static struct ntsync_obj *ntsync_alloc_obj(struct ntsync_device *dev, > > obj->dev = dev; > > get_file(dev->file); > > spin_lock_init(&obj->lock); > > + INIT_LIST_HEAD(&obj->any_waiters); > > > > return obj; > > } > > @@ -191,6 +245,200 @@ static int ntsync_create_sem(struct ntsync_device *dev, void __user *argp) > > return put_user(fd, &user_args->sem); > > } > > > > +static struct ntsync_obj *get_obj(struct ntsync_device *dev, int fd) > > +{ > > + struct file *file = fget(fd); > > + struct ntsync_obj *obj; > > + > > + if (!file) > > + return NULL; > > + > > + if (file->f_op != &ntsync_obj_fops) { > > + fput(file); > > + return NULL; > > + } > > + > > + obj = file->private_data; > > + if (obj->dev != dev) { > > + fput(file); > > + return NULL; > > + } > > + > > + return obj; > > +} > > + > > +static void put_obj(struct ntsync_obj *obj) > > +{ > > + fput(obj->file); > > +} > > + > > +static int ntsync_schedule(const struct ntsync_q *q, const struct ntsync_wait_args *args) > > +{ > > + ktime_t timeout = ns_to_ktime(args->timeout); > > + clockid_t clock = CLOCK_MONOTONIC; > > + ktime_t *timeout_ptr; > > + int ret = 0; > > + > > + timeout_ptr = (args->timeout == U64_MAX ? NULL : &timeout); > > + > > + if (args->flags & NTSYNC_WAIT_REALTIME) > > + clock = CLOCK_REALTIME; > > + > > + do { > > + if (signal_pending(current)) { > > + ret = -ERESTARTSYS; > > + break; > > + } > > + > > + set_current_state(TASK_INTERRUPTIBLE); > > + if (atomic_read(&q->signaled) != -1) { > > + ret = 0; > > + break; > > What happens if the value changes right after you read it? The corresponding wake code flips signaled and then does wake_up_process(), so schedule() returns immediately (and we see q->signaled set and exit the loop.) > Rolling your own lock is tricky, and needs review from the locking > maintainers. And probably some more documentation as to what is > happening and why our normal types of locks can't be used here? Definitely. (Unfortunately this hasn't gotten attention from any locking maintainer yet since your last call for review; not sure if there's anything I can do there.) Hopefully my comment at the top of this mail explains why we're rolling our own everything, but if not please let me know and I can try to explain more clearly. --Zeb

1 0

Bumping the minimum supported macOS version
by Tim Clem 11 Apr '24

11 Apr '24

Hello everyone-- I'm proposing raising the official minimum supported macOS version to Catalina, 10.15. According to the wiki (https://wiki.winehq.org/MacOS), we theoretically support 10.8. Does anyone object? Thanks! --Tim

2 1

Wine staging 9.6 release
by Alistair Leslie-Hughes 06 Apr '24

06 Apr '24

Binary packages for various distributions will be available from: https://www.winehq.org/download Summary since last release * Rebased to current wine 9.6 (431 patches are applied to wine vanilla) Upstreamed (Either directly from staging or fixed with a similar patch). * macOS.yml: Set ac_cv_lib_soname_vulkan * winegstreamer: Add MFVideoFormat_ARGB32 output for the source. * fltmgr.sys: Implement FltBuildDefaultSecurityDescriptor * fltmgr.sys: Create import library * ntoskrnl.exe: Add FltBuildDefaultSecurityDescriptor test * widl: Add initial implementation of SLTG typelib generator. * widl: Add support for structures. * widl: Properly align name table entries. * widl: More accurately report variable descriptions data size. * widl: Calculate size of instance for structures. * widl: Write correct typekind to the SLTG typeinfo block. * widl: Write SLTG blocks according to the index order. * widl: Write correct syskind by SLTG typelib generator. * widl: Add support for VT_VOID and VT_VARIANT to SLTG typelib generator. * widl: Add support for VT_USERDEFINED to SLTG typelib generator. * widl: Factor out SLTG tail initialization. * widl: Fix generation of resources containing an old typelib. * widl: Add --oldtlb switch in usage message. * widl: Minor/cosmetic clean up. Removed (No longer required). * None Added: * None. Updated: * vkd3d-latest * windows.networking.connectivity-new-dll * ntdll-WRITECOPY NOTE: The updated ntdll-WRITECOPY patchset now allow Battle.net to run. Where can you help * Run Steam/Battle.net/GOG/UPlay/Epic * Test your favorite game. * Test your favorite applications. * Improve staging patches and get them accepted upstream. * Suggest patches to be included in staging. As always, if you find a bug, please report it via https://bugs.winehq.org Best Regards Alistair.

1 0

Solving the slow review problem with AI
by Gabriel Ivăncescu 02 Apr '24

02 Apr '24

Hi all, As we all know, the Wine project suffers from a shortage of maintainers/reviewers and timely reviews. This has always been a thing, so it's not something recent. While it's all too easy to dismiss this and say we simply need to get more maintainers, the reality is that it's not that simple, or we would've done so by now already. Since Generative AI and Large Language Models (LLMs) are all the rage these days, I figured it would be a good opportunity to join the trend. I propose a LLM trained for reviewing Wine code with full authority over the entire review process, so we can focus on writing code (and having it ripped out by the AI, for good reasons of course). The plan is to have it completely integrated with gitlab and the review process automatically, with the goal of it becoming the ultimate—and only—maintainer for the project. I've been training one for a while now with cloud services, though it needs more fine tuning of course, and it has no access to gitlab so far. Due to the training data, it exhibits a bias of review styles by famous reviewers such as Linus Torvalds (from the Linux kernel), so expect a lot of productive rants. I also gave it the capability to close MRs if the code is simply unsalvageable, though obviously only when it gets authorization to do so. In my tests, 98.657% of the code I sent it was classified as "garbage" and "unsalvageable", proving its effectiveness. The code tested were random patches and commits that were upstreamed to the Wine project, which explains a lot why we still haven't reached feature parity with Windows… Gone will be the days of waiting weeks to even get a response to your MR; now you'll just get bashed almost immediately and most likely even have your MR instantly closed "as a lost cause" if it stinks that much for the all-knowing LLM. I mean, computers don't make mistakes, so it must be right. For example we have MR !5432, where the LLM instantly rambled about how the old code was even upstreamed in the first place when it was clearly incorrect and didn't do what it was supposed to, but praised the MR for "finally doing something about it." I did tell it the new code doesn't compile, but that's obviously a compiler bug, or so it says. Next I plan to give it the ability to automatically submit bug reports to compiler vendors because obviously they aren't working right. Unfortunately I'll need to find a way to tone its language down a bit because I'm certain they'll be classified as spam—they're not ready for the AI revolution yet. Ideally we'd need to fine tune this a lot more on way more powerful hardware if it sounds like a good way forward. Thoughts?

3 2

[PATCH v3 00/30] NT synchronization primitive driver
by Elizabeth Figura 29 Mar '24

29 Mar '24

This patch series introduces a new char misc driver, /dev/ntsync, which is used to implement Windows NT synchronization primitives. == Background == The Wine project emulates the Windows API in user space. One particular part of that API, namely the NT synchronization primitives, have historically been implemented via RPC to a dedicated "kernel" process. However, more recent applications use these APIs more strenuously, and the overhead of RPC has become a bottleneck. The NT synchronization APIs are too complex to implement on top of existing primitives without sacrificing correctness. Certain operations, such as NtPulseEvent() or the "wait-for-all" mode of NtWaitForMultipleObjects(), require direct control over the underlying wait queue, and implementing a wait queue sufficiently robust for Wine in user space is not possible. This proposed driver, therefore, implements the problematic interfaces directly in the Linux kernel. This driver was presented at Linux Plumbers Conference 2023. For those further interested in the history of synchronization in Wine and past attempts to solve this problem in user space, a recording of the presentation can be viewed here: https://www.youtube.com/watch?v=NjU4nyWyhU8 == Performance == The gain in performance varies wildly depending on the application in question and the user's hardware. For some games NT synchronization is not a bottleneck and no change can be observed, but for others frame rate improvements of 50 to 150 percent are not atypical. The following table lists frame rate measurements from a variety of games on a variety of hardware, taken by users Dmitry Skvortsov, FuzzyQuils, OnMars, and myself: Game Upstream ntsync improvement =========================================================================== Anger Foot 69 99 43% Call of Juarez 99.8 224.1 125% Dirt 3 110.6 860.7 678% Forza Horizon 5 108 160 48% Lara Croft: Temple of Osiris 141 326 131% Metro 2033 164.4 199.2 21% Resident Evil 2 26 77 196% The Crew 26 51 96% Tiny Tina's Wonderlands 130 360 177% Total War Saga: Troy 109 146 34% =========================================================================== == Patches == The intended semantics of the patches are broadly intended to match those of the corresponding Windows functions. For those not already familiar with the Windows functions (or their undocumented behaviour), patch 31/31 provides a detailed specification, and individual patches also include a brief description of the API they are implementing. The patches making use of this driver in Wine can be retrieved or browsed here: https://repo.or.cz/wine/zf.git/shortlog/refs/heads/ntsync5 == Implementation == Some aspects of the implementation may deserve particular comment: * In the interest of performance, each object is governed only by a single spinlock. However, NTSYNC_IOC_WAIT_ALL requires that the state of multiple objects be changed as a single atomic operation. In order to achieve this, we first take a device-wide lock ("wait_all_lock") any time we are going to lock more than one object at a time. The maximum number of objects that can be used in a vectored wait, and therefore the maximum that can be locked simultaneously, is 64. This number is NT's own limit. The acquisition of multiple spinlocks will degrade performance. This is a conscious choice, however. Wait-for-all is known to be a very rare operation in practice, especially with counts that approach the maximum, and it is the intent of the ntsync driver to optimize wait-for-any at the expense of wait-for-all as much as possible. * NT mutexes are tied to their threads on an OS level, and the kernel includes builtin support for "robust" mutexes. In order to keep the ntsync driver self-contained and avoid touching more code than necessary, it does not hook into task exit nor use pids. Instead, the user space emulator is expected to manage thread IDs and pass them as an argument to any relevant functions; this is the "owner" field of ntsync_wait_args and ntsync_mutex_args. When the emulator detects that a thread dies, it should therefore call NTSYNC_IOC_MUTEX_KILL on any open mutexes. * ntsync is module-capable mostly because there was nothing preventing it, and because it aided development. It is not a hard requirement, though. == Previous versions == Changes from v2: * Check the result of fget() for NULL. * Squash patch 31 (introducing the NTSYNC_WAIT_REALTIME flag) into patch 4, per Arnd Bergmann. * Use atomic_try_cmpxchg() instead of atomic_cmpxchg(), per off-list review from Uros Bizjak. * Link to v2: https://lore.kernel.org/lkml/20240219223833.95710-1-zfigura@codeweavers.com/ * Link to v1: https://lore.kernel.org/lkml/20240214233645.9273-1-zfigura@codeweavers.com/ * Link to RFC v2: https://lore.kernel.org/lkml/20240131021356.10322-1-zfigura@codeweavers.com/ * Link to RFC v1: https://lore.kernel.org/lkml/20240124004028.16826-1-zfigura@codeweavers.com/ Elizabeth Figura (30): ntsync: Introduce the ntsync driver and character device. ntsync: Introduce NTSYNC_IOC_CREATE_SEM. ntsync: Introduce NTSYNC_IOC_SEM_POST. ntsync: Introduce NTSYNC_IOC_WAIT_ANY. ntsync: Introduce NTSYNC_IOC_WAIT_ALL. ntsync: Introduce NTSYNC_IOC_CREATE_MUTEX. ntsync: Introduce NTSYNC_IOC_MUTEX_UNLOCK. ntsync: Introduce NTSYNC_IOC_MUTEX_KILL. ntsync: Introduce NTSYNC_IOC_CREATE_EVENT. ntsync: Introduce NTSYNC_IOC_EVENT_SET. ntsync: Introduce NTSYNC_IOC_EVENT_RESET. ntsync: Introduce NTSYNC_IOC_EVENT_PULSE. ntsync: Introduce NTSYNC_IOC_SEM_READ. ntsync: Introduce NTSYNC_IOC_MUTEX_READ. ntsync: Introduce NTSYNC_IOC_EVENT_READ. ntsync: Introduce alertable waits. selftests: ntsync: Add some tests for semaphore state. selftests: ntsync: Add some tests for mutex state. selftests: ntsync: Add some tests for NTSYNC_IOC_WAIT_ANY. selftests: ntsync: Add some tests for NTSYNC_IOC_WAIT_ALL. selftests: ntsync: Add some tests for wakeup signaling with WINESYNC_IOC_WAIT_ANY. selftests: ntsync: Add some tests for wakeup signaling with WINESYNC_IOC_WAIT_ALL. selftests: ntsync: Add some tests for manual-reset event state. selftests: ntsync: Add some tests for auto-reset event state. selftests: ntsync: Add some tests for wakeup signaling with events. selftests: ntsync: Add tests for alertable waits. selftests: ntsync: Add some tests for wakeup signaling via alerts. selftests: ntsync: Add a stress test for contended waits. maintainers: Add an entry for ntsync. docs: ntsync: Add documentation for the ntsync uAPI. Documentation/userspace-api/index.rst | 1 + .../userspace-api/ioctl/ioctl-number.rst | 2 + Documentation/userspace-api/ntsync.rst | 399 +++++ MAINTAINERS | 9 + drivers/misc/Kconfig | 11 + drivers/misc/Makefile | 1 + drivers/misc/ntsync.c | 1166 ++++++++++++++ include/uapi/linux/ntsync.h | 62 + tools/testing/selftests/Makefile | 1 + .../testing/selftests/drivers/ntsync/Makefile | 8 + tools/testing/selftests/drivers/ntsync/config | 1 + .../testing/selftests/drivers/ntsync/ntsync.c | 1407 +++++++++++++++++ 12 files changed, 3068 insertions(+) create mode 100644 Documentation/userspace-api/ntsync.rst create mode 100644 drivers/misc/ntsync.c create mode 100644 include/uapi/linux/ntsync.h create mode 100644 tools/testing/selftests/drivers/ntsync/Makefile create mode 100644 tools/testing/selftests/drivers/ntsync/config create mode 100644 tools/testing/selftests/drivers/ntsync/ntsync.c base-commit: 4cece764965020c22cff7665b18a012006359095 -- 2.43.0

1 30

List failing (?!?!)
by David Kahurani 27 Mar '24

27 Mar '24

Hello, I am subscribed to receive mail from the list wine(a)gitlab.winehq.org However, I notice this morning that all mail from last night's merger are missing. Did the list fail or something I don't understand? Regards David.

1 0

Wine staging 9.5 release
by Alistair Leslie-Hughes 23 Mar '24

23 Mar '24

Binary packages for various distributions will be available from: https://www.winehq.org/download Summary since last release * Rebased to current wine 9.5 (435 patches are applied to wine vanilla) Upstreamed (Either directly from staging or fixed with a similar patch). * shell32: Append .exe when registry lookup fails first time. * wined3d: Use bindless textures for GLSL shaders. * kernel32/tests: Add tests for job object accounting. * shell32: Fix SHFileOperation(FO_MOVE) for creating subdirectories. * user32: Added LoadKeyboardLayoutEx stub. Removed (No longer required). * ws2_32-TransmitFile * ntdll-Threading Added: * None. Updated: * vkd3d-latest NOTE: widl-SLTG_Typelib_Support has been disabled due and is currently being upstreamed. Where can you help * Run Steam/Battle.net/GOG/UPlay/Epic * Test your favorite game. * Test your favorite applications. * Improve staging patches and get them accepted upstream. * Suggest patches to be included in staging. As always, if you find a bug, please report it via https://bugs.winehq.org Best Regards Alistair.

1 0

[PATCH v2 00/31] NT synchronization primitive driver
by Elizabeth Figura 11 Mar '24

11 Mar '24

This patch series introduces a new char misc driver, /dev/ntsync, which is used to implement Windows NT synchronization primitives. This was previously submitted as an RFC [1]. Since there were no major changes requested to the last RFC revision, I've stripped the RFC prefix. [1] https://lore.kernel.org/lkml/20240131021356.10322-1-zfigura@codeweavers.com/ == Background == The Wine project emulates the Windows API in user space. One particular part of that API, namely the NT synchronization primitives, have historically been implemented via RPC to a dedicated "kernel" process. However, more recent applications use these APIs more strenuously, and the overhead of RPC has become a bottleneck. The NT synchronization APIs are too complex to implement on top of existing primitives without sacrificing correctness. Certain operations, such as NtPulseEvent() or the "wait-for-all" mode of NtWaitForMultipleObjects(), require direct control over the underlying wait queue, and implementing a wait queue sufficiently robust for Wine in user space is not possible. This proposed driver, therefore, implements the problematic interfaces directly in the Linux kernel. This driver was presented at Linux Plumbers Conference 2023. For those further interested in the history of synchronization in Wine and past attempts to solve this problem in user space, a recording of the presentation can be viewed here: https://www.youtube.com/watch?v=NjU4nyWyhU8 == Performance == The gain in performance varies wildly depending on the application in question and the user's hardware. For some games NT synchronization is not a bottleneck and no change can be observed, but for others frame rate improvements of 50 to 150 percent are not atypical. The following table lists frame rate measurements from a variety of games on a variety of hardware, taken by users Dmitry Skvortsov, FuzzyQuils, OnMars, and myself: Game Upstream ntsync improvement =========================================================================== Anger Foot 69 99 43% Call of Juarez 99.8 224.1 125% Dirt 3 110.6 860.7 678% Forza Horizon 5 108 160 48% Lara Croft: Temple of Osiris 141 326 131% Metro 2033 164.4 199.2 21% Resident Evil 2 26 77 196% The Crew 26 51 96% Tiny Tina's Wonderlands 130 360 177% Total War Saga: Troy 109 146 34% =========================================================================== == Patches == The intended semantics of the patches are broadly intended to match those of the corresponding Windows functions. For those not already familiar with the Windows functions (or their undocumented behaviour), patch 31/31 provides a detailed specification, and individual patches also include a brief description of the API they are implementing. The patches making use of this driver in Wine can be retrieved or browsed here: https://repo.or.cz/wine/zf.git/shortlog/refs/heads/ntsync5 == Implementation == Some aspects of the implementation may deserve particular comment: * In the interest of performance, each object is governed only by a single spinlock. However, NTSYNC_IOC_WAIT_ALL requires that the state of multiple objects be changed as a single atomic operation. In order to achieve this, we first take a device-wide lock ("wait_all_lock") any time we are going to lock more than one object at a time. The maximum number of objects that can be used in a vectored wait, and therefore the maximum that can be locked simultaneously, is 64. This number is NT's own limit. The acquisition of multiple spinlocks will degrade performance. This is a conscious choice, however. Wait-for-all is known to be a very rare operation in practice, especially with counts that approach the maximum, and it is the intent of the ntsync driver to optimize wait-for-any at the expense of wait-for-all as much as possible. * NT mutexes are tied to their threads on an OS level, and the kernel includes builtin support for "robust" mutexes. In order to keep the ntsync driver self-contained and avoid touching more code than necessary, it does not hook into task exit nor use pids. Instead, the user space emulator is expected to manage thread IDs and pass them as an argument to any relevant functions; this is the "owner" field of ntsync_wait_args and ntsync_mutex_args. When the emulator detects that a thread dies, it should therefore call NTSYNC_IOC_MUTEX_KILL on any open mutexes. * ntsync is module-capable mostly because there was nothing preventing it, and because it aided development. It is not a hard requirement, though. == Previous versions == Changes from v1: * Fix a broken rebase that stole part of the Kconfig documentation from the neighbouring entry, per Randy Dunlap. * Add my email address to copyright and MODULE_AUTHOR lines, per Randy Dunlap. * Document the reference counting behaviour more clearly, per Greg Kroah-Hartman. * Hopefully submit all the patches this time the right way. * Link to v1: https://lore.kernel.org/lkml/20240214233645.9273-1-zfigura@codeweavers.com/ * Link to RFC v2: https://lore.kernel.org/lkml/20240131021356.10322-1-zfigura@codeweavers.com/ * Link to RFC v1: https://lore.kernel.org/lkml/20240124004028.16826-1-zfigura@codeweavers.com/ Elizabeth Figura (31): ntsync: Introduce the ntsync driver and character device. ntsync: Introduce NTSYNC_IOC_CREATE_SEM. ntsync: Introduce NTSYNC_IOC_SEM_POST. ntsync: Introduce NTSYNC_IOC_WAIT_ANY. ntsync: Introduce NTSYNC_IOC_WAIT_ALL. ntsync: Introduce NTSYNC_IOC_CREATE_MUTEX. ntsync: Introduce NTSYNC_IOC_MUTEX_UNLOCK. ntsync: Introduce NTSYNC_IOC_MUTEX_KILL. ntsync: Introduce NTSYNC_IOC_CREATE_EVENT. ntsync: Introduce NTSYNC_IOC_EVENT_SET. ntsync: Introduce NTSYNC_IOC_EVENT_RESET. ntsync: Introduce NTSYNC_IOC_EVENT_PULSE. ntsync: Introduce NTSYNC_IOC_SEM_READ. ntsync: Introduce NTSYNC_IOC_MUTEX_READ. ntsync: Introduce NTSYNC_IOC_EVENT_READ. ntsync: Introduce alertable waits. ntsync: Allow waits to use the REALTIME clock. selftests: ntsync: Add some tests for semaphore state. selftests: ntsync: Add some tests for mutex state. selftests: ntsync: Add some tests for NTSYNC_IOC_WAIT_ANY. selftests: ntsync: Add some tests for NTSYNC_IOC_WAIT_ALL. selftests: ntsync: Add some tests for wakeup signaling with WINESYNC_IOC_WAIT_ANY. selftests: ntsync: Add some tests for wakeup signaling with WINESYNC_IOC_WAIT_ALL. selftests: ntsync: Add some tests for manual-reset event state. selftests: ntsync: Add some tests for auto-reset event state. selftests: ntsync: Add some tests for wakeup signaling with events. selftests: ntsync: Add tests for alertable waits. selftests: ntsync: Add some tests for wakeup signaling via alerts. selftests: ntsync: Add a stress test for contended waits. maintainers: Add an entry for ntsync. docs: ntsync: Add documentation for the ntsync uAPI. Elizabeth Figura (31): ntsync: Introduce the ntsync driver and character device. ntsync: Introduce NTSYNC_IOC_CREATE_SEM. ntsync: Introduce NTSYNC_IOC_SEM_POST. ntsync: Introduce NTSYNC_IOC_WAIT_ANY. ntsync: Introduce NTSYNC_IOC_WAIT_ALL. ntsync: Introduce NTSYNC_IOC_CREATE_MUTEX. ntsync: Introduce NTSYNC_IOC_MUTEX_UNLOCK. ntsync: Introduce NTSYNC_IOC_MUTEX_KILL. ntsync: Introduce NTSYNC_IOC_CREATE_EVENT. ntsync: Introduce NTSYNC_IOC_EVENT_SET. ntsync: Introduce NTSYNC_IOC_EVENT_RESET. ntsync: Introduce NTSYNC_IOC_EVENT_PULSE. ntsync: Introduce NTSYNC_IOC_SEM_READ. ntsync: Introduce NTSYNC_IOC_MUTEX_READ. ntsync: Introduce NTSYNC_IOC_EVENT_READ. ntsync: Introduce alertable waits. ntsync: Allow waits to use the REALTIME clock. selftests: ntsync: Add some tests for semaphore state. selftests: ntsync: Add some tests for mutex state. selftests: ntsync: Add some tests for NTSYNC_IOC_WAIT_ANY. selftests: ntsync: Add some tests for NTSYNC_IOC_WAIT_ALL. selftests: ntsync: Add some tests for wakeup signaling with WINESYNC_IOC_WAIT_ANY. selftests: ntsync: Add some tests for wakeup signaling with WINESYNC_IOC_WAIT_ALL. selftests: ntsync: Add some tests for manual-reset event state. selftests: ntsync: Add some tests for auto-reset event state. selftests: ntsync: Add some tests for wakeup signaling with events. selftests: ntsync: Add tests for alertable waits. selftests: ntsync: Add some tests for wakeup signaling via alerts. selftests: ntsync: Add a stress test for contended waits. maintainers: Add an entry for ntsync. docs: ntsync: Add documentation for the ntsync uAPI. Documentation/userspace-api/index.rst | 1 + .../userspace-api/ioctl/ioctl-number.rst | 2 + Documentation/userspace-api/ntsync.rst | 399 +++++ MAINTAINERS | 9 + drivers/misc/Kconfig | 11 + drivers/misc/Makefile | 1 + drivers/misc/ntsync.c | 1159 ++++++++++++++ include/uapi/linux/ntsync.h | 62 + tools/testing/selftests/Makefile | 1 + .../testing/selftests/drivers/ntsync/Makefile | 8 + tools/testing/selftests/drivers/ntsync/config | 1 + .../testing/selftests/drivers/ntsync/ntsync.c | 1407 +++++++++++++++++ 12 files changed, 3061 insertions(+) create mode 100644 Documentation/userspace-api/ntsync.rst create mode 100644 drivers/misc/ntsync.c create mode 100644 include/uapi/linux/ntsync.h create mode 100644 tools/testing/selftests/drivers/ntsync/Makefile create mode 100644 tools/testing/selftests/drivers/ntsync/config create mode 100644 tools/testing/selftests/drivers/ntsync/ntsync.c base-commit: 8d11c6d9b14f7a87f65529cb33edc5fed846ed9d -- 2.43.0

1 32

Wine staging 9.4 release
by Alistair Leslie-Hughes 09 Mar '24

09 Mar '24

Binary packages for various distributions will be available from: https://www.winehq.org/download vkd3d has been updated to 1.11 For a full list of changes, please follow the link below. https://gitlab.winehq.org/wine/vkd3d/-/releases/vkd3d-1.11 NOTE: Upstream Wine was updated to this version as well. We have continued with keeping wine-staging to latest vkd3d. Summary since last release * Rebased to current wine 9.4 (462 patches are applied to wine vanilla) Upstreamed (Either directly from staging or fixed with a similar patch). * shell32: Implement NewMenu with new folder item. * shell32: Implement insert/paste for item context menus. * shell32: Recognize cut/copy/paste string verbs in item menu - context menu. * shell32: Implement the "runas" verb. * shell32: Add support for setting/getting PREFERREDDROPEFFECT in IDataObject. * shell32: Add parameter to ISFHelper::DeleteItems to allow deleting files without confirmation. * shell32: Remove source files when using cut in the context menu. * wine.inf: Add 'New' context menu handler entry for directories. * msi: Do not sign extend after multiplying. * wine.inf: Set the EnableLUA value to 1. * msi: Create the custom action server as an elevated process. * ntdll: Implement process token elevation through manifests. * ntdll: Always start the initial process through start.exe. * ntdll: Elevate processes if requested in RtlCreateUserProcess(). * user32: Start explorer.exe using limited rights. * programs/runas: Basic implementation for starting processes with a different trustlevel. * server: Create processes using a limited administrator token by default. * kernelbase: Elevate processes if requested in CreateProcessInternal(). Removed (No longer required). * server-File_Permissions * mscoree-CorValidateImage (Fixed uptream already). Added: * None. Updated: * vkd3d-latest * kernel32-CopyFileEx * ntdll-Junction_Points * ntdll-WRITECOPY * user32-rawinput-mouse Where can you help * Run Steam/Battle.net/GOG/UPlay/Epic * Test your favorite game. * Test your favorite applications. * Improve staging patches and get them accepted upstream. * Suggest patches to be included in staging. As always, if you find a bug, please report it via https://bugs.winehq.org Best Regards Alistair.

1 0

Staging update drop part 2
by DodoGTA GT 08 Mar '24

08 Mar '24

Hello, I managed to prepare another round of patches for wine-staging (the last one is actually a Wine patch though and it's a bit hacky too so I'm not sure if it's a good solution) Thanks

2 1

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-devel