wine-devel

wine-devel@winehq.org

84467 discussions

Does the timing of composition need to be moved from dcomp.dll to win32u?
by zhengxianwei 19 Jun '25

19 Jun '25

Zhiyi Zhang provided an implementation of DComp composition： https://gitlab.winehq.org/zhiyi/wine/-/commit/ef4f90c2ae909f4a732f0ebeae3b7… I created a simple sample that renders three equally sized red circles with varying alpha values on a plain white background window. On Windows, it displays as follows. [image: dcomp_test_window.png] But on Linux, it display as follows. [image: dcomp_test_wine.png] One of the main issues here is that the background turns black. This is because the foreground (swapchain) is not alpha-blended with the background (GDI); instead, it is simply overlaid using BitBlt. ``` * BitBlt(dst_dc, 0, 0, rect.right - rect.left, rect.bottom - rect.top, src_dc, 0, 0, SRCCOPY);* ``` So I added an alpha_blend step here instead of simply using the original BitBlt. ``` s1 = src_data; d1 = dst_data; for (int i = 0; i < height; i++) { for (int j = 0; j < width; j++) { // src is alpha pre multiple float bg_alpha = ((255.f - s1[3])) / 255; d1[0] = (d1[0] * bg_alpha) + s1[0]; d1[1] = (d1[1] * bg_alpha) + s1[1]; d1[2] = (d1[2] * bg_alpha) + s1[2]; s1 += 4; d1 += 4; } } //iret = SetDIBits(dst_hdc, dst_bitmap, 0, height, dst_data, &bmi, DIB_RGB_COLORS); iret = SetDIBitsToDevice(dst_hdc, 0, 0, width, height, 0, 0, 0, height, dst_data, &bmi, DIB_RGB_COLORS); ``` The new display effect is as follows. [image: dcomp_test_wine_alpha_blend.png] It looks like basic blending is working, but the alpha values of the circles are lost. After analyzing the issue, I found the following cause. I'll draw a diagram to briefly illustrate the cause of this issue. My original expectation of the image generation process [image: flush1.png] But the actual process is as follows [image: image.png] After the bitmap is alpha-blended and displayed on the screen, it is retrieved again in the next frame and repeatedly involved in alpha blending — resulting in redundant computations. I personally think that a more reasonable solution would be to insert window_surface_composition within window_surface_flush to more thoroughly resolve these kinds of issues [image: image.png] During window_surface_flush, composite the current surface with the swapchain's surface into an offscreen surface, then flush that to the screen. This way, the original window surface won't be affected. I'm trying to fix this issue now — do you have any suggestions?

2 3

Wine staging 10.10 release
by Alistair Leslie-Hughes 14 Jun '25

14 Jun '25

Binary packages for various distributions will be available from: https://www.winehq.org/download Summary since last release * Rebased to current wine 10.10 (348 patches are applied to wine vanilla) Upstreamed (Either directly from staging or fixed with a similar patch). * None. Removed (No longer required). * None Added: * None Updated: * vkd3d-latest Where can you help * Run Steam/Battle.net/GOG/UPlay/Epic * Test your favorite game. * Test your favorite applications. * Improve staging patches and get them accepted upstream. * Suggest patches to be included in staging. As always, if you find a bug, please report it via https://bugs.winehq.org Best Regards Alistair.

1 0

Is it normal that the COM vtbl structure cannot be aligned between Windows and Wine
by zhengxianwei 11 Jun '25

11 Jun '25

In wine, Visual2Vtbl ``` typedef struct IDCompositionVisual2Vtbl { BEGIN_INTERFACE /*** IUnknown methods ***/ HRESULT (STDMETHODCALLTYPE *QueryInterface)( IDCompositionVisual2 *This, REFIID riid, void **ppvObject); ULONG (STDMETHODCALLTYPE *AddRef)( IDCompositionVisual2 *This); ULONG (STDMETHODCALLTYPE *Release)( IDCompositionVisual2 *This); /*** IDCompositionVisual methods ***/ HRESULT (STDMETHODCALLTYPE *SetOffsetX)( IDCompositionVisual2 *This, float offset_x); HRESULT (STDMETHODCALLTYPE *SetOffsetXAnimation)( IDCompositionVisual2 *This, IDCompositionAnimation *animation); HRESULT (STDMETHODCALLTYPE *SetOffsetY)( IDCompositionVisual2 *This, float offset_y); ``` setOffsetX (float *) at offset 0x18 [image: visual2vtbl.png] But in windows 0x18 is setOffsetX (Animation *) Is this correct?

2 4

Mismatch Between win32syscalls.h and Windows System Call Numbers
by zhengxianwei 05 Jun '25

05 Jun '25

The APIs and call numbers in win32syscalls.h don't seem to match those in the Windows system. NtGdiAlphaBlend is listed as 4 in win32syscalls.h, but in reality, it's 0x1075 in win32u.dll on Windows 11. So are these values user-defined?

6 7

How to implement
by zhengxianwei 03 Jun '25

03 Jun '25

Hello, I would like to implement part of the logic within dcomp.dll in order to properly support applications that depend on it. I found that Zhiyi Zhang has implemented some data structures and interface stubs: https://gitlab.winehq.org/zhiyi/wine/-/commits/directcomposition?ref_type=h… Among these, the only method with actual logic appears to be IDCompositionDevice::Commit. However, after reviewing the implementation, I suspect there may be an issue with the current approach. It seems that Zhiyi Zhang starts a separate thread for each IDCompositionDevice, and this thread runs at a fixed refresh rate. But this approach appears to introduce a problem: from the window's (HWND) perspective, there are now *two threads* concurrently updating its device context. This results in a frame sequence similar to the following (note: the frame intervals are illustrative only): gdi_frame | dcomp_frame | gdi_frame | gdi_frame | dcomp_frame In this model, GDI-generated frames and DComp-generated frames are interleaved. Is my understanding correct? If so, I believe this method may lead to *inaccurate rendering results*, although I am not entirely certain about the exact consequences (as I am not an expert in this area). Therefore, I have decided to pursue an approach that produces a *standardized frame stream* like the following: gdi_mix_dcomp_frame | gdi_mix_dcomp_frame | gdi_mix_dcomp_frame In other words, I plan to merge GDI and DComp content before presenting each frame, ensuring consistency in the final output. I’ve reviewed the normal GDI frame refresh process, and it seems to follow this path: --> flush_window_surfaces --> window_surface_flush --> x11drv_surface_flush I’m planning to insert the following logic inside x11drv_surface_flush: if (is_hwnd_bind_to_dcomp(hwnd)) { struct Surface *final = get_comp_surface(hwnd); blend_dcomp_surface_over_gdi(dest_surface, final); } However, there’s still a question regarding *how to access the DComp data* inside x11drv_surface_flush. One option is to do the composition inside IDCompositionDevice::Commit() like this: void IDCompositionDevice_Commit() { composite_proc(); ... ... push_frame_to_x11drv(); } Another option is to *directly call into DComp APIs from within x11drv* to retrieve the surface data on demand. However, *both approaches feel somewhat unnatural*, and from what I can tell, Windows seems to establish some kind of *internal channel* to pass the composed content to the compositor. Is there a better or more canonical way to do this? Any suggestions or guidance would be greatly appreciated.

3 5

Wine staging 10.9 release
by Alistair Leslie-Hughes 01 Jun '25

01 Jun '25

Binary packages for various distributions will be available from: https://www.winehq.org/download Summary since last release * Rebased to current wine 10.9 (342 patches are applied to wine vanilla) Upstreamed (Either directly from staging or fixed with a similar patch). * None. Removed (No longer required). * None Added: * [44931] kernel32: Limit old exe to 3MB available space Updated: * vkd3d-latest Where can you help * Run Steam/Battle.net/GOG/UPlay/Epic * Test your favorite game. * Test your favorite applications. * Improve staging patches and get them accepted upstream. * Suggest patches to be included in staging. As always, if you find a bug, please report it via https://bugs.winehq.org Best Regards Alistair.

1 0

IRandomAccessStream doesn't belong in windows.storage
by light gray 21 May '25

21 May '25

Hi devs! I've recently noticed that there's a new `windows.storage` WinRT library within Wine, and the library houses a stubbed implementation for `IRandomAccessStream`. There's an issue however. Looking at Windows registry keys to see which libraries register which runtime classes, it appears `shcore` houses the implementation for `IRandomAccessStream`. Not `windows.storage`. While inherently this isn't a problem since applications acquire runtime classes via `RoGetActivationFactory`, this could pose an issue later down the line when more WinRT interfaces get implemented within Wine. Mainly with how different classes are registered at compile time. Not only that, it would also make implementing functions such as `CreateRandomAccessStreamOnFile` a bit more complicated. As a reference, the following is my own experimental implementation of `IRandomAccessStream`: https://github.com/Weather-OS/WineCoreUAP/commit/318d3b8ecb036f04dcf6365235… Best wishes, Weather.

3 3

irc.libera.chat ?
by zhengxianwei 19 May '25

19 May '25

May I ask, what's the difference between asking questions on irc.libera.chat and asking here? Will this place gradually be phased out, with activity gradually shifting over there?

2 2

How to add multiple versions of the same DLL (with the same base name) in apisetschema.spec?
by zhengxianwei 18 May '25

18 May '25

Hello, I'm planning to add the following line to apisetschema.spec: *api-ms-win-power-setting-l1-1-1 = powrprof.dll* However, this causes a hash conflict with the existing line: *apiset api-ms-win-power-setting-l1-1-0 = powrprof.dll* May I ask how you usually resolve such conflicts? I'm concerned that removing version 1-0 might cause some older applications to stop working. Would it be possible to delete the router for 1-0 and instead add a new line like this? *ln -s powrprof.dll api-ms-win-power-setting-l1-1-0*

3 3

Wine staging 10.8 release
by Alistair Leslie-Hughes 17 May '25

17 May '25

Binary packages for various distributions will be available from: https://www.winehq.org/download Summary since last release * Rebased to current wine 10.8 (344 patches are applied to wine vanilla) Upstreamed (Either directly from staging or fixed with a similar patch). * odbc32: SQLColAttributesW accept field id SQL_COLUMN_NAME. Removed (No longer required). * None Added: * None Updated: * vkd3d-latest * odbc32-fixes Where can you help * Run Steam/Battle.net/GOG/UPlay/Epic * Test your favorite game. * Test your favorite applications. * Improve staging patches and get them accepted upstream. * Suggest patches to be included in staging. As always, if you find a bug, please report it via https://bugs.winehq.org Best Regards Alistair.

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-devel