wine-devel

wine-devel@winehq.org

1 participants
84478 discussions

TestBot News - MR false positives analysis
by Francois Gouget 19 Oct '23

19 Oct '23

I have been reviewing the TestBot and GitLab CI test results for the merged MRs. While doing that I updated the TestBot's known failures list (https://testbot.winehq.org/FailuresList.pl) in order to drive down the false positive rate. Incidentally I also collected the list of test units causing false positives, so I'll start with that. Specifically, here are the bugs to fix to help the GitLab CI: * Bug 53433 - mmdevapi:capture - impacted 18 MRs * Bug 54064 - ntdll:threadpool - impacted 15 MRs * Bug 54078 - ntdll:pipe - impacted 11 MRs * Bug 54140 - mmdevapi:render - impacted 5 MRs * Bug 54005 - ole32:clipboard - impacted 5 MRs * Bug 54037 - user32:msg - impacted 5 MRs * Bug 54074 - ws2_32:sock - impacted 5 MRs I classified the TestBot / GitLab CI results as follows: * False positive Cases where the CI system incorrectly claimed the MR introduces new failures. This is typically the case when the failures that are already present in nightly WineTest results. * Bad merge MRs that break a test and got merged anyway. * Collateral Damage from a bad merge The false positives (aka collateral damage) caused by one of the bad merges above. * Outside interference This identifies false positives that are not random and intrinsic to the test but that result from change outside the Wine infrastructure, for instance certificates that expire, or configuration changes to servers that break the tests that depend on it. Of those the only ones that a CI can really avoid are the first type, aka "False positive". So I calculated the corresponding weekly rate: Adjusted False Positive rate Week | TestBot | GitLab CI 2022-11-14 | 21.9% | 8.3% 2022-11-21 | 8.0% | 21.6% 2022-11-28 | 14.7% | 28.4% 2022-12-05 | 8.5% | 24.5% 2022-12-12 | 0.0% | 20.0% Note that the TestBot's 8% rate for the 11-21 week is not representative because Wine was broken that week (collateral damage) which prevented the tests from running in Wine, and thus from contributing real "false positives". Also the 12-12 week is still incomplete obviously. Even so I think his shows the TestBot is improving. Here's a list of the incidents for the weeks above: * 11-14 An external certificate revocation issue caused crypt32:cert to fail systematically. This impacted 14 merge requests and was fixed in MR1360. * 11-17 MR!1399 got merged despite the TestBot detecting that it prevented 32-bit Wine tests from running to completion. This impacted 39 merge requests. I could have reduced that number if I had been faster to reconfigure the TestBot to stop running the full 32-bit Wine test suite. This was fixed in MR!1524. * 11-17 MR!1398 got merged despite the TestBot detecting that it broke ntoskrnl.exe:ntoskrnl on Windows 7. This was fixed in MR!1803. * 11-22 MR!1495 got merged despite the TestBot detecting that it broke vbscript:run on Windows *. I don't have a record of the impacted MRs or of when it was fixed. * 11-23 The b00a831d direct commit broke kernel32:process in Wine. This got fixed since. * 12-07 MR!1732 got merged despite the TestBot detecting that it broke taskschd:scheduler on Windows *. I immediately added a known failure entry and no MR got impacted. This was fixed in MR!1736. If not filtering out the failures caused by these incidents, the false positive rate is: Raw False Positive rate Week | TestBot | GitLab CI 2022-11-14 | 52.1% | 27.1% 2022-11-21 | 50.0% | 29.5% 2022-11-28 | 20.0% | 33.7% 2022-12-05 | 19.1% | 57.4% 2022-12-12 | 0.0% | 20.0% I think that also shows that the TestBot is improving. I have attached the raw data I collected and shell snippets to extract various statistics (failures-mr.txt) as well as a spreadsheet import (failures.xls). -- Francois Gouget <fgouget(a)codeweavers.com>

1 5

Wine staging 8.18 release
by Alistair Leslie-Hughes 14 Oct '23

14 Oct '23

Binary packages for various distributions will be available from: https://www.winehq.org/download Summary since last release * Rebased to current wine 8.18 (496 patches are applied to wine vanilla) Upstreamed (Either directly from staging or fixed with a similar patch). * dmime: Implement IDirectMusicSegment8 Download. * dmime: Play a sound in IDirectMusicPerformance8 PlaySegmentEx * d3dx9: D3DXLoadMeshHierarchyFromXInMemory support empty mesh. * include: Always define hton/ntoh macros. Added: * [39876] d3dx9: D3DXLoadMeshHierarchyFromXInMemory return a dummy ID3DXAnimationController. Updated: * vkd3d-latest to latest. * msxml3-FreeThreadedXMLHTTP60 * odbc-remove-unixodbc Where can you help * Run Steam/Battle.net/GOG/UPlay/Epic * Test your favorite game. * Test your favorite applications. * Improve staging patches and get them accepted upstream. * Suggest patches to be included in staging. As always, if you find a bug, please report it via https://bugs.winehq.org Best Regards Alistair.

1 0

Wine staging 8.17 release
by Alistair Leslie-Hughes 30 Sep '23

30 Sep '23

Binary packages for various distributions will be available from: https://www.winehq.org/download Summary since last release * Rebased to current wine 8.17 (494 patches are applied to wine vanilla) Upstreamed (Either directly from staging or fixed with a similar patch). * systeminfo: add basic functionality. Added: * [39876] d3dx9: D3DXLoadMeshHierarchyFromXInMemory return a dummy ID3DXAnimationController. Updated: * vkd3d-latest to latest. * user32-recursive-activation Where can you help * Run Steam/Battle.net/GOG/UPlay/Epic * Test your favorite game. * Test your favorite applications. * Improve staging patches and get them accepted upstream. * Suggest patches to be included in staging. As always, if you find a bug, please report it via https://bugs.winehq.org Best Regards Alistair.

1 0

TestBot News
by Francois Gouget 27 Sep '23

27 Sep '23

* GitLab bridge The bridge to add the TestBot failures as comments on GitLab is broken. It seems like it happened near the end of August. So be sure to look at the wine-gitlab mailing list to not miss issues in your merge requests. * VM changes debian11, debian11b and debiant now have UsePPosition in their fvwm configuration. See the full fvwm configuration below: https://wiki.winehq.org/Wine_TestBot_VMs#Unix_configuration These VMs also got an update to the latest packages. Also there is an ongoing experiment to figure out the best window manager for the tests. And who knows, maybe we'll event keep more than one? Anyway we currently have: - debian11 fvwm2 - debian11b fvwm2 - debian12 openbox - debiant fvwm3 * Test result changes Thanks to Esme's work, user32:msg now has a lot fewer failures, most notably on Windows 7 and 11: https://test.winehq.org/data/patterns.html#user32:msg d3d9:device also got quite a bit better thanks to Stefan's work: https://test.winehq.org/data/patterns And Alexandre fixed a bunch of stack, pointer and parameter size failures in various tests: https://test.winehq.org/data/patterns.html#kernel32:loader https://test.winehq.org/data/patterns.html#kernel32:thread https://test.winehq.org/data/patterns.html#ntdll:om https://test.winehq.org/data/patterns.html#oleaut32:usrmarshal https://test.winehq.org/data/patterns.html#winmm:capture ... Unfortunately there are other tests that started failing: 09-18 - 55650 dbghelp:dbghelp fails on macOS 09-14 - 55648 ntdll:wow64 - test_peb_teb() crashes on macOS - 55658 psapi:psapi_main - test_EnumProcessModules*() fails on macOS - 55655 user32:dialog - test_IsDialogMessageA_proc() fails in the Hindi locale on Wine - 55656 user32:dialog - test_IsDialogMessage() fails in the hi-u8 and mx-MX locales on Windows (bug 55656) 09-12 - 55649 quartz:vmr9 - test_changed3ddevice() fails on the TestBot's w11pro64-amd & -nv VMs 09-11 - 55637 dmime:dmime - test_performance_pmsg() sometimes fails due to bad timing on Windows and Wine - 55656 ntdll:exception - test_thread_context() fails on macOS 09-08 - 55583 d3d8:device - test_wndproc() often is missing a WM_WINDOWPOSCHANGING in Wine 08-30 - 55569 mshtml:dom - The 32-bit test_attr_collection_attr() crashes on Windows 10 2004+ 08-23 - 55588 mf:mf - test_scheme_resolvers() crashes on Windows 7 -- Francois Gouget <fgouget(a)codeweavers.com>

1 0

Wine staging 8.16 release
by Alistair Leslie-Hughes 16 Sep '23

16 Sep '23

Binary packages for various distributions will be available from: https://www.winehq.org/download Summary since last release * Rebased to current wine 8.16 (495 patches are applied to wine vanilla) Upstreamed (Either directly from staging or fixed with a similar patch). * dnsapi/tests: Add some tests for DNS_TYPE_SRV messages. * dnsapi: Accept name records of exact size at the end of the packet. * dnsapi: Set correct wDataLength for DNS_TYPE_SRV records. Added: * [10729] ddraw: Implement Pick() and GetPickRecords(). Updated: * vkd3d-latest to latest. Where can you help * Run Steam/Battle.net/GOG/UPlay/Epic * Test your favorite game. * Test your favorite applications. * Improve staging patches and get them accepted upstream. * Suggest patches to be included in staging. As always, if you find a bug, please report it via https://bugs.winehq.org Best Regards Alistair.

1 0

Recent ntdll/unix/signal_x86_64.c changes
by Gerald Pfeifer 15 Sep '23

15 Sep '23

commit ea640f6cece7660ffc853b7d574fbe52af34901a Author: Alexandre Julliard <julliard(a)winehq.org> Date: Mon Sep 11 11:25:29 2023 +0200 ntdll: Ignore attempts to change segment registers on x86-64. moved the following code +#ifdef DS_sig + DS_sig(sigcontext) = ds64_sel; +#else + __asm__ volatile( "movw %0,%%ds" :: "r" (ds64_sel) ); +#endif +#ifdef ES_sig + ES_sig(sigcontext) = ds64_sel; +#else + __asm__ volatile( "movw %0,%%es" :: "r" (ds64_sel) ); +#endif into static inline void leave_handler( const ucontext_t *sigcontext ) Alas this has "const ucontext_t *sigcontext", so platforms like FreeBSD that define DS_sig will try to do DS_sig(sigcontext) = ds64_sel; which results in GCC rightfully diagnosing: dlls/ntdll/unix/signal_x86_64.c: In function ‘leave_handler’: dlls/ntdll/unix/signal_x86_64.c:822:24: error: assignment of member ‘mc_ds’ in read-only object 822 | DS_sig(sigcontext) = ds64_sel; | ^ I submitted https://gitlab.winehq.org/wine/wine/-/merge_requests/3845 which restores the build on FreeBSD and presumably NetBSD, but wonder: Could FreeBSD/NetBSD align with Linux and macOS which d not define DS_sig (and ES_sig) and thus use into different code paths in leave_handler? Gerald

2 1

Wine staging 8.15 release
by Alistair Leslie-Hughes 02 Sep '23

02 Sep '23

Binary packages for various distributions will be available from: https://www.winehq.org/download Summary since last release * Rebased to current wine 8.15 (496 patches are applied to wine vanilla) Upstreamed (Either directly from staging or fixed with a similar patch). * None. Added: * None Updated: * vkd3d-latest to latest. * user32-rawinput-mouse * mshtml-TranslateAccelerator Where can you help * Run Steam/Battle.net/GOG/UPlay/Epic * Test your favorite game. * Test your favorite applications. * Improve staging patches and get them accepted upstream. * Suggest patches to be included in staging. As always, if you find a bug, please report it via https://bugs.winehq.org Best Regards Alistair.

1 0

Upcoming vkd3d 1.9 release
by Henri Verbeet 23 Aug '23

23 Aug '23

Hi all, The targetted release date for vkd3d 1.9 is four weeks from now, on September 20. That means the development branch will become increasingly frozen as we're nearing the release date. If you're an upstream vkd3d developer, please do the following: - Keep an eye on Bugzilla for any reported regressions. - Review any API changes since the previous release. - Verify all the vkd3d tests pass on your hardware. - Review and improve the documentation. - Apply your best judgment about which patches are appropriate for the current stage of the release process. Note that it's entirely appropriate to queue up more complicated changes for application post 1.9 and ask for review on them, but please either mark those as draft or put some kind of note in the MR description. If you're a downstream user of vkd3d, please test your applications for regressions, and file bug reports if you find any. If you're the maintainer of a Wine module that (indirectly) depends on vkd3d, like e.g. d2d1, d3dx9, d3dcompiler, or any of the core Direct3D modules, that includes making sure the unit tests still pass with the new version. We try our best to avoid regressions, but ultimately we depend on our downstream users to catch anything we may have missed before the final release. The planned release date for the release following vkd3d 1.9 is currently sometime in December. Regards, Henri

1 0

Upcoming vkd3d 1.9 release
by Henri Verbeet 23 Aug '23

23 Aug '23

1 0

Wine staging 8.14 release
by Alistair Leslie-Hughes 21 Aug '23

21 Aug '23

Binary packages for various distributions will be available from: https://www.winehq.org/download Summary since last release * Rebased to current wine 8.14 (496 patches are applied to wine vanilla) Upstreamed (Either directly from staging or fixed with a similar patch). * dmime: Store WAVE data when Loading. Added: * None Updated: * vkd3d-latest to latest. * xactengine3_7-PrepareWave * fltmgr.sys-FltBuildDefaultSecurityDescriptor * winex11-CandidateWindowPos * user32-rawinput-mouse * widl-SLTG_Typelib_Support * ntdll-Syscall_Emulation Where can you help * Run Steam/Battle.net/GOG/UPlay/Epic * Test your favorite game. * Test your favorite applications. * Improve staging patches and get them accepted upstream. * Suggest patches to be included in staging. As always, if you find a bug, please report it via https://bugs.winehq.org Best Regards Alistair.

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-devel