wine-devel

wine-devel@winehq.org

11 participants
84462 discussions

Re: New breakages
by gerard patel 02 May '01

02 May '01

At 02:30 PM 25/04/2001 +0200, I wrote: >At 09:30 AM 25/04/2001 +0200, I wrote: > >Also several apps are not erasing parts of the screen : among others the word viewer 97 >(freeware downloadable). A few other strange crashes. Still talking to myself... I feel I'm soon one of these sad cases talking alone in the street ;-) I have found one way to fix a lot of the ugliness that the evil patch of 24 april has done; by doing : --- dce.c.orig Thu May 3 00:02:35 2001 +++ dce.c Wed May 2 23:49:19 2001 @@ -551,7 +551,7 @@ dce->DCXflags &= ~DCX_DCEDIRTY; hdc = dce->hDC; - if (bUpdateVisRgn) SetHookFlags16( hdc, DCHF_INVALIDATEVISRGN ); /* force update */ + if (bUpdateVisRgn) flags |= 0x8000; if (!USER_Driver.pGetDC( hwnd, hdc, hrgnClip, flags )) hdc = 0; and --- winpos.c.orig Wed Apr 25 01:28:52 2001 +++ winpos.c Wed May 2 23:49:01 2001 @@ -355,7 +355,8 @@ TSXSetClipOrigin( display, physDev->gc, dc->DCOrgX, dc->DCOrgY ); #endif - updateVisRgn = (dc->flags & DC_DIRTY) != 0; + updateVisRgn = (flags & 0x8000) != 0; + dc->flags &= ~DC_DIRTY; GDI_ReleaseObj( hdc ); if (updateVisRgn) I got the following results : Word viewer 32 bits, 16 bits, Lotus Notes (AFAICT), Statview, QuattroPro 1, and a few old 16 bits apps I have display more or less as well as before (some crud for WW32 that was not before, though :-/) Doing things in such a way is more conforming to the way they were done before - and it seems more simple that the SetHookFlags trick IMHO ;-) Gerard

1 0

Re: Script to get committed patches
by gerard patel 02 May '01

02 May '01

At 08:04 PM 01/05/2001 +0200, you wrote: >as of today, the added files are marked with the &&& mark (instead of >the +++ and --- for the diffs), which of course causes some issues when >you use the whole file as a patch (normally, all the added files are at >the end; so the "easy" way of doing it is to remove that part, apply the >patch, and then create the new files) <snip> >I'd say it's a documented feature ;-), Documented ? Oops, I missed completely this part. This weekend I have browsed the wonderful Wine user manual for the first time , since I have now a computer with a working db2html - now I know what *is* the Wine user manual ;-) I have not seen where this info is hiding. Maybe it was in one of your (defunct) WWN. I tried to read them but I probably was lazy too. Btw, your successor has problems to get in the game; I noticed on LinuxToday that the last Kernel Cousin Wine was showing a 'slow week' - the week where Marcus posted CUPS support - IMHO the more interesting patch since months for all non-games apps. He is not following wine-patches and wine-cvs it seems :-/ > I'll try to give it a look later >on I see no reason for you to work on this rather trivial matter. All that is needed is to know the problem. I should have guessed it but I was probably too stressed by the idea of having this 200k patch to look at ;-( Now it's done, thanks for the tip. Gerard

4 4

Re: FreeLibrary() library freeing
by Alexandre Julliard 02 May '01

02 May '01

gerard patel <gerard.patel(a)asi.fr> writes: > If you remember, there are glibc problems with dlclose. Alexandre Julliard > said that it was not a problem because FreeLibrary was not doing anything. > So I guess that people with 'old' glibc could have now new crashes. Actually we still cannot dlclose builtin libraries; the change I made is to free memory used by PE dlls. Freeing builtins properly will require dll separation to be completed first. And once this is done we will no longer rely on glibc dlclose reference counting so the bug shouldn't impact us. -- Alexandre Julliard julliard(a)winehq.com

1 0

Re: FreeLibrary() library freeing
by gerard patel 02 May '01

02 May '01

At 11:23 PM 01/05/2001 +0200, you wrote: <snip> >I believe the potential problems that this can cause are way more important >than some claims that "there are some problems with library freeing". >I've had that FreeLibrary() #if hack removed for a long time, >and I haven't see any adverse effects (not that it's too easy to spot >and attribute to this problem probably, though). If you remember, there are glibc problems with dlclose. Alexandre Julliard said that it was not a problem because FreeLibrary was not doing anything. So I guess that people with 'old' glibc could have now new crashes. Gerard

2 1

Re: FreeLibrary() library freeing
by Alexandre Julliard 02 May '01

02 May '01

Andreas Mohr <a.mohr(a)mailto.de> writes: > I for one would truly like to see it fixed ASAP. > > If FreeLibrary() has a problem, then we need to fix it. > Running away from the problem by implementing strange hacks does no good > to anybody. Agreed; I have uncommented the VirtualFree, and you are hereby volunteered to track down and fix any crash caused by this ;-) -- Alexandre Julliard julliard(a)winehq.com

3 2

Re: Quickbooks 5 and printing
by Alexandre Julliard 02 May '01

02 May '01

"Dmitry Timoshkov" <dmitry(a)sloboda.ru> writes: > Please try the attached patch. It tries to solve the root of the problem: > for now Wine Postscript Driver lives in wineps.dll, but should be in wineps.drv. I'm not sure this is correct. The app is trying to load a 16-bit driver, so giving it the 32-bit dll is probably not a good idea. Maybe we should simply rename wineps16.dll to wineps.drv? -- Alexandre Julliard julliard(a)winehq.com

2 1

Re: FW: Notes and Java test on 20010216 drop
by Alexandre Julliard 02 May '01

02 May '01

"Nerijus Baliunas" <nerijus(a)users.sourceforge.net> writes: > why the following patch is not applied? I don't think it was ever submitted; but anyway, it's quite ugly to check the callouts on every module load/unload. The right fix is to get rid of the Callout structure and do a GetProcAddress at the time we need a specific function. -- Alexandre Julliard julliard(a)winehq.com

1 0

FreeLibrary() library freeing
by Andreas Mohr 01 May '01

01 May '01

Hi all, can't we just free the libraries for real now in FreeLibrary() ? I just got a report from someone who had an InstallSh***** installer say this: Call kernel32.192: CreateFileA(40566cf4 "C:\\WINDOWS\\uninst.exe",c0000000,00000001,00000000,00000004,00000080,00000000) ret=0044364e fs=008f trace:file:CreateFileA C:\WINDOWS\uninst.exe GENERIC_READ GENERIC_WRITE FILE_SHARE_READ OPEN_ALWAYS trace:dosfs:DOSFS_GetFullName C:\WINDOWS\uninst.exe (last=0) trace:string:lstrcpynA (0x40566148, "/home/jnu/.wine/fake_windows", 1024) trace:dosfs:DOSFS_FindUnixName /home/jnu/.wine/fake_windows,WINDOWS\uninst.exe trace:dosfs:DOSFS_FindUnixName (/home/jnu/.wine/fake_windows,WINDOWS\uninst.exe) -> Windows (WINDOWS) trace:dosfs:DOSFS_FindUnixName /home/jnu/.wine/fake_windows/Windows,uninst.exe warn:dosfs:DOSFS_FindUnixName 'uninst.exe' not found in '/home/jnu/.wine/fake_windows/Windows' trace:dosfs:DOSFS_GetFullName returning /home/jnu/.wine/fake_windows/Windows/uninst.exe = C:\WINDOWS\uninst.exe warn:file:FILE_CreateFile Unable to create file '/home/jnu/.wine/fake_windows/Windows/uninst.exe' (GLE 32) Ret kernel32.192: CreateFileA() retval=ffffffff ret=0044364e fs=008f . . . Call kernel32.943: lstrcpyA(40566834,40380370 "Setup Initialization Error") ret=00403322 fs=008f Ret kernel32.943: lstrcpyA() retval=40566834 ret=00403322 fs=008f trace:string:wvsnprintfA 0x40566960 1024 "Setup is unable to find a hard disk location to store temporary files.\n\nMake at "... trace:string:wvsnprintfA "Setup is unable to find a hard disk location to store temporary files.\n\nMake at "... Call user32.425: MessageBoxA(00000000,40566960 "Setup is unable to find a hard disk location to store temporary files.\n\nMake at "...,40566834 "Setup Initialization Error",00000010) ret=00403402 fs=008f This happened because the program did some FileVersionGet*() calls before on uninst.exe, which do LoadLibrary()/FreeLibrary() internally, but of course the file handle didn't get freed any more. I believe the potential problems that this can cause are way more important than some claims that "there are some problems with library freeing". I've had that FreeLibrary() #if hack removed for a long time, and I haven't see any adverse effects (not that it's too easy to spot and attribute to this problem probably, though). Besides, Musicmatch Jukebox used zillions of MB (yes, that's a leak for you) due to that Wine "feature". I for one would truly like to see it fixed ASAP. If FreeLibrary() has a problem, then we need to fix it. Running away from the problem by implementing strange hacks does no good to anybody. Andreas Mohr -- Microsoft Windows: Made for the Internet The Internet: Made for Unix

1 0

Script to get committed patches
by gerard patel 01 May '01

01 May '01

I have tried to retrieve this patch : http://cvs.winehq.com/patch.py?id=9881549330718504618853331 It does not look as a regular diff ??? I suspect a problem in the script. I have absolutely no knowledge of the language used in this script, so I can't do more than report. Here is quoted a small part of the beast, cut & paste from Netscape. Gerard --- /opt/cvs-commit/wine/dlls/x11drv/x11drv.spec 2001/01/15 20:23:06 1.7 +++ /opt/cvs-commit/wine/dlls/x11drv/x11drv.spec 2001/04/24 23:28:52 1.8 @@ -11,8 +11,6 @@ # USER driver -@ cdecl Synchronize() X11DRV_Synchronize -@ cdecl CheckFocus() X11DRV_CheckFocus @ cdecl UserRepaintDisable(long) X11DRV_UserRepaintDisable @ cdecl InitKeyboard() X11DRV_InitKeyboard @ cdecl VkKeyScan(long) X11DRV_VkKeyScan @@ -24,8 +22,6 @@ @ cdecl Beep() X11DRV_Beep @ cdecl GetDIState(long ptr) X11DRV_GetDIState @ cdecl GetDIData(ptr long ptr ptr long) X11DRV_GetDIData -@ cdecl GetKeyboardConfig(ptr) X11DRV_GetKeyboardConfig -@ cdecl SetKeyboardConfig(ptr long) X11DRV_SetKeyboardConfig @ cdecl InitMouse(ptr) X11DRV_InitMouse @ cdecl SetCursor(ptr) X11DRV_SetCursor @ cdecl MoveCursor(long long) X11DRV_MoveCursor @@ -34,6 +30,16 @@ @ cdecl GetScreenSaveTimeout() X11DRV_GetScreenSaveTimeout @ cdecl SetScreenSaveTimeout(long) X11DRV_SetScreenSaveTimeout @ cdecl LoadOEMResource(long long) X11DRV_LoadOEMResource +@ cdecl CreateWindow(long) X11DRV_CreateWindow +@ cdecl DestroyWindow(long) X11DRV_DestroyWindow +@ cdecl GetDC(long long long long) X11DRV_GetDC +@ cdecl EnableWindow(long long) X11DRV_EnableWindow +@ cdecl SetFocus(long) X11DRV_SetFocus +@ cdecl SetParent(long long) X11DRV_SetParent +@ cdecl SetWindowPos(ptr) X11DRV_SetWindowPos +@ cdecl SetWindowRgn(long long) X11DRV_SetWindowRgn +@ cdecl SetWindowIcon(long long long) X11DRV_SetWindowIcon +@ cdecl SetWindowText(long wstr) X11DRV_SetWindowText @ cdecl IsSingleWindow() X11DRV_IsSingleWindow @ cdecl AcquireClipboard() X11DRV_AcquireClipboard @ cdecl ReleaseClipboard() X11DRV_ReleaseClipboard &&& wine/dlls/x11drv/window.c /* * Window related functions * * Copyright 1993, 1994, 1995, 1996, 2001 Alexandre Julliard * Copyright 1993 David Metcalfe * Copyright 1995, 1996 Alex Korobka */ #include "config.h" #include "ts_xlib.h" #include "ts_xutil.h" #include "winbase.h" #include "wingdi.h" #include "winuser.h"

2 1

FW: Notes and Java test on 20010216 drop
by Nerijus Baliunas 01 May '01

01 May '01

Hello, why the following patch is not applied? -----Original Message----- From: David.Goodenough(a)dga.co.uk [mailto:David.Goodenough@dga.co.uk] Subject: RE: Notes and Java test on 20010216 drop The Java problem I had with the last drop (the problem with Callout not being initialised) is still there, so obviously the fix that was generated and which fixes the problem has not made it into the CVS. The good news is that now Java works (if the patch is applied). Now the fonts display correctly. I am not sure what you have done guys, but it works a treat. Now for some more testing with some of the things I wanted to run but could not because of the Java support. Interestingly both the Sun and the IBM JREs now work, where last month with the fix the Sun one produced the wrong output but at least ran to completion, while the IBM one locked up somewhere. Now both run to completion properly. I was sent this (I think on wine-develop but it might have been directly). It fixes the Callout problem. I forget who originally sent it to me, but I could find out if that is necessary. diff -ur wine-cvs/if1632/thunk.c wine-uw/if1632/thunk.c --- wine-cvs/if1632/thunk.c Wed Jan 3 22:51:30 2001 +++ wine-uw/if1632/thunk.c Mon Jan 29 00:35:49 2001 @@ -166,7 +166,7 @@ NE_MODULE *pModule; hModule = GetModuleHandleA( "user32.dll" ); - if ( hModule ) + if ( hModule && !Callout.PeekMessageA ) { #define GETADDR( name ) \ *(FARPROC *)&Callout.name = GetProcAddress( hModule, #name ) @@ -185,10 +185,24 @@ GETADDR( MessageBoxW ); #undef GETADDR } - else WARN("no 32-bit USER\n"); + if ( !hModule && Callout.PeekMessageA ) + { + Callout.PeekMessageA = NULL; + Callout.GetMessageA = NULL; + Callout.SendMessageA = NULL; + Callout.PostMessageA = NULL; + Callout.TranslateMessage = NULL; + Callout.DispatchMessageA = NULL; + Callout.RedrawWindow = NULL; + Callout.WaitForInputIdle = NULL; + Callout.MsgWaitForMultipleObjects = NULL; + Callout.WindowFromDC = NULL; + Callout.MessageBoxA = NULL; + Callout.MessageBoxW = NULL; + } pModule = NE_GetPtr( GetModuleHandle16( "USER.EXE" ) ); - if ( pModule ) + if ( pModule && !Callout.FinalUserInit16 ) { #define GETADDR( var, name, thk ) \ *(FARPROC *)&Callout.var = THUNK_GetCalloutThunk( pModule, name, \ @@ -201,5 +215,12 @@ GETADDR( UserSignalProc, "SignalProc32", word_lllw ); #undef GETADDR } - else WARN("no 16-bit USER\n"); + if ( !pModule && Callout.FinalUserInit16 ) + { + Callout.FinalUserInit16 = NULL; + Callout.InitThreadInput16 = NULL; + Callout.UserYield16 = NULL; + Callout.DestroyIcon32 = NULL; + Callout.UserSignalProc = NULL; + } } diff -ur wine-cvs/loader/module.c wine-uw/loader/module.c --- wine-cvs/loader/module.c Tue Jan 16 00:29:27 2001 +++ wine-uw/loader/module.c Mon Jan 29 00:30:20 2001 @@ -1432,6 +1432,9 @@ /* decrement the dependencies through the MODULE_FreeLibrary call. */ pwm->refCount++; + /* Update the kernel Callout tables */ + THUNK_InitCallout(); + RtlReleasePebLock(); SetLastError( err ); /* restore last error */ HeapFree ( GetProcessHeap(), 0, filename ); @@ -1526,6 +1529,9 @@ HeapFree( GetProcessHeap(), 0, wm->short_filename ); HeapFree( GetProcessHeap(), 0, wm ); } + + /* Update the kernel Callout tables */ + THUNK_InitCallout(); } /*********************************************************************** diff -ur wine-cvs/miscemu/main.c wine-uw/miscemu/main.c --- wine-cvs/miscemu/main.c Wed Jan 10 02:42:49 2001 +++ wine-uw/miscemu/main.c Mon Jan 29 00:36:05 2001 @@ -34,7 +34,6 @@ MESSAGE( "Cannot load user32.dll\n" ); ExitProcess( GetLastError() ); } - THUNK_InitCallout(); if ((instance = NE_StartMain( main_exe_name, main_exe_file )) < 32) { diff -ur wine-cvs/scheduler/process.c wine-uw/scheduler/process.c --- wine-cvs/scheduler/process.c Sun Jan 28 18:58:09 2001 +++ wine-uw/scheduler/process.c Mon Jan 29 00:36:17 2001 @@ -346,9 +346,6 @@ MODULE_DllProcessAttach( NULL, (LPVOID)1 ); RtlReleasePebLock(); - /* Get pointers to USER routines called by KERNEL */ - THUNK_InitCallout(); - /* Call FinalUserInit routine */ if (Callout.FinalUserInit16) Callout.FinalUserInit16();

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-devel