Re: [PATCH 2/7] dpwsockx: Implementation of SPInit

[Henri Verbeet]

2009/9/1 Ismael Barros² :
> On Tue, Sep 1, 2009 at 11:00 AM, Henri Verbeet wrote:
> > 2009/9/1 Ismael Barros :
> > > +typedef struct tagDPSP_MSG_HEADER
> > > +{
> > > - DWORD       size;           /* size & 0x000FFFFF, token & 0xFFF00000 */
> > > - SOCKADDR_IN SockAddr;
> > >
> > > +} DPSP_MSG_HEADER, *LPDPSP_MSG_HEADER;
> > > +typedef const DPSP_MSG_HEADER* LPCDPSP_MSG_HEADER;
> > > -
> >
> > It seems you're sending this over the network, so you should make sure
> > it's correctly packed, and take the byte order into account.
>
> I tested it with a wireshark dissector and against the original
> implementation, and it seems to work nicely.

Probably, but that depends on how the compiler packs the structure,
and on the host byte order.